Repository navigation
Conversation
UX Review (Opus 5.5, fork) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5, fork) — ⏭️ skippedRevision |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this is a docs-only correction, and the routes it now names ( [DESIGN-REVIEWED] 8cb194e Description read[DESCRIPTION-READ] 6d6b1ebd1a043cabff7c72f353053404d7528b5670b2da07d53370dac658609e That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
477b784 to
4c34f12
Compare
…e landed
The rfc-crewmate-share index row says no export route and no owner
Import entry exist. Both are on main: POST /api/members/{slug}/export
came in with kirodotdev#23223 and the owner Import dialog, with POST
/api/members/import, with kirodotdev#23424.
The row now names both, and the document's implementation-prs lists
them. Only those two claims were re-checked, at 9c3c6b5; the status
and the remaining phases are left as they were, since a re-audit of the
whole document is a maintainer's call.
4c34f12 to
8cb194e
Compare
|
Thanks for keeping the RFC index accurate. This PR edits an RFC and the RFC index, so a maintainer needs to sign it off before it can merge. A maintainer will post the decision here. Review result: no blocking findings on this head. I checked each claim against main:
Done well: each claim is narrow and names the route, the component and the PR, so a reader can check every one. Optional:
|
|
Thanks for this fix, @JiaDe-Wu. Closing it as superseded: #37153 (merged 2026-11-14, re-audit of the request-for-change RFCs against |
Problem / Motivation
Goal: The RFC index stops saying a crewmate cannot be exported or imported from the owner UI, now that both are on main.
The
rfc-crewmate-sharerow indocs/request-for-change/README.mdsays "no export route and no owner Import entry exist".POST /api/members/{slug}/exportmerged with #23223 and the owner Import dialog withPOST /api/members/importmerged with #23424. The README itself says that when a document and the code disagree, the document is the bug.Why it matters
The row is how a reader decides whether the share feature exists. Someone planning on top of it (for example an app that proposes Bots) reads that nothing is built.
Not a goal
What changed (motivation → approach → change)
The row now names the export route and the Import dialog with their PRs, and says only those two claims were re-checked at
9c3c6b58e9.implementation-prsin the RFC front matter lists #23223 and #23424 beside #21721.statusandlast-auditedare left as they were because the rest was not re-audited.Backwards compatibility
Compatible. Documentation only.
Removes nothing: no code, config or behaviour changes.
Tests
N/A, documentation only.
./scripts/docs-lint.shpasses (exit 0).Proof: not provable -- docs or config only
Manual verification
Checked on main: the route is registered in
src/kiro_crew/dashboard/routes/agents.py;importCrewmateinwebsite/src/api/cards.tsposts to/api/members/importandCrewmateImportDialogcalls it; both PRs are merged (#23223 on 2026-10-26, #23424 introduced the dialog on 2026-10-23).Related Issues
None.
Checklist