Skip to content

docs(rfc): record that crewmate export and the owner import entry have landed - #30623

Closed
JiaDe-Wu wants to merge 1 commit into
kirodotdev:mainfrom
JiaDe-Wu:docs/rfc-crewmate-share-export-is-built
Closed

JiaDe-Wu wants to merge 1 commit into
kirodotdev:mainfrom
JiaDe-Wu:docs/rfc-crewmate-share-export-is-built

Conversation

@JiaDe-Wu

@JiaDe-Wu JiaDe-Wu commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The RFC index stops saying a crewmate cannot be exported or imported from the owner UI, now that both are on main.

The rfc-crewmate-share row in docs/request-for-change/README.md says "no export route and no owner Import entry exist". POST /api/members/{slug}/export merged with #23223 and the owner Import dialog with POST /api/members/import merged with #23424. The README itself says that when a document and the code disagree, the document is the bug.

Why it matters

The row is how a reader decides whether the share feature exists. Someone planning on top of it (for example an app that proposes Bots) reads that nothing is built.

Not a goal

  • Changing the RFC's status or re-auditing its remaining phases. That is a maintainer's call.
  • Editing the RFC's historical "Current state" prose, which records the tree when it was written.

What changed (motivation → approach → change)

The row now names the export route and the Import dialog with their PRs, and says only those two claims were re-checked at 9c3c6b58e9. implementation-prs in the RFC front matter lists #23223 and #23424 beside #21721. status and last-audited are left as they were because the rest was not re-audited.

Backwards compatibility

Compatible. Documentation only.

Removes nothing: no code, config or behaviour changes.

Tests

N/A, documentation only. ./scripts/docs-lint.sh passes (exit 0).

Proof: not provable -- docs or config only

Manual verification

Checked on main: the route is registered in src/kiro_crew/dashboard/routes/agents.py; importCrewmate in website/src/api/cards.ts posts to /api/members/import and CrewmateImportDialog calls it; both PRs are merged (#23223 on 2026-10-26, #23424 introduced the dialog on 2026-10-23).

Related Issues

None.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality — N/A, documentation only
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@JiaDe-Wu
JiaDe-Wu requested review from a team and KiroCrewCaptain as code owners November 5, 2026 17:52
@buluoray
buluoray enabled auto-merge (squash) November 5, 2026 17:52
@buluoray
buluoray disabled auto-merge November 5, 2026 17:52
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention labels Nov 5, 2026
@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ⏭️ skipped

Revision 8cb194e2c3da6b097f2a42fb5f00f41cf08c8523 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ⏭️ skipped

Revision 8cb194e2c3da6b097f2a42fb5f00f41cf08c8523 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of 8cb194e2c3da6b097f2a42fb5f00f41cf08c8523 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this is a docs-only correction, and the routes it now names (/api/members/{slug}/export, /api/members/import) are registered on the base tree.

[DESIGN-REVIEWED] 8cb194e

Description read

[DESCRIPTION-READ] 6d6b1ebd1a043cabff7c72f353053404d7528b5670b2da07d53370dac658609e

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed 8cb194e2c3da6b097f2a42fb5f00f41cf08c8523 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 8cb194e

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed 8cb194e2c3da6b097f2a42fb5f00f41cf08c8523 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 8cb194e

@iamwhatever
iamwhatever force-pushed the docs/rfc-crewmate-share-export-is-built branch from 477b784 to 4c34f12 Compare November 14, 2026 08:46
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 14, 2026
…e landed

The rfc-crewmate-share index row says no export route and no owner
Import entry exist. Both are on main: POST /api/members/{slug}/export
came in with kirodotdev#23223 and the owner Import dialog, with POST
/api/members/import, with kirodotdev#23424.

The row now names both, and the document's implementation-prs lists
them. Only those two claims were re-checked, at 9c3c6b5; the status
and the remaining phases are left as they were, since a re-audit of the
whole document is a maintainer's call.
@iamwhatever
iamwhatever force-pushed the docs/rfc-crewmate-share-export-is-built branch from 4c34f12 to 8cb194e Compare November 14, 2026 11:08
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 14, 2026
@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

Thanks for keeping the RFC index accurate. This PR edits an RFC and the RFC index, so a maintainer needs to sign it off before it can merge. A maintainer will post the decision here.
To propose a design, follow the request-for-change process in CONTRIBUTING.md (docs/request-for-change/).

Review result: no blocking findings on this head. I checked each claim against main:

Done well: each claim is narrow and names the route, the component and the PR, so a reader can check every one.

Optional:

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 14, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor

Thanks for this fix, @JiaDe-Wu. Closing it as superseded: #37153 (merged 2026-11-14, re-audit of the request-for-change RFCs against 1d08e941b3) already updated this row on main. The rfc-crewmate-share.md index row is now partial and names Import #23424 and Export #23223, and its front matter has implementation-prs: [21721, 23424, 23223]. This branch now conflicts with that change and adds nothing on top of it. Please reopen if you see a fact main is still missing.

@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor) merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants