Repository navigation
Conversation
0fcba4d to
b69cb98
Compare
b69cb98 to
1c778e2
Compare
|
Rebased onto main (head 1c778e2) to clear the merge conflict in docs/request-for-change/README.md. Main has since rewritten the rfc-work-ledger-concurrency-cap row itself (now |
First Principles Review (Opus 5.5, fork) — ⏭️ skippedRevision |
UX Review (Opus 5.5, fork) — ⏭️ skippedRevision |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Documentation-only fix to four index rows. Nothing is taken away and no user-visible surface changes, so nothing blocks. Notes
[DESIGN-REVIEWED] 4eb6cb8 Description read[DESCRIPTION-READ] 1caa721ccf91a0aa585f4e99bda6f0b7ce0415ea13b58ab682f314c7be5a0206 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
…as landed Five RFC index rows still say "nothing built" or "implementation waits" for work that is on main: agent-started-turns (kirodotdev#18285), goal-loop-approval-hold (kirodotdev#16993), wake-on-stop-signal (kirodotdev#18854), work-ledger-concurrency-cap (kirodotdev#19338) and work-dispatch (kirodotdev#25101). Each row now leads with what landed and the PR, and relabels the old "Verified at" sentence as the baseline recorded before the merge, so the design reasoning stays readable. Only one symbol per row was re-checked, at 9c3c6b5, and the row says which. rfc-work-dispatch now lists its PR in implementation-prs. Statuses and audited-at stamps are left for a maintainer's re-audit.
1c778e2 to
4eb6cb8
Compare
Code change approver recommendation: ApproveWhy: the decider estimates a 7% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes. Docs-only correction of four RFC index rows plus implementation-prs for rfc-work-dispatch. Every symbol claim was verified in the repo at head (_claude/origin in client_transport.py, release_approval_hold_for in autonudge.py, WORK_WAKE_STATUSES imported in ledger_wake.py, work_dispatch in spec_prompts.py). The fifth row named in the description is already correct at head. No status fields change, so no trust boundary or First Principles lane input moves. Approve; status/vocabulary drift and the four-vs-five wording go in the non-blocking notes. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
|
Thanks for this. The review found no blocking problems on this head. This PR edits the request-for-change index and an RFC file, so a maintainer needs to agree to it before it can merge. A maintainer will post the decision here. To propose a design, follow the request-for-change process in CONTRIBUTING.md (docs/request-for-change/). What the review checked on this head: the diff is two docs files, +5/-5. Commit 9c3c6b5 is an ancestor of main. Every symbol the new "Built:" text cites is present at that commit: Optional:
|
|
Thanks for this fix, @JiaDe-Wu. Closing it as superseded: #37153 (merged 2026-11-14, re-audit of the request-for-change RFCs against |
Problem / Motivation
Goal: Five RFC index rows stop saying "nothing built" for work that is on main.
docs/request-for-change/README.mdsays that when a document and the code disagree the document is the bug. Five rows still describe the tree from before their work merged:rfc-agent-started-turns_meta["_claude/origin"]acp/client_transport.py(#18285)rfc-goal-loop-approval-holdrelease_approval_holdhas zero hitsrelease_approval_hold_forinautonudge.py(#16993)rfc-wake-on-stop-signalwork_vocab.pydeclares noWORK_WAKE_STATUSESledger_wake.py(#18854)rfc-work-ledger-concurrency-capgoal_concurrency_cap_reachedis documented inspec_prompts.pyrfc-work-dispatchwork_dispatchdocumented inspec_prompts.py(#25101)Why it matters
The index is how a reader decides what exists before building on it, and these rows describe accepted designs that shipped.
Not a goal
audited-atstamp, or re-auditing the rest of each row. Only one symbol per row was re-checked, and each row says which.What changed (motivation → approach → change)
Each row now leads with what landed and the PR with its merge date. The old "Verified at " sentence is relabelled "Baseline recorded at , before it merged", so the design reasoning stays readable.
rfc-work-dispatchlists #25101 inimplementation-prs(the other four already list their PRs).Backwards compatibility
Compatible. Documentation only.
Removes nothing: no code, config or behaviour changes.
Tests
N/A, documentation only.
./scripts/docs-lint.shpasses (exit 0) and the brand-name gate is clean.Proof: not provable -- docs or config only
Manual verification
Re-checked on main with
git grep:_claude/origininacp/client_transport.py;release_approval_hold_forinautonudge.py;WORK_WAKE_STATUSESimported inledger_wake.py;goal_concurrency_cap_reachedandwork_dispatchinagent_parts/spec_prompts.py. #18285, #16993, #18854, #19338 and #25101 are all merged.Related Issues
None.
Checklist