Skip to content

docs(rfc): correct four work-ledger and agent index rows whose work has landed - #30634

Closed
JiaDe-Wu wants to merge 1 commit into
kirodotdev:mainfrom
JiaDe-Wu:docs/rfc-index-work-ledger-rows-landed
Closed

JiaDe-Wu wants to merge 1 commit into
kirodotdev:mainfrom
JiaDe-Wu:docs/rfc-index-work-ledger-rows-landed

Conversation

@JiaDe-Wu

@JiaDe-Wu JiaDe-Wu commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Five RFC index rows stop saying "nothing built" for work that is on main.

docs/request-for-change/README.md says that when a document and the code disagree the document is the bug. Five rows still describe the tree from before their work merged:

Document Row said On main
rfc-agent-started-turns nothing reads _meta["_claude/origin"] read in acp/client_transport.py (#18285)
rfc-goal-loop-approval-hold release_approval_hold has zero hits release_approval_hold_for in autonudge.py (#16993)
rfc-wake-on-stop-signal work_vocab.py declares no WORK_WAKE_STATUSES imported by ledger_wake.py (#18854)
rfc-work-ledger-concurrency-cap nothing built; implementation waits in #19338 merged; the refusal goal_concurrency_cap_reached is documented in spec_prompts.py
rfc-work-dispatch nothing built work_dispatch documented in spec_prompts.py (#25101)

Why it matters

The index is how a reader decides what exists before building on it, and these rows describe accepted designs that shipped.

Not a goal

  • Changing any status or audited-at stamp, or re-auditing the rest of each row. Only one symbol per row was re-checked, and each row says which.
  • Rewriting the baseline reasoning in the rows.

What changed (motivation → approach → change)

Each row now leads with what landed and the PR with its merge date. The old "Verified at " sentence is relabelled "Baseline recorded at , before it merged", so the design reasoning stays readable. rfc-work-dispatch lists #25101 in implementation-prs (the other four already list their PRs).

Backwards compatibility

Compatible. Documentation only.

Removes nothing: no code, config or behaviour changes.

Tests

N/A, documentation only. ./scripts/docs-lint.sh passes (exit 0) and the brand-name gate is clean.

Proof: not provable -- docs or config only

Manual verification

Re-checked on main with git grep: _claude/origin in acp/client_transport.py; release_approval_hold_for in autonudge.py; WORK_WAKE_STATUSES imported in ledger_wake.py; goal_concurrency_cap_reached and work_dispatch in agent_parts/spec_prompts.py. #18285, #16993, #18854, #19338 and #25101 are all merged.

Related Issues

None.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality — N/A, documentation only
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@JiaDe-Wu
JiaDe-Wu requested review from a team and KiroCrewCaptain as code owners November 5, 2026 18:02
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 5, 2026
@JiaDe-Wu
JiaDe-Wu force-pushed the docs/rfc-index-work-ledger-rows-landed branch from 0fcba4d to b69cb98 Compare November 7, 2026 10:48
@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 7, 2026
@iamwhatever
iamwhatever force-pushed the docs/rfc-index-work-ledger-rows-landed branch from b69cb98 to 1c778e2 Compare November 14, 2026 08:34
@iamwhatever iamwhatever changed the title docs(rfc): correct five work-ledger and agent index rows whose work has landed docs(rfc): correct four work-ledger and agent index rows whose work has landed Nov 14, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor

Rebased onto main (head 1c778e2) to clear the merge conflict in docs/request-for-change/README.md. Main has since rewritten the rfc-work-ledger-concurrency-cap row itself (now partial, verified at 9b32941, with the 2026-11-13 §7 amendment), so this PR no longer touches that row and keeps main's text. The other four rows (agent-started-turns, goal-loop-approval-hold, wake-on-stop-signal, work-dispatch) and the work-dispatch implementation-prs field are unchanged from the original commit; I updated the title from five to four rows to match.

@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 14, 2026
@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ⏭️ skipped

Revision 4eb6cb847700bf48d581e4b0e680f11d58dbd094 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ⏭️ skipped

Revision 4eb6cb847700bf48d581e4b0e680f11d58dbd094 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of 4eb6cb847700bf48d581e4b0e680f11d58dbd094 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Documentation-only fix to four index rows. Nothing is taken away and no user-visible surface changes, so nothing blocks.

Notes

[DESIGN-REVIEWED] 4eb6cb8

Description read

[DESCRIPTION-READ] 1caa721ccf91a0aa585f4e99bda6f0b7ce0415ea13b58ab682f314c7be5a0206

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed 4eb6cb847700bf48d581e4b0e680f11d58dbd094 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 4eb6cb8

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed 4eb6cb847700bf48d581e4b0e680f11d58dbd094 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 4eb6cb8

…as landed

Five RFC index rows still say "nothing built" or "implementation
waits" for work that is on main: agent-started-turns (kirodotdev#18285),
goal-loop-approval-hold (kirodotdev#16993), wake-on-stop-signal (kirodotdev#18854),
work-ledger-concurrency-cap (kirodotdev#19338) and work-dispatch (kirodotdev#25101).

Each row now leads with what landed and the PR, and relabels the old
"Verified at" sentence as the baseline recorded before the merge, so
the design reasoning stays readable. Only one symbol per row was
re-checked, at 9c3c6b5, and the row says which. rfc-work-dispatch
now lists its PR in implementation-prs. Statuses and audited-at
stamps are left for a maintainer's re-audit.
@iamwhatever
iamwhatever force-pushed the docs/rfc-index-work-ledger-rows-landed branch from 1c778e2 to 4eb6cb8 Compare November 14, 2026 11:47
@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: Approve

Why: the decider estimates a 7% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes.

Docs-only correction of four RFC index rows plus implementation-prs for rfc-work-dispatch. Every symbol claim was verified in the repo at head (_claude/origin in client_transport.py, release_approval_hold_for in autonudge.py, WORK_WAKE_STATUSES imported in ledger_wake.py, work_dispatch in spec_prompts.py). The fifth row named in the description is already correct at head. No status fields change, so no trust boundary or First Principles lane input moves. Approve; status/vocabulary drift and the four-vs-five wording go in the non-blocking notes.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 4eb6cb8477 · 10 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 14, 2026
@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

Thanks for this. The review found no blocking problems on this head. This PR edits the request-for-change index and an RFC file, so a maintainer needs to agree to it before it can merge. A maintainer will post the decision here.

To propose a design, follow the request-for-change process in CONTRIBUTING.md (docs/request-for-change/).

What the review checked on this head: the diff is two docs files, +5/-5. Commit 9c3c6b5 is an ancestor of main. Every symbol the new "Built:" text cites is present at that commit: _claude/origin in acp/client_transport.py, release_approval_hold_for in autonudge.py, approval_stalled_at in autonudge_service, WORK_WAKE_STATUSES imported in ledger_wake.py, and work_dispatch in agent_parts/spec_prompts.py. The merge dates of #18285, #16993, #18854 and #25101 match main. No script or test reads these rows or implementation-prs. The branch merges cleanly into main. One thing done well: each row says exactly what was re-checked, and the old "Verified at" evidence is kept as a labelled pre-merge baseline instead of being deleted.

Optional:

  • docs: re-audit request-for-change rfcs against main #37153 rewrites the same four rows and the same implementation-prs line, and it also does the status changes. Whichever PR merges second will conflict, so a maintainer should pick the merge order.
  • The PR body table, the Manual verification section and the commit subject still describe five rows, including rfc-work-ledger-concurrency-cap. The diff edits four, because main already rewrote that row. Updating the body table and Manual verification (not the Goal line) would make them match.
  • The Status cells on the agent-started-turns row (accepted) and the goal-loop-approval-hold row (in-progress) disagree with each RFC's own frontmatter (partial, implemented). This was already true on main.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 14, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor

Thanks for this fix, @JiaDe-Wu. Closing it as superseded: #37153 (merged 2026-11-14, re-audit of the request-for-change RFCs against 1d08e941b3) re-audited all four rows this PR corrects (rfc-agent-started-turns, rfc-goal-loop-approval-hold, rfc-wake-on-stop-signal, rfc-work-dispatch). rfc-work-dispatch.md on main is now implemented with implementation-prs: [25101]. This branch now conflicts with that change and adds nothing on top of it. Please reopen if you see a fact main is still missing.

@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor) merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants