Repository navigation
Conversation
5a76b98 to
5fdd811
Compare
5fdd811 to
e2ef40b
Compare
First Principles Review (Opus 5.5, fork) — ⏭️ skippedRevision |
UX Review (Opus 5.5, fork) — ⏭️ skippedRevision |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Docs-only index correction; the cited files exist on base and nothing is taken away. Notes
[DESIGN-REVIEWED] 1ecdfa4 Description read[DESCRIPTION-READ] 68aece973a9072899cf1830245974842e4aa8391716f4cad774ff2298c7669f7 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Code change approver recommendation: ApproveWhy: the decider estimates a 7% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes. Documentation-only correction of eight RFC index rows plus two implementation-prs front-matter entries. Every file and symbol the rewritten rows cite exists in the repo: dashboard_agentic.py, page_look.py, page_offer.py, member_goals.py (CADENCE_HEARTBEAT at line 127), DASHBOARD_BUILD_LINE in goal_reminder.py:283, edition.py, the blocking docstring in ask_question.py, CrewDashboardTab.tsx and layoutTree.ts. profile_goals_soon has no hit outside docs. No status field changes, so the decision record the First Principles lane reads is unaffected, and nothing outside the docs reads implementation-prs. The rows are now more accurate than on main. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
…hose work has landed Eight RFC index rows still say the work is not built or still open for changes that merged: crewmate-dynamic-dashboard (kirodotdev#17507), crewmate-page-on-goal-wake (kirodotdev#22533, kirodotdev#22560), crewmate-page-ambient-motion (kirodotdev#22533), crewmate-heartbeat (kirodotdev#21172), crewmate-goals (kirodotdev#19539), crew-enterprise-edition (the edition constant, kirodotdev#23213), question-card-pager (kirodotdev#15250) and composable-layout-mechanism (kirodotdev#13572). Each row now leads with what landed and the PR, and relabels the old "Verified at" sentence as the baseline recorded before the merge. Only one symbol per row was re-checked, at 9c3c6b5, and the row says which; the enterprise row is marked partly built because only the edition constant was checked. rfc-crewmate-goals and rfc-crew-enterprise-edition now list their PR in implementation-prs. Statuses and audited-at stamps are left for a maintainer's re-audit.
e2ef40b to
1ecdfa4
Compare
|
This PR edits the request-for-change index and two RFC documents. A maintainer decides changes to design docs, so this review does not approve it. A maintainer will review and post the decision here. To propose a design, follow the request-for-change process in CONTRIBUTING.md (docs/request-for-change/). Review result on this head: nothing blocks. All eight cited PRs (#23213, #17507, #15250, #13572, #19539, #22533, #22560, #21172) are on main, and their merge dates match. Commit 9c3c6b5 is on main, and every file and symbol the rows name exists at that commit. Each old "Verified at" sentence is kept as a dated baseline, and each row says exactly what was re-checked. That makes the corrections easy to trust. Optional:
|
|
Thanks for this fix, @JiaDe-Wu. Closing it as superseded: #37153 (merged 2026-11-14, re-audit of the request-for-change RFCs against |
Problem / Motivation
Goal: Eight RFC index rows stop saying "not built" or "still open" for changes that merged.
docs/request-for-change/README.mdsays that when a document and the code disagree the document is the bug. These rows still describe the tree from before their work merged:rfc-crewmate-dynamic-dashboardmanifest.py,dashboard_agentic.py,CrewDashboardTab.tsxrfc-crewmate-page-on-goal-wakeDASHBOARD_BUILD_LINE,page_offer.pyabsent; #22533 and #22560 openrfc-crewmate-page-ambient-motionpage_look.pyabsent; #22533 openrfc-crewmate-heartbeatCADENCE_HEARTBEATinmember_goals.py(#21172)rfc-crewmate-goalsprofile_goals_soonmember_goals.pyexists,profile_goals_soonhas no hit (#19539)rfc-crew-enterprise-editionedition.pyrfc-question-card-pagerrfc-composable-layout-mechanismWhy it matters
The index is how a reader decides what exists before building on it. Several of these rows describe accepted designs that shipped, so a reader planning on top of them reads that nothing is there. The enterprise edition row matters for anyone planning work that depends on the edition constant.
Not a goal
audited-atstamp, or re-auditing the rest of each row. Only one symbol per row was re-checked, and each row says which.What changed (motivation → approach → change)
Each row now leads with what landed and the PR with its merge date. The old "Verified at " sentence is relabelled "Baseline recorded at , before it merged", so the design reasoning stays readable.
rfc-crewmate-goalsandrfc-crew-enterprise-editionlist their PR inimplementation-prs; the others already did.Backwards compatibility
Compatible. Documentation only.
Removes nothing: no code, config or behaviour changes.
Tests
N/A, documentation only.
./scripts/docs-lint.shpasses (exit 0) and the brand-name gate is clean.Proof: not provable -- docs or config only
Manual verification
Re-checked on main with
git grepandls:dashboard_agentic.py,dashboard_templates/page_look.py,dashboard/page_offer.py,member_goals.py,edition.py,dashboard/handlers/ask_question.pyandwebsite/src/components/crew/layout/layoutTree.tsexist;DASHBOARD_BUILD_LINEandCADENCE_HEARTBEATare defined;profile_goals_soonhas no hit insrc/orwebsite/src/. #17507, #22533, #22560, #21172, #19539, #23213, #15250 and #13572 are all merged.Related Issues
None.
Checklist