Skip to content

docs(rfc): correct eight crewmate, enterprise and layout index rows whose work has landed - #30637

Closed
JiaDe-Wu wants to merge 1 commit into
kirodotdev:mainfrom
JiaDe-Wu:docs/rfc-index-crewmate-dashboard-rows-landed
Closed

JiaDe-Wu wants to merge 1 commit into
kirodotdev:mainfrom
JiaDe-Wu:docs/rfc-index-crewmate-dashboard-rows-landed

Conversation

@JiaDe-Wu

@JiaDe-Wu JiaDe-Wu commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Eight RFC index rows stop saying "not built" or "still open" for changes that merged.

docs/request-for-change/README.md says that when a document and the code disagree the document is the bug. These rows still describe the tree from before their work merged:

Document Row said On main
rfc-crewmate-dynamic-dashboard no manifest.py, dashboard_agentic.py, CrewDashboardTab.tsx all exist (#17507)
rfc-crewmate-page-on-goal-wake DASHBOARD_BUILD_LINE, page_offer.py absent; #22533 and #22560 open present; both merged 2026-10-22
rfc-crewmate-page-ambient-motion page_look.py absent; #22533 open present; merged
rfc-crewmate-heartbeat no heartbeat cadence CADENCE_HEARTBEAT in member_goals.py (#21172)
rfc-crewmate-goals no per-member goal record; Goals tab shows profile_goals_soon member_goals.py exists, profile_goals_soon has no hit (#19539)
rfc-crew-enterprise-edition no edition.py exists (#23213); other phases not re-checked, so the row says "partly built"
rfc-question-card-pager #15250 open, tool returns at once merged 2026-10-09
rfc-composable-layout-mechanism #13572 in flight, package not on main merged 2026-09-25, package present

Why it matters

The index is how a reader decides what exists before building on it. Several of these rows describe accepted designs that shipped, so a reader planning on top of them reads that nothing is there. The enterprise edition row matters for anyone planning work that depends on the edition constant.

Not a goal

  • Changing any status or audited-at stamp, or re-auditing the rest of each row. Only one symbol per row was re-checked, and each row says which.
  • Rewriting the baseline reasoning in the rows.

What changed (motivation → approach → change)

Each row now leads with what landed and the PR with its merge date. The old "Verified at " sentence is relabelled "Baseline recorded at , before it merged", so the design reasoning stays readable. rfc-crewmate-goals and rfc-crew-enterprise-edition list their PR in implementation-prs; the others already did.

Backwards compatibility

Compatible. Documentation only.

Removes nothing: no code, config or behaviour changes.

Tests

N/A, documentation only. ./scripts/docs-lint.sh passes (exit 0) and the brand-name gate is clean.

Proof: not provable -- docs or config only

Manual verification

Re-checked on main with git grep and ls: dashboard_agentic.py, dashboard_templates/page_look.py, dashboard/page_offer.py, member_goals.py, edition.py, dashboard/handlers/ask_question.py and website/src/components/crew/layout/layoutTree.ts exist; DASHBOARD_BUILD_LINE and CADENCE_HEARTBEAT are defined; profile_goals_soon has no hit in src/ or website/src/. #17507, #22533, #22560, #21172, #19539, #23213, #15250 and #13572 are all merged.

Related Issues

None.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality — N/A, documentation only
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@JiaDe-Wu
JiaDe-Wu requested review from a team and KiroCrewCaptain as code owners November 5, 2026 18:06
@JiaDe-Wu
JiaDe-Wu requested a review from buluoray November 5, 2026 18:06
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 5, 2026
@JiaDe-Wu
JiaDe-Wu force-pushed the docs/rfc-index-crewmate-dashboard-rows-landed branch from 5a76b98 to 5fdd811 Compare November 7, 2026 10:48
@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 7, 2026
@iamwhatever
iamwhatever force-pushed the docs/rfc-index-crewmate-dashboard-rows-landed branch from 5fdd811 to e2ef40b Compare November 14, 2026 08:32
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 14, 2026
@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ⏭️ skipped

Revision 1ecdfa4ca630081d7305478987638b33a7f37014 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ⏭️ skipped

Revision 1ecdfa4ca630081d7305478987638b33a7f37014 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed 1ecdfa4ca630081d7305478987638b33a7f37014 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 1ecdfa4

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed 1ecdfa4ca630081d7305478987638b33a7f37014 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 1ecdfa4

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of 1ecdfa4ca630081d7305478987638b33a7f37014 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Docs-only index correction; the cited files exist on base and nothing is taken away.

Notes

  • The description and title refer to rfc-crew-enterprise-edition, but the patch edits rfc-crew-lts-edition.md. Fix the description so the row can be found by its name.

[DESIGN-REVIEWED] 1ecdfa4

Description read

[DESCRIPTION-READ] 68aece973a9072899cf1830245974842e4aa8391716f4cad774ff2298c7669f7

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 14, 2026
@KiroCrewCaptain

KiroCrewCaptain commented Nov 14, 2026 •

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: Approve

Why: the decider estimates a 7% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes.

Documentation-only correction of eight RFC index rows plus two implementation-prs front-matter entries. Every file and symbol the rewritten rows cite exists in the repo: dashboard_agentic.py, page_look.py, page_offer.py, member_goals.py (CADENCE_HEARTBEAT at line 127), DASHBOARD_BUILD_LINE in goal_reminder.py:283, edition.py, the blocking docstring in ask_question.py, CrewDashboardTab.tsx and layoutTree.ts. profile_goals_soon has no hit outside docs. No status field changes, so the decision record the First Principles lane reads is unaffected, and nothing outside the docs reads implementation-prs. The rows are now more accurate than on main.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 1ecdfa4ca6 · 20 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

…hose work has landed

Eight RFC index rows still say the work is not built or still open
for changes that merged: crewmate-dynamic-dashboard (kirodotdev#17507),
crewmate-page-on-goal-wake (kirodotdev#22533, kirodotdev#22560), crewmate-page-ambient-motion
(kirodotdev#22533), crewmate-heartbeat (kirodotdev#21172), crewmate-goals (kirodotdev#19539),
crew-enterprise-edition (the edition constant, kirodotdev#23213),
question-card-pager (kirodotdev#15250) and composable-layout-mechanism (kirodotdev#13572).

Each row now leads with what landed and the PR, and relabels the old
"Verified at" sentence as the baseline recorded before the merge.
Only one symbol per row was re-checked, at 9c3c6b5, and the row
says which; the enterprise row is marked partly built because only the
edition constant was checked. rfc-crewmate-goals and
rfc-crew-enterprise-edition now list their PR in implementation-prs.
Statuses and audited-at stamps are left for a maintainer's re-audit.
@iamwhatever
iamwhatever force-pushed the docs/rfc-index-crewmate-dashboard-rows-landed branch from e2ef40b to 1ecdfa4 Compare November 14, 2026 11:21
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 14, 2026
@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

This PR edits the request-for-change index and two RFC documents. A maintainer decides changes to design docs, so this review does not approve it. A maintainer will review and post the decision here.

To propose a design, follow the request-for-change process in CONTRIBUTING.md (docs/request-for-change/).

Review result on this head: nothing blocks. All eight cited PRs (#23213, #17507, #15250, #13572, #19539, #22533, #22560, #21172) are on main, and their merge dates match. Commit 9c3c6b5 is on main, and every file and symbol the rows name exists at that commit. Each old "Verified at" sentence is kept as a dated baseline, and each row says exactly what was re-checked. That makes the corrections easy to trust.

Optional:

  • README.md:93 opens the dynamic-dashboard row with "Built:", but the RFC records only P1 as shipped and P2 onward as open. "P1 built:" would match the in-progress status.
  • The title and body name rfc-crew-enterprise-edition, but the file this PR edits is rfc-crew-lts-edition.md, after the rename in refactor: rename the Enterprise Edition to the LTS Edition #32970. Editing the title and body would make the row easy to find.
  • Open PR docs: re-audit request-for-change rfcs against main #37153 rewrites the same eight rows and the same two implementation-prs lines, and it also moves the statuses. Whichever PR merges second will conflict, so a maintainer should choose the order and link the two PRs.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 14, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor

Thanks for this fix, @JiaDe-Wu. Closing it as superseded: #37153 (merged 2026-11-14, re-audit of the request-for-change RFCs against 1d08e941b3) re-audited all eight rows this PR corrects. On main, rfc-crewmate-goals.md is implemented with implementation-prs: [19539, 22962], and rfc-crew-lts-edition.md is partial with implementation-prs: [23213, 23697, 23703, 23968, 24661, 26818, 32970]. This branch now conflicts with that change and adds nothing on top of it. Please reopen if you see a fact main is still missing.

@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor) merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants