Repository navigation
fix(ui): name the Artifacts Load more button for the page load in flight - #30655
Conversation
The per-provider Load more button on the Artifacts page is disabled while the next page loads and swaps its text for a spinner, but its aria-label stayed "Load more <provider> artifacts" throughout, so a screen reader read a disabled Load more with no reason. While the page is loading the label is now "Loading more <provider> artifacts…" and it switches back when the request settles, the same shape kirodotdev#29146 gave the refresh buttons. The new catalog key is added to every catalog and en-XA is regenerated. The test holds page two open, expects the loading name on a disabled button, then expects the idle name on an enabled one once it resolves. Closes kirodotdev#29140
c8c2584 to
66b48d1
Compare
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS This is a one-attribute accessibility fix with a linked issue (#29140) and a test that fails on base. It adds no surface beyond one translation key. What this change shipsInventory (3 items) — 3 justifiedIntent: while the next page of artifacts is loading, a screen-reader user hears why the Load more button is unavailable. FIX.
[FIRST-PRINCIPLES-REVIEWED] 66b48d1 Description read[DESCRIPTION-READ] 7adfcca4da35f0b0255649dceb0bbd835c17064c44c0ce03e5558417957fae9d That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the busy Load more button now gets its own accessible name, and the visible output is unchanged. [DESIGN-REVIEWED] 66b48d1 Description read[DESCRIPTION-READ] 6bcaabd5a86f914e23e3db2ac88192ea747c570770e9e086f63079b805ed4b5f That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5, fork) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. Only the accessible name changes while the page is loading, and no screenshot can show that. Notes
[UX-REVIEWED] 66b48d1 Description read[DESCRIPTION-READ] 6ff12042034724da119c4013d6dcca6fcd6c851b914612c7a02ba2d619c12071 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
Code change approver recommendation: ApproveWhy: the decider estimates a 5% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes. This is a small accessibility fix. While isFetchingNextPage is true, the Load more button's aria-label switches to a new loading_more_artifacts key and goes back to the existing key when the request settles. The new key is in en.manual.json, where load_more_artifacts already lives, and in all 11 translated catalogs plus en-XA, each with {{provider}} kept. I recomputed the en-XA padding with the generator's rules and it matches. The new test holds page 2 open, checks the loading name and aria-disabled while busy, then checks the idle name is restored, so it would fail without the change. The existing focus test holds on to the button element rather than looking it up by name, so the name change can't break it, and the terminal-page /load more/i query doesn't match "Loading more". I found no regressions on sibling paths. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (15 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: accessibility fix that gives the Artifacts "Load more" button a loading-state accessible name while the next page loads, with one new translation key in every catalog and a regression test.
Problem / Motivation
Goal: A screen reader no longer reads an unavailable "Load more artifacts" with no reason while the next page is loading.
The per-provider Load more button on the Artifacts page (
website/src/pages/ArtifactsPageSections.tsx) is busy whileisFetchingNextPage(since #32269 it isaria-disabledplus a click guard, so focus stays on it) and swaps its text for a spinner while the next page loads, but itsaria-labelstayspages.artifactsPage.load_more_artifactsthe whole time. The accessible name says "Load more", and the button is unavailable for no stated reason.Why it matters
A screen-reader user who activates Load more hears nothing change: the name is the same and the control is now disabled. This is the same shape #29146 fixed on four refresh buttons; this button was found by that PR's sibling sweep and left out of its scope.
Not a goal
aria-disabledfocus handling from fix(a11y): keep focus on the remote artifacts Load more while it loads #32269.What changed (motivation → approach → change)
While
isFetchingNextPageis true thearia-labelis a new key,pages.artifactsPage.loading_more_artifacts("Loading more {{provider}} artifacts…"); it switches back to the existing label when the request settles. It is an inline ternary of two translation calls, as in #29146. The key is added toen.manual.jsonnext toload_more_artifacts, translated in the other 11 catalogs, anden-XA.jsonis regenerated withnpm run i18n:pseudo.Backwards compatibility
Compatible. Only the accessible name during an in-flight page load changes; no key is renamed or removed.
Removes nothing: the existing label and key are unchanged.
Tests
names the Load more button for the page load while it is busy, then restores the name(website/src/test/RemoteArtifacts.test.tsx): page two is held open by a deferred promise, so the in-flight state is observable without a timer. The button's name is "Loading more companion provider artifacts…" and it isaria-disabled; the idle name is gone. After page two resolves with another token, the idle name is back andaria-disabledis gone. The fix(a11y): keep focus on the remote artifacts Load more while it loads #32269 focus test in the same file still passes.Proof: not provable -- frontend test (prove.py runs Python only); run by hand, the new test fails with the label reverted (
Unable to find role="button" and name /^loading more companion provider artifacts/i), the other 10 tests in the file pass, and with the fix all pass. Re-run after rebasing on #32269: the new test fails withArtifactsPageSections.tsxat main, and all 12 tests in the file pass with the fix;tsc -p tsconfig.app.json, eslint on both files andcheck-i18n-strings.mjspassManual verification
N/A — unit coverage sufficient: the change is an attribute value, asserted through the accessible name.
npm run typecheck,npm run lint,RemoteArtifacts.test.tsxandArtifactsPage.test.tsx(62 tests) pass, andnpm run i18n:checkis green againstupstream/main.Screenshots / video
N/A — no rendered change: only the accessible name differs while the button is already busy and showing a spinner.
Why no screenshot: the visible output is unchanged; only the
aria-labeldiffers during a page load.Related Issues
Closes #29140
Sibling sweep
Swept:
git grep -n -B3 -A3 "disabled={.*isFetchingNextPage" -- website/src ':!*.test.*'Sibling: website/src/pages/ArtifactsPageSections.tsx -- changed here
Sibling: website/src/apps/aws-control/DrivePageFiles.tsx -- not affected -- the visible text stays "Load more" while disabled, so there is no icon-only state
Sibling: website/src/apps/aws-control/DrivePageLibrary.tsx -- not affected -- same: visible text, no icon-only state
Sibling: website/src/pages/overview/MemoryRetiredCard.tsx -- not affected -- same: visible text, no icon-only state
Pattern harvest
Not generalizable: an icon-only loading state that keeps the idle
aria-label; each such button is found by the sweep above, and a rule would need to know which props carry the name.Checklist