Skip to content

fix(ui): name the Artifacts Load more button for the page load in flight - #30655

Merged
KiroCrewCaptain merged 1 commit into
kirodotdev:mainfrom
JiaDe-Wu:fix/artifacts-load-more-aria-label
Nov 14, 2026
Merged

KiroCrewCaptain merged 1 commit into
kirodotdev:mainfrom
JiaDe-Wu:fix/artifacts-load-more-aria-label

Conversation

@JiaDe-Wu

@JiaDe-Wu JiaDe-Wu commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A screen reader no longer reads an unavailable "Load more artifacts" with no reason while the next page is loading.

The per-provider Load more button on the Artifacts page (website/src/pages/ArtifactsPageSections.tsx) is busy while isFetchingNextPage (since #32269 it is aria-disabled plus a click guard, so focus stays on it) and swaps its text for a spinner while the next page loads, but its aria-label stays pages.artifactsPage.load_more_artifacts the whole time. The accessible name says "Load more", and the button is unavailable for no stated reason.

Why it matters

A screen-reader user who activates Load more hears nothing change: the name is the same and the control is now disabled. This is the same shape #29146 fixed on four refresh buttons; this button was found by that PR's sibling sweep and left out of its scope.

Not a goal

What changed (motivation → approach → change)

While isFetchingNextPage is true the aria-label is a new key, pages.artifactsPage.loading_more_artifacts ("Loading more {{provider}} artifacts…"); it switches back to the existing label when the request settles. It is an inline ternary of two translation calls, as in #29146. The key is added to en.manual.json next to load_more_artifacts, translated in the other 11 catalogs, and en-XA.json is regenerated with npm run i18n:pseudo.

Backwards compatibility

Compatible. Only the accessible name during an in-flight page load changes; no key is renamed or removed.

Removes nothing: the existing label and key are unchanged.

Tests

  • names the Load more button for the page load while it is busy, then restores the name (website/src/test/RemoteArtifacts.test.tsx): page two is held open by a deferred promise, so the in-flight state is observable without a timer. The button's name is "Loading more companion provider artifacts…" and it is aria-disabled; the idle name is gone. After page two resolves with another token, the idle name is back and aria-disabled is gone. The fix(a11y): keep focus on the remote artifacts Load more while it loads #32269 focus test in the same file still passes.

Proof: not provable -- frontend test (prove.py runs Python only); run by hand, the new test fails with the label reverted (Unable to find role="button" and name /^loading more companion provider artifacts/i), the other 10 tests in the file pass, and with the fix all pass. Re-run after rebasing on #32269: the new test fails with ArtifactsPageSections.tsx at main, and all 12 tests in the file pass with the fix; tsc -p tsconfig.app.json, eslint on both files and check-i18n-strings.mjs pass

Manual verification

N/A — unit coverage sufficient: the change is an attribute value, asserted through the accessible name. npm run typecheck, npm run lint, RemoteArtifacts.test.tsx and ArtifactsPage.test.tsx (62 tests) pass, and npm run i18n:check is green against upstream/main.

Screenshots / video

N/A — no rendered change: only the accessible name differs while the button is already busy and showing a spinner.

Why no screenshot: the visible output is unchanged; only the aria-label differs during a page load.

Related Issues

Closes #29140

Sibling sweep

Swept: git grep -n -B3 -A3 "disabled={.*isFetchingNextPage" -- website/src ':!*.test.*'
Sibling: website/src/pages/ArtifactsPageSections.tsx -- changed here
Sibling: website/src/apps/aws-control/DrivePageFiles.tsx -- not affected -- the visible text stays "Load more" while disabled, so there is no icon-only state
Sibling: website/src/apps/aws-control/DrivePageLibrary.tsx -- not affected -- same: visible text, no icon-only state
Sibling: website/src/pages/overview/MemoryRetiredCard.tsx -- not affected -- same: visible text, no icon-only state

Pattern harvest

Not generalizable: an icon-only loading state that keeps the idle aria-label; each such button is found by the sweep above, and a rule would need to know which props carry the name.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable) — N/A
  • No secrets, credentials, or internal references in the diff

@JiaDe-Wu
JiaDe-Wu requested review from a team and KiroCrewCaptain as code owners November 5, 2026 18:20
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 5, 2026
The per-provider Load more button on the Artifacts page is disabled
while the next page loads and swaps its text for a spinner, but its
aria-label stayed "Load more <provider> artifacts" throughout, so a
screen reader read a disabled Load more with no reason.

While the page is loading the label is now "Loading more <provider>
artifacts…" and it switches back when the request settles, the same
shape kirodotdev#29146 gave the refresh buttons. The new catalog key is added to
every catalog and en-XA is regenerated. The test holds page two open,
expects the loading name on a disabled button, then expects the idle
name on an enabled one once it resolves.

Closes kirodotdev#29140
@iamwhatever
iamwhatever force-pushed the fix/artifacts-load-more-aria-label branch from c8c2584 to 66b48d1 Compare November 14, 2026 08:36
@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed 66b48d1dbb1c054377dc97d4c2e37585d7359de4 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 66b48d1

@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ PASS

Premise-level review of 66b48d1dbb1c054377dc97d4c2e37585d7359de4 via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

This is a one-attribute accessibility fix with a linked issue (#29140) and a test that fails on base. It adds no surface beyond one translation key.

What this change ships

Inventory (3 items) — 3 justified

Intent: while the next page of artifacts is loading, a screen-reader user hears why the Load more button is unavailable. FIX.

  1. While a page loads, the Artifacts Load more button's accessible name changes to "Loading more {provider} artifacts…", then goes back to the idle name when the load finishes — justified
  2. A new translation key, pages.artifactsPage.loading_more_artifacts, added to all 13 catalogs — justified
  3. The rewritten comment drops the word "Stable" but keeps its stated reason (an accessible name in both states), which the change still meets — justified

[FIRST-PRINCIPLES-REVIEWED] 66b48d1

Description read

[DESCRIPTION-READ] 7adfcca4da35f0b0255649dceb0bbd835c17064c44c0ce03e5558417957fae9d

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of 66b48d1dbb1c054377dc97d4c2e37585d7359de4 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the busy Load more button now gets its own accessible name, and the visible output is unchanged.

[DESIGN-REVIEWED] 66b48d1

Description read

[DESCRIPTION-READ] 6bcaabd5a86f914e23e3db2ac88192ea747c570770e9e086f63079b805ed4b5f

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ✅ PASS

UX-level review of 66b48d1dbb1c054377dc97d4c2e37585d7359de4 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing to check. Only the accessible name changes while the page is loading, and no screenshot can show that.

Notes

  • Many screen readers don't announce a name change on a button that already has focus. Add a polite live region to RemoteBrowseSection that announces "Loading more {{provider}} artifacts…" when isFetchingNextPage turns true, so the busy state is actually heard.

[UX-REVIEWED] 66b48d1

Description read

[DESCRIPTION-READ] 6ff12042034724da119c4013d6dcca6fcd6c851b914612c7a02ba2d619c12071

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed 66b48d1dbb1c054377dc97d4c2e37585d7359de4 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 66b48d1

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 14, 2026
@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: Approve

Why: the decider estimates a 5% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes.

This is a small accessibility fix. While isFetchingNextPage is true, the Load more button's aria-label switches to a new loading_more_artifacts key and goes back to the existing key when the request settles. The new key is in en.manual.json, where load_more_artifacts already lives, and in all 11 translated catalogs plus en-XA, each with {{provider}} kept. I recomputed the en-XA padding with the generator's rules and it matches. The new test holds page 2 open, checks the loading name and aria-disabled while busy, then checks the idle name is restored, so it would fail without the change. The existing focus test holds on to the button element rather than looking it up by name, so the name change can't break it, and the terminal-page /load more/i query doesn't match "Loading more". I found no regressions on sibling paths.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 66b48d1dbb · 59 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Nov 14, 2026
@KiroCrewCaptain
KiroCrewCaptain enabled auto-merge (squash) November 14, 2026 11:02

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: fix (15 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: accessibility fix that gives the Artifacts "Load more" button a loading-state accessible name while the next page loads, with one new translation key in every catalog and a regression test.

@KiroCrewCaptain
KiroCrewCaptain merged commit 6a61c84 into kirodotdev:main Nov 14, 2026
97 of 101 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Artifacts Load more button keeps its name while disabled for a page load

2 participants