Skip to content

docs(rfc): correct the microvm and mate-sessions index rows whose work has landed - #30660

Open
JiaDe-Wu wants to merge 1 commit into
kirodotdev:mainfrom
JiaDe-Wu:docs/rfc-index-failover-microvm-rows-landed
Open

JiaDe-Wu wants to merge 1 commit into
kirodotdev:mainfrom
JiaDe-Wu:docs/rfc-index-failover-microvm-rows-landed

Conversation

@JiaDe-Wu

@JiaDe-Wu JiaDe-Wu commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Rebased 2026-11-17 (stale-PR cleanup): the RFC index re-audit on main (#37153) already fixed six of the eight rows. This PR now carries what is left: the rfc-remote-instance-on-microvm and rfc-mate-sessions-folder-or-lineage rows, and implementation-prs in rfc-app-contribution-points.md (#26878) and rfc-mate-sessions-folder-or-lineage.md (#26952). The text below is the original description.

Goal: Eight more RFC index rows stop saying "nothing built" or "PR open" for changes that merged.

docs/request-for-change/README.md says that when a document and the code disagree the document is the bug. These rows still describe the tree from before their work merged:

Document Row said On main
rfc-acp-backend-failover nothing on main; phase 1 in open #26123 merged 2026-11-02; acp_failover.py exists
rfc-crew-panel-default-tab nothing built; offerPanelView does not take focus #25936 merged; offerPanelView activates the offered view when nobody has picked one
rfc-conductor-chat-board-on-tab the prompt asks for the Task board widget at every milestone #18608 merged; the prompt skips it when the Dashboard tab shows the board
rfc-app-contribution-points nothing it proposes is built; no messageActions contributes.messageActions validated in manifest_contributes.py (#26878)
rfc-remote-instance-on-microvm nothing of the design; only #17540 open #17540 merged 2026-10-14; cloud/microvm/engine.py exists; suspend, resume and archive not re-checked
rfc-crewmate-workers-under-the-crewmate nothing built; #26952 open #26952 merged 2026-11-02; MATE_ROOT_FIELD in crew_mode.py
rfc-mate-sessions-folder-or-lineage first step #26952 is open merged
rfc-chat-core-extraction ChatEmbed, SideChat, ChatPage still hand-roll their POST; #8599, #8655, #8689 open #8655 and #8689 merged; #8599 closed unmerged; sendTurn used from SideChat and ChatEmbed

Why it matters

The index is how a reader decides what exists before building on it or proposing something that overlaps. The two mate-root rows matter for anyone working on a crewmate's sessions, and the microvm row for anyone planning on remote Crew lanes.

Not a goal

  • Changing any status or audited-at stamp, or re-auditing the rest of each row. Only one symbol per row was re-checked, and each row says which.
  • Rewriting the baseline reasoning in the rows. The microvm row keeps its "acceptance requested" sentence.

What changed (motivation → approach → change)

Each row now leads with what landed and the PR with its merge date. The old "Verified at " sentence is relabelled "Baseline recorded at , before it merged". rfc-crewmate-workers-under-the-crewmate and rfc-mate-sessions-folder-or-lineage list #26952 in implementation-prs, and rfc-app-contribution-points adds #26878; the others already listed theirs.

Backwards compatibility

Compatible. Documentation only.

Removes nothing: no code, config or behaviour changes.

Tests

N/A, documentation only. ./scripts/docs-lint.sh passes (exit 0) and the brand-name gate is clean.

Proof: not provable -- docs or config only

Manual verification

Re-checked on main (aadd0fcbe6) with git grep: acp_failover.py, cloud/microvm/engine.py exist; unpicked is in usePanelTabs.ts; the new Task board rule is in spec_prompts.py; contributes.messageActions is validated in manifest_contributes.py; MATE_ROOT_FIELD is in crew_mode.py; sendTurn is referenced from SideChat.tsx and ChatEmbed.tsx. #26123, #25936, #18608, #26878, #17540, #26952, #8655 and #8689 are merged; #8599 is closed unmerged.

Related Issues

None.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality — N/A, documentation only
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@JiaDe-Wu
JiaDe-Wu requested review from a team and KiroCrewCaptain as code owners November 5, 2026 18:24
@JiaDe-Wu
JiaDe-Wu requested a review from iamwhatever November 5, 2026 18:24
@JiaDe-Wu JiaDe-Wu changed the title docs(rfc): correct eight failover, microvm, mate-root and layout index rows whose work has landed docs(rfc): correct eight failover, microvm, mate-root and chat-core index rows whose work has landed Nov 5, 2026
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 5, 2026
@iamwhatever
iamwhatever force-pushed the docs/rfc-index-failover-microvm-rows-landed branch from a7a25b5 to ee26215 Compare November 17, 2026 22:50
@iamwhatever iamwhatever changed the title docs(rfc): correct eight failover, microvm, mate-root and chat-core index rows whose work has landed docs(rfc): correct the microvm and mate-sessions index rows whose work has landed Nov 17, 2026
@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ⏭️ skipped

Revision ee262157e8082651541df56b9660b34cb93fb60c touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ⏭️ skipped

Revision ee262157e8082651541df56b9660b34cb93fb60c ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of ee262157e8082651541df56b9660b34cb93fb60c via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Docs-only correction of two RFC index rows and two front-matter lists; nothing blocks.

Notes

[DESIGN-REVIEWED] ee26215

Description read

[DESCRIPTION-READ] eb7914cfd4722b168e4bcbfe7bb07a8f36089d224f1daa95ceb310a41cb5ac77

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed ee262157e8082651541df56b9660b34cb93fb60c via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] ee26215

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed ee262157e8082651541df56b9660b34cb93fb60c via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

Notes:

[OPUS-REVIEWED] ee26215

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 18, 2026
…k has landed

The RFC index re-audit on main (kirodotdev#37153) fixed most rows this PR first
touched. Two are left: rfc-remote-instance-on-microvm still says the
MicroVM backend half (kirodotdev#17540, merged 2026-10-14) is open, and
rfc-mate-sessions-folder-or-lineage still calls kirodotdev#26952 open. Both rows
now say what merged. rfc-app-contribution-points.md lists kirodotdev#26878 and
rfc-mate-sessions-folder-or-lineage.md lists kirodotdev#26952 in
implementation-prs.
@iamwhatever
iamwhatever force-pushed the docs/rfc-index-failover-microvm-rows-landed branch from ee26215 to 48c7acc Compare November 18, 2026 00:18
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: action required A blocking check or review needs attention labels Nov 18, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor

Stale-PR cleanup note: every check on head 48c7acc passes except the fork Security Scope Review. Its run did not finish (scope-floor:unsettled) because the shared GitHub app API rate limit was spent, so it found nothing. This PR is docs-only. A maintainer can re-run the Fork Security Scope Review lane for this head once the rate limit clears, and readiness will then re-evaluate.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor) readiness: checking Automated validation is still running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants