Repository navigation
Conversation
a7a25b5 to
ee26215
Compare
UX Review (Opus 5.5, fork) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5, fork) — ⏭️ skippedRevision |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Docs-only correction of two RFC index rows and two front-matter lists; nothing blocks. Notes
[DESIGN-REVIEWED] ee26215 Description read[DESCRIPTION-READ] eb7914cfd4722b168e4bcbfe7bb07a8f36089d224f1daa95ceb310a41cb5ac77 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. Notes:
[OPUS-REVIEWED] ee26215 |
…k has landed The RFC index re-audit on main (kirodotdev#37153) fixed most rows this PR first touched. Two are left: rfc-remote-instance-on-microvm still says the MicroVM backend half (kirodotdev#17540, merged 2026-10-14) is open, and rfc-mate-sessions-folder-or-lineage still calls kirodotdev#26952 open. Both rows now say what merged. rfc-app-contribution-points.md lists kirodotdev#26878 and rfc-mate-sessions-folder-or-lineage.md lists kirodotdev#26952 in implementation-prs.
ee26215 to
48c7acc
Compare
|
Stale-PR cleanup note: every check on head 48c7acc passes except the fork Security Scope Review. Its run did not finish ( |
Problem / Motivation
Goal: Eight more RFC index rows stop saying "nothing built" or "PR open" for changes that merged.
docs/request-for-change/README.mdsays that when a document and the code disagree the document is the bug. These rows still describe the tree from before their work merged:rfc-acp-backend-failoveracp_failover.pyexistsrfc-crew-panel-default-tabofferPanelViewdoes not take focusofferPanelViewactivates the offered view when nobody has picked onerfc-conductor-chat-board-on-tabrfc-app-contribution-pointsmessageActionscontributes.messageActionsvalidated inmanifest_contributes.py(#26878)rfc-remote-instance-on-microvmcloud/microvm/engine.pyexists; suspend, resume and archive not re-checkedrfc-crewmate-workers-under-the-crewmateMATE_ROOT_FIELDincrew_mode.pyrfc-mate-sessions-folder-or-lineagerfc-chat-core-extractionsendTurnused from SideChat and ChatEmbedWhy it matters
The index is how a reader decides what exists before building on it or proposing something that overlaps. The two mate-root rows matter for anyone working on a crewmate's sessions, and the microvm row for anyone planning on remote Crew lanes.
Not a goal
audited-atstamp, or re-auditing the rest of each row. Only one symbol per row was re-checked, and each row says which.What changed (motivation → approach → change)
Each row now leads with what landed and the PR with its merge date. The old "Verified at " sentence is relabelled "Baseline recorded at , before it merged".
rfc-crewmate-workers-under-the-crewmateandrfc-mate-sessions-folder-or-lineagelist #26952 inimplementation-prs, andrfc-app-contribution-pointsadds #26878; the others already listed theirs.Backwards compatibility
Compatible. Documentation only.
Removes nothing: no code, config or behaviour changes.
Tests
N/A, documentation only.
./scripts/docs-lint.shpasses (exit 0) and the brand-name gate is clean.Proof: not provable -- docs or config only
Manual verification
Re-checked on main (
aadd0fcbe6) withgit grep:acp_failover.py,cloud/microvm/engine.pyexist;unpickedis inusePanelTabs.ts; the new Task board rule is inspec_prompts.py;contributes.messageActionsis validated inmanifest_contributes.py;MATE_ROOT_FIELDis increw_mode.py;sendTurnis referenced fromSideChat.tsxandChatEmbed.tsx. #26123, #25936, #18608, #26878, #17540, #26952, #8655 and #8689 are merged; #8599 is closed unmerged.Related Issues
None.
Checklist