Skip to content

feat(connections): register Quo, launch-gated - #30668

Merged
bolichen97 merged 1 commit into
mainfrom
fix/19182-quo-connector
Nov 6, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
fix/19182-quo-connector

Conversation

@bolichen97

@bolichen97 bolichen97 commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Quo users get a catalogue-governed Connect for Quo's hosted MCP server, hidden behind the launch gate until the manual check passes.

The Connections catalogue has no Quo entry. A user who wants an agent to read their Quo texts, calls and contacts has to add https://mcp.quo.com/mcp by hand, and gets none of the catalogue's guarantees: no nightly OAuth metadata watch, no consent-banner allowlisting, no narrowed scopes and no copy saying which tools text or call real people.

Why it matters

Quo (formerly OpenPhone) hosts its own remote MCP server, is listed in both the Claude and ChatGPT connector directories, and publishes standard OAuth discovery with dynamic client registration and PKCE, so it clears the first rungs of the admission path. Its tools can send texts, have Quo's AI agent place calls, and file a billed carrier registration, so a curated entry that asks for read access only and names those tools is worth more here than for most vendors.

Not a goal

  • Flipping launch_gate_passed: the Connect grid renders the same cards as main until a human walks the flow with a real Quo account.
  • Verifying the revoke surface: revoke_verified_note says pending manual check.
  • A logo: the card's lettered fallback covers an entry with no mark, as it does for Amplitude and the Google entries.
  • Any change to the registry loader, the alias pass or the Connections page.

What changed (motivation → approach → change)

Quo joins src/kiro_crew/connections/registry.json hidden, the same way TickTick did (#29289): tier 2, launch_gate_passed: false, category calendar-email (the registry's communication bucket; Claude's directory files Quo under Communication).

Fact Value, from live discovery on 2026-11-05
Endpoint https://mcp.quo.com/mcp (401 with resource_metadata pointing at its RFC 9728 document)
Issuer https://mcp.quo.com, with registration_endpoint (DCR) and PKCE S256
Scopes requested read:account, read:conversations, read:calls, out of eight in scopes_supported
Smoke fixture list-inboxes, a read-only tool with no required arguments
Tool aliases none: Quo's hyphenated tool names collide with no other catalogue provider

Quo is the rare vendor that publishes separate read and write scopes, so the entry asks only for the read ones and leaves the write half of the issue's title out on purpose. Quo does not document whether a read-only grant can still call its write tools, so the entry's gotcha_copy (reference text, not rendered on the card) says to treat them as callable and names the ones that send texts and spend credits, the two that have Quo's Sona agent call or text a person on its own, the billed carrier registration, and the inbox-settings change that applies to live calls. The consent URL mcp.quo.com/authorize joins _OAUTH_AUTHORIZATION_ENDPOINTS in security/exfil_oauth.py and the URL corpus as one exact host-and-path pair, which is rung 4 of the admission path. The user doc (src/kiro_crew/docs/connections.md, src/kiro_crew/docs/index.md) counts 38 providers, and the spec roster gains a Quo row.

Backwards compatibility

Compatible: the registry gains one hidden entry and the banner allowlist one exact pair; nothing main accepts is rejected.

Removes nothing: every touched file only gains lines or a bumped count.

Tests

  • test/test_connections_registry.py: Quo is on the roster and launch-gated. test_quo_requests_only_read_scopes_and_names_the_tools_that_send_or_spend pins the endpoint, the three read scopes, and the seven send, call, billed and live-settings tools named in the copy.
  • test/oauth_url_corpus.py: a Quo consent URL carrying the three scopes, which the banner allowlist must accept.

Ran on this head (main moved in none of this PR's files since the previous head, so the patch is unchanged): the backend lane of scripts/local-gate.py (59 related files, 2619 passed), mypy on the touched module, black/isort/flake8 on the touched files, check_comment_history.py, check_brand_name.py, check_file_line_cap.py and docs-lint.sh. On an earlier head, before the rebase past the Railway entry (#30662), which landed on the same lines: the three vitest files that import the real registry (141 passed), mypy src/kiro_crew, the flake-pattern ratchet and semgrep 1.78.0 on the diff. Determinism, on that earlier head: the new test passed 20 times at -n0, its file plus the URL-corpus and line-budget files passed 10 times at -n 4, and the registry and URL-corpus files passed in a shuffled order (seed 8658).

Manual verification

Done:

  • Both discovery documents fetched live on 2026-11-05 (values above). python -m kiro_crew.connections.l0_probe on the previous head, whose registry is byte-identical to this one: 38 of 38 providers ok, Quo observed authorization_server https://mcp.quo.com, dcr true, pkce true.
  • The tool names come from Quo's published tool list and its Claude directory listing; no signed-in tools/list was run from this checkout.

Still owed before the card goes visible (the launch-gate check, on a test gateway with a real Quo account):

  • Connect, consent, Connected, Test, Disconnect. Quo's docs name only the client's own Disconnect and an RFC 7009 revocation endpoint for ending a grant, so record whether a Quo-side page lists it and replace revoke_page_url (Quo's MCP security page today) with what the check finds.
  • Confirm which tools a read-only grant can call, including list-contacts and get-contact (Quo has no read:contacts scope), and that list-inboxes answers.

Screenshots / video

N/A — the diff touches no frontend file, and the entry ships with launch_gate_passed=false, so the Connect grid renders the same cards as main.

Related Issues

Closes #19182

Split out of #7130. Prior art: #29289 (TickTick), the entry this one mirrors and which closed its issue the same way: the remaining manual launch-gate walk is tracked in the spec roster's gate column, like every other gated entry.

Sibling sweep

N/A — a feat PR, so there is no defect to sweep.

Pattern harvest

N/A — a feat PR.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners November 5, 2026 18:33
@bolichen97
bolichen97 requested a review from CrysisDeu November 5, 2026 18:33
@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Sensitive Change Review

Sensitive files changed:

  • src/kiro_crew/security/exfil_oauth.py

  • No reasoning template for 0e2a5ca yet.

How to clear this check:

  1. The PR author posts the template below as a PR comment, with
    every field filled (N/A needs a reason). Keep the
    Head commit line: it must name the current head SHA.
  2. The check turns green within a minute, with no push.
  3. A new push resets this check: post it again for the new head.

Only the author's comment counts this way. A reviewer can instead
paste the filled template into an "Approve" review on this head.
Merging still needs a reviewer's approval.

## Sensitive change review
- Head commit: 0e2a5caa90498114de8262d5a2c39e26145cd2a5
- What rule changed:
- Before -> after (what was allowed/blocked, now):
- Worst case if wrong (breaks commands / leaks secret / locks user out):
- Evidence checked (which sandbox result proves it):
- No regression:
  - Tools still work (which tools/commands were run, result):
  - Backward compatible (old config / old data / old callers still work, how checked):
  - Existing tests (which suites passed on this head):
- How to undo:

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 5, 2026
@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 0e2a5caa90498114de8262d5a2c39e26145cd2a5 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing to check. One hidden catalogue entry plus the exact consent-host pair its Connect flow needs; no default changes while launch_gate_passed is false.

What this change ships

Inventory (4 items) — 4 justified

Intent: Quo users get a curated, read-scoped Connect for Quo's hosted MCP server, kept hidden until the manual launch-gate check passes. ADDITION.

  1. A Quo entry is added to the Connections catalogue but stays hidden behind the launch gate: three read scopes and a list of the tools that send texts, place calls or spend credits — justified
  2. The ACP consent-banner allowlist now accepts Quo's consent URL mcp.quo.com/authorize (one exact host-and-path pair) — justified
  3. The user docs now say the catalogue has 38 providers instead of 37 — justified
  4. The connections spec roster gains a Quo row with its launch-gate status — justified

[FIRST-PRINCIPLES-REVIEWED] 0e2a5ca

Description read

[DESCRIPTION-READ] 9cf1c1577e7e2bac0a447f9525159f31149a7faec5e600881d1b3d833cbc9dfa

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 0e2a5caa90498114de8262d5a2c39e26145cd2a5 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 0e2a5caa90498114de8262d5a2c39e26145cd2a5 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this adds one hidden, launch-gated registry entry and one exact consent-host pair, takes nothing away, and follows the TickTick precedent.

Notes

  • Missing revoke_manual_path and a revoke_page_url that points at a docs page are expected to be replaced at the manual launch-gate check. Make sure that check fails if they are still placeholders, so the card can't go visible with them.

[DESIGN-REVIEWED] 0e2a5ca

Description read

[DESCRIPTION-READ] 6629f02a6977c27f65f1fdac5312b0f196ce7531fd584ff4878186e8816d56b3

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 0e2a5caa90498114de8262d5a2c39e26145cd2a5 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 0e2a5ca

Verdict parsed from the review's SHA-scoped output markers for commit 0e2a5caa90498114de8262d5a2c39e26145cd2a5.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 0e2a5caa90498114de8262d5a2c39e26145cd2a5 false-positive: <reason, 20 to 500 characters>

@bolichen97
bolichen97 enabled auto-merge (squash) November 5, 2026 18:43
@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 0e2a5caa90498114de8262d5a2c39e26145cd2a5 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 0e2a5ca

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 0e2a5caa90498114de8262d5a2c39e26145cd2a5 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 5, 2026
@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Security Scope Review -- ✅ PASS

Which legitimate operations does 0e2a5caa90498114de8262d5a2c39e26145cd2a5 newly refuse? Updated in place on each push. A script-confirmed regression blocks; the model proposes candidates and never decides a refusal.

Verdict basis: adjudicated, zero confirmed regressions.

Security scope review -- adjudicated candidates

  • macos-latest (platform posix): 9 classified, 0 newly refused, 9 still allowed.
  • ubuntu-latest (platform posix): 9 classified, 0 newly refused, 9 still allowed.
  • windows-latest (platform windows): 5 classified, 0 newly refused, 5 still allowed.

No candidate flipped from allowed to refused.

Scope-Verdict: PASS

Reason: Nothing in this diff makes a check stricter. Its only security-relevant hunk adds one exact (host, path) pair to the code-owned OAuth consent-endpoint allowlist, which can only let more through. The guard it changes is the ACP banner-safety gate for OAuth consent URLs, not the shell deny composite, so the shell classifier can't measure the change directly; that gap is named under UNADJUDICATED.

TIGHTENING: none. The one security edit loosens a check: src/kiro_crew/security/exfil_oauth.py _OAUTH_AUTHORIZATION_ENDPOINTS gains + ("mcp.quo.com", "/authorize"),. This exempts the standard front-channel parameters on that exact HTTPS endpoint, with no explicit port, from the base64-blob and query-length checks, so that Quo's consent banner can open. Before this, it failed closed with "URL contained credential or exfiltration pattern". The rest of the diff is the registry entry, docs, and tests.

ADJUDICATED: 14 candidates, 0 confirmed newly-refused

PLATFORM COVERAGE: The diff adds no assumption about paths, separators, executables or environment variables. The new pair is a host-and-path string compared exactly, the same on every platform.

  • posix: the RFC 9728 and RFC 8414 discovery curl probes against mcp.quo.com, a HEAD check of the MCP endpoint, the pytest runs for the touched tests, json.tool validation of the registry, a grep for the new entry, and open/xdg-open on the entry's docs and revoke URLs.
  • windows: the same operations spelled for Windows: curl.exe, backslash test and registry paths, > NUL, and start for the URLs.
  • any: no rows, because every row names an executable or a path.

No platform assumption in the diff is left without a candidate.

UNADJUDICATED: The guard is the ACP banner-safety OAuth carve-out: _approved_oauth_authorization_endpoint (exfil_oauth.py:549). It is reached when an MCP server's OAuth consent URL is checked before its banner is shown (dashboard/chat_turn/mcp_session.py near line 358). It is not part of sensitive-bash, exfil or deny-rules for shell text. The change only adds a member to an exact-match set, so the one operation it can affect is opening a consent URL, and that operation moves from refused to allowed. No input that was allowed before can be refused after it. The input I would have submitted is the consent URL the patch adds to test/oauth_url_corpus.py LEGIT_OAUTH_URLS (quo-mcp): https://mcp.quo.com/authorize with client_id, response_type=code, a loopback redirect_uri, the three read: scopes, an S256 code_challenge and a 128-character state. That corpus row covers it in the repo's own tests; this lane has no verdict for it. The neighbouring endpoints already in the set (for example mcp.miro.com /authorize and mcp.postman.com /authorize) can't be affected by adding a new member.

[SCOPE-REVIEWED] 0e2a5ca

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 5, 2026
@bolichen97
bolichen97 force-pushed the fix/19182-quo-connector branch from 04ad1d6 to adb33cc Compare November 5, 2026 22:39
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 5, 2026
Add Quo's hosted MCP server (https://mcp.quo.com/mcp) to the Connections
registry as a tier-2 entry with launch_gate_passed=false, so the Connect
grid does not change until the manual launch-gate check passes. Quo is
listed by both connector directories and publishes RFC 9728 resource
metadata naming an RFC 8414 issuer with dynamic client registration and
PKCE, so the L0 probe passes and no operator app is needed.

The entry asks only for Quo's read scopes. Its gotcha copy names the
tools that send texts, have Quo's agent call or text people, spend
credits or file a billed carrier registration. Quo's consent endpoint
joins the OAuth banner allowlist and the URL corpus; the user doc, the
docs index and the spec roster count the new entry.

Closes #19182
@bolichen97
bolichen97 force-pushed the fix/19182-quo-connector branch from adb33cc to 0e2a5ca Compare November 6, 2026 00:30
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 6, 2026
@bolichen97

bolichen97 commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/system-specs/modules/, src/kiro_crew/docs/ and test/ (same-directory neighbours only; none of this PR's own files changed, and the patch is unchanged) since this head went green (7a09d86 -> 8fb88a6); CI re-running.

The new head also replaces the Security Scope Review red on the old head: that lane's verdict was PASS, and the job failed afterwards on a GitHub API rate limit while reading its own earlier results, which a rerun of the same head cannot clear.

[operator: bolichen97]

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 6, 2026
@bolichen97
bolichen97 merged commit 2b4a348 into main Nov 6, 2026
101 of 103 checks passed
@bolichen97
bolichen97 deleted the fix/19182-quo-connector branch November 6, 2026 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quo connector: read, write and trigger actions through its API

2 participants