Repository navigation
Conversation
eb094fa to
40f1f09
Compare
40f1f09 to
58bef20
Compare
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
First Principles Review (Opus 5.5, fork) — ⏭️ skippedRevision |
UX Review (Opus 5.5, fork) — ⏭️ skippedRevision |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this changes docs only, and the rows it edits now match the code on main. Notes
[DESIGN-REVIEWED] 3404de3 Description read[DESCRIPTION-READ] 2cb4e3eeb9ebdef816a7aae4e9ce8eb8465d6de0ad79b00b41c3cbdda5fcdb40 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Code change approver recommendation: ApproveWhy: the decider estimates a 7% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes. Docs-only fix to six RFC index rows plus three front-matter implementation-prs lists. Every claim the diff makes was checked in repo/ and holds: fresh_conversation=True in history_consolidation_pass.py; UPKEEP_DIR_NAME and _upkeep exist; session_control.py calls ensure_patrol and conductor_patrol.py names the member-thread exception; terminal.py uses WindowsPty; resolve_parent_policy/_founding_session and root_session_key exist for founder trust; WorkflowDefinitionLibrary.remove() tombstones and the DELETE route exists. No status or audited-at stamp changes, which matches the stated non-goals. The PR description contradicts the diff on two rows, but the diff is the correct one, so this is description drift and does not block. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Thanks for keeping these RFC index rows honest. Five of the six updated rows match main. One row needs a fix before this can merge.
docs/request-for-change/README.md:171(the rfc-workflow-library-removal row). Once this merges, the index will say thatworkflows/library.py"has no removal or tombstone, so 'nothing yet' still holds but no implementation PR is open". That is not true at this PR's own merge-base. #27528 ("remove a saved workflow from the library", merged 2026-11-08,Fixes #18998) is already in the base. At this head,WorkflowDefinitionLibrary.remove()atsrc/kiro_crew/workflows/library.py:534writes a tombstone, andDELETE /api/workflows/definitions/{ref}insrc/kiro_crew/dashboard/handlers/workflows.pybacks it. A reader would think the work is unclaimed and pick it up again. The claim was true at thed775742d19stamp, but the second commit re-checked only the founder row against the new base. Smallest fix: re-check this row at the current merge-base, as you did for the founder row. Say that #19040 was closed unmerged and that #27528 built the removal (tombstone plus the DELETE route). Drop "nothing yet still holds" and "no implementation PR is open", and leave the status for a maintainer. Optionally, add 27528 toimplementation-prsinrfc-workflow-library-removal.md, the same way the other two front-matter edits list their merged PRs.
Optional:
- The table and Manual verification in the PR body still say that
root_session_key/contested_roothave no hit insrc/. The founder row at this head correctly says founder trust is on main. The body also says library.py has no tombstone or remove. Please correct these in a PR comment or in the Manual verification section, and leave the Goal, Why it matters and Not a goal sections as they are. - Open #37153 rewrites five of the same rows. It is not a duplicate, because it changes statuses. But whichever PR merges second will need a rebase, so linking the two would help a maintainer choose the merge order.
85bd5f4 to
33f6ee5
Compare
|
Addressed the review in 33f6ee5 (squashed to keep PR Hygiene's 2-commit cap): the rfc-workflow-library-removal row is re-checked at the merge-base 6a61c84. It now says #19040 was closed unmerged and #27528 (merged 2026-11-08) built the removal, with Correction to the PR body's table and Manual verification: founder trust ( Note for merge order: open #37153 rewrites five of the same rows; whichever merges second will need a rebase. |
…erged Six RFC index rows describe an implementation PR that has since merged or died. Merged: consolidation-fresh-conversation (kirodotdev#22207), crewmate-dashboard-upkeep-skill (kirodotdev#19069, kirodotdev#19866), conductor-default-patrol (kirodotdev#19742, kirodotdev#27948) and terminal-exit-closes-tab (kirodotdev#14511). Closed unmerged: conversation-trust-follows-founder (kirodotdev#13109) and workflow-library-removal (kirodotdev#19040), whose rows still call them open. Merged rows lead with what landed and relabel the old "Verified at" sentence as the baseline. For the two closed PRs the row keeps its original text behind an update line that says the PR is closed and that the feature is still not on main, since only a maintainer can re-judge the in-progress status. Only one symbol per row was re-checked, at d775742, and the row says which. Two documents now list their PRs in implementation-prs.
… in kirodotdev#27528 Re-checked the founder row and the rfc-workflow-library-removal row at the merge-base 6a61c84. kirodotdev#27528 added the tombstone remove() and the DELETE route, so that row no longer says nothing yet; list kirodotdev#27528 in implementation-prs beside the closed kirodotdev#19040.
33f6ee5 to
3404de3
Compare
|
Thanks for keeping these RFC index rows accurate. The review found nothing that blocks this PR. It edits the request-for-change index and RFC front matter, which are design records, so a maintainer decides the merge. If any of these rows needs a status change, that is a separate proposal. To propose a design, follow the request-for-change process in CONTRIBUTING.md (docs/request-for-change/). Earlier review: the README.md:171 row (rfc-workflow-library-removal) is fixed on this head. It now says #19040 was closed unmerged and #27528 built the removal through What the review checked on this head: the cited merged PRs (#22207, #19742, #27948, #19069, #14511, #27528) are on main, and #13109 and #19040 were closed without merging. The cited commits are on main. Every symbol the six rows name exists where the rows say: Optional:
|
Withdrawn: every item in this review is fixed or answered on the current head (see the follow-up comment). Other holds on this PR are listed there.
|
Thanks for this fix, @JiaDe-Wu. Closing it as superseded: #37153 (merged 2026-11-14, re-audit of the request-for-change RFCs against |
Problem / Motivation
Goal: Six RFC index rows stop pointing at implementation PRs that have merged, or that were closed without merging.
docs/request-for-change/README.mdsays that when a document and the code disagree the document is the bug. These rows are wrong about their PR:rfc-consolidation-fresh-conversationhistory_consolidation_pass.pycallsbackground_turn(..., fresh_conversation=True)rfc-crewmate-dashboard-upkeep-skilldashboard_upkeep.pyand_upkeepindashboard_templates/manifest.pyexistrfc-conductor-default-patrolapi_session_control_createcallensure_patrol; the amendment merged as #27948rfc-terminal-exit-closes-tabterminal.pyusesWindowsPtyrfc-conversation-trust-follows-founderroot_session_key/contested_roothave no hit insrc/rfc-workflow-library-removalworkflows/library.pyhas no removalWhy it matters
The first four make a reader think the work does not exist. The last two are the opposite and quieter: the status
in-progressreads as "someone is on it" when the PR it hangs on is dead, so nobody picks the work up.Not a goal
audited-atstamp. Whether the two dead-PR documents go back toaccepted, orrfc-terminal-exit-closes-tabbecomesimplemented, is a maintainer's call.What changed (motivation → approach → change)
Rows whose PR merged lead with what landed, the PR and the merge date, and the old "Verified at" sentence is relabelled as the baseline. For the two closed PRs the original row stays behind an update line stating that the PR is closed unmerged and that the feature is still not on main.
rfc-crewmate-dashboard-upkeep-skillandrfc-conductor-default-patrollist their merged PRs inimplementation-prs.Backwards compatibility
Compatible. Documentation only.
Removes nothing: no code, config or behaviour changes.
Tests
N/A, documentation only.
./scripts/docs-lint.shpasses (exit 0) and the brand-name gate is clean.Proof: not provable -- docs or config only
Manual verification
Re-checked on main (
d775742d19) withgit grepandgh pr view:fresh_conversation=Trueinhistory_consolidation_pass.py;UPKEEP_DIR_NAMEindashboard_upkeep.pyand_upkeepinmanifest.py;ensure_patrolcalled insession_control.py;WindowsPtyinterminal.py; no hit forroot_session_key|contested_rootinsrc/and none fortombstone|removeinworkflows/library.py. #22207, #19069, #19866, #19742, #27948 and #14511 are merged; #13109 and #19040 are closed withmergedAt: null.Related Issues
None.
Checklist