Skip to content

docs(rfc): correct six index rows whose PRs merged or were closed unmerged - #30675

Closed
JiaDe-Wu wants to merge 2 commits into
kirodotdev:mainfrom
JiaDe-Wu:docs/rfc-index-consolidation-upkeep-patrol-rows
Closed

JiaDe-Wu wants to merge 2 commits into
kirodotdev:mainfrom
JiaDe-Wu:docs/rfc-index-consolidation-upkeep-patrol-rows

Conversation

@JiaDe-Wu

@JiaDe-Wu JiaDe-Wu commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Six RFC index rows stop pointing at implementation PRs that have merged, or that were closed without merging.

docs/request-for-change/README.md says that when a document and the code disagree the document is the bug. These rows are wrong about their PR:

Document Row said Actually
rfc-consolidation-fresh-conversation nothing yet #22207 merged 2026-10-19; history_consolidation_pass.py calls background_turn(..., fresh_conversation=True)
rfc-crewmate-dashboard-upkeep-skill nothing yet #19069 and #19866 merged; dashboard_upkeep.py and _upkeep in dashboard_templates/manifest.py exist
rfc-conductor-default-patrol phase 2 arm-on-create not on main; the 2026-11-02 amendment in an open PR #19742 made api_session_control_create call ensure_patrol; the amendment merged as #27948
rfc-terminal-exit-closes-tab the Windows ConPTY exit status, #14511, is not merged merged 2026-10-10; terminal.py uses WindowsPty
rfc-conversation-trust-follows-founder in-progress while #13109 is open #13109 was closed unmerged; root_session_key / contested_root have no hit in src/
rfc-workflow-library-removal in-progress; the implementation is #19040 #19040 was closed unmerged; workflows/library.py has no removal

Why it matters

The first four make a reader think the work does not exist. The last two are the opposite and quieter: the status in-progress reads as "someone is on it" when the PR it hangs on is dead, so nobody picks the work up.

Not a goal

  • Changing any status or audited-at stamp. Whether the two dead-PR documents go back to accepted, or rfc-terminal-exit-closes-tab becomes implemented, is a maintainer's call.
  • Re-auditing the rest of each row; only one symbol per row was re-checked.

What changed (motivation → approach → change)

Rows whose PR merged lead with what landed, the PR and the merge date, and the old "Verified at" sentence is relabelled as the baseline. For the two closed PRs the original row stays behind an update line stating that the PR is closed unmerged and that the feature is still not on main. rfc-crewmate-dashboard-upkeep-skill and rfc-conductor-default-patrol list their merged PRs in implementation-prs.

Backwards compatibility

Compatible. Documentation only.

Removes nothing: no code, config or behaviour changes.

Tests

N/A, documentation only. ./scripts/docs-lint.sh passes (exit 0) and the brand-name gate is clean.

Proof: not provable -- docs or config only

Manual verification

Re-checked on main (d775742d19) with git grep and gh pr view: fresh_conversation=True in history_consolidation_pass.py; UPKEEP_DIR_NAME in dashboard_upkeep.py and _upkeep in manifest.py; ensure_patrol called in session_control.py; WindowsPty in terminal.py; no hit for root_session_key|contested_root in src/ and none for tombstone|remove in workflows/library.py. #22207, #19069, #19866, #19742, #27948 and #14511 are merged; #13109 and #19040 are closed with mergedAt: null.

Related Issues

None.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality — N/A, documentation only
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@JiaDe-Wu
JiaDe-Wu requested review from a team and KiroCrewCaptain as code owners November 5, 2026 18:44
@JiaDe-Wu
JiaDe-Wu requested a review from iamwhatever November 5, 2026 18:44
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention labels Nov 5, 2026
@iamwhatever
iamwhatever force-pushed the docs/rfc-index-consolidation-upkeep-patrol-rows branch from eb094fa to 40f1f09 Compare November 14, 2026 08:46
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 14, 2026
@iamwhatever
iamwhatever force-pushed the docs/rfc-index-consolidation-upkeep-patrol-rows branch from 40f1f09 to 58bef20 Compare November 14, 2026 11:51
@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed 3404de32f2f666ba26cb682e18277bdf12be69a4 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 3404de3

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed 3404de32f2f666ba26cb682e18277bdf12be69a4 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 3404de3

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 14, 2026
@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ⏭️ skipped

Revision 3404de32f2f666ba26cb682e18277bdf12be69a4 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ⏭️ skipped

Revision 3404de32f2f666ba26cb682e18277bdf12be69a4 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of 3404de32f2f666ba26cb682e18277bdf12be69a4 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this changes docs only, and the rows it edits now match the code on main.

Notes

  • The description is out of date for the two closed-PR rows. It says "the feature is still not on main", that root_session_key / contested_root have "no hit in src/", and that workflows/library.py "has no removal". The diff says the opposite, and the base tree agrees with the diff: run_record.py:143 has root_session_key, library.py:534 has remove(), and turn_session.py:120 has resolve_parent_policy. Post a PR comment correcting the Problem table and Manual verification, so a reader doesn't trust the wrong version.
  • The rfc-workflow-library-removal row still ends with "The implementation is feat(workflows): remove a saved workflow from the library #19040" after the update line. The feature shipped through feat(workflows): remove a saved workflow from the library #27528, so its status of in-progress is now about a finished feature, not just a dead PR. Flag that for the maintainer's re-judge instead of leaving it to the "left for a maintainer" line.

[DESIGN-REVIEWED] 3404de3

Description read

[DESCRIPTION-READ] 2cb4e3eeb9ebdef816a7aae4e9ce8eb8465d6de0ad79b00b41c3cbdda5fcdb40

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 14, 2026
@KiroCrewCaptain

KiroCrewCaptain commented Nov 14, 2026 •

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: Approve

Why: the decider estimates a 7% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes.

Docs-only fix to six RFC index rows plus three front-matter implementation-prs lists. Every claim the diff makes was checked in repo/ and holds: fresh_conversation=True in history_consolidation_pass.py; UPKEEP_DIR_NAME and _upkeep exist; session_control.py calls ensure_patrol and conductor_patrol.py names the member-thread exception; terminal.py uses WindowsPty; resolve_parent_policy/_founding_session and root_session_key exist for founder trust; WorkflowDefinitionLibrary.remove() tombstones and the DELETE route exists. No status or audited-at stamp changes, which matches the stated non-goals. The PR description contradicts the diff on two rows, but the diff is the correct one, so this is description drift and does not block.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 33f6ee5602 · 18 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping these RFC index rows honest. Five of the six updated rows match main. One row needs a fix before this can merge.

  1. docs/request-for-change/README.md:171 (the rfc-workflow-library-removal row). Once this merges, the index will say that workflows/library.py "has no removal or tombstone, so 'nothing yet' still holds but no implementation PR is open". That is not true at this PR's own merge-base. #27528 ("remove a saved workflow from the library", merged 2026-11-08, Fixes #18998) is already in the base. At this head, WorkflowDefinitionLibrary.remove() at src/kiro_crew/workflows/library.py:534 writes a tombstone, and DELETE /api/workflows/definitions/{ref} in src/kiro_crew/dashboard/handlers/workflows.py backs it. A reader would think the work is unclaimed and pick it up again. The claim was true at the d775742d19 stamp, but the second commit re-checked only the founder row against the new base. Smallest fix: re-check this row at the current merge-base, as you did for the founder row. Say that #19040 was closed unmerged and that #27528 built the removal (tombstone plus the DELETE route). Drop "nothing yet still holds" and "no implementation PR is open", and leave the status for a maintainer. Optionally, add 27528 to implementation-prs in rfc-workflow-library-removal.md, the same way the other two front-matter edits list their merged PRs.

Optional:

  • The table and Manual verification in the PR body still say that root_session_key/contested_root have no hit in src/. The founder row at this head correctly says founder trust is on main. The body also says library.py has no tombstone or remove. Please correct these in a PR comment or in the Manual verification section, and leave the Goal, Why it matters and Not a goal sections as they are.
  • Open #37153 rewrites five of the same rows. It is not a duplicate, because it changes statuses. But whichever PR merges second will need a rebase, so linking the two would help a maintainer choose the merge order.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision readiness: action required A blocking check or review needs attention labels Nov 14, 2026
@iamwhatever
iamwhatever force-pushed the docs/rfc-index-consolidation-upkeep-patrol-rows branch from 85bd5f4 to 33f6ee5 Compare November 14, 2026 16:40
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 14, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor

Addressed the review in 33f6ee5 (squashed to keep PR Hygiene's 2-commit cap): the rfc-workflow-library-removal row is re-checked at the merge-base 6a61c84. It now says #19040 was closed unmerged and #27528 (merged 2026-11-08) built the removal, with WorkflowDefinitionLibrary.remove() writing a tombstone and DELETE /api/workflows/definitions/{ref} backing it. "Nothing yet still holds" and "no implementation PR is open" are gone, the status is left for a maintainer, and 27528 is added to implementation-prs.

Correction to the PR body's table and Manual verification: founder trust (root_session_key/contested_root) is on main, and library.py does have remove() and a tombstone, as the rows at this head say.

Note for merge order: open #37153 rewrites five of the same rows; whichever merges second will need a rebase.

JiaDe-Wu and others added 2 commits November 14, 2026 17:14
…erged

Six RFC index rows describe an implementation PR that has since
merged or died. Merged: consolidation-fresh-conversation (kirodotdev#22207),
crewmate-dashboard-upkeep-skill (kirodotdev#19069, kirodotdev#19866),
conductor-default-patrol (kirodotdev#19742, kirodotdev#27948) and terminal-exit-closes-tab
(kirodotdev#14511). Closed unmerged: conversation-trust-follows-founder (kirodotdev#13109)
and workflow-library-removal (kirodotdev#19040), whose rows still call them open.

Merged rows lead with what landed and relabel the old "Verified at"
sentence as the baseline. For the two closed PRs the row keeps its
original text behind an update line that says the PR is closed and
that the feature is still not on main, since only a maintainer can
re-judge the in-progress status. Only one symbol per row was
re-checked, at d775742, and the row says which. Two documents now
list their PRs in implementation-prs.
… in kirodotdev#27528

Re-checked the founder row and the rfc-workflow-library-removal row at
the merge-base 6a61c84. kirodotdev#27528 added the tombstone remove() and the
DELETE route, so that row no longer says nothing yet; list kirodotdev#27528 in
implementation-prs beside the closed kirodotdev#19040.
@iamwhatever
iamwhatever force-pushed the docs/rfc-index-consolidation-upkeep-patrol-rows branch from 33f6ee5 to 3404de3 Compare November 14, 2026 17:15
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 14, 2026
@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

Thanks for keeping these RFC index rows accurate. The review found nothing that blocks this PR. It edits the request-for-change index and RFC front matter, which are design records, so a maintainer decides the merge. If any of these rows needs a status change, that is a separate proposal. To propose a design, follow the request-for-change process in CONTRIBUTING.md (docs/request-for-change/).

Earlier review: the README.md:171 row (rfc-workflow-library-removal) is fixed on this head. It now says #19040 was closed unmerged and #27528 built the removal through remove() and the DELETE route, the status is left for a maintainer, and 27528 is in implementation-prs.

What the review checked on this head: the cited merged PRs (#22207, #19742, #27948, #19069, #14511, #27528) are on main, and #13109 and #19040 were closed without merging. The cited commits are on main. Every symbol the six rows name exists where the rows say: fresh_conversation=True, ensure_patrol in session_control.py, UPKEEP_DIR_NAME and _upkeep, WindowsPty, resolve_parent_policy and _founding_session, root_session_key, and the workflow library remove(). Each row says exactly what was re-checked and at which commit, and keeps the old text labelled as the baseline. Open #37153 rewrites some of the same rows, so whichever PR merges second needs a rebase.

Optional:

@KiroCrewCaptain
KiroCrewCaptain dismissed their stale review November 14, 2026 19:59

Withdrawn: every item in this review is fixed or answered on the current head (see the follow-up comment). Other holds on this PR are listed there.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 14, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor

Thanks for this fix, @JiaDe-Wu. Closing it as superseded: #37153 (merged 2026-11-14, re-audit of the request-for-change RFCs against 1d08e941b3) re-audited all six rows this PR corrects. On main, rfc-conductor-default-patrol.md is implemented with implementation-prs: [17069, 19742, 27948], and the rfc-workflow-library-removal row names #27528. This branch now conflicts with that change. One small gap is left: the front matter of rfc-workflow-library-removal.md still lists only [19040]. A one-line follow-up adding 27528 there would be welcome.

@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor) merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants