Repository navigation
docs(specs): drop two follow-up notes whose issues have shipped - #30698
Conversation
ea9d9bd to
fa2fb70
Compare
UX Review (Opus 5.5, fork) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5, fork) — ⏭️ skippedRevision |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Docs-only removal of two stale follow-up notes; the base tree backs the claim ( [DESIGN-REVIEWED] d63c5a2 Description read[DESCRIPTION-READ] 5c5e1ef429b470bdde554dc11555ff8b8e3b911c8492d83fe2dbb2f3ed7b3656 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
memory-skills-hooks.md says the gateway's unattended policy-provider apply "does not yet" copy memory before it rewrites the install (kirodotdev#21898). kirodotdev#21873 merged on 2026-10-21 and update_apply.py now calls snapshot_memory_before_update ahead of the reset, so every applier takes the copy and the parenthetical is false. crew-mode.md says the Schedules guard state sits in the wrong owner, with follow-up kirodotdev#20512. kirodotdev#29274 moved it into MembersPageProfile.tsx, which the owner table already lists, and kirodotdev#20512 is closed. Both sentences lose the stale note and keep the rule they sat beside.
fa2fb70 to
d63c5a2
Compare
|
Thanks for this cleanup. This PR edits system specs under docs/system-specs/, so a maintainer needs to approve it before it can merge. A maintainer will post the decision here. The review found nothing that blocks this head. I checked that both dropped notes are stale against main. The unattended update apply now runs Optional:
|
bolichen97
left a comment
There was a problem hiding this comment.
Approving. Docs only. It drops two follow-up notes whose issues are closed as completed: #20512 (Schedules exit-guard state moved into its owner hook, closed 2026-11-04) and #21898 (pre-update memory copy on the unattended policy-provider apply, closed 2026-10-24). The surrounding sentences still read correctly without them. No regex. 94 checks green on d63c5a2.
Problem / Motivation
Goal: Two system specs stop describing follow-up work that has shipped.
docs/system-specs/modules/memory-skills-hooks.mdsays "Every applier that rewrites this install takes a copy first. (The gateway's unattended policy-provider apply does not yet: The unattended policy-provider update applies with no pre-update memory copy #21898.)" fix(update): copy memory before the dashboard and unattended appliers rewrite the install #21873 merged 2026-10-21 and the gateway's unattended apply (slack/gateway_runtime/update_apply.py) now awaitssnapshot_memory_before_updatebefore the reset; The unattended policy-provider update applies with no pre-update memory copy #21898 is closed.docs/system-specs/modules/crew-mode.mdsays a few pieces sit away from their responsibility, "the Schedules guard state below, say", with "follow-up refactor(members): move the Schedules exit-guard state into its owner hook #20512". refactor(members): move the Schedules exit-guard state into its owner hook #29274 moved that state intoMembersPageProfile.tsx, which the owner table in the same file already lists; refactor(members): move the Schedules exit-guard state into its owner hook #20512 is closed.Why it matters
The first sentence tells a reader that unattended updates can drop memory, which is no longer true. The second sends a reader looking for a follow-up that is done.
Not a goal
Schedulesguard rows elsewhere increw-mode.mdneed updating; they already describe the owner on main.What changed (motivation → approach → change)
Each sentence loses its stale note and keeps the rule it sat beside: every applier takes a copy first, and a change that regroups registrations reorders them deliberately and edits the order pin.
Backwards compatibility
Compatible. Documentation only.
Removes nothing: no code, config or behaviour changes.
Tests
N/A, documentation only.
./scripts/docs-lint.shpasses (exit 0).Proof: not provable -- docs or config only
Manual verification
Checked on main:
update_apply.pycallssnapshot_memory_before_updatethroughasyncio.to_thread;MembersPageProfile.tsxholds the Schedules draft and its exit-guard state. #21873 and #29274 are merged; #21898 and #20512 are closed.Related Issues
None.
Checklist