Skip to content

docs(specs): drop two follow-up notes whose issues have shipped - #30698

Merged
bolichen97 merged 1 commit into
kirodotdev:mainfrom
JiaDe-Wu:docs/specs-drop-two-shipped-followups
Nov 14, 2026
Merged

bolichen97 merged 1 commit into
kirodotdev:mainfrom
JiaDe-Wu:docs/specs-drop-two-shipped-followups

Conversation

@JiaDe-Wu

@JiaDe-Wu JiaDe-Wu commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Two system specs stop describing follow-up work that has shipped.

Why it matters

The first sentence tells a reader that unattended updates can drop memory, which is no longer true. The second sends a reader looking for a follow-up that is done.

Not a goal

  • Re-reading the rest of either spec. Only the two sentences were checked.
  • Deciding whether the Schedules guard rows elsewhere in crew-mode.md need updating; they already describe the owner on main.

What changed (motivation → approach → change)

Each sentence loses its stale note and keeps the rule it sat beside: every applier takes a copy first, and a change that regroups registrations reorders them deliberately and edits the order pin.

Backwards compatibility

Compatible. Documentation only.

Removes nothing: no code, config or behaviour changes.

Tests

N/A, documentation only. ./scripts/docs-lint.sh passes (exit 0).

Proof: not provable -- docs or config only

Manual verification

Checked on main: update_apply.py calls snapshot_memory_before_update through asyncio.to_thread; MembersPageProfile.tsx holds the Schedules draft and its exit-guard state. #21873 and #29274 are merged; #21898 and #20512 are closed.

Related Issues

None.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality — N/A, documentation only
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@JiaDe-Wu
JiaDe-Wu requested review from a team and KiroCrewCaptain as code owners November 5, 2026 19:10
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention labels Nov 5, 2026
@iamwhatever
iamwhatever force-pushed the docs/specs-drop-two-shipped-followups branch from ea9d9bd to fa2fb70 Compare November 14, 2026 08:35
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 14, 2026
@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ⏭️ skipped

Revision d63c5a2fb9dd21986179b481cc730f5e077f924b touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ⏭️ skipped

Revision d63c5a2fb9dd21986179b481cc730f5e077f924b ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed d63c5a2fb9dd21986179b481cc730f5e077f924b via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] d63c5a2

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of d63c5a2fb9dd21986179b481cc730f5e077f924b via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Docs-only removal of two stale follow-up notes; the base tree backs the claim (update_apply.py routes through run_wheel_apply, which calls snapshot_memory_before_update).

[DESIGN-REVIEWED] d63c5a2

Description read

[DESCRIPTION-READ] 5c5e1ef429b470bdde554dc11555ff8b8e3b911c8492d83fe2dbb2f3ed7b3656

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed d63c5a2fb9dd21986179b481cc730f5e077f924b via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] d63c5a2

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 14, 2026
memory-skills-hooks.md says the gateway's unattended policy-provider
apply "does not yet" copy memory before it rewrites the install
(kirodotdev#21898). kirodotdev#21873 merged on 2026-10-21 and update_apply.py now calls
snapshot_memory_before_update ahead of the reset, so every applier
takes the copy and the parenthetical is false.

crew-mode.md says the Schedules guard state sits in the wrong owner,
with follow-up kirodotdev#20512. kirodotdev#29274 moved it into MembersPageProfile.tsx,
which the owner table already lists, and kirodotdev#20512 is closed.

Both sentences lose the stale note and keep the rule they sat beside.
@iamwhatever
iamwhatever force-pushed the docs/specs-drop-two-shipped-followups branch from fa2fb70 to d63c5a2 Compare November 14, 2026 11:15
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 14, 2026
@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

Thanks for this cleanup. This PR edits system specs under docs/system-specs/, so a maintainer needs to approve it before it can merge. A maintainer will post the decision here.

The review found nothing that blocks this head. I checked that both dropped notes are stale against main. The unattended update apply now runs run_wheel_apply, whose before_promote hook takes the memory copy, and test/test_update_memory_copy_placement.py pins that. #21898 is closed. The Schedules exit-guard state now lives in MembersPageProfile.tsx, and MembersPage.owners.test.tsx pins that. #20512 is closed. Each edit removes only the stale parenthetical and keeps the rule sentence around it.

Optional:

  • crew-mode.md lines 2078 to 2081, and the owner-table row at line 2049, still say useMembersPageSidePanel in MembersPageSidePanel.tsx declares schedAtStake, schedReleased and schedulesMountedRef. refactor(members): move the Schedules exit-guard state into its owner hook #29274 moved them to MembersPageProfile.tsx. So the body's claim that those rows "already describe the owner on main" is not accurate. This PR did not add that text, so a follow-up is fine.
  • The manual verification note says update_apply.py calls snapshot_memory_before_update through asyncio.to_thread. It actually awaits wheel_apply.run_wheel_apply, whose memory_snapshot_hook makes that call. The conclusion is the same, and the diff needs no change.

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Docs only. It drops two follow-up notes whose issues are closed as completed: #20512 (Schedules exit-guard state moved into its owner hook, closed 2026-11-04) and #21898 (pre-update memory copy on the unattended policy-provider apply, closed 2026-10-24). The surrounding sentences still read correctly without them. No regex. 94 checks green on d63c5a2.

@bolichen97
bolichen97 enabled auto-merge (squash) November 14, 2026 23:25
@bolichen97
bolichen97 merged commit bdfd589 into kirodotdev:main Nov 14, 2026
94 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants