Skip to content

feat(connections): pass the TickTick launch gate - #30763

Merged
buluoray merged 1 commit into
kirodotdev:mainfrom
martchellop:feat/connections-ticktick-launch-gate
Nov 9, 2026
Merged

buluoray merged 1 commit into
kirodotdev:mainfrom
martchellop:feat/connections-ticktick-launch-gate

Conversation

@martchellop

@martchellop martchellop commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Show the TickTick card on the Connections page by recording a passed manual (L2) launch gate, with the card's token copy matching the grant TickTick actually issues and its mark in TickTick's brand colours.

TickTick was registered in src/kiro_crew/connections/registry.json gated (launch_gate_passed: false, #29289, superseding #26407 for #26388). The automated rungs are green: the nightly L0 probe watches its OAuth metadata, and the entry carries a smoke_fixture, tool_aliases and gotcha_copy. What was left is rung 5 of the launch ladder in docs/system-specs/modules/connections.md: a human walks Connect → consent → Connected → Test → Disconnect on an isolated instance and records the revoke surface. Until that flag flips, get_visible_providers() hides the card and nobody can connect TickTick from the catalogue.

Why it matters

A catalogue entry that never ships is a hidden feature: the user who wants TickTick has to add https://mcp.ticktick.com by hand and loses the curated scopes, the revoke link, the delete-tool warning and the Sign in control. The launch gate exists to make the card a promise the flow works; this PR records that the promise was checked.

Not a goal

  • No change to the TickTick entry other than launch_gate_passed and the one gotcha_copy sentence about token lifetime; no change to any other provider's mark or to the mask/colour tiers themselves. Scopes, endpoint, aliases and the L0 baseline stay as feat(connections): register TickTick, launch-gated #29289 shipped them.
  • No change to the launch-gate mechanism, the L0/L1 lanes, or any other provider's flag.
  • No automated L2: the walk is manual by design and the evidence lives in this description.
  • No fix for the Disconnect census counting the gateway's own skill-view projections as sharers (step 9, same class as Disconnect keeps the stored sign-in token and says the endpoint is "also configured by: notion" #29767); recorded here for follow-up. The revoke_* fields were corrected in this PR after the walk found the authorized-apps list under TickTick Settings → Integrations rather than "Settings → Account" (step 10): revoke_manual_path now names that path, revoke_verified_on is 2026-11-05 and revoke_verified_note records the click-verified "kiro" rows.

What changed (motivation → approach → change)

Rung 5 says the flag flips only after a human has walked the whole flow. I walked it on an isolated gateway built from this branch and recorded what the spec's L2 asserts: the card renders with its copy, the consent screen is TickTick's, the grant lands and the card reads Connected, Test reports the agent sees the server's tools, one read-only call goes through the governed agent path, Disconnect removes the grant, and the revoke page the entry links to is where the grant appears.

File Change
src/kiro_crew/connections/registry.json TickTick launch_gate_passed: false → true; gotcha_copy sentence "Access tokens refresh automatically" → "The access token is valid for 180 days and does not refresh; reconnect when it expires."
test/test_connections_registry.py ticktick leaves the LAUNCH_GATED roster (the test pins which entries are still gated and which render)
src/kiro_crew/docs/connections.md visible-card count 14 → 15 and the launch-gate-passed list gains TickTick (a test pins both to the registry)
docs/system-specs/modules/connections.md roster row: Grid gated → shown, gate column —
website/src/pages/connections/logos/ticktick.svg, ProviderLogo.tsx the mark moves from the currentColor mask tier to the full-colour <img> tier: same simple-icons path, split into the blue ring #4772FA and amber check #FFB000 of TickTick's own app icon
website/src/i18n/glossary.json, website/scripts/lib/render-scan.mjs, website/src/i18n/renderScan.test.ts TickTick joins the do-not-translate proper nouns (glossary dnt) and the launch-set brands the i18n render scan strips before leak detection (ALWAYS_LATIN): the visible card renders the name on capabilities-mcp, which the en-XA head-vs-base gate otherwise reports as a Latin leak

The copy change comes out of step 8 of the walk: the grant kiro-cli stored has expires_in: 15551999 (180 days), token_type: bearer, the two scopes, and no refresh_token; TickTick's authorization-server metadata (https://ticktick.com/.well-known/oauth-authorization-server) lists grant_types_supported: ["authorization_code"] only. A card that promises automatic refresh would be wrong on the day the token lapses, so the sentence now says what happens instead. No localized bundle mirrors gotcha_copy; the registry tests pin other phrases of the sentence's neighbours and still pass.

Backwards compatibility

Compatible: one boolean flips from false to true and one copy sentence changes; the loader already accepts both values and every other entry is unchanged.

Removes nothing: the change adds a card; nothing that renders or resolves today stops doing so.

Tests

No new test. test/test_connections_registry.py::test_probe_accessor_includes_every_entry_even_when_launch_gated and ::test_only_gated_launch_services_are_visible pin the gated and visible sets, so ticktick moves out of their LAUNCH_GATED roster. test/test_connections_doc.py pins the visible-card count and the launch-gate-passed list in src/kiro_crew/docs/connections.md to the registry, which is why that doc changes with the flag. python3 scripts/local-gate.py --base upstream/main passed; the three connections test files pass (160 tests); isort/flake8/mypy clean. Frontend: tsc -p tsconfig.app.json, eslint, the Connections vitest files (137 tests) and renderScan.test.ts (50) pass; restyle-ratchet, phantom-classes and i18n:check pass; npm run i18n:render head vs base reports PASS [vs-base] — no surface got worse.

Manual verification

The L2 walk-through is the manual verification; it is the reason this PR exists.

L2 walk-through evidence

Environment:

  • Built with make build in a fresh worktree off kirodotdev/KiroCrew@7720e97448, with the flag flipped (the only code difference between the tested tree and this PR's head is the gotcha_copy sentence and the test/doc rows).
  • Gateway: isolated pod-style instance (own KIROCREW_HOME, own KIRO_HOME, own KIROCREW_OS_HOME; KIROCREW_PROFILE=standalone, port 6777). The live gateway and the live ~/.kiro were not touched.
  • kiro-cli 3.0.0.
  • The gateway was started by the operator from an interactive shell (tmux) at 2026-11-05T18:27:24Z; a gateway started from an agent sandbox is in different Linux namespaces and kirocrew token is then refused (member_owner_token_refused), which is by design.
  • Boot warnings observed, neither affecting the walk: auth store .local/share/kiro-cli exceeded 512 files; staging stopped (the pod stages the kiro-cli identity store create-only with a 512-file cap; the kas tree was copied in full beforehand and kiro-cli whoami under the pod home reports the signed-in identity) and dropping spec env key 'KIROCREW_HOME': the KIROCREW_ namespace is reserved (4×, the pod's rendered specs carry the pod home in env; the gateway re-derives it from its own channel).
# Step (what L2 asserts) Result UTC
1 Card hidden on main (launch_gate_passed: false) GET /api/connections/status on the unflipped build listed 14 slugs, no ticktick; get_visible_providers() returned 14 2026-11-05T13:00:48Z
2 Card renders after the flip: name, logo, Connect After the flip + npm run build + restart: GET /api/connections/status lists 15 slugs including {"slug": "ticktick", "status": "not_connected", "reason": "no_grant"}; get_visible_providers() returns 15; the built bundle carries the TickTick entry with "launch_gate_passed":true and logos/ticktick.svg. The card renders no warning triangle by design: TickTick has no prerequisite_copy, and cards do not render gotcha_copy (website/src/pages/connections/registry.ts). Operator confirmed the card in the grid with a Connect button (~19:50Z). Logo: the card shows the mark as a plain grey check-in-circle, which is the convention, not a defect: ProviderLogo.tsx paints every industry-baseline mark (Todoist, Asana, Postman, Neon, TickTick, …) as a CSS mask over currentColor from the CC0 simple-icons single-path glyph so it stays legible in every theme; only Linear, Atlassian, Stripe and GitLab ship full-colour <img> marks. The glyph is simple-icons' TickTick logomark shape (circle + check), and Todoist renders grey the same way. The operator checked the live grid: the other cards render their marks in brand colours, and a grey TickTick glyph among them did not read as TickTick, so the mark now ships in the full-colour tier (before: grey mask of the simple-icons path; after: the same path as blue ring + amber check, matching the vendor app icon's #4772FA / #FFB000). Verified by rendering the SVG beside the vendor icon and by the ProviderLogo tests 2026-11-05T13:03:40Z
3 Connect → consent screen is TickTick's own (https://ticktick.com), scopes shown Operator: card present with Connect; authorization on TickTick succeeded. The automatic loopback callback failed in the browser (expected: the listener is on the gateway host, the browser was on a laptop over an SSH tunnel); the landed callback URL was pasted into Complete connection and the card turned Connected. Consent host and the scopes as rendered on the consent page were not captured by the operator (the registry's recommended_scopes, tasks:read + tasks:write, are what the stored grant carries, see step 8) consent ~18:31Z
4 Back from consent: card reads Connected; grant pair present GET /api/connections/status: status: connected, reason: grant_present, grantSharedWith: [ticktick], connectedSince: 2026-11-05T18:31:47Z. Warning triangle: the connected card showed a ⚠ beside Disconnect with the status line "Return address delivered. Checking the connection…" (~20:11Z). The triangle is the connected-row PrerequisiteTip ("Before you disconnect" / "TickTick shared sign-in"), rendered whenever grantSharedWith is non-empty; its text says the stored authorization is shared with ticktick and that Disconnect keeps the shared token. It is not a registry flag and not the manual-callback path: the ownership census found the same endpoint in the gateway's own kirocrew-skill-view-*.json projections and reported them as a sharer (the same census behaviour as step 9 and #29767). It persisted while those projections existed and is gone now that they are (status shows no grantSharedWith). The status line is the normal post-relay text after Complete connection; it clears once the status poll returns. Neither is TickTick-specific. Grant pair 5d1b…bba6.token.json (0600) + .registration.json written 18:31:45Z under the pod OS home; stat only, token file opened once for its non-secret keys (see step 8) 18:50:20Z
5 Test: verdict usable, toolCount reported POST /api/connections/test {"slug":"ticktick"} → {"verdict": "usable", "code": "tools_available", "toolCount": 58} in 3 s 19:53:16Z
6 tools/list roster vs the 58-tool card copy; list_projects, search, fetch present Same promptless /mcp + /tools path as Test, fresh session: /mcp row ticktick: running, toolCount 58; /tools has 58 names with source mcp:ticktick, including list_projects, search, fetch, get_tool_details and the five delete tools the gotcha names. No ticktick_* alias present, which is the rule: resolve_tool_aliases renames only when a second connected provider claims the same name (verified: {ticktick} → {}, {ticktick, todoist} → ticktick_search, ticktick_fetch, todoist_*) 19:54:41Z
7 One smoke call through the governed agent path: list_projects with limit: 1 (the registry smoke_fixture), read-only kiro-cli chat --agent kirocrew --no-interactive --trust-tools=@ticktick/list_projects, prompt asked for exactly that call. Stream: one tool_call @ticktick/list_projects with rawInput {"limit": 1}, status: completed, isError: false, result {"result": []} (an empty project list for this account; the call itself succeeded). Agent final text: "Tool called: list_projects (ticktick server) / Error: no / Projects returned: 0". No other tool was called 19:55:42Z
8 Token lifetime and reuse across sessions The token file carries expires_in: 15551999 (180 days), token_type: bearer, scope: tasks:read tasks:write and no refresh_token; TickTick's AS metadata lists grant_types_supported: ["authorization_code"] only. So there is no refresh to exercise and a hold past expiry is not feasible; the equivalent check is reuse: three cold kiro-cli sessions at 19:53, 19:54 and 19:55Z (82–84 min after consent) all authenticated from the stored grant with no re-consent, and the token file mtime stayed 18:31:45Z. Finding: the entry's gotcha_copy sentence "Access tokens refresh automatically" is not what the grant shows; see below 19:57:13Z
9 Disconnect: grant pair removed; card back to Not connected POST /api/connections/disconnect {"slug":"ticktick"} → 200 {"ok": true, "entryRemoved": true, "agentSpecRewritten": true, "grantRemoved": false, "grantSharedWith": ["ticktick"], "grantCensusIncomplete": false}. The ticktick entry left kirocrew.json, but the grant pair was kept and the card still reads Connected, because the ownership census found the same URL in two kirocrew-skill-view-*.json files: Kiro Crew's own auto-managed projections of kirocrew and kirocrew-worker, written by the promptless sessions of steps 6–7 before the purge. agent_spec_sources labels every non-kirocrew.json spec agent: (a hand-written sharer that may block a revoke), so the gateway's own reflection blocked its own revoke. A second Disconnect after a fresh spawn republished the kirocrew view (now without ticktick) still refused: the stale view files survive until the budgeted prune reaps them. Not a TickTick defect; same class as #29767 (a Notion grant kept because another spec named the endpoint). The two stale views were orphaned (no live spawn, superseded by views with a new digest, 40 min past the 600 s reclaim age) and were produced by this walk's own sessions, so they were set aside; the next Disconnect returned grantRemoved: true, grantSharedWith: [], the token/registration pair was unlinked (kiro-cli's own .metadata.json sidecar remains, as designed), and status read not_connected / no_grant 20:30:37Z, 20:32:40Z, 20:35:17Z
10 Revoke surface: https://ticktick.com/webapp/#settings → Settings → Account → authorized apps lists the client; revoked there revoke_page_url answers 200 (redirects to https://ticktick.com/ for an anonymous client; the #settings fragment is client-side); docs_url 200. Operator (~20:09Z, logged in): TickTick Settings → Integrations ("manage other apps that have been authorized by the TickTick") lists the client as kiro with an UnLink action, so the revoke surface exists and is reachable from revoke_page_url; the entry's revoke_manual_path says "Settings → Account → … authorized apps", and the page is actually under Integrations. The app appears five times, all named "kiro": each dynamic client registration leaves its own row (today's consent plus earlier registrations against the same server from this operator's hand-added mcp.json entry and earlier connect attempts), and stale rows are unlinked by hand. The stored registration file carries client_id, client_secret, redirect_uri, scopes and no client_name, so the "kiro" label is what kiro-cli registers. Nothing was unlinked during the walk 19:57:29Z, ~20:09Z

Screenshots / video

The TickTick mark, before (grey currentColor mask) and after (brand colours), next to the vendor's own app icon:

TickTick mark: new coloured SVG (left), vendor app icon (centre), Linear for comparison (right)

The Connections grid itself is unchanged apart from this card appearing; a grid screenshot of the connected state shows a personal account, so it is not attached.

Related Issues

Relates to #26388 (closed by #29289, which registered the entry gated). Step 9 hit the same Disconnect census behaviour as #29767.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@martchellop
martchellop requested review from a team and KiroCrewCaptain as code owners November 5, 2026 20:46
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: checking Automated validation is still running labels Nov 5, 2026
@martchellop
martchellop force-pushed the feat/connections-ticktick-launch-gate branch 2 times, most recently from 5243aa7 to 6c47e67 Compare November 5, 2026 20:59
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 5, 2026
@martchellop
martchellop force-pushed the feat/connections-ticktick-launch-gate branch from 6c47e67 to 3970400 Compare November 5, 2026 21:44
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 5, 2026
@martchellop
martchellop force-pushed the feat/connections-ticktick-launch-gate branch from 3970400 to b74cb26 Compare November 6, 2026 02:05
@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 6, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed at b74cb2613e (T2: it makes one new Connections card visible and changes nothing users already have).

The diff matches the description. In registry.json only two TickTick fields change: launch_gate_passed goes to true, and gotcha_copy now says the token lasts 180 days and does not refresh. The test drops ticktick from LAUNCH_GATED, and both docs move with it (14 to 15 cards, the launch-gate table row). The logo moves from the mono mask list to the full-colour list. One commit, no merge commits.

Approved on this head. It merges once fork CI runs and is green.

AI-assisted, sent by CommunityCrew

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of 31e2230b2760335bbaada1e13245fd253fe02dd0 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

A registry flag flip backed by a recorded manual L2 walk; the copy and logo changes stay within the stated goal.

Notes

  • The walk found that every reconnect registers a new client and leaves another identical "kiro" row in TickTick. With a 180-day token that never refreshes, every user who reconnects collects stale rows. A follow-up that reuses the registered client across reconnects would fix the cause, rather than leaving users to unlink stale rows by hand.

[DESIGN-REVIEWED] 31e2230

Description read

[DESCRIPTION-READ] a6543baa8364ee129ee1f3788f485003c6dcd2247ef00046f571755800a35d6a

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ PASS

Premise-level review of 31e2230b2760335bbaada1e13245fd253fe02dd0 via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. Flipping the flag is the launch ladder's own rung 5, and the copy and revoke edits come from what the walk-through observed. The logo recolour has the weakest support.

Notes

  • Item 4 — inherited: the only harm named is "a single-hue mask lost the mark's identity among the coloured cards", which is an argument from symmetry with the other cards. No user is named who failed to recognise the mark. Subtraction: drop the ticktick.svg fill split and leave ticktick in MASKED in ProviderLogo.tsx. The card ships the same without it.

What this change ships

Inventory (7 items) — 6 justified

Intent: let users connect TickTick from the Connections catalogue now that a person has walked its flow end to end. This is an ADDITION.

  1. The TickTick card now shows on the Connections page (launch_gate_passed true) — justified
  2. The card's warning text now says the token lasts 180 days and does not refresh — justified
  3. The revoke instructions now point to Settings → Integrations → kiro → UnLink — justified
  4. The TickTick logo is now in blue and amber instead of single-colour — rides along; based on symmetry with the other cards
  5. "TickTick" is added to the do-not-translate names and the render scan's Latin exemptions — justified
  6. The user doc's visible-card count goes from 14 to 15, the launch-gate list gains TickTick, and the spec row reads shown — justified
  7. A logo screenshot is committed under temp-screenshots/ — justified

[FIRST-PRINCIPLES-REVIEWED] 31e2230

Description read

[DESCRIPTION-READ] c2eee5c0868ba5cde4f3b44cec58921ed814c3e25cceece2de3d55a270a8d8ce

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed 31e2230b2760335bbaada1e13245fd253fe02dd0 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 31e2230

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed 31e2230b2760335bbaada1e13245fd253fe02dd0 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 31e2230

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 6, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martchellop. One blocker from CI on b74cb2613e: the i18n Render Gate (en-XA, head vs base) fails because this PR makes the TickTick card visible, and the card renders {provider.name} raw (website/src/pages/connections/ConnectionsPageCard.tsx:625). The gate reads "TickTick" as untranslated text (2 findings on capabilities-mcp).

The other visible providers pass because their names are proper nouns in the do-not-translate list. Please add "TickTick" to the dnt array in website/src/i18n/glossary.json, in alphabetical order. Don't route it through t(): it is a brand name, like GitLab and Vercel, which are already in that list.

Everything else in my earlier review still stands. Once that is pushed, I'll re-review the new head.

AI-assisted, sent by CommunityCrew

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 6, 2026
@martchellop
martchellop force-pushed the feat/connections-ticktick-launch-gate branch from b74cb26 to 915962a Compare November 6, 2026 22:56
@martchellop

Copy link
Copy Markdown
Contributor Author

CI on b74cb2613e had three reds. Diagnosis and what changed in 915962acd0 (rebased onto 7c364bc62b, still one commit):

Lane Ours? What
Backend Tests (3.12, 6): test_the_lazy_imports_stay_inside_the_functions_that_need_them (131 == 130) No Red on main at our base 6a8f6826a3: #30591 added a lazy import and left the pin at 130. Fixed on main by #30984 (5dcda3bd0d, pin now 133). The rebase picks it up; the test passes on the rebased tree.
i18n Render Gate (en-XA, head vs base): latin-leak/untranslated-text "TickTick" on capabilities-mcp ×2 Yes The gate exempts launch-set provider brands through ALWAYS_LATIN in website/scripts/lib/render-scan.mjs; making the TickTick card visible rendered its name there without the exemption. Added 'TickTick' beside Notion/Linear/Stripe/Vercel, and to the brand list renderScan.test.ts pins. npm run i18n:render head vs base 7c364bc62b now reports PASS [vs-base] — no surface got worse.
Coverage Gate No Failed closed on the backend red above.

PR body updated with the same two rows under What changed.

@martchellop
martchellop force-pushed the feat/connections-ticktick-launch-gate branch from 915962a to 1a2ac31 Compare November 6, 2026 22:59
@martchellop

Copy link
Copy Markdown
Contributor Author

@bolichen97 thanks, done in 1a2ac3154d: "TickTick" is in website/src/i18n/glossary.json dnt, between Telegram and TypeScript, not routed through t().

One note on the mechanism, so the fix is complete rather than cosmetic: the head-vs-base leak scan does not read glossary.json; it strips the hard-coded ALWAYS_LATIN list in website/scripts/lib/render-scan.mjs (its comment says it mirrors the glossary dnt plus the launch-set brands, which is where Notion/Linear/Stripe/Vercel actually get their pass). So the commit adds TickTick to both, and renderScan.test.ts pins it beside the other launch-set brands. Local npm run i18n:render head vs 7c364bc62b: PASS [vs-base] — no surface got worse; check-dnt-catalogs.mjs: 79 terms intact across 11 catalogs.

Still one commit, rebased onto 7c364bc62b, which also carries the #30984 fix for the Backend Tests lazy-import pin that was red on the previous run.

bolichen97
bolichen97 previously approved these changes Nov 6, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed at 1a2ac3154d. This fixes my change request: "TickTick" is now in the glossary's dnt list and in ALWAYS_LATIN in render-scan.mjs, beside the other launch-set brands. So the i18n render gate reads the card name as a proper noun. Nothing else changed from b74cb2613e, and it's still one commit.

Approved on this head. It merges once fork CI and the AI review lanes on this head are green.

AI-assisted, sent by CommunityCrew

@bolichen97 bolichen97 reopened this Nov 9, 2026
@bolichen97 bolichen97 closed this Nov 9, 2026
@bolichen97 bolichen97 reopened this Nov 9, 2026
@bolichen97 bolichen97 closed this Nov 9, 2026
@bolichen97 bolichen97 reopened this Nov 9, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 9, 2026
@bolichen97 bolichen97 closed this Nov 9, 2026
@bolichen97 bolichen97 reopened this Nov 9, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 9, 2026
@bolichen97 bolichen97 closed this Nov 9, 2026
@bolichen97 bolichen97 reopened this Nov 9, 2026
Flip launch_gate_passed for ticktick after the manual L2 walk on an
isolated gateway built from this branch: card rendered, consent on
ticktick.com, grant stored, Test usable with 58 tools, list_projects
smoke call through the governed agent path, Disconnect unlinked the
grant, revoke surface confirmed under TickTick Settings > Integrations.

The grant kiro-cli stores has expires_in 15551999 (180 days) and no
refresh_token, and TickTick's authorization server supports only the
authorization_code grant, so the gotcha_copy sentence promising
automatic refresh is replaced with the token's real lifetime.

The visible-card count and launch-gate-passed list in the user doc and
the roster row in the module spec follow the flag; ticktick leaves the
LAUNCH_GATED roster in the registry test.

The card mark moves from the currentColor mask to the full-colour tier:
the simple-icons path is split into the brand's blue ring (#4772FA) and
amber check (#FFB000), the hues of TickTick's own app icon, so the card
reads like its coloured neighbours instead of a grey glyph.

The card's brand name now renders on the capabilities-mcp surface, so
TickTick joins the launch-set brands the i18n render scan treats as
do-not-translate proper nouns (glossary.json dnt and ALWAYS_LATIN), like
Notion and Linear.

The revoke_* fields record the surface the walk actually found: the
grant sits under Settings > Integrations as an authorized app named
"kiro" (one row per connected Kiro install), unlinked with UnLink, so
revoke_manual_path, revoke_verified_on and revoke_verified_note now
describe that path instead of the pre-walk guess.

Relates to kirodotdev#26388
@martchellop
martchellop force-pushed the feat/connections-ticktick-launch-gate branch from d877821 to 31e2230 Compare November 9, 2026 14:33
@martchellop

Copy link
Copy Markdown
Contributor Author

Rebased onto main 52a2ebb3c2 to pick up the #33795 (skill size cap) and #33178 (decision ledger) fixes that were redding the merge checkout; head is now 31e2230b27, same single commit, no content change (identical patch-id to d877821bd6).

@bolichen97 could you re-approve the review and the runs when you have a moment? Thanks.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 9, 2026
@buluoray
buluoray enabled auto-merge (rebase) November 9, 2026 17:00

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:

Approve at 31e2230. This puts the TickTick card in the Connections gallery with a Connect button. Until now the entry was hidden behind the launch gate, so anyone who wanted TickTick had to add https://mcp.ticktick.com by hand and lost the curated scopes, the revoke link and the delete-tool warning.

Checked:

  • The credential-lifetime copy change is right. TickTick's authorization-server metadata (https://ticktick.com/.well-known/oauth-authorization-server) lists grant_types_supported: ["authorization_code"] only, so there is no refresh grant. The old gotcha_copy sentence promised automatic refresh, which was false. The new one says the grant lasts 180 days, does not refresh, and needs a reconnect when it expires; that matches the metadata and the expires_in: 15551999 your walk recorded.
  • The flag flip is the only behaviour change: launch_gate_passed true, so get_visible_providers() now includes TickTick. The registry's launch-gate-passed set at this head is Notion, Linear, Atlassian, Stripe, Vercel, GitLab, TickTick, which matches the seven names and the 14 → 15 count in src/kiro_crew/docs/connections.md.
  • The L2 walk covers each step rung 5 asks for: card renders, consent, Connected, Test (usable, 58 tools), one governed list_projects call with limit: 1, Disconnect with the grant pair removed, and the revoke surface click-verified. The revoke_manual_path correction (Settings → Integrations → kiro → UnLink) comes from that walk.
  • Scopes, endpoint, aliases and the delete-tool gotcha_copy are unchanged, so nothing about what the grant can do is loosened.
  • test/test_connections_registry.py and test/test_connections_doc.py pass on this head (84 tests). The logo moves from the mask tier to the full-colour tier with the same path in TickTick's two app-icon colours.
  • All five AI lanes pass on this head, and CI shows 81 success, 12 skipped, 0 failing. PR Readiness is still re-checking. Auto-merge is on, so this approval lets it merge once readiness is green.

Non-blocking follow-ups:

  1. temp-screenshots/ticktick-launch-gate/logo-after.png is committed, as a fork PR has to do. It will land in main's history; a maintainer should remove it from the tip after merge.
  2. UX Review notes that no screenshot shows the card in the grid itself. The card is the same component every visible provider uses and only the flag and logo change, so I am not holding the PR for it.
  3. The Disconnect census counting the gateway's own skill-view projections as sharers (walk step 9) is the existing #29767 class, not something this PR adds.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 9, 2026
@buluoray
buluoray merged commit 0027051 into kirodotdev:main Nov 9, 2026
94 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 9, 2026
@martchellop
martchellop deleted the feat/connections-ticktick-launch-gate branch November 9, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants