Repository navigation
feat(connections): pass the TickTick launch gate - #30763
Conversation
5243aa7 to
6c47e67
Compare
6c47e67 to
3970400
Compare
3970400 to
b74cb26
Compare
bolichen97
left a comment
There was a problem hiding this comment.
Reviewed at b74cb2613e (T2: it makes one new Connections card visible and changes nothing users already have).
The diff matches the description. In registry.json only two TickTick fields change: launch_gate_passed goes to true, and gotcha_copy now says the token lasts 180 days and does not refresh. The test drops ticktick from LAUNCH_GATED, and both docs move with it (14 to 15 cards, the launch-gate table row). The logo moves from the mono mask list to the full-colour list. One commit, no merge commits.
Approved on this head. It merges once fork CI runs and is green.
AI-assisted, sent by CommunityCrew
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS A registry flag flip backed by a recorded manual L2 walk; the copy and logo changes stay within the stated goal. Notes
[DESIGN-REVIEWED] 31e2230 Description read[DESCRIPTION-READ] a6543baa8364ee129ee1f3788f485003c6dcd2247ef00046f571755800a35d6a That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. Flipping the flag is the launch ladder's own rung 5, and the copy and revoke edits come from what the walk-through observed. The logo recolour has the weakest support. Notes
What this change shipsInventory (7 items) — 6 justifiedIntent: let users connect TickTick from the Connections catalogue now that a person has walked its flow end to end. This is an ADDITION.
[FIRST-PRINCIPLES-REVIEWED] 31e2230 Description read[DESCRIPTION-READ] c2eee5c0868ba5cde4f3b44cec58921ed814c3e25cceece2de3d55a270a8d8ce That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
bolichen97
left a comment
There was a problem hiding this comment.
Thanks @martchellop. One blocker from CI on b74cb2613e: the i18n Render Gate (en-XA, head vs base) fails because this PR makes the TickTick card visible, and the card renders {provider.name} raw (website/src/pages/connections/ConnectionsPageCard.tsx:625). The gate reads "TickTick" as untranslated text (2 findings on capabilities-mcp).
The other visible providers pass because their names are proper nouns in the do-not-translate list. Please add "TickTick" to the dnt array in website/src/i18n/glossary.json, in alphabetical order. Don't route it through t(): it is a brand name, like GitLab and Vercel, which are already in that list.
Everything else in my earlier review still stands. Once that is pushed, I'll re-review the new head.
AI-assisted, sent by CommunityCrew
b74cb26 to
915962a
Compare
|
CI on
PR body updated with the same two rows under What changed. |
915962a to
1a2ac31
Compare
|
@bolichen97 thanks, done in One note on the mechanism, so the fix is complete rather than cosmetic: the head-vs-base leak scan does not read Still one commit, rebased onto |
bolichen97
left a comment
There was a problem hiding this comment.
Re-reviewed at 1a2ac3154d. This fixes my change request: "TickTick" is now in the glossary's dnt list and in ALWAYS_LATIN in render-scan.mjs, beside the other launch-set brands. So the i18n render gate reads the card name as a proper noun. Nothing else changed from b74cb2613e, and it's still one commit.
Approved on this head. It merges once fork CI and the AI review lanes on this head are green.
AI-assisted, sent by CommunityCrew
Flip launch_gate_passed for ticktick after the manual L2 walk on an isolated gateway built from this branch: card rendered, consent on ticktick.com, grant stored, Test usable with 58 tools, list_projects smoke call through the governed agent path, Disconnect unlinked the grant, revoke surface confirmed under TickTick Settings > Integrations. The grant kiro-cli stores has expires_in 15551999 (180 days) and no refresh_token, and TickTick's authorization server supports only the authorization_code grant, so the gotcha_copy sentence promising automatic refresh is replaced with the token's real lifetime. The visible-card count and launch-gate-passed list in the user doc and the roster row in the module spec follow the flag; ticktick leaves the LAUNCH_GATED roster in the registry test. The card mark moves from the currentColor mask to the full-colour tier: the simple-icons path is split into the brand's blue ring (#4772FA) and amber check (#FFB000), the hues of TickTick's own app icon, so the card reads like its coloured neighbours instead of a grey glyph. The card's brand name now renders on the capabilities-mcp surface, so TickTick joins the launch-set brands the i18n render scan treats as do-not-translate proper nouns (glossary.json dnt and ALWAYS_LATIN), like Notion and Linear. The revoke_* fields record the surface the walk actually found: the grant sits under Settings > Integrations as an authorized app named "kiro" (one row per connected Kiro install), unlinked with UnLink, so revoke_manual_path, revoke_verified_on and revoke_verified_note now describe that path instead of the pre-walk guess. Relates to kirodotdev#26388
d877821 to
31e2230
Compare
|
Rebased onto main @bolichen97 could you re-approve the review and the runs when you have a moment? Thanks. |
buluoray
left a comment
There was a problem hiding this comment.
🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:
Approve at 31e2230. This puts the TickTick card in the Connections gallery with a Connect button. Until now the entry was hidden behind the launch gate, so anyone who wanted TickTick had to add https://mcp.ticktick.com by hand and lost the curated scopes, the revoke link and the delete-tool warning.
Checked:
- The credential-lifetime copy change is right. TickTick's authorization-server metadata (
https://ticktick.com/.well-known/oauth-authorization-server) listsgrant_types_supported: ["authorization_code"]only, so there is no refresh grant. The oldgotcha_copysentence promised automatic refresh, which was false. The new one says the grant lasts 180 days, does not refresh, and needs a reconnect when it expires; that matches the metadata and theexpires_in: 15551999your walk recorded. - The flag flip is the only behaviour change:
launch_gate_passedtrue, soget_visible_providers()now includes TickTick. The registry's launch-gate-passed set at this head is Notion, Linear, Atlassian, Stripe, Vercel, GitLab, TickTick, which matches the seven names and the 14 → 15 count insrc/kiro_crew/docs/connections.md. - The L2 walk covers each step rung 5 asks for: card renders, consent, Connected, Test (
usable, 58 tools), one governedlist_projectscall withlimit: 1, Disconnect with the grant pair removed, and the revoke surface click-verified. Therevoke_manual_pathcorrection (Settings → Integrations → kiro → UnLink) comes from that walk. - Scopes, endpoint, aliases and the delete-tool
gotcha_copyare unchanged, so nothing about what the grant can do is loosened. test/test_connections_registry.pyandtest/test_connections_doc.pypass on this head (84 tests). The logo moves from the mask tier to the full-colour tier with the same path in TickTick's two app-icon colours.- All five AI lanes pass on this head, and CI shows 81 success, 12 skipped, 0 failing. PR Readiness is still re-checking. Auto-merge is on, so this approval lets it merge once readiness is green.
Non-blocking follow-ups:
temp-screenshots/ticktick-launch-gate/logo-after.pngis committed, as a fork PR has to do. It will land in main's history; a maintainer should remove it from the tip after merge.- UX Review notes that no screenshot shows the card in the grid itself. The card is the same component every visible provider uses and only the flag and logo change, so I am not holding the PR for it.
- The Disconnect census counting the gateway's own skill-view projections as sharers (walk step 9) is the existing #29767 class, not something this PR adds.
Problem / Motivation
Goal: Show the TickTick card on the Connections page by recording a passed manual (L2) launch gate, with the card's token copy matching the grant TickTick actually issues and its mark in TickTick's brand colours.
TickTick was registered in
src/kiro_crew/connections/registry.jsongated (launch_gate_passed: false, #29289, superseding #26407 for #26388). The automated rungs are green: the nightly L0 probe watches its OAuth metadata, and the entry carries asmoke_fixture,tool_aliasesandgotcha_copy. What was left is rung 5 of the launch ladder indocs/system-specs/modules/connections.md: a human walks Connect → consent → Connected → Test → Disconnect on an isolated instance and records the revoke surface. Until that flag flips,get_visible_providers()hides the card and nobody can connect TickTick from the catalogue.Why it matters
A catalogue entry that never ships is a hidden feature: the user who wants TickTick has to add
https://mcp.ticktick.comby hand and loses the curated scopes, the revoke link, the delete-tool warning and the Sign in control. The launch gate exists to make the card a promise the flow works; this PR records that the promise was checked.Not a goal
launch_gate_passedand the onegotcha_copysentence about token lifetime; no change to any other provider's mark or to the mask/colour tiers themselves. Scopes, endpoint, aliases and the L0 baseline stay as feat(connections): register TickTick, launch-gated #29289 shipped them.revoke_*fields were corrected in this PR after the walk found the authorized-apps list under TickTick Settings → Integrations rather than "Settings → Account" (step 10):revoke_manual_pathnow names that path,revoke_verified_onis 2026-11-05 andrevoke_verified_noterecords the click-verified "kiro" rows.What changed (motivation → approach → change)
Rung 5 says the flag flips only after a human has walked the whole flow. I walked it on an isolated gateway built from this branch and recorded what the spec's L2 asserts: the card renders with its copy, the consent screen is TickTick's, the grant lands and the card reads Connected, Test reports the agent sees the server's tools, one read-only call goes through the governed agent path, Disconnect removes the grant, and the revoke page the entry links to is where the grant appears.
src/kiro_crew/connections/registry.jsonlaunch_gate_passed:false→true;gotcha_copysentence "Access tokens refresh automatically" → "The access token is valid for 180 days and does not refresh; reconnect when it expires."test/test_connections_registry.pyticktickleaves theLAUNCH_GATEDroster (the test pins which entries are still gated and which render)src/kiro_crew/docs/connections.mddocs/system-specs/modules/connections.mdgated→shown, gate column—website/src/pages/connections/logos/ticktick.svg,ProviderLogo.tsxcurrentColormask tier to the full-colour<img>tier: same simple-icons path, split into the blue ring#4772FAand amber check#FFB000of TickTick's own app iconwebsite/src/i18n/glossary.json,website/scripts/lib/render-scan.mjs,website/src/i18n/renderScan.test.tsTickTickjoins the do-not-translate proper nouns (glossarydnt) and the launch-set brands the i18n render scan strips before leak detection (ALWAYS_LATIN): the visible card renders the name oncapabilities-mcp, which the en-XA head-vs-base gate otherwise reports as a Latin leakThe copy change comes out of step 8 of the walk: the grant kiro-cli stored has
expires_in: 15551999(180 days),token_type: bearer, the two scopes, and norefresh_token; TickTick's authorization-server metadata (https://ticktick.com/.well-known/oauth-authorization-server) listsgrant_types_supported: ["authorization_code"]only. A card that promises automatic refresh would be wrong on the day the token lapses, so the sentence now says what happens instead. No localized bundle mirrorsgotcha_copy; the registry tests pin other phrases of the sentence's neighbours and still pass.Backwards compatibility
Compatible: one boolean flips from
falsetotrueand one copy sentence changes; the loader already accepts both values and every other entry is unchanged.Removes nothing: the change adds a card; nothing that renders or resolves today stops doing so.
Tests
No new test.
test/test_connections_registry.py::test_probe_accessor_includes_every_entry_even_when_launch_gatedand::test_only_gated_launch_services_are_visiblepin the gated and visible sets, soticktickmoves out of theirLAUNCH_GATEDroster.test/test_connections_doc.pypins the visible-card count and the launch-gate-passed list insrc/kiro_crew/docs/connections.mdto the registry, which is why that doc changes with the flag.python3 scripts/local-gate.py --base upstream/mainpassed; the three connections test files pass (160 tests); isort/flake8/mypy clean. Frontend:tsc -p tsconfig.app.json, eslint, the Connections vitest files (137 tests) andrenderScan.test.ts(50) pass; restyle-ratchet, phantom-classes and i18n:check pass;npm run i18n:renderhead vs base reportsPASS [vs-base] — no surface got worse.Manual verification
The L2 walk-through is the manual verification; it is the reason this PR exists.
L2 walk-through evidence
Environment:
make buildin a fresh worktree offkirodotdev/KiroCrew@7720e97448, with the flag flipped (the only code difference between the tested tree and this PR's head is thegotcha_copysentence and the test/doc rows).KIROCREW_HOME, ownKIRO_HOME, ownKIROCREW_OS_HOME;KIROCREW_PROFILE=standalone, port 6777). The live gateway and the live~/.kirowere not touched.kirocrew tokenis then refused (member_owner_token_refused), which is by design.auth store .local/share/kiro-cli exceeded 512 files; staging stopped(the pod stages the kiro-cli identity store create-only with a 512-file cap; thekastree was copied in full beforehand andkiro-cli whoamiunder the pod home reports the signed-in identity) anddropping spec env key 'KIROCREW_HOME': the KIROCREW_ namespace is reserved(4×, the pod's rendered specs carry the pod home inenv; the gateway re-derives it from its own channel).main(launch_gate_passed: false)GET /api/connections/statuson the unflipped build listed 14 slugs, noticktick;get_visible_providers()returned 14npm run build+ restart:GET /api/connections/statuslists 15 slugs including{"slug": "ticktick", "status": "not_connected", "reason": "no_grant"};get_visible_providers()returns 15; the built bundle carries the TickTick entry with"launch_gate_passed":trueandlogos/ticktick.svg. The card renders no warning triangle by design: TickTick has noprerequisite_copy, and cards do not rendergotcha_copy(website/src/pages/connections/registry.ts). Operator confirmed the card in the grid with a Connect button (~19:50Z). Logo: the card shows the mark as a plain grey check-in-circle, which is the convention, not a defect:ProviderLogo.tsxpaints every industry-baseline mark (Todoist, Asana, Postman, Neon, TickTick, …) as a CSS mask overcurrentColorfrom the CC0 simple-icons single-path glyph so it stays legible in every theme; only Linear, Atlassian, Stripe and GitLab ship full-colour<img>marks. The glyph is simple-icons' TickTick logomark shape (circle + check), and Todoist renders grey the same way. The operator checked the live grid: the other cards render their marks in brand colours, and a grey TickTick glyph among them did not read as TickTick, so the mark now ships in the full-colour tier (before: grey mask of the simple-icons path; after: the same path as blue ring + amber check, matching the vendor app icon's#4772FA/#FFB000). Verified by rendering the SVG beside the vendor icon and by theProviderLogotestshttps://ticktick.com), scopes shownrecommended_scopes,tasks:read+tasks:write, are what the stored grant carries, see step 8)GET /api/connections/status:status: connected, reason: grant_present, grantSharedWith: [ticktick], connectedSince: 2026-11-05T18:31:47Z. Warning triangle: the connected card showed a ⚠ beside Disconnect with the status line "Return address delivered. Checking the connection…" (~20:11Z). The triangle is the connected-rowPrerequisiteTip("Before you disconnect" / "TickTick shared sign-in"), rendered whenevergrantSharedWithis non-empty; its text says the stored authorization is shared withticktickand that Disconnect keeps the shared token. It is not a registry flag and not the manual-callback path: the ownership census found the same endpoint in the gateway's ownkirocrew-skill-view-*.jsonprojections and reported them as a sharer (the same census behaviour as step 9 and #29767). It persisted while those projections existed and is gone now that they are (status shows nograntSharedWith). The status line is the normal post-relay text after Complete connection; it clears once the status poll returns. Neither is TickTick-specific. Grant pair5d1b…bba6.token.json(0600) +.registration.jsonwritten 18:31:45Z under the pod OS home; stat only, token file opened once for its non-secret keys (see step 8)usable,toolCountreportedPOST /api/connections/test {"slug":"ticktick"}→{"verdict": "usable", "code": "tools_available", "toolCount": 58}in 3 stools/listroster vs the 58-tool card copy;list_projects,search,fetchpresent/mcp+/toolspath as Test, fresh session:/mcprowticktick: running, toolCount 58;/toolshas 58 names with sourcemcp:ticktick, includinglist_projects,search,fetch,get_tool_detailsand the five delete tools the gotcha names. Noticktick_*alias present, which is the rule:resolve_tool_aliasesrenames only when a second connected provider claims the same name (verified:{ticktick}→{},{ticktick, todoist}→ticktick_search,ticktick_fetch,todoist_*)list_projectswithlimit: 1(the registrysmoke_fixture), read-onlykiro-cli chat --agent kirocrew --no-interactive --trust-tools=@ticktick/list_projects, prompt asked for exactly that call. Stream: onetool_call@ticktick/list_projectswithrawInput {"limit": 1},status: completed,isError: false, result{"result": []}(an empty project list for this account; the call itself succeeded). Agent final text: "Tool called: list_projects (ticktick server) / Error: no / Projects returned: 0". No other tool was calledexpires_in: 15551999(180 days),token_type: bearer,scope: tasks:read tasks:writeand norefresh_token; TickTick's AS metadata listsgrant_types_supported: ["authorization_code"]only. So there is no refresh to exercise and a hold past expiry is not feasible; the equivalent check is reuse: three cold kiro-cli sessions at 19:53, 19:54 and 19:55Z (82–84 min after consent) all authenticated from the stored grant with no re-consent, and the token file mtime stayed 18:31:45Z. Finding: the entry'sgotcha_copysentence "Access tokens refresh automatically" is not what the grant shows; see belowPOST /api/connections/disconnect {"slug":"ticktick"}→ 200{"ok": true, "entryRemoved": true, "agentSpecRewritten": true, "grantRemoved": false, "grantSharedWith": ["ticktick"], "grantCensusIncomplete": false}. Theticktickentry leftkirocrew.json, but the grant pair was kept and the card still reads Connected, because the ownership census found the same URL in twokirocrew-skill-view-*.jsonfiles: Kiro Crew's own auto-managed projections ofkirocrewandkirocrew-worker, written by the promptless sessions of steps 6–7 before the purge.agent_spec_sourceslabels every non-kirocrew.jsonspecagent:(a hand-written sharer that may block a revoke), so the gateway's own reflection blocked its own revoke. A second Disconnect after a fresh spawn republished thekirocrewview (now without ticktick) still refused: the stale view files survive until the budgeted prune reaps them. Not a TickTick defect; same class as #29767 (a Notion grant kept because another spec named the endpoint). The two stale views were orphaned (no live spawn, superseded by views with a new digest, 40 min past the 600 s reclaim age) and were produced by this walk's own sessions, so they were set aside; the next Disconnect returnedgrantRemoved: true, grantSharedWith: [], the token/registration pair was unlinked (kiro-cli's own.metadata.jsonsidecar remains, as designed), and status readnot_connected / no_granthttps://ticktick.com/webapp/#settings→ Settings → Account → authorized apps lists the client; revoked thererevoke_page_urlanswers 200 (redirects tohttps://ticktick.com/for an anonymous client; the#settingsfragment is client-side);docs_url200. Operator (~20:09Z, logged in): TickTick Settings → Integrations ("manage other apps that have been authorized by the TickTick") lists the client as kiro with an UnLink action, so the revoke surface exists and is reachable fromrevoke_page_url; the entry'srevoke_manual_pathsays "Settings → Account → … authorized apps", and the page is actually under Integrations. The app appears five times, all named "kiro": each dynamic client registration leaves its own row (today's consent plus earlier registrations against the same server from this operator's hand-addedmcp.jsonentry and earlier connect attempts), and stale rows are unlinked by hand. The stored registration file carriesclient_id,client_secret,redirect_uri,scopesand noclient_name, so the "kiro" label is what kiro-cli registers. Nothing was unlinked during the walkScreenshots / video
The TickTick mark, before (grey
currentColormask) and after (brand colours), next to the vendor's own app icon:The Connections grid itself is unchanged apart from this card appearing; a grid screenshot of the connected state shows a personal account, so it is not attached.
Related Issues
Relates to #26388 (closed by #29289, which registered the entry gated). Step 9 hit the same Disconnect census behaviour as #29767.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)