Skip to content

fix(config): describe Mint Timeout's below-10 fallback in its help text - #30799

Merged
KiroCrewCaptain merged 2 commits into
mainfrom
fix/30396-mint-timeout-help
Nov 8, 2026
Merged

KiroCrewCaptain merged 2 commits into
mainfrom
fix/30396-mint-timeout-help

Conversation

@tim-finnigan

@tim-finnigan tim-finnigan commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The Remote Crew "Mint Timeout" help text says what actually happens to every value a user can enter.

The help said "Clamped to [10, 120]", but only the top is a clamp. InstancesConfig.__post_init__ discards a value below 10 with a warning and falls back to the transport default (SSH 30s, SSM 90s), so a user who enters 5 expecting 10 gets 30s on SSH or 90s on SSM.

Why it matters

A user tuning a slow remote host reads the help to pick a value. A low value they believe is raised to 10 silently becomes 30s or 90s, which is the opposite of what they asked for and is hard to spot without reading the gateway log.

Not a goal

  • Changing the below-10 behaviour itself (making it a true clamp). The issue reports the help/code mismatch; the code's fallback is deliberate and logged.
  • Rewording other fields' help text.

What changed (motivation → approach → change)

Symptom: help says "Clamped to [10, 120]" while a value below 10 becomes the transport default. Root cause: the help string in src/kiro_crew/config/integration_sections.py described a two-sided clamp that __post_init__ never implemented on the low side. Change: the help now states each case. I read the code (InstancesConfig.__post_init__, _build_instances_config in src/kiro_crew/config/section_builders.py, _safe_float in src/kiro_crew/config/fields.py) and checked each input through KiroCrewConfig.load() on this branch. _safe_float would read a non-number as 30s, but validate_config_data drops it first, so that fallback is unreachable on the real load path:

Input Result Help now says
below 10 (5) None, warning logged, transport default used (SSH 30s, SSM 90s) "discarded with a warning and the transport default is used"
10 10.0 in range, no special case
120 120.0 in range, no special case
above 120 (500) 120.0 "clamped to 120"
non-numeric ("abc") dropped by validate_config_data with a type-mismatch warning, so None and the transport default "one that is not a number, is discarded with a warning and the transport default is used"
empty string "" same as non-numeric: dropped with a warning, transport default same sentence as non-numeric
unset (null / key absent) None, transport default existing "When unset, SSH uses 30s and SSM uses 90s" sentence

config-baseline.json is regenerated for the new description string. No code path changed.

Backwards compatibility

Compatible: only a help/description string and its baseline snapshot change; every value accepted today is handled the same way.

Removes nothing: the diff changes descriptive text only and takes away no key, path, record or validator.

Tests

No new test: the change is help copy only, and test/test_config_baseline.py pins the description string through config-baseline.json, which is updated in this commit.

Proof: not provable -- copy-only change

Ran locally on the rebased head (main 90a555f): config baseline, config loader sections, configuration doc defaults, config module boundaries, remote crew doc, connections mint flow and ssh tunnel manager bindings tests: 619 passed, 1 failed. The failure (test_ssh_tunnel_manager_bindings.py::test_a_moved_class_annotations_still_resolve) fails identically on a clean origin/main checkout at 90a555f, so it is pre-existing.

Rebased onto main 7c364bc (no content change) to pick up #31625 (security package line budget) and #31803 (pull_request_target allowlist), both of which failed Backend Tests on earlier merge refs; test/test_config_baseline.py, test/test_security_gate_liveness.py and test/test_pull_request_target_allowlist.py pass on the rebased head.

Manual verification

Loaded a config through KiroCrewConfig.load() with mint_timeout_secs set to each of unset, "", 5, 10, 120, 500 and "abc" on this branch; results are the table above, and the below-10, above-120 and non-numeric cases logged their warnings.

Related Issues

Fixes #30396

Sibling sweep

Swept: git grep -n -E "Clamped to [" -- src/
Sibling: src/kiro_crew/config/memory_sections.py -- not affected -- both "Clamped to" fields (lines 98 and 390) are read via _safe_float(lo, hi), a true two-sided clamp
Sibling: src/kiro_crew/mcp_gateway/daemon/cli.py:132 -- not affected -- CLI flag help naming its min/max flags, not a config floor with a fallback

Pattern harvest

Not generalizable: one field whose low bound is a discard-and-fallback rather than a clamp; the other "Clamped to" strings in src/ are real clamps.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

@tim-finnigan
tim-finnigan requested review from a team and KiroCrewCaptain as code owners November 5, 2026 22:23
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 5, 2026
@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 77878cab696342e6f1f14d3a6736997c13a46c87 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 77878cab696342e6f1f14d3a6736997c13a46c87 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Copy-only fix: the help text now matches what the loader does for each input, and the baseline is updated with it.

[DESIGN-REVIEWED] 77878ca

Description read

[DESCRIPTION-READ] a54233d94cfe4ecd4f95933a9f0fa9b79ffb9b404a68a284baa654b28cd540f3

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 77878cab696342e6f1f14d3a6736997c13a46c87 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. This is a help-text fix tied to issue #30396. The new wording matches what InstancesConfig.__post_init__ does for values below 10 and above 120.

What this change ships

Inventory (2 items) — 2 justified

Intent: a user setting Mint Timeout can read in the help text what happens to any value they enter. FIX.

  1. The Mint Timeout help now says a value below 10, or a non-number, is discarded and the transport default is used. A value above 120 is clamped. — justified
  2. The config baseline snapshot carries the same new help string. — justified

[FIRST-PRINCIPLES-REVIEWED] 77878ca

Description read

[DESCRIPTION-READ] d4c54dd818dfdfcd2e578f2c1bb3040a2cce23ec71f274afeecc0c44cc910a7c

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ human override accepted

Reviewed 77878cab696342e6f1f14d3a6736997c13a46c87 — this comment is updated in place on each push.

Human judgment by @tim-finnigan overrides the Opus 5.5 finding for 77878cab696342e6f1f14d3a6736997c13a46c87; the recorded reason is authoritative for this commit.

[OPUS-OVERRIDE] 77878ca

Verdict recorded from an authorized human decision for commit 77878cab696342e6f1f14d3a6736997c13a46c87.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 77878cab696342e6f1f14d3a6736997c13a46c87 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 77878cab696342e6f1f14d3a6736997c13a46c87 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 77878ca

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 77878cab696342e6f1f14d3a6736997c13a46c87 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 5, 2026
@tim-finnigan
tim-finnigan force-pushed the fix/30396-mint-timeout-help branch from c29515a to 5031c85 Compare November 6, 2026 18:52
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 6, 2026
@tim-finnigan
tim-finnigan force-pushed the fix/30396-mint-timeout-help branch from 5031c85 to 81a6a4c Compare November 6, 2026 21:25
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 6, 2026
The help said "Clamped to [10, 120]", but InstancesConfig.__post_init__
discards a value below 10 and uses the transport default (SSH 30s, SSM
90s), and the loader reads a non-numeric value as 30s. Say what the code
does for each input.

Fixes #30396
validate_config_data drops a non-number before the section builder runs,
so the 30s _safe_float fallback is unreachable on KiroCrewConfig.load().
@tim-finnigan
tim-finnigan force-pushed the fix/30396-mint-timeout-help branch from 81a6a4c to 77878ca Compare November 6, 2026 22:17
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 6, 2026
@tim-finnigan

Copy link
Copy Markdown
Contributor Author

/ai-review override fable 77878ca false-positive: validate_config_data drops a non-number mint_timeout_secs before _build_instances_config runs (jsonschema is a pinned dependency), so "abc" and true load as None with a type-mismatch warning and the transport default applies. Verified by loading both through KiroCrewConfig.load().

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Human judgment recorded

@tim-finnigan recorded a false-positive release (class false-positive) for the fable AI finding on 77878cab696342e6f1f14d3a6736997c13a46c87.

validate_config_data drops a non-number mint_timeout_secs before _build_instances_config runs (jsonschema is a pinned dependency), so "abc" and true load as None with a type-mismatch warning and the transport default applies. Verified by loading both through KiroCrewConfig.load().

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 7, 2026
@KiroCrewCaptain
KiroCrewCaptain enabled auto-merge (squash) November 8, 2026 00:03

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: fix (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: help text for Mint Timeout now states the real below-10 fallback and the above-120 clamp; only the help string and its config baseline change.

@KiroCrewCaptain
KiroCrewCaptain merged commit 0b4e7fe into main Nov 8, 2026
119 of 128 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the fix/30396-mint-timeout-help branch November 8, 2026 00:04
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 8, 2026
buluoray added a commit that referenced this pull request Nov 8, 2026
…xt (#30799)

* fix(config): describe Mint Timeout's below-10 fallback in its help text

The help said "Clamped to [10, 120]", but InstancesConfig.__post_init__
discards a value below 10 and uses the transport default (SSH 30s, SSM
90s), and the loader reads a non-numeric value as 30s. Say what the code
does for each input.

Fixes #30396

* fix(config): say a non-numeric Mint Timeout uses the transport default

validate_config_data drops a non-number before the section builder runs,
so the 30s _safe_float fallback is unreachable on KiroCrewConfig.load().

(cherry picked from commit 0b4e7fe)

Original author: @tim-finnigan
buluoray added a commit that referenced this pull request Nov 8, 2026
…xt (#30799)

* fix(config): describe Mint Timeout's below-10 fallback in its help text

The help said "Clamped to [10, 120]", but InstancesConfig.__post_init__
discards a value below 10 and uses the transport default (SSH 30s, SSM
90s), and the loader reads a non-numeric value as 30s. Say what the code
does for each input.

Fixes #30396

* fix(config): say a non-numeric Mint Timeout uses the transport default

validate_config_data drops a non-number before the section builder runs,
so the 30s _safe_float fallback is unreachable on KiroCrewConfig.load().

(cherry picked from commit 0b4e7fe)

Original author: @tim-finnigan
buluoray added a commit that referenced this pull request Nov 8, 2026
…xt (#30799)

* fix(config): describe Mint Timeout's below-10 fallback in its help text

The help said "Clamped to [10, 120]", but InstancesConfig.__post_init__
discards a value below 10 and uses the transport default (SSH 30s, SSM
90s), and the loader reads a non-numeric value as 30s. Say what the code
does for each input.

Fixes #30396

* fix(config): say a non-numeric Mint Timeout uses the transport default

validate_config_data drops a non-number before the section builder runs,
so the 30s _safe_float fallback is unreachable on KiroCrewConfig.load().

(cherry picked from commit 0b4e7fe)

Original author: @tim-finnigan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remote-crew "Mint Timeout" help says "Clamped to [10, 120]" but a value below 10 falls back to 30 s

2 participants