Repository navigation
fix(config): describe Mint Timeout's below-10 fallback in its help text - #30799
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Copy-only fix: the help text now matches what the loader does for each input, and the baseline is updated with it. [DESIGN-REVIEWED] 77878ca Description read[DESCRIPTION-READ] a54233d94cfe4ecd4f95933a9f0fa9b79ffb9b404a68a284baa654b28cd540f3 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. This is a help-text fix tied to issue #30396. The new wording matches what What this change shipsInventory (2 items) — 2 justifiedIntent: a user setting Mint Timeout can read in the help text what happens to any value they enter. FIX.
[FIRST-PRINCIPLES-REVIEWED] 77878ca Description read[DESCRIPTION-READ] d4c54dd818dfdfcd2e578f2c1bb3040a2cce23ec71f274afeecc0c44cc910a7c That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ human override acceptedReviewed Human judgment by @tim-finnigan overrides the Opus 5.5 finding for [OPUS-OVERRIDE] 77878ca Verdict recorded from an authorized human decision for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
c29515a to
5031c85
Compare
5031c85 to
81a6a4c
Compare
The help said "Clamped to [10, 120]", but InstancesConfig.__post_init__ discards a value below 10 and uses the transport default (SSH 30s, SSM 90s), and the loader reads a non-numeric value as 30s. Say what the code does for each input. Fixes #30396
validate_config_data drops a non-number before the section builder runs, so the 30s _safe_float fallback is unreachable on KiroCrewConfig.load().
81a6a4c to
77878ca
Compare
|
/ai-review override fable 77878ca false-positive: validate_config_data drops a non-number mint_timeout_secs before _build_instances_config runs (jsonschema is a pinned dependency), so "abc" and true load as None with a type-mismatch warning and the transport default applies. Verified by loading both through KiroCrewConfig.load(). |
Human judgment recorded@tim-finnigan recorded a false-positive release (class
This decision applies only to this commit. A new push requires a new judgment. |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: help text for Mint Timeout now states the real below-10 fallback and the above-120 clamp; only the help string and its config baseline change.
…xt (#30799) * fix(config): describe Mint Timeout's below-10 fallback in its help text The help said "Clamped to [10, 120]", but InstancesConfig.__post_init__ discards a value below 10 and uses the transport default (SSH 30s, SSM 90s), and the loader reads a non-numeric value as 30s. Say what the code does for each input. Fixes #30396 * fix(config): say a non-numeric Mint Timeout uses the transport default validate_config_data drops a non-number before the section builder runs, so the 30s _safe_float fallback is unreachable on KiroCrewConfig.load(). (cherry picked from commit 0b4e7fe) Original author: @tim-finnigan
…xt (#30799) * fix(config): describe Mint Timeout's below-10 fallback in its help text The help said "Clamped to [10, 120]", but InstancesConfig.__post_init__ discards a value below 10 and uses the transport default (SSH 30s, SSM 90s), and the loader reads a non-numeric value as 30s. Say what the code does for each input. Fixes #30396 * fix(config): say a non-numeric Mint Timeout uses the transport default validate_config_data drops a non-number before the section builder runs, so the 30s _safe_float fallback is unreachable on KiroCrewConfig.load(). (cherry picked from commit 0b4e7fe) Original author: @tim-finnigan
…xt (#30799) * fix(config): describe Mint Timeout's below-10 fallback in its help text The help said "Clamped to [10, 120]", but InstancesConfig.__post_init__ discards a value below 10 and uses the transport default (SSH 30s, SSM 90s), and the loader reads a non-numeric value as 30s. Say what the code does for each input. Fixes #30396 * fix(config): say a non-numeric Mint Timeout uses the transport default validate_config_data drops a non-number before the section builder runs, so the 30s _safe_float fallback is unreachable on KiroCrewConfig.load(). (cherry picked from commit 0b4e7fe) Original author: @tim-finnigan
Problem / Motivation
Goal: The Remote Crew "Mint Timeout" help text says what actually happens to every value a user can enter.
The help said "Clamped to [10, 120]", but only the top is a clamp.
InstancesConfig.__post_init__discards a value below 10 with a warning and falls back to the transport default (SSH 30s, SSM 90s), so a user who enters 5 expecting 10 gets 30s on SSH or 90s on SSM.Why it matters
A user tuning a slow remote host reads the help to pick a value. A low value they believe is raised to 10 silently becomes 30s or 90s, which is the opposite of what they asked for and is hard to spot without reading the gateway log.
Not a goal
What changed (motivation → approach → change)
Symptom: help says "Clamped to [10, 120]" while a value below 10 becomes the transport default. Root cause: the help string in
src/kiro_crew/config/integration_sections.pydescribed a two-sided clamp that__post_init__never implemented on the low side. Change: the help now states each case. I read the code (InstancesConfig.__post_init__,_build_instances_configinsrc/kiro_crew/config/section_builders.py,_safe_floatinsrc/kiro_crew/config/fields.py) and checked each input throughKiroCrewConfig.load()on this branch._safe_floatwould read a non-number as 30s, butvalidate_config_datadrops it first, so that fallback is unreachable on the real load path:None, warning logged, transport default used (SSH 30s, SSM 90s)"abc")validate_config_datawith a type-mismatch warning, soNoneand the transport default""null/ key absent)None, transport defaultconfig-baseline.jsonis regenerated for the new description string. No code path changed.Backwards compatibility
Compatible: only a help/description string and its baseline snapshot change; every value accepted today is handled the same way.
Removes nothing: the diff changes descriptive text only and takes away no key, path, record or validator.
Tests
No new test: the change is help copy only, and
test/test_config_baseline.pypins the description string throughconfig-baseline.json, which is updated in this commit.Proof: not provable -- copy-only change
Ran locally on the rebased head (main 90a555f): config baseline, config loader sections, configuration doc defaults, config module boundaries, remote crew doc, connections mint flow and ssh tunnel manager bindings tests: 619 passed, 1 failed. The failure (
test_ssh_tunnel_manager_bindings.py::test_a_moved_class_annotations_still_resolve) fails identically on a clean origin/main checkout at 90a555f, so it is pre-existing.Rebased onto main 7c364bc (no content change) to pick up #31625 (security package line budget) and #31803 (pull_request_target allowlist), both of which failed Backend Tests on earlier merge refs;
test/test_config_baseline.py,test/test_security_gate_liveness.pyandtest/test_pull_request_target_allowlist.pypass on the rebased head.Manual verification
Loaded a config through
KiroCrewConfig.load()withmint_timeout_secsset to each of unset,"", 5, 10, 120, 500 and"abc"on this branch; results are the table above, and the below-10, above-120 and non-numeric cases logged their warnings.Related Issues
Fixes #30396
Sibling sweep
Swept: git grep -n -E "Clamped to [" -- src/
Sibling: src/kiro_crew/config/memory_sections.py -- not affected -- both "Clamped to" fields (lines 98 and 390) are read via _safe_float(lo, hi), a true two-sided clamp
Sibling: src/kiro_crew/mcp_gateway/daemon/cli.py:132 -- not affected -- CLI flag help naming its min/max flags, not a config floor with a fallback
Pattern harvest
Not generalizable: one field whose low bound is a discard-and-fallback rather than a clamp; the other "Clamped to" strings in src/ are real clamps.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project's Apache-2.0 license.