Repository navigation
fix(release): backport one knowledge fix to 0.12.0 line - #31019
Conversation
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks: this is a clean What this change shipsInventory (5 items) — 5 justifiedIntent: let a 0.12.x user add a long document to knowledge and still find its end by search — FIX (backport).
[FIRST-PRINCIPLES-REVIEWED] cc69f36 Description read[DESCRIPTION-READ] 3bcdbb5b54e7abfb564841da0891178b8b68dbe42c229a2a7a4ea2315865c3c3 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this is a clean single-commit backport of a fix already merged on main. It takes nothing away and renders no new UI. Notes
[DESIGN-REVIEWED] cc69f36 Description read[DESCRIPTION-READ] fcf309f4a7e13b3fe5810977377b347015ac7c83802d7d3d06da87922522b5bb That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ human override acceptedReviewed Human judgment by @buluoray overrides the Opus 5.5 finding for [OPUS-OVERRIDE] cc69f36 Verdict recorded from an authorized human decision for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findings (all downgraded on adjudication)GPT 6.1 flagged blocking issues on This comment is updated in place on each push. Review detailsBLOCKING -- src/kiro_crew/knowledge/chunker.py:193 -- Merging chunks drops previously embedded content
Adjudication (Opus 5.5) — is blocking on each finding proportionate?F1 — MEDIUM harm at most, recoverable, and the PR makes things strictly better than before. These conditions are in the code:
False positive or not applicable? A repository writer can comment: |
…g the tail (#30588) A document that split into more than MAX_CHUNKS_PER_FILE (50) chunks kept only the first 50, with no log, and its file row still said done: a ~48,000-character Japanese file lost its last sentence from search. Every chunker path now merges neighbouring chunks so the document fits the cap whole. The cap and every bound that reads it are unchanged. Fixes #30335 Co-authored-by: Zezhen Xu <zezhexu@amazon.com> (cherry picked from commit 0c5e576)
5add895 to
cc69f36
Compare
|
/ai-review override fable cc69f36 evidence-supplied: backport of #30588 unchanged; on main this diff passed Opus and GPT adjudicated the same finding non-blocking (#30588 (comment)). All text stays stored and keyword-searchable, where base dropped every piece past 50. |
Human judgment recorded@buluoray recorded a evidence-supplied release (class
This decision applies only to this commit. A new push requires a new judgment. |
Problem / Motivation
Goal: Bring one knowledge fix that merged on
mainafterv0.12.0ontorelease/0.12.0, as its own commit, so the 0.12.1 patch ships it and it can be reverted alone.Why it matters
Not a goal
main; nothing is changed only here.CHANGELOG.mdchange. Cuttingv0.12.1-rc.Nand the bare tag follow docs/build/release.md and stay with the maintainers.main, and then comes back together with that fix in a later release PR.What changed (motivation → approach → change)
The main squash commit was cherry-picked with
-xontorelease/0.12.0@f315771db6(=v0.12.0) and applied clean. The branch also merges clean onto today'srelease/0.12.0@6c33d94b6e(git merge-tree, no conflicts).0c5e576ff7cc69f3650aBackwards compatibility
Compatible: the change is the one already merged on
main, and #30588's own compatibility note applies unchanged.Removes nothing: the pick hides, deletes or renames nothing 0.12.0 accepts beyond what #30588 already reviewed.
Tests
Proof: not provable -- other: a backport of a main commit whose proof ran on its own PR
release/*, so the related set was run here: the 11 knowledge test files that importkiro_crew.knowledge.chunker, including the changedtest_knowledge_chunker.py, in one pytest process,-n 0. 403 passed.knowledge/chunker.py.Manual verification
N/A - the pick was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.
Related Issues
Backport of #30588 to the 0.12 line for 0.12.1. Source issue: #30335.
Sibling sweep
Siblings: none -- #30588 carried its own sibling sweep; this PR only carries that fix unchanged.
Pattern harvest
Not generalizable: this PR only carries one fix already on
main. #30588 has its own harvest.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.