Skip to content

fix(chat): say when a chosen steer ran as its own turn - #31055

Merged
KiroCrewCaptain merged 1 commit into
mainfrom
pearcekieser/steer-receipt-own-turn
Nov 7, 2026
Merged

KiroCrewCaptain merged 1 commit into
mainfrom
pearcekieser/steer-receipt-own-turn

Conversation

@Pearcekieser

@Pearcekieser Pearcekieser commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The steer receipt on a row that ran as its own turn no longer says "interrupt this turn".

A send in Auto (Jev) mode while a turn runs can get a steer decision. The user row then shows the receipt "Jev chose: interrupt this turn". The running turn does not always take the steer. If the turn ends before it confirms the steer, the steer row is marked requeued and the text runs as its own turn. If the steer path is not available, the send falls through to the queue. In both cases the receipt still says "interrupt this turn". After #18517, the drain copies the receipt onto the new row below the [Stopped] card, and there it reads as a decision about the new turn.

Why it matters

The receipt is the only place that tells the sender who decided how the message was handled, and the thumbs beside it rate that decision. On these rows the sentence states an outcome that did not happen, so the sender can rate the wrong thing. This was deferred from the #18517 UX review, span fc2547699fb0.

Not a goal

  • Changing when a steer is requeued, or which row carries the receipt. fix(dashboard): run a requeued steer on its own row instead of a duplicate #18517 owns both.
  • Changing the queue choice sentence, "Jev chose: run after this turn". It already names what happened.
  • Changing the requeued lifecycle line, "Turn ended before this applied, runs as its own message".
  • Marking a steer whose RPC died after it wrote the frame (ambiguous_delivery). That steer is also marked requeued, and its row carries no flag for the case: STEER_POSSIBLY_DELIVERED_META is set only on the queue entry, and the drain pops it before it writes the row. The new receipt says only what Jev chose, so it makes no claim about whether the steer was read. The lifecycle line on main still says "Turn ended before this applied" on those rows.

What changed (motivation → approach → change)

SteerDecisionLine (website/src/pages/chat/SteerDecisionLine.tsx) picked its sentence from record.choice alone, so a steer choice always read "interrupt this turn". The row meta says whether a running turn took the steer, but the line did not read it.

UserMessage (website/src/pages/chat/UserMessage.tsx) now computes steerOwnMessage. It is set when the row has no meta.steer, or when steerState is requeued or superseded. A row with no meta.steer that carries a steer receipt is the row the drain writes for a requeued steer, or the queued row of a steer that was not available. UserMessage passes the value to both places that draw SteerDecisionLine as the optional ownMessage prop.

For a steer choice on those rows, SteerDecisionLine states the choice as an intent, "chose to interrupt", and does not use the "interrupt this turn" command form. There are two sentences, so the row never says the same thing twice:

  • short, "Jev chose to interrupt", on a requeued steer row. That row already shows the lifecycle line "Turn ended before this applied, runs as its own message", so the receipt leaves the outcome to that line.
  • full, "Jev chose to interrupt, but this runs as its own message", on every other such row. Those rows have no lifecycle line.

The line sets data-ran-as-own-turn="true" in both cases, and data-choice stays steer. The full sentence wraps instead of truncating, and so does the line, so on a narrow pane the score and thumbs move below the sentence instead of cutting off its last clause. A queue choice ignores the prop. A steer row that is written, consumed or has no state keeps "interrupt this turn".

Two earlier versions failed the UX review. "Jev chose: interrupt the turn, but this runs as its own message" read as a contradiction, because "interrupt the turn" sounds done and "but" then undoes it, and it repeated the lifecycle line on a requeued row. "Jev chose: interrupt, not applied" also read as "it interrupted and it did not", because the verb stood next to its own cancellation. "Chose to interrupt" names the intent, so the outcome after it does not undo a verb.

The two keys, steer_chose_steer_requeued and steer_chose_steer_own_message, are added next to steer_chose_steer in en.manual.json and in the 11 translated catalogs, and en-XA.json is regenerated with npm run i18n:pseudo.

The change works on main alone: requeued steer rows and fall-through rows already carry the receipt there. #18517 adds the superseded state and copies the receipt onto the drained row. This change reads superseded already, so either PR can merge first and neither needs a change for the other.

Backwards compatibility

Compatible: the prop is optional and unset by default, and rows on disk keep their meta. Only the sentence on rows that run as their own message changes.

Removes nothing: the change adds two sentences and one data attribute and keeps every existing sentence, key and attribute.

Tests

website/src/test/SteerDecisionLine.test.tsx, new describe block "a chosen steer the running turn did not take", eight tests:

  • A requeued steer row shows "Jev chose to interrupt", sets data-ran-as-own-turn="true", keeps data-choice="steer", says "its own message" once for the whole row, and does not say "not applied".
  • The own-message sentence wraps and the line wraps, and the plain steer sentence still truncates.
  • A superseded steer row, which draws no lifecycle line, shows the full sentence.
  • A plain user row with a steer receipt shows the full sentence.
  • A written, consumed or stateless steer row keeps "Jev chose: interrupt this turn" with no new attribute.
  • A queue receipt keeps "Jev chose: run after this turn" on a plain, a requeued and a consumed row.
  • SteerDecisionLine with ownMessage="full" and a queue record keeps the queue sentence.

The requeued, superseded, plain-row and wrap tests failed on the previous head. The others pin behaviour that does not change, so they pass on both sides.

Proof: not provable -- frontend test (prove.py runs Python only)

Manual verification

N/A. Unit coverage is sufficient, and the stills below draw the real components.

Screenshots / video

The sheet draws three separate moments with the real UserMessage and StopEventCard, and each frame has its own caption. Frame 1 is the steer row marked requeued above the Stop card, before its own turn starts: its lifecycle line says the text runs as its own message, and the receipt only says what Jev chose. Frame 2 is the same message later, on the row its own turn runs from, below the Stop card. With #18517 the row from frame 1 is hidden at that point, so the message shows once. That row has no lifecycle line and gets the full sentence. Frame 3 is a consumed steer for comparison, which keeps "interrupt this turn". The capture runner asserts the sentence and the data-ran-as-own-turn attribute in each frame, that frame 1's receipt does not repeat "own message", and that no receipt says "not applied".

Steer receipt on rows that run as their own message, dark theme

Steer receipt on rows that run as their own message, light theme

Related Issues

Deferred from the #18517 UX review. Tracked first as Pearcekieser#46.

Sibling sweep

Swept: git grep -n "SteerDecisionLine|steer_chose_steer" -- website/src
Sibling: website/src/pages/chat/UserMessage.tsx -- changed here
Sibling: website/src/pages/chat/DecisionStrip.tsx -- not affected -- the skills strip names no delivery outcome

Pattern harvest

Not generalizable: the receipt line is the only surface that states a decision next to a delivery outcome it does not read, and the change makes it read that outcome.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license.

Fixes #31054

@Pearcekieser
Pearcekieser requested review from a team and KiroCrewCaptain as code owners November 6, 2026 03:57
@Pearcekieser
Pearcekieser requested a review from Zedmor November 6, 2026 03:57
@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 8de349635a569102ca21fa2912751159cd55a711 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 8de3496

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 8de349635a569102ca21fa2912751159cd55a711 false-positive: <reason, 20 to 500 characters>

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

chore (non-blocking): same-tree rerun for lanes that failed on the CI rate limit

c0c49f7 has the same tree as ad20f6f. On ad20f6f, Dependency License Gate, Design Review, First Principles Review, Opus 5.5 Review and UX Review failed between 03:59 and 04:05 UTC with GitHub API rate-limit errors, and PR Readiness failed as their rollup.

@Pearcekieser
Pearcekieser force-pushed the pearcekieser/steer-receipt-own-turn branch from ad20f6f to c0c49f7 Compare November 6, 2026 05:42
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 8de349635a569102ca21fa2912751159cd55a711 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Small fix in the right place: the receipt now checks the delivery state the row already has. It adds no new data and takes nothing away.

[DESIGN-REVIEWED] 8de3496

Description read

[DESCRIPTION-READ] a21e6b93ed1d22ede2910bf4d11de23731b8ad2a84f288e922939946eb55e108

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 8de349635a569102ca21fa2912751159cd55a711 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. The blind reader saw both new receipt sentences and read them correctly: Jev picked interrupt, and the message ran on its own.

Notes

  • Wrapping on a narrow pane (flex-wrap, break-words) shows in neither still. A narrow-width capture would confirm that the score and thumbs drop below the sentence cleanly.

[UX-REVIEWED] 8de3496

Description read

[DESCRIPTION-READ] 78b037d23aa46bfea2bf6cd01904dbaffd8c45ec985df59812ef96ebd3524931

That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 8de349635a569102ca21fa2912751159cd55a711 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Small fix aimed at the mechanism: the receipt line now checks whether a running turn took the steer. Only the new DOM attribute has no consumer.

Notes

  • Item 5 — zero consumers: data-ran-as-own-turn={ownTurn ? 'true' : undefined} is read only by SteerDecisionLine.test.tsx. I grepped ran-as-own-turn across the repo and found 0 non-test readers; capture-decision-message-steer.mjs reads only data-choice. Subtraction: delete the attribute and have the tests check the rendered sentence, which they already do.

What this change ships

Inventory (5 items) — 4 justified

Intent: a sender rating Jev's steer decision sees a receipt that matches what happened to their message. This is a FIX.

  1. A steer receipt on a requeued steer row now reads "Jev chose to interrupt" instead of "interrupt this turn" — justified
  2. A steer receipt on a superseded or plain drained/fall-through row reads "…chose to interrupt, but this runs as its own message" — justified
  3. Steer and queue receipts on every other row keep their current sentence — justified
  4. The own-message receipt wraps instead of truncating, so the score and thumbs move below the sentence on a narrow pane — justified
  5. A new DOM attribute data-ran-as-own-turn marks these rows — zero consumers

[FIRST-PRINCIPLES-REVIEWED] 8de3496

Description read

[DESCRIPTION-READ] 164d0adc7b3f0ff764e2c26add62d68aadd1f64cf5ba420075f9c960ff4cffae

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 8de349635a569102ca21fa2912751159cd55a711 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 8de3496

Verdict parsed from the review's SHA-scoped output markers for commit 8de349635a569102ca21fa2912751159cd55a711.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 8de349635a569102ca21fa2912751159cd55a711 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 6, 2026
@Pearcekieser
Pearcekieser force-pushed the pearcekieser/steer-receipt-own-turn branch from c0c49f7 to 3779309 Compare November 7, 2026 04:15
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 7, 2026
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

span=03025e01447e

Fixed in 3779309. The sentence now names the choice and says that it was not applied, with no second verb.

A requeued steer row already shows "Turn ended before this applied, runs as its own message". On that row the receipt is now "Jev chose: interrupt, not applied". Every other row that no turn took gets "Jev chose: interrupt, not applied, so this runs as its own message". No row says "interrupt the turn", and no row says "its own message" twice.

The stills in the PR body show both rows. A test in website/src/test/SteerDecisionLine.test.tsx checks that the requeued row says "its own message" one time only.

A steer the running turn did not take runs as its own turn: the turn
ended before it read the steer (requeued, then superseded), or the steer
path was unavailable and the send fell through to the queue. Its decision
receipt still read 'Jev chose: interrupt this turn', which on the row below
the Stop card reads as a decision about the new turn.

UserMessage now passes ranAsOwnTurn to SteerDecisionLine for a row with
no meta.steer or a requeued or superseded steer row. A steer choice on
such a row shows 'Jev chose: interrupt the turn, but this runs as its own
message' and sets data-ran-as-own-turn. A queue choice is unchanged.
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 7, 2026
@Pearcekieser
Pearcekieser force-pushed the pearcekieser/steer-receipt-own-turn branch from 3779309 to 8de3496 Compare November 7, 2026 04:47
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

span=1ddb32b2e02a

Fixed in 8de3496. The receipt now states the choice as an intent, "chose to interrupt", and no longer puts "not applied" next to the verb.

On a requeued steer row, which already shows "Turn ended before this applied, runs as its own message", the receipt is "Jev chose to interrupt". The outcome is left to the lifecycle line, so the row says it one time. On every other row that runs as its own message, the receipt is "Jev chose to interrupt, but this runs as its own message".

For the note about frames 1 and 2, each frame caption now says which moment it shows. Frame 2 says that with #18517 the row from frame 1 is hidden when this row lands, so the message shows once. The stills in the PR body are recaptured, and the capture runner fails if a receipt says "not applied".

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 7, 2026
@KiroCrewCaptain
KiroCrewCaptain enabled auto-merge (squash) November 7, 2026 07:04

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: fix (16 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: the steer decision line says when a chosen steer ran as its own message, with new strings in every locale and component tests; display-only change.

@KiroCrewCaptain
KiroCrewCaptain merged commit 2bc83d0 into main Nov 7, 2026
101 of 104 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the pearcekieser/steer-receipt-own-turn branch November 7, 2026 07:06
buluoray pushed a commit that referenced this pull request Nov 8, 2026
A steer the running turn did not take runs as its own turn: the turn
ended before it read the steer (requeued, then superseded), or the steer
path was unavailable and the send fell through to the queue. Its decision
receipt still read 'Jev chose: interrupt this turn', which on the row below
the Stop card reads as a decision about the new turn.

UserMessage now passes ranAsOwnTurn to SteerDecisionLine for a row with
no meta.steer or a requeued or superseded steer row. A steer choice on
such a row shows 'Jev chose: interrupt the turn, but this runs as its own
message' and sets data-ran-as-own-turn. A queue choice is unchanged.

(cherry picked from commit 2bc83d0)
buluoray pushed a commit that referenced this pull request Nov 8, 2026
A steer the running turn did not take runs as its own turn: the turn
ended before it read the steer (requeued, then superseded), or the steer
path was unavailable and the send fell through to the queue. Its decision
receipt still read 'Jev chose: interrupt this turn', which on the row below
the Stop card reads as a decision about the new turn.

UserMessage now passes ranAsOwnTurn to SteerDecisionLine for a row with
no meta.steer or a requeued or superseded steer row. A steer choice on
such a row shows 'Jev chose: interrupt the turn, but this runs as its own
message' and sets data-ran-as-own-turn. A queue choice is unchanged.

(cherry picked from commit 2bc83d0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Steer receipt says "interrupt this turn" on a steer that ran as its own message

2 participants