Skip to content

feat: show a pending badge on the project chip after a mid-reply pick - #31080

Merged
KiroCrewCaptain merged 2 commits into
mainfrom
feat/staged-project-pending-badge-20350
Nov 14, 2026
Merged

KiroCrewCaptain merged 2 commits into
mainfrom
feat/staged-project-pending-badge-20350

Conversation

@JLargent42

@JLargent42 JLargent42 commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A project picked while a reply runs shows a visible, accessible pending badge on the project chip until that project takes effect.

Since #17729 the project chip stays enabled mid-reply and a pick is staged for the next turn. The chip names the picked project at once, but the only sign that the running reply still works in its old directory is the chip's tooltip. Touch users cannot hover, so they see the new project name with no hint that it has not applied yet.

Why it matters

A user on a phone or tablet who picks a project mid-reply reads the chip as "already switched" and can misjudge where the running reply is writing files. The reviewer on #17729 asked for this follow-up so the pending state is discoverable without hover; #7263 stays open until it is.

Not a goal

What changed (motivation → approach → change)

The tooltip was the only carrier of the pending state, so the fix puts it on the chip as rendered text. The start-of-turn snapshot that the tooltip already used moves out of ChatInput.tsx into website/src/components/chat-input/stagedProject.tsx (useStagedProject), which also answers whether a pick is still pending: the composer is busy and the chip's project differs from the one the busy window started in. The composer's busy flag stays true while attached sub-agents run after the reply ends, which is exactly the window where the server's deferred reset stays armed. The badge clears as soon as the composer goes idle: from then on the chip names the project the next message will use, so nothing is pending.

While pending, the chip shows a small "Starts next message" badge, which says on its own that the switch is still to come (on a compact shelf, where the chip drops its folder name, it is a clock followed by the picked folder's name, truncated at 88px), its accessible name and title gain "Switching to from your next message.", and the existing role="status" line announces it. The locked-by-sub-agents tooltip keeps the pending line too. The start-of-turn project is kept per chat (a map keyed by slot, dropped once that chat is seen idle), so leaving a busy chat and coming back keeps its pick pending. ChatPane.tsx and ComposerDockView.tsx pass a projectTurnKey (stagedProjectTurnKey(messages): the last row that opens a run turn, per the shared opensRunTurn predicate in groupDisplayItems.ts, which crewmateBrowserLive.tsx now uses too); when a queued message opens the next turn without the composer going idle, the hook re-takes the start project and the badge clears. While the chip is locked by attached sub-agents the held start survives a turn-key change, because the server keeps the reset deferred, so a sub-agent completion turn does not clear the badge. Two new catalog keys (components.chatInput.project_switch_pending, project_pending_badge) go into website/src/i18n/locales/en.manual.json and every shipped locale, with entries in website/src/i18n/en.context.json, and en-XA is regenerated. A capture script, website/scripts/capture-project-chip-pending.mjs, renders the real ChatInput and asserts the badge before writing each frame; the fixture website/capture/project-chip-mid-turn.tsx gains bare=1 (product UI only, no printed accessible name), width=N (compact shelf) and lockAfterPick=1 (sub-agents attach after the pick).

Backwards compatibility

Compatible: purely additive UI on the existing chip; no route, payload or stored state changes.

Removes nothing: the tooltip and accessible name keep every line they had, with one line added.

Tests

website/src/test/ChatInput.stagedProject.test.tsx (new, 12 tests) pins:

  • no badge without a pick, or after an idle pick;
  • normal completion: a mid-reply pick shows the badge reading exactly "Starts next message", accessible name and status line, which clear when the reply ends and stay clear on the next reply;
  • repeated picks name the latest pick, and picking the start project back clears it;
  • attached sub-agents: the badge stays on the locked chip until the composer goes idle;
  • slot switching: a pending pick does not carry into another chat, and survives leaving a busy chat and coming back;
  • turn key: a queued message opening the next turn clears the badge, while a sub-agent completion turn on a locked chip keeps it pending (fails without passing projectLocked to the hook);
  • stagedProjectTurnKey names the last run-turn opener and skips steers and parked sends;
  • keyboard: the focused chip names the pending pick and Enter opens the picker;
  • touch: the badge is rendered, visible, not screen-reader-only, with no hover, and a touch press opens the picker;
  • compact shelf: the chip drops its folder name and the badge is the clock (svg.lucide-clock) plus the picked folder name, aria-hidden, while the accessible name keeps the pending line.

Six of the first seven fail with the ChatInput.tsx change reverted (the first is the negative case). The copy and compact-glyph assertions (2 tests) fail with the previous revision's badge.

Proof: not provable -- frontend test (prove.py runs Python only)

Local gate at 40033fc: frontend related set green (126 files, 2167 tests); backend related batches green with the host reds below deselected. Backend related set: every red also fails at the merge-base on this host (sandbox/environment reds, not this diff): file_explorer/tests/test_server.py, test_auto_improvement_members.py, test_design_tweak_backend.py, test_design_tweak_devproc.py, test_dashboard_gallery_approvals.py, test_docker_entrypoint.py, test_crew_image_build_plan.py, test_mcp_slim_entry.py, test_kas_bundle.py, test_find_ui_auto.py, test_living_ui_harness.py, test_native_skill_projection.py. One load-sensitive red in test_sandbox_argv_spawn.py passed on two reruns at HEAD.

Manual verification

Ran website/scripts/capture-project-chip-pending.mjs at 28e39da against a local Vite server with every /api call stubbed (no gateway, no dashboard token) in both themes, three after-pick states each: every frame asserted no badge before the pick, the fixture's printed label hidden, and after a tap-pick a visible badge with no hover ("Starts next message" on the full shelf and on the locked chip; on a compact shelf the clock glyph plus the visible text "OtherRepo"), plus the pending line and either "This reply finishes in KiroCrew." or the sub-agents lock line in the accessible name.

Screenshots / video

Product UI only (no printed tooltip text). After a mid-reply pick, pointer away from the chip (dark, light):

Project chip with Starts next message badge, dark theme

Project chip with Starts next message badge, light theme

Compact shelf (400px window): the chip drops its folder name, and the badge is a clock followed by the picked folder name, "OtherRepo". Captured at 28e39da (dark, light):

Compact project chip with clock and OtherRepo badge, dark theme

Compact project chip with clock and OtherRepo badge, light theme

Sub-agents attached after the pick: the chip is disabled (asserted by the capture) and keeps the badge. The disabled chip has no separate disabled look, so this frame matches the unlocked one pixel for pixel (dark, light):

Locked project chip keeping the badge, dark theme

Locked project chip keeping the badge, light theme

Before a pick (no badge)

Project chip before a pick, dark theme

Project chip before a pick, light theme

Related Issues

Closes #20350
Follow-up to #17729; part of #7263 (stays open).
#20352 stacks on this PR; merge this first.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

@JLargent42
JLargent42 requested review from a team and KiroCrewCaptain as code owners November 6, 2026 04:47
@JLargent42
JLargent42 requested a review from Zedmor November 6, 2026 04:47
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 28e39da23818445d9527bb74486687e894260ce8 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: a real touch-discoverability gap, closed by a small client-side hook on the existing chip, with rendered evidence attached.

Notes

  • The pending state is worked out in the client from the busy flag and the turn key. It is not read from the server's deferred-reset state, so the badge can disagree with what the server will actually do in the reload case the PR leaves out. A future server-exposed start project should replace useStagedProject's baseline map rather than sit alongside it.

[DESIGN-REVIEWED] 28e39da

Description read

[DESCRIPTION-READ] 1cb9d00f61377bff8283e92d2cf2c216bc53ebf8c1d4596aeaf6e927bd4e1517

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of 28e39da23818445d9527bb74486687e894260ce8 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing the compact-shelf badge as HEAD renders it (clock plus truncated folder name). The description says the compact frames were "captured before the folder name was added and show the clock alone".

Evidence gaps

  • Compact-shelf pending badge (ProjectPendingBadge compact: <Clock/> + <span className="truncate max-w-[88px]">{folderName(project)}</span>). Shots 03 and 04 show the earlier clock-only badge, which the blind reader could not decode: "The clock alone doesn't tell me 'next message'". To close the gap, re-run capture-project-chip-pending.mjs at a 400px window on HEAD and attach dark and light stills.

Notes

  • The blind reader understood "Starts next message" correctly but only rated it a guess, and asked whether "starts" meant "a new chat starts". Naming the subject would fix that: "Switches next message" (string project_pending_badge).
  • The reader found nothing that says how to cancel a staged pick. The pending line could add "Pick again to cancel" (project_switch_pending).
  • Shots 05 and 06 (the locked chip) look identical to 01 and 02. The reader "can't see any difference", so nothing visible tells the user the chip is locked. This visual already existed before this PR, so it is only a note here.

[UX-REVIEWED] 28e39da

Description read

[DESCRIPTION-READ] 85be7872f234cf973057090acdb0bf3403e730e26f083281440ab252b7b3259e

That sha256 names everything this verdict read: the PR description, plus the 11 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 28e39da23818445d9527bb74486687e894260ce8 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. Every item is needed to show the staged pick until it applies, and the one helper this PR moves, opensRunTurn, now has two callers instead of a private copy.

Not checked: whether issue #20350 matches this scope; the description is the only source.

What this change ships

Inventory (8 items) — 8 justified

Intent: when someone picks a project while a reply is running, they can see without hovering that the switch has not applied yet. ADDITION, a follow-up to #17729.

  1. After a mid-reply pick, the chip shows a visible "Starts next message" badge — justified
  2. On a compact shelf, the badge is a clock plus the picked folder's name — justified
  3. The chip's accessible name and title gain "Switching to from your next message." — justified
  4. The role="status" line announces the pending switch — justified
  5. The locked-by-sub-agents tooltip keeps the pending line — justified
  6. A pending pick survives leaving a busy chat and coming back (kept per slot) — justified
  7. A queued message that opens the next turn clears the badge, except while sub-agents hold the chip locked — justified
  8. The run-turn predicate moves from crewmateBrowserLive.tsx into groupDisplayItems.ts as opensRunTurn, used by both callers — justified

[FIRST-PRINCIPLES-REVIEWED] 28e39da

Description read

[DESCRIPTION-READ] 2c529779f20d181632fa649661ee4482c40986ab0edd74487d3e9d9a2dcaa57d

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 28e39da23818445d9527bb74486687e894260ce8 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 28e39da

Verdict parsed from the review's SHA-scoped output markers for commit 28e39da23818445d9527bb74486687e894260ce8.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 28e39da23818445d9527bb74486687e894260ce8 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Nov 6, 2026
@JLargent42

Copy link
Copy Markdown
Contributor Author

UX Review BLOCK addressed in 40033fc:

  • Badge text explains itself. It now reads "Starts next message", so it says the switch is still to come without needing the tooltip. Updated in en.manual.json and every shipped locale (bn, de, es, fr, hi, it, ja, ko, pt, ru, zh-CN), the en.context.json translator note now says the label must read as a pending action, and en-XA is regenerated. The test pins the exact text.
  • Compact shelf. The bare accent dot is now a clock glyph (lucide Clock, aria-hidden), so the cue is a shape and not only a colour. A new test checks that a 300px shelf drops the folder name and renders the glyph inside the chip, and that the accessible name keeps the pending line.
  • Screenshots recaptured without the fixture's tooltip text (new bare=1 fixture mode). Added the missing states: a compact shelf at a 400px window, and the chip locked by sub-agents after the pick (lockAfterPick=1; the capture asserts the chip is disabled and still shows the badge). All are in the description, both themes.
  • Design note: the hook docstring now says the badge clears when the composer goes idle.

GPT 6.1 Review posted no verdict comment on db09087 (treated as a rate-limit flake). Its lane re-runs on this push.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 28e39da23818445d9527bb74486687e894260ce8 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 28e39da

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 28e39da23818445d9527bb74486687e894260ce8 false-positive: <reason, 20 to 500 characters>

@JLargent42
JLargent42 force-pushed the feat/staged-project-pending-badge-20350 branch from 40033fc to de2c649 Compare November 6, 2026 07:59
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 6, 2026
@JLargent42
JLargent42 force-pushed the feat/staged-project-pending-badge-20350 branch from de2c649 to afe29e4 Compare November 6, 2026 09:28
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 6, 2026
@JLargent42
JLargent42 force-pushed the feat/staged-project-pending-badge-20350 branch from afe29e4 to edd0fc5 Compare November 6, 2026 10:07
@JLargent42

Copy link
Copy Markdown
Contributor Author

UX Review BLOCK on afe29e4 (compact-shelf clock glyph not understood) is addressed in edd0fc5, folded into the 2nd commit:

  • On a compact shelf, where the chip hides its folder name, the pending marker is no longer a bare clock. It is now the clock followed by the picked folder's name as visible text, truncated at 88px, in the same accent pill as the wide badge. A touch user sees which project the pending switch goes to without the tooltip. The chip's accessible name and the live status still carry the full "Switching to from your next message." line.
  • website/src/test/ChatInput.stagedProject.test.tsx: the compact-shelf test now checks that the marker's visible text is the picked folder name and that it still contains the clock glyph. This test fails on afe29e4 and passes now.
  • Checks: typecheck, eslint and i18n:check are clean, and the ChatInput vitest files pass (78 files, 1074 tests). No new strings.

The two non-blocking notes (naming the subject in the "Starts next message" badge, and adding a picker cue on the chip) are not in this push.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 6, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 12, 2026
@JLargent42
JLargent42 force-pushed the feat/staged-project-pending-badge-20350 branch from 64681f5 to 9b117df Compare November 12, 2026 23:42
@JLargent42

Copy link
Copy Markdown
Contributor Author

Review follow-up on 64681f5, folded into the 2nd commit as 9b117df:

  • Opus 5.5 BLOCK (chat round-trip hides the pending pick): fixed. useStagedProject now keeps the start-of-turn project per slot (a map keyed by slotId, dropped once that chat is seen idle) instead of one component-local snapshot. Going from busy chat A to B and back while A is still running restores A's own start project, so the badge, the accessible-name pending line and the role="status" text stay, and the tooltip still says the reply finishes in StartRepo. New test keeps a pending pick when the user leaves a busy chat and comes back fails on 64681f5 and passes now.
  • GPT 6.1 BLOCK (same round-trip, plus a queued successor turn keeping the badge): fixed. This lane's verdict was withheld by a GitHub API rate limit, so I read it from its withheld-verdict artifact. Besides the per-slot fix above, the composer now gets a projectTurnKey (the ts of the chat's last turn-opening row; steers and parked sends don't count). ComposerDockView and ChatPane compute it. When a queued message opens the next turn without the composer going idle, the key changes and the hook takes the start project again, so the badge clears once the switch has applied. New test clears the badge when a queued message opens the next turn... fails on 64681f5 and passes now. A unit test covers stagedProjectTurnKey.
  • Analyze (javascript-typescript): no change needed. The SARIF upload hit the API rate limit, an infra error. It runs again on this push.
  • Checks: typecheck, eslint on the touched files and i18n:check are clean. vitest passes for ChatInput*, ChatPane* and ComposerDock* (160 files, 1750 tests).

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 12, 2026
@JLargent42
JLargent42 force-pushed the feat/staged-project-pending-badge-20350 branch from 9b117df to 28e39da Compare November 13, 2026 00:10
@JLargent42

Copy link
Copy Markdown
Contributor Author

Review follow-up on 9b117df. I folded the fix into the 2nd commit as 28e39da.

  • Opus 5.5 BLOCK (a sub-agent completion row re-baselines while the reset is deferred): fixed. useStagedProject now takes projectLocked. While the chip is locked, the held start project survives a turn-key change. Only the key is updated, so once the lock lifts, the next real turn opener applies the pick. A subagent: completion turn therefore keeps the badge, the status line and "finishes in StartRepo". New test keeps the pick pending when a sub-agent completion opens a turn while the chip is locked fails without passing projectLocked and passes now.
  • GPT 6.1 BLOCK (same digest-drain path): fixed by the same change, which is the remedy the adjudication named.
  • First Principles BLOCK (second copy of the turn-opener predicate): fixed. The predicate is now opensRunTurn in website/src/pages/chat/groupDisplayItems.ts. crewmateBrowserLive.tsx and stagedProjectTurnKey both call it, and the inline condition appears nowhere else in website/src.
  • First Principles / Design / UX notes on the description: updated. The compact badge is now described as a clock plus the folder name. I added the projectTurnKey plumbing, the per-slot baselines and the locked hold. I have not re-captured the compact frames yet, so the description says they show the earlier clock-only render.
  • Analyze (javascript-typescript): no change needed. No verdict for this head. It runs again on this push.
  • Checks: typecheck, eslint on the touched files and i18n:check are clean. vitest passes for ChatInput*, ChatPane*, ComposerDock*, crewmate* and groupDisplay* (162 files) and for BrowserLiveCard (39 tests).

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Nov 13, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. The code and tests look solid on this head. One thing still blocks, and it is evidence, not code.

  1. website/src/components/chat-input/stagedProject.tsx:104-115 (compact ProjectPendingBadge): nobody has seen this render as HEAD draws it. On a compact shelf (400px window), HEAD draws a clock followed by the truncated folder name. The two compact frames in the description were captured before the folder name was added, so they show the clock alone, and your last comment says they have not been re-captured. The UX review on this head says it "cannot evaluate" the compact badge for that reason. It reads as PASS only because of a format rule. Under the review rules, a verdict a lane cannot reach because evidence is missing is a block. The earlier clock-only badge also failed the UX read, so the folder name is the fix that most needs a look. The "Manual verification" text also still says each frame asserted "the clock on a compact shelf", but website/scripts/capture-project-chip-pending.mjs:31 now expects "OtherRepo", so that sentence describes an older run.
    Smallest fix: run capture-project-chip-pending.mjs at this head in dark and light. Swap the two compact images for the new frames and update the Manual verification sentence to describe this run. No code change is needed. The UX review will then run again on the new evidence.

Done well: the turn opener check is now one shared opensRunTurn in groupDisplayItems.ts instead of a second copy, and each review-round fix comes with a test that fails without it.

Optional:

  • docs/system-specs/modules/learn-cron-dashboard.md (section "Project switch during a response") does not yet describe the visible badge, the new project_switch_pending line, or how useStagedProject keeps the start project for each slot. One or two sentences in this PR would cover it.
  • On a wide shelf just above the compact cutoff, the badge is shrink-0 with no truncate, so a long translation (pt, es) could push into the next segment. One frame at about 380px wide in a long locale would show whether it fits, and you can take it in the same capture run.
  • ChatPane.tsx computes and passes projectTurnKey, but ChatPane never renders the project chip, and StagedProject.turnStartProject is never read. You could drop both.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: passed Eligible automated validation passed for the current revision labels Nov 13, 2026
@JLargent42

Copy link
Copy Markdown
Contributor Author

The KiroCrew conductor (largjaco's v2 drive-to-green session) now owns this PR under the 24h orphan rule; the desk session that opened it has been offline since 11-06. I'll rebase onto main, fix CI and answer review here.

@JLargent42

Copy link
Copy Markdown
Contributor Author

@KiroCrewCaptain the evidence block on 28e39da is addressed. No code changed, so the head is the same.

  • Compact ProjectPendingBadge: I re-ran website/scripts/capture-project-chip-pending.mjs at 28e39da in dark and light, on a local Vite page with every /api call stubbed (no gateway, no dashboard token). All 12 frame assertions passed. The compact frames now show what HEAD draws: the clock glyph followed by "OtherRepo" in the accent pill. Both compact images in the description are replaced.
  • Manual verification: The sentence now describes this run at this head. It says the compact badge is the clock plus the visible text "OtherRepo", which matches what the capture script expects on line 31.

Optional notes, not in this round:

  • I haven't added the spec sentence in docs/system-specs/modules/learn-cron-dashboard.md.
  • I haven't taken the ~380px long-locale frame. Seeing whether the badge fits there would need a fixture locale option that the capture page doesn't have yet.
  • I haven't dropped projectTurnKey in ChatPane or the unused StagedProject.turnStartProject. That would be a code change, which would restart every review lane. Each is a small follow-up if you want it.

@JLargent42 JLargent42 self-assigned this Nov 14, 2026
@KiroCrewCaptain
KiroCrewCaptain enabled auto-merge (squash) November 14, 2026 20:25

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This head fixes the earlier change request. The compact frames were re-captured at 28e39da and show the clock followed by "OtherRepo", which matches what ProjectPendingBadge compact draws, and the Manual verification sentence now describes that run. The review checked the full diff and every ChatInput host: the per-slot start project, the run-turn re-key, the hold while sub-agents lock the chip, and the move of opensRunTurn with no logic change. It found no security change and no blocking rule hit. Every check run on this head passed. Done well: each review-round fix ships with a test that goes red without it, and the shared opensRunTurn replaces a private copy.
The design is signed off under the standing maintainer sign-off for changes by team members.
Optional:

  • docs/system-specs/modules/learn-cron-dashboard.md ("Project switch during a response") still says ChatInput snapshots the start project. If this PR merges before #31229, the spec stays stale until that one lands.
  • stagedProjectTurnKey keys on the opener row's ts, and the send echo rewrites it to the server time. Keying on meta.clientTs ?? ts (as useStableMessageKey does) and adding a test for it would remove that risk.
  • ChatPane.tsx computes projectTurnKey but renders no project chip, and StagedProject.turnStartProject has no reader. Both can be dropped in a follow-up.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention labels Nov 14, 2026
@KiroCrewCaptain
KiroCrewCaptain merged commit a4b4468 into main Nov 14, 2026
110 of 126 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the feat/staged-project-pending-badge-20350 branch November 14, 2026 20:26
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show the staged project switch without requiring hover

2 participants