Skip to content

feat: add scheduled light and dark theme switching - #31196

Open
JLargent42 wants to merge 2 commits into
mainfrom
feat/scheduled-light-dark-theme-21097
Open

JLargent42 wants to merge 2 commits into
mainfrom
feat/scheduled-light-dark-theme-21097

Conversation

@JLargent42

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Let users switch the dashboard between light and dark automatically, at local sunrise and sunset or at fixed times, while still changing the theme by hand.

Today the Mode picker offers Auto (follow the OS), Light and Dark. There is no way to have the dashboard turn light during the day and dark at night on its own schedule.

Why it matters

Light theme is easier to read beside a bright window during the day; dark theme is easier at night. Without a schedule the user flips the mode by hand twice a day, or has to tie it to an OS setting they may not want changed.

Not a goal

  • Syncing the schedule across devices: it is bound to the device's clock, time zone and location, so it is stored on the device.
  • Detecting the location automatically. No geolocation prompt and no lookup service; the user types an approximate latitude and longitude.
  • Changing the existing Auto / Light / Dark options or the server-side theme_mode values.
  • A schedule in the Electron main process or the system tray.

What changed (motivation → approach → change)

Goal → reuse the existing theme surface and setTheme rather than add a fourth mode → a small device-local schedule plus a driver.

  • website/src/utils/themeSchedule.ts (pure): the schedule type and parser, the sunrise equation (sunTimes, refraction-corrected, polar day/night handled), and the boundary logic (scheduledModeAt, dueScheduledMode). Days and clock times are built with the local Date constructor, so everything follows the device time zone, DST included. With the sunrise/sunset method but no location, the fixed times apply.
  • website/src/hooks/useThemeSchedule.ts: a useSyncExternalStore store over localStorage["mc-theme-schedule"] (cross-tab via storage). Editing when the schedule switches clears appliedAt so it applies at once.
  • website/src/components/ThemeScheduleDriver.tsx (mounted beside ThemeExperienceLayer in main.tsx): applies the scheduled mode through the same setTheme the Mode picker uses, once per boundary, recording it in appliedAt. A manual mode change therefore holds until the next scheduled switch. Re-checks at the next boundary (at least hourly) and on tab visibility.
  • website/src/pages/settings/ThemeScheduleSettings.tsx, mounted under the Mode picker in DisplayPanel.tsx: the toggle (shows the device time zone), method (Sunrise and sunset / Custom times), latitude/longitude with range validation and today's computed times, or the two time fields. SettingsInput accepts type="time".
  • Strings in all 12 shipped catalogs (+ regenerated en-XA); settings registry and UI index regenerated (settingsExtract.ts maps the new panel file); docs/system-specs/modules/themes.md documents it.

Why not a fourth schedule mode value: it would need a backend validator change, an Electron themeSource mapping, and would leak a device-local schedule into the workspace-wide theme_mode.

Backwards compatibility

Compatible: purely additive; with the schedule off (the default) nothing runs and the existing modes behave as before.

Removes nothing: no key, value, route or capability is removed or tightened.

Tests

  • website/src/utils/themeSchedule.test.ts: sunrise/sunset within minutes of published times (Seattle June solstice, London December solstice), polar day/night, fixed times, an inverted (night-shift) schedule, sun-method fallback without a location, once-per-boundary application with a manual change held until the next boundary, parser defaults.
  • website/src/components/ThemeScheduleDriver.test.tsx: off does nothing; on applies at once and switches at the next boundary; a manual pick holds until the next boundary.
  • website/src/pages/settings/ThemeScheduleSettings.test.tsx: toggling writes the schedule; fixed times are stored; a typed location computes sun times with no fetch and no geolocation call; an out-of-range latitude is not stored.

Proof: not provable -- frontend test (prove.py runs Python only); all three files import modules this PR adds, so they fail without it.

Rebased on 4f7b1ee782; the ui-index.generated.json conflict was resolved by taking main's file and regenerating it with npm run gen:ui (settings registry re-run with npm run gen:settings, no change). Local gate (scripts/local-gate.py plan, run at 2 workers): frontend related 519 files / 14252 tests pass; typecheck, eslint on changed files and gen-ui-index --check pass; backend related batch 1 passes and batch 2 passes apart from the host reds below; black/subprocess-encoding, comment-history, brand-name and file-line-cap pass. Host reds outside this diff, each reproduced with the same failures on the merge-base 4f7b1ee782 in a temporary worktree: file_explorer/tests/test_server.py, test_design_tweak_backend.py, test_design_tweak_devproc.py (/local/home 403s), test_docker_entrypoint.py, test_crew_image_build_plan.py (libffi), test_auto_improvement_members.py, test_native_skill_projection.py (essential-source sandbox), test_dashboard_gallery_approvals.py (platform composition), test_kas_bundle.py (no network), test_mcp_slim_entry.py, test_living_ui_harness.py, and one test_find_ui_auto.py case (continue with github).

Manual verification

Rendered the real ThemeScheduleSettings rows in light and dark through a throwaway capture entry (vitest pins TZ=UTC, so times read in UTC): off, sunrise/sunset without a location, with a location (today's times shown), and custom times. Not yet exercised against a running gateway across a real boundary; the driver test covers the boundary with fake timers.

Screenshots / video

Schedule off, dark
Sunrise and sunset, no location, dark
Sunrise and sunset with a location, dark
Sunrise and sunset with a location, light
Custom times, light

Related Issues

Closes #21097

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@JLargent42
JLargent42 requested review from a team and KiroCrewCaptain as code owners November 6, 2026 07:24
@JLargent42
JLargent42 requested a review from Zedmor November 6, 2026 07:24
@github-actions github-actions Bot added readiness: checking Automated validation is still running merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 6, 2026
@JLargent42
JLargent42 force-pushed the feat/scheduled-light-dark-theme-21097 branch from dcae718 to 2bebec7 Compare November 12, 2026 20:30
@JLargent42

Copy link
Copy Markdown
Contributor Author

Note: #34653 also targets #21097 with a wider change (backend config + Electron). This PR is the smaller dashboard-only version, opened first; happy to close it if the maintainers prefer #34653.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 30ccd0daaf90eb552bae3c8b1cbce4530524611a — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

The schedule is off by default, so nobody gets it without choosing it. It is not product shape, and nothing in the repository already does this.

Notes

  • Item 6 (undeclared): the description says the driver "applies the scheduled mode through the same setTheme the Mode picker uses… recording it in appliedAt". The diff switches through the new applyLocalTheme and records pickedAt. That method has one consumer (ThemeScheduleDriver.tsx), and the Not-a-goal "stored on the device" supports it.

What this change ships

Inventory (8 items) — 7 justified

Intent: let the dashboard switch itself between light and dark at sunrise/sunset or at set times, while a pick by hand still works. This is an ADDITION.

  1. A new "Switch light and dark on a schedule" toggle under Mode, default off — justified
  2. A choice between sunrise/sunset (typed latitude/longitude, today's times shown) and two custom times — justified
  3. The dashboard changes mode on its own at each boundary, re-checking hourly and when the tab becomes visible — justified
  4. A mode picked by hand holds until the next scheduled switch — justified
  5. The schedule is kept on this device only (mc-theme-schedule in localStorage) and is shared across tabs — justified
  6. Scheduled switches never write the workspace theme_mode (new applyLocalTheme) — undeclared
  7. The settings input accepts type="time" — justified
  8. The new rows appear in the settings search and the UI index, with strings in all 12 catalogs — justified

[FIRST-PRINCIPLES-REVIEWED] 30ccd0d

Description read

[DESCRIPTION-READ] bd427893364eccc0cf514ff2107bdf13907e4518720350757a401520be54c706

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 12, 2026
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 30ccd0daaf90eb552bae3c8b1cbce4530524611a — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks: the reader read the toggle and the method choice correctly, and the place is right. The screenshots show the older copy, though: the toggle reads "Switch on a schedule" and the time fields "Light from".

Notes

  • With "Sunrise and sunset" selected and no location, the "Light theme from / Dark theme from" fields are visible, and the blind reader asked "which choice is actually in effect". Put the fallback sentence directly above those fields, or rename them "Custom times (used until a location is set)".
  • The Latitude and Longitude fields give no way to find your coordinates ("I wouldn't know what to type"). Add an example to theme_schedule_location_hint, e.g. "For example, 47.6 and -122.3 for Seattle."
  • Take the screenshots again in a non-UTC time zone. The current shot reads "Today: light from 2:57 PM, dark from 12:47 AM" and the reader took it as broken. This also captures the renamed toggle and time-field labels, which no screenshot shows yet.

[UX-REVIEWED] 30ccd0d

Description read

[DESCRIPTION-READ] 42af589f6310fd71903cb00d2a2190e2a2eb8615362f040c445c32eea57bd0c6

That sha256 names everything this verdict read: the PR description, plus the 8 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 30ccd0daaf90eb552bae3c8b1cbce4530524611a — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the schedule stays on the device, and switches go through the existing theme surface without a fourth mode value.

Notes

  • The description no longer matches the code. It says the driver "applies the scheduled mode through the same setTheme the Mode picker uses… recording it in appliedAt", but the driver calls applyLocalTheme and records hand picks in pickedAt. Correct the "What changed" bullet; the frozen Goal and Why sections don't need to change.
  • The useTheme.tsx change (splitting out applyLocalMode so that setMode_ alone saves to the workspace) carries the key design decision: a scheduled switch must never write theme_mode. Name it in the description.

[DESIGN-REVIEWED] 30ccd0d

Description read

[DESCRIPTION-READ] b32554db2c890d4c6a693b07e47950aacdaea3fbb835025ee044b0fd7bf1cdae

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — 🔴 changes requested (blocking)

Reviewed 30ccd0daaf90eb552bae3c8b1cbce4530524611a — this comment is updated in place on each push.

Blocking: after a reload, the scheduled mode is shown but the mc-theme cache keeps the workspace mode. Changing the colour theme then flips the tab back to the workspace mode and counts that as a hand pick, so the schedule stops until its next boundary.

BLOCKING — website/src/components/ThemeScheduleDriver.tsx:607

        applyLocalTheme(due.mode)

Trigger: The schedule is on and the period is dark. The workspace mode is light. mc-theme holds dark from an earlier scheduled switch, so ThemeProvider starts with mode=dark (useTheme.tsx:875). On reload, the boot read sets mode=light, themeBootReady and bootApplied{modeChanged:true} while rendering, all in one commit. React runs passive effects child-first, so the driver (a child of ThemeProvider in main.tsx:210-213) runs first and applyLocalTheme('dark') writes mc-theme=dark. Then the parent's bootApplied effect runs safeSetItem('mc-theme', data.mode) (useTheme.tsx:1222), which writes light back.
Outcome: The tab shows dark while mc-theme holds light. The next reload paints light first and then flips to dark. Picking a colour theme makes setColorTheme read mc-theme (light) and broadcast it (useTheme.tsx:1411-1412); the SYNC_EVENT handler calls setMode('light'); the driver sees preference !== shownMode, records pickedAt, and leaves the mode on light until the next boundary, though the user never picked a mode.
Anchor: defect
Fix: Make the driver's first apply land after ThemeProvider's boot effect. Either defer it past the commit (for example, schedule the first tick with setTimeout(tick, 0)), or have the bootApplied effect skip the mc-theme write when the current mode no longer equals data.mode.

[BLOCK-MERGE] 30ccd0d
[OPUS-REVIEWED] 30ccd0d

Verdict parsed from the review's SHA-scoped output markers for commit 30ccd0daaf90eb552bae3c8b1cbce4530524611a.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 30ccd0daaf90eb552bae3c8b1cbce4530524611a false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — 🔴 changes requested (blocking)

GPT 6.1 found at least one blocking issue that must be resolved before merging 30ccd0daaf90eb552bae3c8b1cbce4530524611a. Adjudication upheld 1 of 2 blocking finding(s); those must be resolved before merging.

This comment is updated in place on each push.

BLOCKING -- website/src/components/ThemeScheduleDriver.tsx:62 -- Boot reconciliation overwrites the scheduled mode cache

applyLocalTheme(due.mode)
Trigger: Reload at 20:00 with a 07:00/19:00 schedule, cached dark, workspace system, and a light OS theme. Boot sets themeBootReady during rendering; the driver’s child effect writes dark before the provider’s boot effect overwrites the cache with system. Selecting a color theme then broadcasts that cached mode.
Outcome: The dashboard switches to light, and the driver records a false manual override that suppresses scheduled dark mode until the next boundary.
Anchor: defect
Fix: Complete boot’s cache reconciliation before allowing the schedule driver to apply its mode.
Sites: website/src/hooks/useTheme.tsx:1222 (competing writer); website/src/hooks/useTheme.tsx:875, website/src/hooks/useTheme.tsx:1350, website/src/hooks/useTheme.tsx:1411, website/src/apps/mochi/src/shared/themes.ts:95, website/src/apps/crew-companion/dashboardTheme.ts:166 (cache readers).

BLOCKING -- website/src/components/ThemeScheduleDriver.tsx:58 -- Schedule edits retain a failed-write manual override

const pickedAt = Math.max(current.pickedAt ?? -Infinity, unsavedPickAt.current ?? -Infinity)
Trigger: With storage near quota and no reclaimable caches, a noon manual dark pick cannot store the larger pickedAt value, so the driver retains unsavedPickAt. Changing lightAt from 07:00 to 08:00 succeeds without increasing storage size; the store clears pickedAt, but the driver still uses its retained timestamp.
Outcome: The successfully edited schedule does not apply its current light mode; the obsolete override suppresses it until the next boundary.
Anchor: defect
Fix: Clear the in-memory override when timing fields successfully change, including disabling and re-enabling the schedule.
Sites: website/src/hooks/useThemeSchedule.ts:67 and website/src/hooks/useThemeSchedule.ts:75 (all timing-field updates); website/src/components/ThemeScheduleDriver.tsx:44 (disabling also retains the override).

[BLOCK-MERGE] 30ccd0d
[GPT-REVIEWED] 30ccd0d

Adjudication (Opus 5.5) — is blocking on each finding proportionate?

F1 — Rung: MEDIUM. Any reload where the scheduled mode differs from the workspace mode (the normal case while a schedule is on) sets themeBootReady during render (useTheme.tsx:1215). The driver's child effect then writes the scheduled mode (ThemeScheduleDriver.tsx:62), and the provider's boot effect writes over it with the workspace mode (useTheme.tsx:1222).
After that, the wrong cached mode is read by the colour-pick broadcast (useTheme.tsx:1411), the next cold load (useTheme.tsx:875) and the app theme readers. The scheduled mode is wrong on a common path and it can record a false manual pick.
Real fix: order the driver's write after boot's cache write, which is one ordering change in two modules. That cost is moderate and the harm justifies it.

F2 — Rung: LOW. It needs every one of these: the hand-pick write is refused even after every reclaim tier (safeStorage.ts:175, ThemeScheduleDriver.tsx:50), and a later timing edit then succeeds (useThemeSchedule.ts:74-75). The tab-local unsavedPickAt still wins at ThemeScheduleDriver.tsx:58 and suppresses dueScheduledMode (themeSchedule.ts:226).
Recovery: a reload drops the ref (ThemeScheduleDriver.tsx:41), and it clears itself at the next boundary (themeSchedule.ts:226). The problem is visible and limited to one tab.
Real fix: the driver has to remember the previous timing fields and compare them, which is new state kept only for the storage-full path. That permanent cost is larger than a rare, visible degradation that corrects itself.

[ADJUDICATION] 30ccd0daaf90eb552bae3c8b1cbce4530524611a total=2 uphold=1 downgrade=1
UPHOLD F1 website/src/components/ThemeScheduleDriver.tsx:62 reason=harm-warrants-remedy
DOWNGRADE F2 website/src/components/ThemeScheduleDriver.tsx:58 reason=disproportionate-remedy
[GPT-ADJUDICATED] 30ccd0daaf90eb552bae3c8b1cbce4530524611a

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 30ccd0daaf90eb552bae3c8b1cbce4530524611a false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 12, 2026
@JLargent42

Copy link
Copy Markdown
Contributor Author

4db6c86 addresses the review blocks on 2bebec7: (Opus) a polar day/night boundary now starts after the previous day's last sun event and same-mode boundaries merge, so polar day stays light and doesn't re-switch at midnight; (GPT F1) a tab follows a boundary another tab records; (GPT F2) the driver waits for themeBootReady; (GPT F3) a refused storage write leaves the snapshot unchanged (no render loop) and the boundary is remembered in memory. Each has a test that fails on 2bebec7. Also adds the feature-map row for the Source Gates feature-map check.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 12, 2026
@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: A person should decide

Why: the decider raised 2 possible problems and estimates a 72% chance that this change introduces a defect; a person should check them.

The schedule logic, the store and the settings UI look well built and are tested, and the earlier-head polar-day and sibling-tab bugs appear fixed. But the driver switches modes through the Mode picker's setTheme, which also PUTs the workspace-wide theme_mode (persistTheme({ mode })). So every sunrise and sunset is written to the server, and other devices and browsers adopt it at their next boot. That contradicts the PR's own reason for this design (avoiding leaking a device-local schedule into theme_mode) and its 'backend: none' feature-map entry. It also changes behaviour that works on main for devices with no schedule. Request a local-only apply path plus a test that a scheduled switch makes no workspace write.

Things to check (possible problems the decider raised; at this confidence many turn out to be fine):

  • Every scheduled boundary writes the light or dark mode to the server's workspace-wide theme_mode, which is exactly the leak the PR's design says it avoids. Another tab that sees the boundary record calls setTheme again and writes it again. The PR's stated reason for this design is therefore not (website/src/components/ThemeScheduleDriver.tsx, medium)
  • Shared state on a sibling path: a device or browser with no schedule (for example left on Auto) now has its mode overwritten at its next load by whatever light/dark the scheduled device last wrote at sunrise or sunset. On main, theme_mode changes only when someone picks a mode by hand. The reverse (website/src/hooks/useTheme.tsx, medium)

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 4db6c86639 · 1332 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@JLargent42
JLargent42 force-pushed the feat/scheduled-light-dark-theme-21097 branch from 4db6c86 to 8c2f559 Compare November 12, 2026 23:35
@JLargent42

Copy link
Copy Markdown
Contributor Author

Review follow-up for 4db6c86 → 8c2f559:

  • UX Review BLOCK (toggle doesn't say what it switches): fixed in 8c2f559. Label is now "Switch light and dark on a schedule"; the always-visible description reads "Switches between the light and dark themes automatically, using this device's time zone (…)"; the ⓘ tooltip keeps only the manual-override detail. Done in all 12 shipped catalogs + regenerated en-XA, settings registry and UI index. New test says in the always-visible text that it switches the light and dark themes in website/src/pages/settings/ThemeScheduleSettings.test.tsx fails on the old strings.
  • UX note (light/dark read as daylight): fixed in 8c2f559: "Today: light theme from …, dark theme from …", "Light theme from" / "Dark theme from", and the same-times error now says "theme".
  • UX note (fixed-time fields shown under Sunrise and sunset): not changed; the visible line above them already says "Until then, the custom times below apply."
  • UX evidence gaps (error/polar states, TZ=UTC capture, stray 35351 shots): description evidence needs a recapture; not a code change.
  • Analyze (python): infra, not an alert. The analysis finished; the SARIF upload failed with "API rate limit exceeded for installation". This PR touches no Python. Not re-run separately, because the push starts a fresh CodeQL run on the new head.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 13, 2026
@JLargent42
JLargent42 force-pushed the feat/scheduled-light-dark-theme-21097 branch from 8c2f559 to 412cc94 Compare November 13, 2026 00:55
@JLargent42

Copy link
Copy Markdown
Contributor Author

412cc94 addresses the blocks on 8c2f559:

  • Opus 5.5: scheduled switch written to the workspace mode. Fixed in 412cc94. The driver now switches through a new applyLocalTheme in useTheme. It updates the tab and the mc-theme cache and never sends PUT /api/config/theme. A pick by hand still goes through setTheme and the workspace. The driver records the pick's time in the device-local schedule (pickedAt, which replaces appliedAt), so the pick holds until the next boundary. Nothing the schedule shows is saved, so the driver re-asserts the period's mode when it starts watching after themeBootReady. The themes.md spec and the feature-map row now say this. Tests: ThemeScheduleDriver.test.tsx ("never saves a scheduled switch as the workspace mode", "puts the scheduled mode back after a reload adopts the workspace mode") and useTheme.test.tsx ("saves a picked mode to the workspace, but not one shown by applyLocalTheme").
  • GPT 6.1 F1: a boundary recorded during boot is missed. Fixed by the same change. Cross-tab state is gone (seenAppliedAt), and every tab applies the current period once its own boot read lands. Test: "follows a boundary another tab reached while this tab was booting".
  • GPT 6.1 F2: a rejected schedule save fails silently. Fixed. useThemeSchedule.update now returns whether the write was stored, and the panel shows an ErrorNotice (storage full or blocked). A latitude or longitude the browser refused stays in its field when you leave it. While such a draft is held, the hand-off is off, with a No hand-off comment naming the draft; otherwise askAgent is on. Tests: two new cases in ThemeScheduleSettings.test.tsx.
  • Frontend Tests (1): frStyle.test.ts (U+202F before :). Fixed: fr.json theme_schedule_today now has Aujourd'hui :. This was in our diff, not a main red.
  • UX Review: screenshots of the current copy. Not a code change. The PR description needs fresh screenshots of this head; the UI labels did not change in this push. I updated the stale feature-map label (Switch light and dark on a schedule). The "Until a location is set:" label suggestion was a note, not a blocker, so I left it out of this round.
  • GPT 6.1 / UX / Analyze runs that were rate-limited were re-run by the parent and get no code change from this round.

@JLargent42
JLargent42 force-pushed the feat/scheduled-light-dark-theme-21097 branch from 412cc94 to 2420d11 Compare November 13, 2026 01:00
@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 13, 2026
Jacob Largent added 2 commits November 13, 2026 01:41
Settings > Display > Theme gains a 'Switch on a schedule' toggle under the
Mode picker. It switches light/dark at local sunrise and sunset, computed
on the device from a typed coarse latitude/longitude (no network call, no
geolocation), or at fixed light and dark times. Times follow the device
time zone. The schedule applies once per boundary through the existing
setTheme, so a mode picked by hand holds until the next switch.

Closes #21097
@JLargent42
JLargent42 force-pushed the feat/scheduled-light-dark-theme-21097 branch from 2420d11 to 30ccd0d Compare November 13, 2026 01:46
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 13, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: action required A blocking check or review needs attention

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add scheduled light and dark themes

2 participants