Skip to content

fix(dashboard): alias slots share one compaction threshold - #31284

Merged
bolichen97 merged 1 commit into
mainfrom
fix/7497-alias-binding-settings
Nov 7, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
fix/7497-alias-binding-settings

Conversation

@bolichen97

@bolichen97 bolichen97 commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A compaction threshold set on one tab of a shared conversation is the threshold every tab on that conversation holds and saves, with no hand-written copy between them.

Two live tabs can point at one transcript (a channel thread opened from the dashboard, for example). Each tab held its own copy of the session's compaction threshold, so a tab still holding the old number could write it back over a threshold another tab had just saved. The threshold route patched this by copying each commit onto every tab on the transcript by hand, and then running a second save to put the durable record back in order after a stale tab's flush. That copy is one of the per-field point patches #7497 names as the root cause.

Why it matters

Each per-field copy is its own patch with its own rollback loops, and a path that misses one lets a stale tab undo a threshold the user was told was saved. Holding the value once removes that failure for this field and makes the route one save instead of two.

Not a goal

What changed (motivation → approach → change)

Tabs on one transcript already share one TranscriptBinding object for the project directory (#25899, #26060), and every join site joins it. The compaction threshold now lives in that same object, read and written through a _ChatSlot.autocompact_pct property. A write through any tab is the group's write, and every tab's save reads that one value under the transcript lock.

With one value there is nothing to copy, so the threshold route's alias copy loop, its two rollback loops and its second confirm save are deleted, leaving one save.

A shared value must never hold a threshold that may not be saved, because every tab, and a tab restored beside them, reads it. So the route now saves the new threshold before any tab holds it, the way the turn time limit route already does: the save writes the requested value, and it reaches the tabs only once that write has landed. From the moment it lands, every other tab's save of that conversation writes it too, and the route then hands it to the tabs on the server's event loop, where every tab move runs, so a tab moving to another conversation at that moment can never carry it there. That holds when the tab is moved during the save, and for a conversation with no stored line yet, whose line another tab's save then creates. A failed or refused request leaves every tab, and the session's live threshold, as they were, so there is no rollback left to get wrong. A tab alone on its transcript sees the same answers as before. A save that waits for the lock while its tab moves to another conversation still writes the threshold of the conversation it saves, not the one the tab just joined.

The shared object also records whether anything has set its threshold, a clear included, the way it already records a directory choice. A tab joining a live peer keeps the peer's threshold, and only a peer nothing has set (a workflow result tab that never read its stored settings) takes the joining tab's. A stored threshold read back from disk, by a restore or a surfaced channel conversation, never replaces a threshold or a clear a live tab saved after it was read.

Backwards compatibility

Compatible: the metadata line keeps the same autocompact_pct key and values, and a tab alone on its transcript gets the same responses and stored values as before.

Removes nothing: slot.autocompact_pct still reads and writes for every caller (now through a property); only the route's alias copy and its second save are gone, because the shared value makes them redundant.

Tests

  • test_alias_slot_shared_project.py: a real save from a tab that joined after its peer set a threshold keeps the stored threshold; the route's save writes its value on the merge and the full-save path while the tabs still hold the old one, and runs both commit hooks; a stored threshold read by a restore or a surfaced channel conversation never replaces a live tab's threshold or clear, nor reaches the session's live threshold; a restored tab gives an unseeded live tab its threshold and keeps a live tab's own; a tab leaving the group keeps its threshold; the edit-resend and rewind copies never write autocompact_pct.
  • test_session_autocompact_override.py: the alias tests join their tabs the way production does; the route makes exactly one save and hands it the value to write; while the save runs every tab holds the old value, and only a write that landed reaches them and the live threshold, including one whose save raised after landing; a refused request leaves the group alone; a rebind during the save, refused or landed on either save path, set or clear, leaves the old transcript at what its line holds and never carries the request's value to the new one; a tab's save queued behind a real merge writes the committed value before the route hands it to the tabs, for a tab rebound mid-save and for a transcript with no line yet; the commit hook changes no tab's value and leaves nothing behind once the request ends, and a tab moved right after the commit leaves the value on the conversation it landed on; a tab's queued save, merge or full save, writes the threshold of the conversation it saves when the tab leaves it or finishes joining another while the save waits for the lock.
  • test_dashboard_source_link_unlink_hydration.py: the bind-site scan also recognises a site that restores the threshold through the new seed helper.
  • test_chat_persistence_composition_contract.py: the two save signatures carry the new staged argument and the transcript commit hook.
  • test_state_parts_facade.py: autocompact_pct is a property of the slot, no longer an instance field.

Determinism: the changed tests ran 20 times at -n0, 10 times at -n 4 --dist loadgroup --max-worker-restart=2 beside test_transcript_binding_join_sites.py and test_slot_metadata_codec.py, and once in a shuffled order (seed 31284), all green.

Proof: PROVEN test/test_alias_slot_shared_project.py::test_a_stale_alias_save_keeps_the_peers_threshold, test/test_alias_slot_shared_project.py::test_a_stored_threshold_never_replaces_a_live_aliases[surface-set], test/test_alias_slot_shared_project.py::test_a_stored_threshold_never_replaces_a_live_aliases[surface-cleared], test/test_alias_slot_shared_project.py::test_a_stored_threshold_never_replaces_a_live_aliases[restore-set], test/test_alias_slot_shared_project.py::test_a_stored_threshold_never_replaces_a_live_aliases[restore-cleared] (head b667c510a53d)

Manual verification

N/A — unit coverage sufficient: the change is the in-memory home of one slot field and the order of one route's save, and the tests drive real saves through the transcript lock and the route end to end.

Screenshots / video

N/A — no user-visible frontend surface is touched.

Related Issues

Part of #7497

Sibling sweep

Swept: git grep -nE "slot_history_key((other|peer|s)) ?== " -- src/kiro_crew/dashboard
Sibling: src/kiro_crew/dashboard/chat_api/slot_settings.py:206 -- not affected -- finds one live tab on the committed transcript and writes the binding they all share once, on the event loop, no per-tab copy
Sibling: src/kiro_crew/dashboard/chat_api/slot_settings.py:445 -- tracked in #7497
Sibling: src/kiro_crew/dashboard/session_directive_apply_slot.py:531 -- tracked in #7497
Sibling: src/kiro_crew/dashboard/chat_api/source_links.py:599 -- not affected -- dismissed links are a grow-only union on save, so a stale tab cannot shrink them

Pattern harvest

Rule candidate: review-prompt
Pattern: a per-transcript slot field copied onto alias slots by a loop over state._slots matching slot_history_key instead of living in the shared TranscriptBinding

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners November 6, 2026 08:33
@bolichen97
bolichen97 requested a review from Zedmor November 6, 2026 08:33
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 6, 2026
@bolichen97
bolichen97 enabled auto-merge (squash) November 6, 2026 08:43
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 700ddef9085c7c5f601bf9c940591f0a085d7a77 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 700ddef9085c7c5f601bf9c940591f0a085d7a77 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks. Keeping the threshold in the shared TranscriptBinding follows the existing project pattern and removes the per-tab copy at its root.

Notes

  • The new module-global autocompact_commits is cleaned up only on the route's publish line, not in a finally. If the request is cancelled after _record_commit runs but before autocompact_commits.pop(...), the entry stays. Every later save of that transcript then writes the staged value while the tabs and the live threshold keep the old one, until the next threshold request. Putting the pop in a finally closes this.

[DESIGN-REVIEWED] 700ddef

Description read

[DESCRIPTION-READ] 971a3e5716fdcc04b51c192f5ef01fd0f3ee241b3cf7bb0e4b78956a67632765

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 700ddef9085c7c5f601bf9c940591f0a085d7a77 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

The route now relies on a process-global commit table and a second commit hook that only this route uses. Each has a named race behind it, so neither blocks.

Notes

  • Item 5 — one consumer, generalized: after_commit_on_transcript is a second save hook beside after_commit_under_lock, and slot_settings.py is its only caller (grepped after_commit_on_transcript=: 1 non-test site). Subtraction: once the remaining Single-source transcript-shared slot metadata (alias slots hold divergent per-slot copies) #7497 fields move into the binding, fold it into after_commit_under_lock with the rebound-slot skip as a flag on the existing hook.
  • Item 6 — oversized: autocompact_commits is a module-global dict that autocompact_fold reads, and it exists only because publishing moved from the hook to the event loop. The turn-time-limit twin (slot_settings.py:440) publishes inside the hook and has no such table. Subtraction: delete the table if that in-hook publish is shown to be race-free. Clears when: the mechanism is removed, or a human amends the Goal.

What this change ships

Inventory (8 items) — 6 justified

Intent: one compaction threshold shared by every tab on a conversation, so a stale tab cannot overwrite a saved one. This is a FIX (part of #7497).

  1. All tabs on one conversation hold a single threshold (property on TranscriptBinding) — justified
  2. The route's per-tab copy loop, both rollback loops and the second confirm save are deleted — justified
  3. The route saves the new threshold before any tab or the live gate sees it — justified
  4. A save that raises after its write landed now returns 200 and publishes — justified
  5. New after_commit_on_transcript save hook — one consumer, generalized
  6. New process-global autocompact_commits table read by every save — oversized; twin route needs none
  7. A threshold read from disk on restore or surfacing never replaces a live tab's (seed_autocompact_from_disk, autocompact_set) — justified
  8. routing_snapshot also returns the binding the save routed with — justified

[FIRST-PRINCIPLES-REVIEWED] 700ddef

Description read

[DESCRIPTION-READ] d6e1a16edfaf38177cbf227ff9a65f966de43989b4e40600b0a8657de9926f8a

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 700ddef9085c7c5f601bf9c940591f0a085d7a77 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 700ddef

Verdict parsed from the review's SHA-scoped output markers for commit 700ddef9085c7c5f601bf9c940591f0a085d7a77.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 700ddef9085c7c5f601bf9c940591f0a085d7a77 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 700ddef9085c7c5f601bf9c940591f0a085d7a77 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 700ddef

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 700ddef9085c7c5f601bf9c940591f0a085d7a77 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 6, 2026
@bolichen97
bolichen97 force-pushed the fix/7497-alias-binding-settings branch from cb973a7 to b70d0ee Compare November 7, 2026 03:35
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 7, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Identity rollback of a None clear writes the old threshold onto another transcript's alias group span=a64d0e7ce20e

fixed in b70d0ee: the rollback moved to rollback_autocompact (transcript_binding.py) and never puts the prior value on a binding the slot only adopted in a rebind while other live tabs hold it.
An adopted group is touched only to undo a join fill of this request's non-None value, back to the None the fill replaced, so a clear cannot match a peer that follows its default.
A private copy the rebind gave the slot still rolls back to the prior value, as before.
Pinned by test_a_request_rebound_onto_a_peer_on_its_default_leaves_that_default (clear and set, refused and committed).
[operator: bolichen97]

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Clearing a threshold can roll back an unrelated conversation span=324ec7934888

fixed in b70d0ee: rollback_autocompact (transcript_binding.py) no longer undoes by identity on a binding the slot adopted in a rebind; a group other live tabs hold keeps its own value.
The only change it makes there is undoing a join fill of this request's non-None value, which is unique to the request, back to the None it replaced.
Pinned by test_a_request_rebound_onto_a_peer_on_its_default_leaves_that_default (clear and set, refused and committed).
[operator: bolichen97]

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Rollback leaves a sibling’s provisional write durable span=324ec7934888

fixed in b70d0ee: when the write did not land (refused or raised), rollback_autocompact marks every other slot holding the written binding dirty, so an alias that flushed the provisional value saves the restored one.
When it undoes a join fill on a group the slot joined, it marks that group's tabs dirty too. The requester's own dirty mark on the exception arm is unchanged.
Pinned by the refused cases of test_a_rebind_during_the_save_leaves_each_transcript_its_own_value and test_a_refused_commit_rolls_the_group_back (b._dirty).
[operator: bolichen97]

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Channel hydration overwrites an acknowledged alias threshold span=2f3a0f4dbfec

fixed in b70d0ee: surface_channel_session seeds the stored threshold only when the binding the new slot joined holds none, the same rule bind_transcript applies on restore, so a live alias's saved value is never replaced by the older snapshot and the session override is not re-seeded from it.
Pinned by test_surfacing_a_channel_alias_keeps_the_live_peers_threshold.
Not changed here: an explicit clear held live is still indistinguishable from an unseeded None, so a stale snapshot can fill it; the restore path carries the same rule.
[operator: bolichen97]

@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in src/kiro_crew/dashboard/state_parts/chat_slot.py, src/kiro_crew/dashboard/state_parts/slot_session.py, test/test_state_parts_facade.py since this head went green (f02c887 -> e6524c8); CI re-running.
[operator: bolichen97]

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 7, 2026
@bolichen97
bolichen97 force-pushed the fix/7497-alias-binding-settings branch from b70d0ee to 1af4570 Compare November 7, 2026 06:23
@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Hydration can overwrite an acknowledged threshold span=61ea77cbdfb3

fixed in 1af4570: TranscriptBinding.autocompact_set records that anything wrote the threshold, a clear included (set by the _ChatSlot.autocompact_pct setter), the way assigned records a directory choice.
Both disk readers, surface_channel_session and the codec's _read_autocompact_pct, now go through seed_autocompact_from_disk, which skips the stored value whenever the slot shares a binding with a live peer whose threshold was written. That holds whether the slot joined before the read (construction with the channel link) or after.
bind_transcript fills a peer only when nothing wrote the peer's threshold, so an acknowledged clear (None) is no longer read as "never set".
The session's live gate is pushed only the slot's value after the seed, so a stale line never reaches it.
Pinned by test_a_stored_threshold_never_replaces_a_live_aliases[surface|restore × set|cleared] (asserts the live value and that 40 never reaches set_autocompact_pct).
[operator: bolichen97]

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Rollback leaves a rejected threshold in the session override map span=3eb32f58bc96

removed in 1af4570: the route no longer writes a provisional value into the shared binding, so there is no rollback. It persists before it publishes, as the turn time limit route does.
The save writes the request's value staged (autocompact_override -> SaveFolds.autocompact_pct) while the binding keeps the committed one; the commit hook publishes it under the transcript lock once the write lands.
A restore that joins during the persist therefore reads and seeds only the committed value, and a failed or refused save leaves the binding and the session override map untouched. rollback_autocompact is deleted.
Pinned by test_an_alias_holds_the_committed_value_while_the_save_runs[committed|failed|failed-after-commit] and test_a_staged_threshold_lands_before_any_alias_holds_it[merge|full-save].
[operator: bolichen97]

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 7, 2026
@bolichen97
bolichen97 force-pushed the fix/7497-alias-binding-settings branch from 1af4570 to a67eadb Compare November 7, 2026 09:38
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 7, 2026
@bolichen97
bolichen97 force-pushed the fix/7497-alias-binding-settings branch from a67eadb to 76a3847 Compare November 7, 2026 12:12
@bolichen97

Copy link
Copy Markdown
Contributor Author
  • A queued save persists the replacement transcript's threshold span=579d6ade8a05
    self-added: yes
    mechanism: the save reads the slot's binding with its routing and, under the target transcript's lock, writes that binding's threshold when the slot has moved

fixed in 76a3847: routing_snapshot also returns the slot's binding, read inside its confirm loop, and autocompact_fold picks the threshold under the target transcript's lock for both the empty-window merge and the full save.
The endpoint's staged value still wins. Otherwise a slot still on the target writes its live binding, and a slot that moved writes the binding read with its routing, so another transcript's threshold never lands on this one.
The class's other arm, a save routed after the key moved but before the join, reads the live binding under the lock, so it writes the group's value, not the tab's old one.
Pinned by test_a_queued_save_writes_its_own_transcripts_threshold[moved-away|joined-in-gap x merge|full-save], each rebinding inside the real lock acquire.
[operator: bolichen97]

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 7, 2026
@bolichen97
bolichen97 force-pushed the fix/7497-alias-binding-settings branch from 76a3847 to 11359f4 Compare November 7, 2026 15:43
@bolichen97

Copy link
Copy Markdown
Contributor Author
  • A concurrent rebind redirects publication into another transcript span=324ec7934888
    self-added: yes
    mechanism: the commit hook only records the committed value for the transcript's saves; the route publishes it to the tabs on the event loop
    resolution: removed -- the save's worker no longer writes any binding, so the publish that raced event-loop rebinds now runs on the loop

fixed in 11359f4: the commit hook, which runs in the save's worker, no longer writes a binding. It records (pct,) in autocompact_commits for the committed transcript, and autocompact_fold writes that value for every save of it, under its lock, until the route publishes.
The route publishes after the save returns, on the event loop where _bind_cron_slot and every other rebind run, with no await between reading a tab's key and writing its binding, then drops the record.
The class is any worker-side write into a binding that loop code checks and writes: a rebind, the bind_transcript joiner fill and seed_autocompact_from_disk all now serialize with the publish.
Pinned by test_the_commit_hook_writes_no_binding (the hook changes no binding, a cron bind lands right after the commit, only the committed transcript's tab gets the value, no record is left) and test_a_queued_alias_save_writes_a_merges_commit[rebound|line-less].
Span 324ec7934888 hit its third fix (rounds 0, 2, 4), so this round removes the worker-side write instead of patching it a third time.
[operator: bolichen97]

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 7, 2026
Alias slots (two live slots on one transcript) each held their own
copy of the session's compaction threshold, so the threshold route
mirrored a commit onto every alias by hand and ran a second confirm
save to re-order the durable record after a stale alias flush.

The threshold now lives in the TranscriptBinding the aliases already
share for the project directory, behind a _ChatSlot property. A write
through one alias is the group's write and every alias's save reads
it under the transcript lock, so the mirror, its rollback loops and
the confirm save are gone.

The route persists before it publishes, as the turn time limit route
does: its save writes the new value staged while the shared field
keeps the previous one. The commit hook, run in the save's worker
under the transcript lock, only records the committed value, which
every save of that transcript writes until the route publishes it on
the event loop, where every rebind runs. A value that never lands is
never visible to an alias's save or to a restore seeding the
session's live gate, so a failed or refused request has nothing to
undo.

The binding records whether anything wrote its threshold, a clear
included. A joining slot keeps a live peer's threshold and only
fills a peer nothing wrote, as it already does for the directory,
and a stored threshold read from disk (a restore or a surfaced
channel slot) never replaces a live alias's.

Part of #7497
@bolichen97
bolichen97 force-pushed the fix/7497-alias-binding-settings branch from 11359f4 to 700ddef Compare November 7, 2026 18:24
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in src/kiro_crew/dashboard/state_parts/chat_slot.py and test/test_state_parts_facade.py (same files), plus import and same-directory neighbours such as cli_commands.py, cli_config.py, dashboard/chat_folders*.py, dashboard/chat_turn/queue_drain.py and dashboard/routes/system.py, since this head went green (a254f30 -> 928d145); CI re-running.

The patch is unchanged by the rebase (range-diff identical). Related backend tests passed locally on the new base.

[operator: bolichen97]

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: passed Eligible automated validation passed for the current revision readiness: checking Automated validation is still running labels Nov 7, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved: PR Readiness passed on 700ddef, and all five review lanes (Opus 5.5, GPT 6.1, Design, UX, First Principles) report no blocking finding on this head. No conflict and no open change request.

@bolichen97
bolichen97 merged commit 41a8bb3 into main Nov 7, 2026
99 checks passed
@bolichen97
bolichen97 deleted the fix/7497-alias-binding-settings branch November 7, 2026 19:47
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 7, 2026
@buluoray

buluoray commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:

Post-merge review: the change works as intended; a remaining gap is tracked in #32569.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants