Skip to content

fix(apps): pin the adopted apps at commits carrying the wheel's fixes - #31343

Merged
bolichen97 merged 1 commit into
mainfrom
feat/adopt-sync-wheel-fixes
Nov 6, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
feat/adopt-sync-wheel-fixes

Conversation

@bolichen97

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A host that adopts one of the five former built-ins runs a copy that has every fix the built-in copy has.

The adoption pins named repository snapshots cut before several fixes landed in the wheel copy: personal-shopper's non-ASCII group names (#30535) and field labels (#30493), papyrus's Windows userspace compiler probe (#30438), seven file-explorer fixes (#27870, #27995, #28649, #29854, #30177, #30505, #30445), seven design-critique translation and a11y fixes (#27392 through #30299), and four pptx-maker engine fixes (#28972, #28737, #30185, #31094). A host that adopted ran without them while a host still on the built-in had them.

Why it matters

Adoption is meant to be invisible to the user. Instead, adopting silently took fixes away: a Windows Papyrus user with only a userspace TeX saw "no compiler found" again, and a pptx-maker engine install could re-resolve to an mcp major it cannot import.

Not a goal

What changed (motivation → approach → change)

Each app repository now carries those fixes at a patch release, with green CI on ubuntu, macOS and Windows. This PR pins those commits: each row is the output of scripts/adoption_pin.py compute, and adoption_pin.py verify reports all five ok (git tree and codeload archive digests match, and the pinned-tree checks pass against the shipped built-in).

The wheel built-in's app.json version moves to the same patch release. A first-adoption pin must equal the wheel version (D12, pinned_tree_refusal). Without the bump, every host that has not adopted yet would block the new pin with version_mismatch, a code that is never retried for that pin.

How each host reaches the new code:

  • A host still on the built-in adopts the new commit on its next boot after upgrading, as before. STAGE resets its ledger for the new commit.
  • A host that already adopted is an ordinary registry app, so this pin does not move it. It reaches the new commit through the catalog (kirodotdev/KiroCrewApps, linked below). Its record version is below the new one, so the store offers the update.

Backwards compatibility

Compatible: same names, repositories, legacyNav and minAppSdkLevel. Each version moves one patch up, so neither the record-version check nor would_downgrade refuses it.

Removes nothing: only the pinned commit and the matching wheel version change.

Tests

test_the_shipped_pin_file_validates_and_pins_exactly_the_shipped_table takes the five new rows; test_every_shipped_pin_matches_its_wheel_built_in_version holds the bump.

Proof: PROVEN test/test_builtin_adoption_pins.py::test_the_shipped_pin_file_validates_and_pins_exactly_the_shipped_table (head 475fb27)

Determinism: no test logic changes, only the pinned data table.

Locally: the seven adoption test files, integration boot included, give 226 passed and 3 skipped. The related backend set gives 4399 passed and 13 skipped. black, subprocess-encoding, isort, flake8, comment-history, brand and line-cap gates are clean.

Manual verification

scripts/adoption_pin.py verify was run over the network: all five rows ok.

Related Issues

Part of #26967

Sibling sweep

Swept: git log --since=2026-11-01 -- src/kiro_crew/apps/builtins/{personal_shopper,papyrus,file_explorer,design_critique,pptx_maker} website/src/apps/{personal-shopper,papyrus,file-explorer,design-critique,pptx-maker}, checked against each repository commit's list of carried fixes
Sibling: src/kiro_crew/apps/adoption-pins.json -- changed here
Sibling: src/kiro_crew/apps/builtins/personal_shopper/app.json -- changed here
Sibling: src/kiro_crew/apps/builtins/papyrus/app.json -- changed here
Sibling: src/kiro_crew/apps/builtins/file_explorer/app.json -- changed here
Sibling: src/kiro_crew/apps/builtins/design_critique/app.json -- changed here
Sibling: src/kiro_crew/apps/builtins/pptx_maker/app.json -- changed here

Pattern harvest

Rule candidate: review-prompt
Pattern: a change under the wheel copy of an app with an adoption pin also needs the same fix in that app's repository and a pin bump; otherwise adopted hosts lose it

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

The five adopted former built-ins were pinned at repository snapshots
cut before several fixes landed in the wheel copy, so a host that
adopted ran code missing fixes a built-in host had. Each repository
now carries those fixes at a patch release; pin those commits.

The wheel built-in's version moves to the same patch release, because
a first-adoption pin must equal it (D12): otherwise every host that
has not adopted yet would refuse the new pin with version_mismatch.
@bolichen97

Copy link
Copy Markdown
Contributor Author

Catalog pair: kirodotdev/KiroCrewApps#68 moves the five catalog refs to the same commits. It merges right after this PR lands. That move is what offers the update to hosts that already adopted; this pin covers hosts that have not adopted yet.

@bolichen97
bolichen97 enabled auto-merge (squash) November 6, 2026 10:35
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 475fb273d7258ae40a4962ae38739ea0f3f279d5 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 475fb273d7258ae40a4962ae38739ea0f3f279d5 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this only bumps the pinned data, with matching wheel versions under the D12 equality rule, and it takes nothing away.

[DESIGN-REVIEWED] 475fb27

Description read

[DESCRIPTION-READ] 3f052862b6f84059f17b4848b549df1e15c60c8c036d572cf6db91337f2310d3

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 475fb273d7258ae40a4962ae38739ea0f3f279d5 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. This is a data-only fix: each pin moves to a commit that carries the wheel copy's fixes, and each wheel version bump is required by the existing version_mismatch equality check.

What this change ships

Inventory (6 items) — 6 justified

Intent: a host that adopts one of the five former built-in apps should run a copy with every fix the built-in copy has. This is a FIX.

  1. Adopting personal-shopper now installs 0.1.1, which has the non-ASCII group-name and field-label fixes (fix(personal-shopper): match group names case-insensitively for non-ASCII letters #30535, fix(website): name the Personal Shopper text fields #30493) — justified
  2. Adopting papyrus now installs 0.2.1, which finds a Windows userspace TeX compiler (fix(papyrus): probe tectonic.exe/pdflatex.exe in userspace on Windows #30438) — justified
  3. Adopting file-explorer now installs 1.0.1, which has seven listed fixes — justified
  4. Adopting design-critique now installs 1.0.1, which has the translation and a11y fixes — justified
  5. Adopting pptx-maker now installs 0.3.1, which has four engine fixes including the mcp-major resolution fix — justified
  6. All five built-in apps now report a version one patch higher, matching the pins as builtin_adoption_checks.py:131 (version_mismatch) requires — justified

[FIRST-PRINCIPLES-REVIEWED] 475fb27

Description read

[DESCRIPTION-READ] 70164a8a4604c9681624b1ae8722efcb39e3909e08fd936e5194a4bb2a561401

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 475fb273d7258ae40a4962ae38739ea0f3f279d5 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 475fb27

Verdict parsed from the review's SHA-scoped output markers for commit 475fb273d7258ae40a4962ae38739ea0f3f279d5.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 475fb273d7258ae40a4962ae38739ea0f3f279d5 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 475fb273d7258ae40a4962ae38739ea0f3f279d5 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 475fb27

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 475fb273d7258ae40a4962ae38739ea0f3f279d5 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 6, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:

APPROVE.

What it does for users: hosts that adopt one of the five former built-ins now get the same fixes as hosts still on the built-in copy. That covers the papyrus Windows userspace TeX probe, the non-ASCII group names and field labels in personal-shopper, the file-explorer search and Windows path fixes, the design-critique translations and accessible names, and the pptx-maker engine install fixes. The wheel app.json versions move up one patch, so first adoption is not refused with version_mismatch.

Each pin was checked against its app repository through the GitHub API:

  • personal-shopper e3d71dec00. The commit exists and is the head of main. It is 1 commit ahead of the old pin and 0 behind. app.json at that commit says 0.1.1. CI: 6 checks, all success.
  • papyrus 6ca7bc697f. Exists, head of main, 1 ahead and 0 behind. app.json says 0.2.1. 6 of 6 success.
  • file-explorer e68646984d. Exists, head of main, 1 ahead and 0 behind. app.json says 1.0.1. 6 of 6 success.
  • design-critique 3618805505. Exists, head of main, 1 ahead and 0 behind. app.json says 1.0.1. 7 of 7 success.
  • pptx-maker 1c47c5099d. Exists, head of main, 2 ahead (one is a merge commit) and 0 behind. app.json says 0.3.1. 6 of 6 success.

Fixes carried. I downloaded each pinned archive and checked every fix the body lists against it:

  • All 21 listed fixes have a row in that app's PORTING.md, keyed by the core merge commit: 2 for personal-shopper, 1 for papyrus, 7 for file-explorer, 7 for design-critique and 4 for pptx-maker.
  • I compared the lines each fix PR added to the wheel copy with the pinned tree. Many added lines match exactly. The rest differ only for porting reasons. The app repositories use their own i18n namespaces: t('historyTab.search_label') where core has i18nT('apps.personalShopper.historyTab.search_label'). They replace core helpers with local ones: relativeToRoot moves to ui/src/lib/platform.ts, and safe_read_prefix and FileTooLargeError come through the host bridge with a fallback. Some lines were reformatted, such as the casefold group lookup in backend/store.py:432.
  • I opened the remaining differences by hand. design-critique's AskLayer question_label (line 89) and the step-range and screen fallbacks are all present. pptx-maker's start button is disabled={!engineReady} where core has disabled={startChat.isPending || !engineReady}. The engineReady gate is the #30185 fix, and the app's startChat is a plain function, not a mutation, so it has no isPending.
  • No fixes appear to be missing. I listed every core commit since each old pin's date that touches the five wheel copies. Everything not in PORTING.md is test-only, a core-independence refactor, or (for #27451, file-explorer aria-expanded) already in ui/src/TreeNode.tsx:99.

The repo's own verifier, run over the network at this head, reports ok for all five: tree and archive digests match, and the pinned-tree checks pass.

Tests: test/test_builtin_adoption_pins.py gave 47 passed. Mutation: putting papyrus app.json back to 0.2.0 reddened test_every_shipped_pin_matches_its_wheel_built_in_version ("assert '0.2.1' == '0.2.0'"), and the tree was clean afterwards.

CI on this head: 77 success, 16 skipped, 0 failing. PR Readiness is success. Design and First Principles both PASS. No reviews and no inline threads. The merge-tree against main exits 0.

Source-only: I did not boot a host to exercise first adoption or the catalog update path for an already-adopted host.

Follow-up: #31351 (the App repo: line check) would fail this PR's PR Hygiene on any later run, because this PR edits five wheel-copy app.json files. If this PR runs CI again after #31351 merges, add one App repo: line per app naming the pinned commit. That is a body edit, with no push.

@bolichen97
bolichen97 merged commit 60b8d18 into main Nov 6, 2026
97 checks passed
@bolichen97
bolichen97 deleted the feat/adopt-sync-wheel-fixes branch November 6, 2026 17:35
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants