Skip to content

fix(apps): join app detail and registry name lists the reader way - #31365

Merged
RohanK6 merged 1 commit into
mainfrom
crew/conductor/r11-version-prefix
Nov 6, 2026
Merged

RohanK6 merged 1 commit into
mainfrom
crew/conductor/r11-version-prefix

Conversation

@RohanK6

@RohanK6 RohanK6 commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Name lists on the App detail page and in the registry refresh banner are joined the way the reader language joins a list.

The App detail Resources card (agent, skill and cron names), its Platform row, and the registry refresh banner build their lists with a hardcoded join(", "). Japanese and Chinese do not separate list items with a comma and a space, so those readers see auditor, scribe where their language writes auditor、scribe.

Why it matters

These rows tell a person what an app installs and which registries failed to refresh. An English comma in CJK text reads as a missed string, and the repo already has fmtList for exactly this case.

Not a goal

What changed (motivation → approach → change)

Symptom: an English comma between names in CJK. Cause: each list is a hardcoded join(", "). Change: each goes through fmtList(..., { style: "narrow" }). The narrow conjunction style produces a, b, c in English, so English output is byte-identical; Japanese and Chinese get a、b、c.

Locale Before After
en auditor, scribe unchanged
ja auditor, scribe auditor、scribe

Each item is passed through String(x ?? "") first. Intl.ListFormat throws on a non-string where join stringified it, so this keeps an odd manifest or API value rendering instead of crashing the page.

Backwards compatibility

Compatible: only displayed text changes in non-English languages; English is byte-identical, and no API, route, setting or stored value is touched.

Removes nothing: no key, field or code path is removed.

Tests

  • website/src/test/AppDetailPageCoverage.test.tsx adds two Japanese tests: the installed Resources rows read auditor、scribe, SKILL.md、NOTES.md and nightly-close、weekly-sum, and a registry app Platform row reads darwin、linux. Both fail with origin/main and pass with this change.
  • website/src/test/registryRefreshMessage.test.ts adds a Japanese test: the banner names read a、b、c. It fails with origin/main and passes with this change.
  • The existing English tests (auditor, scribe, darwin, linux, a, b, c) still pass and pin that English is unchanged.

Proof: not provable -- frontend test (prove.py runs Python only)

Determinism: each test switches i18next language and restores English afterwards; no clock, timer or network. tsc, eslint, i18n:check (with I18N_BASE_REF=origin/main), the 14 AppDetail test files (171 tests) and the registry, RegistryManager and Discover tests (65) pass. Local GPT review on gpt-5.6-sol and Opus 5.5: no findings.

Manual verification

N/A -- unit coverage sufficient: the change is the list separator, and the tests assert the rendered Japanese rows through the real page.

Screenshots / video

Why no screenshot: the English rows are unchanged and the capture host has no CJK font, so a screenshot would show no visible difference; the Japanese text is asserted by the tests.

Related Issues

Fixes #31361

Sibling sweep

Swept: git grep -n "join(', ')" -- website/src/pages/apps website/src/components/appstore website/src/pages/AppDetailPage.tsx
Sibling: website/src/pages/AppDetailPage.tsx -- changed here
Sibling: website/src/components/appstore/registryRefreshMessage.ts -- changed here
Sibling: website/src/pages/apps/useAppUpdates.ts -- tracked in #29936

Pattern harvest

Rule candidate: lint
Pattern: a user-visible list built with join(", ") instead of fmtList, the same shape i18n-catalog.md already warns about.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project Apache-2.0 license.

The App detail Resources rows, its Platform row and the registry refresh
banner joined names with a hardcoded English comma, so Japanese and
Chinese readers saw a, b instead of their list mark. They now go through
fmtList with the narrow style, which keeps English byte-identical.
@RohanK6
RohanK6 requested review from a team and KiroCrewCaptain as code owners November 6, 2026 11:15
@RohanK6
RohanK6 requested a review from Zedmor November 6, 2026 11:15
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of d25f3fe059e5fa7aeea0dbd9d63d86d2d97bc868 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the change routes three hand-joined name lists through the repo's existing locale-aware list helper, fmtList. It adds no new surface and removes nothing.

Notes

  • fmtList drops empty items (format.ts:640), so a name that is missing now disappears instead of rendering as a, , b. That's harmless, but the description's claim that English output is "byte-identical" doesn't hold for that case.

[DESIGN-REVIEWED] d25f3fe

Description read

[DESCRIPTION-READ] d54b18e102c4a26a268f141cc7a4ff2e5abe168bb278caf88fbc6434bd60b5ed

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of d25f3fe059e5fa7aeea0dbd9d63d86d2d97bc868 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks: no control is added or changed. The only visible change is the list separator in Japanese and Chinese, and English text is byte-identical, so the missing blind read leaves no control unexamined.

[UX-REVIEWED] d25f3fe

Description read

[DESCRIPTION-READ] f813ae48da3e918fd991687bb3d347b807522d15482f0173c436c443751c4b0a

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of d25f3fe059e5fa7aeea0dbd9d63d86d2d97bc868 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Small, cause-level fix that reuses the existing fmtList; only gap is one sibling in the same registry surface the sweep missed.

Notes

  • Item 1 — symptom-level point patch: the description's sweep "git grep ... -- website/src/pages/apps website/src/components/appstore website/src/pages/AppDetailPage.tsx" leaves out website/src/components/RegistryManager.tsx:258, where trustNotice.join(', ') builds the registry trust-banner host list. The grep join\(['"], ['"]\) finds 169 hits in 111 non-test-dir files, but this is the only unswept one on the registry/app surface this PR's Goal covers. Subtraction: replace that join(', ') with the same fmtList(..., { style: 'narrow' }) call, or name it as deferred in the sweep.

What this change ships

Inventory (4 items) — 3 justified

Intent: Japanese and Chinese readers see app resource, platform and registry name lists joined with their own list mark. FIX.

  1. Registry refresh banner joins registry names with the locale's list mark — symptom-level (one registry sibling unswept)
  2. App detail Resources card (agents, skills, crons) joins names per locale — justified
  3. App detail Platform row joins OS names per locale — justified
  4. A null or non-string list item renders as empty instead of crashing the formatter — justified

[FIRST-PRINCIPLES-REVIEWED] d25f3fe

Description read

[DESCRIPTION-READ] 7fda1ddc5b1bd8c2173731f81b859e6a705a742f35952ae21532e3bfe12a49ef

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of d25f3fe059e5fa7aeea0dbd9d63d86d2d97bc868 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] d25f3fe

False positive or not applicable? A repository writer can comment:
/ai-review override gpt d25f3fe059e5fa7aeea0dbd9d63d86d2d97bc868 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed d25f3fe059e5fa7aeea0dbd9d63d86d2d97bc868 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] d25f3fe

Verdict parsed from the review's SHA-scoped output markers for commit d25f3fe059e5fa7aeea0dbd9d63d86d2d97bc868.

False positive or not applicable? A repository writer can comment:
/ai-review override fable d25f3fe059e5fa7aeea0dbd9d63d86d2d97bc868 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 6, 2026
@RohanK6
RohanK6 enabled auto-merge (squash) November 6, 2026 12:23

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: fix (4 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: app detail and registry name lists use the locale's list format.

@RohanK6
RohanK6 merged commit a490a09 into main Nov 6, 2026
97 checks passed
@RohanK6
RohanK6 deleted the crew/conductor/r11-version-prefix branch November 6, 2026 13:33
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 6, 2026
buluoray added a commit that referenced this pull request Nov 8, 2026
…1365)

The App detail Resources rows, its Platform row and the registry refresh
banner joined names with a hardcoded English comma, so Japanese and
Chinese readers saw a, b instead of their list mark. They now go through
fmtList with the narrow style, which keeps English byte-identical.

(cherry picked from commit a490a09)

Original author: Rohan Khanderia (#31365).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App detail and registry banner join name lists with an English comma

2 participants