Repository navigation
fix(apps): join app detail and registry name lists the reader way - #31365
Conversation
The App detail Resources rows, its Platform row and the registry refresh banner joined names with a hardcoded English comma, so Japanese and Chinese readers saw a, b instead of their list mark. They now go through fmtList with the narrow style, which keeps English byte-identical.
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the change routes three hand-joined name lists through the repo's existing locale-aware list helper, Notes
[DESIGN-REVIEWED] d25f3fe Description read[DESCRIPTION-READ] d54b18e102c4a26a268f141cc7a4ff2e5abe168bb278caf88fbc6434bd60b5ed That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: no control is added or changed. The only visible change is the list separator in Japanese and Chinese, and English text is byte-identical, so the missing blind read leaves no control unexamined. [UX-REVIEWED] d25f3fe Description read[DESCRIPTION-READ] f813ae48da3e918fd991687bb3d347b807522d15482f0173c436c443751c4b0a That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Small, cause-level fix that reuses the existing Notes
What this change shipsInventory (4 items) — 3 justifiedIntent: Japanese and Chinese readers see app resource, platform and registry name lists joined with their own list mark. FIX.
[FIRST-PRINCIPLES-REVIEWED] d25f3fe Description read[DESCRIPTION-READ] 7fda1ddc5b1bd8c2173731f81b859e6a705a742f35952ae21532e3bfe12a49ef That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (4 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: app detail and registry name lists use the locale's list format.
…1365) The App detail Resources rows, its Platform row and the registry refresh banner joined names with a hardcoded English comma, so Japanese and Chinese readers saw a, b instead of their list mark. They now go through fmtList with the narrow style, which keeps English byte-identical. (cherry picked from commit a490a09) Original author: Rohan Khanderia (#31365).
Problem / Motivation
Goal: Name lists on the App detail page and in the registry refresh banner are joined the way the reader language joins a list.
The App detail Resources card (agent, skill and cron names), its Platform row, and the registry refresh banner build their lists with a hardcoded
join(", "). Japanese and Chinese do not separate list items with a comma and a space, so those readers seeauditor, scribewhere their language writesauditor、scribe.Why it matters
These rows tell a person what an app installs and which registries failed to refresh. An English comma in CJK text reads as a missed string, and the repo already has
fmtListfor exactly this case.Not a goal
useAppUpdatesfailed-update list, which open PR fix(apps): surface the trust reason when Update All hits a trust-gated app #29936 already changes.What changed (motivation → approach → change)
Symptom: an English comma between names in CJK. Cause: each list is a hardcoded
join(", "). Change: each goes throughfmtList(..., { style: "narrow" }). The narrow conjunction style producesa, b, cin English, so English output is byte-identical; Japanese and Chinese geta、b、c.auditor, scribeauditor, scribeauditor、scribeEach item is passed through
String(x ?? "")first.Intl.ListFormatthrows on a non-string wherejoinstringified it, so this keeps an odd manifest or API value rendering instead of crashing the page.Backwards compatibility
Compatible: only displayed text changes in non-English languages; English is byte-identical, and no API, route, setting or stored value is touched.
Removes nothing: no key, field or code path is removed.
Tests
website/src/test/AppDetailPageCoverage.test.tsxadds two Japanese tests: the installed Resources rows readauditor、scribe,SKILL.md、NOTES.mdandnightly-close、weekly-sum, and a registry app Platform row readsdarwin、linux. Both fail with origin/main and pass with this change.website/src/test/registryRefreshMessage.test.tsadds a Japanese test: the banner names reada、b、c. It fails with origin/main and passes with this change.auditor, scribe,darwin, linux,a, b, c) still pass and pin that English is unchanged.Proof: not provable -- frontend test (prove.py runs Python only)
Determinism: each test switches i18next language and restores English afterwards; no clock, timer or network.
tsc,eslint,i18n:check(withI18N_BASE_REF=origin/main), the 14 AppDetail test files (171 tests) and the registry, RegistryManager and Discover tests (65) pass. Local GPT review on gpt-5.6-sol and Opus 5.5: no findings.Manual verification
N/A -- unit coverage sufficient: the change is the list separator, and the tests assert the rendered Japanese rows through the real page.
Screenshots / video
Why no screenshot: the English rows are unchanged and the capture host has no CJK font, so a screenshot would show no visible difference; the Japanese text is asserted by the tests.
Related Issues
Fixes #31361
Sibling sweep
Swept: git grep -n "join(', ')" -- website/src/pages/apps website/src/components/appstore website/src/pages/AppDetailPage.tsx
Sibling: website/src/pages/AppDetailPage.tsx -- changed here
Sibling: website/src/components/appstore/registryRefreshMessage.ts -- changed here
Sibling: website/src/pages/apps/useAppUpdates.ts -- tracked in #29936
Pattern harvest
Rule candidate: lint
Pattern: a user-visible list built with join(", ") instead of fmtList, the same shape i18n-catalog.md already warns about.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project Apache-2.0 license.