Repository navigation
docs: describe the first-load pinned-order seed accurately - #31411
Conversation
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. The diff only changes comments, docstrings, docs and one tool-description sentence. No website line outside a comment is touched, so no user-visible control is added or changed and no screenshot is needed. [UX-REVIEWED] 457f606 Description read[DESCRIPTION-READ] 66671f19a1e31118b22eae731699e0a734251db62270d14a1f846fa7504b915c That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Prose only. The comments that said "never reordered" now match the first-load seed at What this change shipsInventory (6 items) — 6 justifiedIntent: make the pinned-order contract comments and the agent tool text describe the sidebar's real first-load seed. FIX (docs).
[FIRST-PRINCIPLES-REVIEWED] 457f606 Description read[DESCRIPTION-READ] 8b5f69f36364c0a226cbacd692e8e49b638da3e8c502bd459fc16416ba37b090 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Only comments, docstrings and one tool description sentence change, and they now match the first-load seed the code and tests already have. Nothing to check. [DESIGN-REVIEWED] 457f606 Description read[DESCRIPTION-READ] 6ee97eda7891bd59172bbc30a857723f74332f01b15c81e89400750ab25c20c0 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
cda48c6 to
88f8270
Compare
The pinned-order contract said a person who never reordered keeps the plain sort inside the pinned section. The sidebar's first list-view load seeds an order with only_if_unset (this browser's old local order if it kept one, then the natural order), so rows gain a pin_rank without any reorder and later pins append. The seed is intended, so the text is corrected wherever it repeated the claim: the contract docstring, the seed hook and client notes, the route and store docstrings, the agent-facing pin-move description and session-control doc, and the owning spec. No code changes. Builds on #22936. Co-authored-by: Matthew Briones <50031759+mbriones98@users.noreply.github.com>
88f8270 to
457f606
Compare
|
Rebased: main moved in 17 files beside or imported by this diff since this head's CI ran (85ce466 -> 89a6107); CI re-running. The diff is unchanged. The backend shard that failed was main's own security package line-budget test, which main raised in #31469; the two AI review lanes failed on a rate limit before reviewing. [operator: bolichen97] |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Approved by Crew Captain for the on-call: checks green, PR Readiness passed, review lanes clean on this head.
Problem / Motivation
Goal: Make the pinned-order comments and the agent-facing pin-move text describe what the sidebar actually does on first load.
The pinned-order contract in
website/src/utils/pinnedSessionOrder.tssays pinned rows stay unranked until someone reorders, so the pinned section keeps its plain sort. In the list view that is not what happens: the sidebar's first load saves the order it is showing (only_if_unset), so every pinned row gets apin_rankwithout anyone reordering, and a later pin appends instead of sorting in. Other comments, and thechat_session_pin_movetool description, repeat the same claim.Why it matters
The docstring reads as the contract for pinned ordering. Anyone changing the sidebar or the gateway route from that text would expect unranked rows that are in fact ranked, and could "fix" the intended seed or build on behaviour that does not exist. An agent reading the tool description is told the wrong order for rows nobody dragged.
Not a goal
handOff/legacyPinnedOrderMigratedidentifiers.What changed (motivation → approach → change)
The text promised a plain sort the sidebar does not keep. The first-load seed is deliberate: its own comment says so, and the
ChatSidebar.hapticTapsandChatSidebar.slotSearchOrdertests name it. So the text is what is wrong, and only text changes.utils/pinnedSessionOrder.tscontractchat-sidebar/pinnedOrder.ts,api/client/chatOrganization.tsdashboard/chat_folders.py,dashboard/pinned_session_order.py,state_parts/dashboard_state.py,state_parts/sidebar_stores.py,test_pinned_session_order.pymcp_dashboard.py,mcp_dashboard_folder_tree.py,docs/session-control.mddocs/system-specs/modules/learn-cron-dashboard.mdBackwards compatibility
Compatible: only comments, docstrings, one test docstring, one tool description sentence and doc prose change; no code path, route, or stored format is touched.
Removes nothing: the diff edits prose only.
Tests
No tests added: no behaviour changes. The one test edit rewords the docstring of
test_pin_into_an_unused_order_keeps_it_empty; its assertion is unchanged. Ran:pytest -n 4ontest_pinned_session_order.py,test_pinned_order_real_sandbox.py,test_chat_folders_facade.py,test_mcp_dashboard_pin_move.py,test_mcp_dashboard_registration.py,test_session_control_doc.py,test_session_control_member_gate.py,test_session_control_audit.py: 239 passedvitest runonChatSidebar.hapticTaps,ChatSidebar.slotSearchOrder,pinnedSessionOrder: 21 passedtsc -p tsconfig.app.json, eslint on the three TS files; black, isort, flake8, mypy on the touched Python files;test_flake_pattern_ratchet.py,check_comment_history.py,check_brand_name.py,check_file_line_cap.py,docs-lint.sh, semgrep on the diff: all passManual verification
N/A — comments and description text only, no runtime behaviour to exercise.
Screenshots / video
Why no screenshot: comments only under
website/src/, so nothing renders differently.Related Issues
Closes #22182
Builds on #22936 by @mbriones98.
Follow-up: #25075 (deferred seed change, option 2 in #22182)
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.