Skip to content

fix(release): backport two dashboard and Bot steering fixes to 0.12.0 line - #31422

Merged
buluoray merged 2 commits into
release/0.12.0from
crew/slack/0.12.1-batch-8
Nov 6, 2026
Merged

buluoray merged 2 commits into
release/0.12.0from
crew/slack/0.12.1-batch-8

Conversation

@buluoray

@buluoray buluoray commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Bring two dashboard and Bot fixes that merged on main after v0.12.0 onto release/0.12.0, one commit per fix, so the 0.12.1 patch ships them and each one can be reverted alone.

Why it matters

PR What a 0.12.0 user sees today
#31308 Text typed but not yet sent in a split-view pane or a Bot chat is lost when the dashboard page reloads.
#31131 With more than 64 global steering files, every Bot turn fails.

Not a goal

  • No fix that is not already merged on main; nothing is changed only here.
  • No version bump, no tag, no CHANGELOG.md change. Cutting v0.12.1-rc.N and the bare tag follow docs/build/release.md and stay with the maintainers.
  • fix: skip a declared steering link that leaves the project #30722 (a declared steering link that leaves the project) is not carried; see the resolution below.

What changed (motivation → approach → change)

Each main squash commit was cherry-picked with -x onto release/0.12.0 @ 8da4c55e6e, in this order, one commit each.

# PR main commit release commit Pick
1 #31308 keep unsent split-view and Bot chat text across a page reload 090dad8cf1 3484537c01 clean
2 #31131 load steering up to the document cap instead of failing every Bot turn 73af86099f 79349e1b8d one hunk resolved

The only hand resolution was one hunk in _resource_paths in src/kiro_crew/member_essential_context.py:

-        left_out = linked if "steering" in Path(pattern).parts else None
+        steering_glob = "steering" in Path(pattern).parts
+        left_out = linked if steering_glob else None
         escaping = outside if path.is_absolute() else None
Line release main resolved Why
steering_glob absent added by #31131 added #31131's own change
left_out inline test uses steering_glob uses steering_glob #31131's own change
escaping else None else left_out else None main's value comes from #30722, which is not on this branch

The escaping line stays as release has it because else left_out belongs to #30722, not #31131 (git log -S'else left_out' names only #30722). Taking it would carry part of an unpicked fix. Every other #31131 hunk applies unchanged, including the over_cap=... if steering_glob argument that uses the new name. The commit message records the resolution.

Backwards compatibility

Compatible: each change is the one already merged on main, and each PR's own compatibility note applies unchanged.

Removes nothing: no pick hides, deletes or renames anything 0.12.0 accepts.

Tests

Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs

  • CI does not run the backend suite on PRs into release/*, so the related set was run here: the added test_member_essential_context_steering_doc_cap.py (7 passed) plus every test file that imports member_essential_context, 21 files, one pytest process, -n 0. 1042 passed. 2 tests fail, and both fail the same way on clean release/0.12.0 @ 8da4c55e6e, so neither comes from this diff: two in test_folder_steering_provider_dedup.py.
  • The useChatPaneDraft frontend tests, including the added reload test: 4 passed.
  • flake8 and mypy pass on the changed Python file.

Manual verification

N/A - every pick was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.

Screenshots / video

Why no screenshot: #31308 only saves the composer text when the page is about to be hidden, so nothing renders differently, as its own PR states.

Related Issues

Backport of #31308 and #31131 to the 0.12 line for 0.12.1. Source issues: #31296, #31128.

Sibling sweep

Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.

Pattern harvest

Not generalizable: this PR only carries two fixes already on main. Each source PR has its own harvest.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

buluoray and others added 2 commits November 6, 2026 12:54
… every Bot turn (#31131)

* fix(members): load steering up to the document cap instead of failing every Bot turn

A Bot inherits global steering by default. With more than 64 steering
files, the essential-context reader raised 'too many documents' and every
Bot turn failed, while main chats kept working.

Steering past the cap is now left out unread and named in an in-band
note and a warning, the same way oversized and unreadable steering
already is. The first files in sorted order are kept. A member's own
sources (persona, SOUL.md, declared resources) take the last kept
steering file's slot before they would be refused, so they are never
the ones dropped. The cap itself is unchanged. The native launch list
and the projected KAS resource snapshot get the same treatment so they
do not refuse the session start either.

* fix(members): never evict a core source to make room at the document cap

A steering file reused as the Bot's file:// persona is marked core, but it
stayed in the evictable steering list, so a later source (the template's
context settings) could pop it and the persona was lost. Marking a source
core now removes it from that list, and an evicted path leaves 'seen' so a
later source naming it loads it again. Documents the keep-first-64 rule and
the over-cap note in the memory spec.

(cherry picked from commit 73af860)

Conflict resolution (release/0.12.0): src/kiro_crew/member_essential_context.py,
one hunk in _resource_paths. Main's side also changed the `escaping` line
(`else left_out` instead of `else None`), which comes from a later main
PR this branch does not carry. The release `escaping` line is kept, and
only this pick's change is applied: the `steering_glob` local and its use
in `left_out`. Every other hunk applies unchanged.
@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 6, 2026 13:04
@buluoray
buluoray requested review from Zedmor and removed request for a team November 6, 2026 13:04
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 79349e1b8d5033b963a06ef32b3e6514beb78342 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing to check. The PR adds no control, label or state: it keeps unsent draft text across a reload, and the steering cap is a backend fix.

[UX-REVIEWED] 79349e1

Description read

[DESCRIPTION-READ] c251b5d18bfb8f6ec51d433ce428bdc82b1792c8e86e533b9d6dc6184424cd40

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 79349e1b8d5033b963a06ef32b3e6514beb78342 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this backports two fixes already merged on main. Neither one takes anything away or changes what the page shows, and the one hand-resolved hunk leaves out #30722's else left_out, as the PR's stated scope says it should.

[DESIGN-REVIEWED] 79349e1

Description read

[DESCRIPTION-READ] 45a0077ed4c1a33afd75bc28eff6de401ae8b52f936e24588c4fb328f2fada75

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 79349e1b8d5033b963a06ef32b3e6514beb78342 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. Both picks are fixes for linked issues (#31296, #31128) that already merged on main, and each ships a test that fails on base. The one hand-resolved hunk keeps #30722 out, as its Not-a-goal says.

What this change ships

Inventory (6 items) — 6 justified

Intent: ship two main fixes to 0.12.x users in 0.12.1, one revertable commit each. This is a FIX.

  1. Unsent split-view or Bot composer text now survives a page reload (saved on pagehide, taken back on a back/forward-cache restore) — justified
  2. A Bot turn with more than 64 steering files now loads steering up to the cap instead of failing — justified
  3. A member's own persona, SOUL.md, declared resource or context settings takes the last kept steering file's slot instead of being refused — justified
  4. A new in-band essential-context#over-cap-skipped note counts and names the steering that was left out — justified
  5. The KAS launch-document and projected-resource readers apply the same steering cap to always-included files — justified
  6. The memory-skills-hooks spec paragraph now describes the over-cap behaviour — justified

[FIRST-PRINCIPLES-REVIEWED] 79349e1

Description read

[DESCRIPTION-READ] 36f28ec805756dcd1401898575cd2ec2403727be416d45183c65ecc4c9022d7e

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 79349e1b8d5033b963a06ef32b3e6514beb78342 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 79349e1

Verdict parsed from the review's SHA-scoped output markers for commit 79349e1b8d5033b963a06ef32b3e6514beb78342.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 79349e1b8d5033b963a06ef32b3e6514beb78342 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 79349e1b8d5033b963a06ef32b3e6514beb78342 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 79349e1

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 79349e1b8d5033b963a06ef32b3e6514beb78342 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 6, 2026
@buluoray
buluoray merged commit 2f17ec6 into release/0.12.0 Nov 6, 2026
22 checks passed
@buluoray
buluoray deleted the crew/slack/0.12.1-batch-8 branch November 6, 2026 13:48
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant