Repository navigation
fix(settings): move the notification sources intro into its info tip - #31472
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: a small copy move that follows the existing Notes
[DESIGN-REVIEWED] cd89b9f Description read[DESCRIPTION-READ] 3ca296cfa6c835a89774e1a28dc34182feb5ea32f8c9a80d35a3ee6f1ccbe583 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. Moving the definition sentence into the tip is what What this change shipsInventory (3 items) — 3 justifiedIntent: let someone muting a noisy notification source see right away what muting does, with the section's definition one hover away. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] cd89b9f Description read[DESCRIPTION-READ] a91d43c169fe8b983a4d060494d30323e1f543d05ae94c656261b436a9496846 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. The info tip repeats the visible line word for word, which looks messy but makes nothing unreadable. Notes
[UX-REVIEWED] cd89b9f Description read[DESCRIPTION-READ] 7ed8a4782b2888867076badba3d4b7a6acc74966652b7d8bca7022c5247a95d6 That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
[operator: bolichen97] The red |
Settings > Notifications > Sources showed what the section is and what muting costs as one paragraph under the heading. The section intro now sits in the heading's info tip, and only the consequence line (muted notifications keep their history but never badge, sound or banner) stays visible, the same split the other Settings rows use. Closes #29729
0dc0bb9 to
cd89b9f
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Approved for the on-call. Review lanes pass on cd89b9f, no conflict, no open change request.
…31472) Settings > Notifications > Sources showed what the section is and what muting costs as one paragraph under the heading. The section intro now sits in the heading's info tip, and only the consequence line (muted notifications keep their history but never badge, sound or banner) stays visible, the same split the other Settings rows use. Closes #29729 (cherry picked from commit 83b7a6d)
Problem / Motivation
Goal: Settings → Notifications → Sources shows only the line a reader needs to decide under its heading, with what the section is one hover away in an info tip.
The Sources section opens with a two-sentence paragraph: "Mute notification sources or override their priority. Muted notifications stay in history but never badge, sound, or banner." The first sentence says what the section is. Only the second changes the choice. #29581 applied the help-text rule to the other rows this issue quotes (Plain diffs, Show Pasted Text in Full), and the Browser extension-token row it quotes is no longer on main. Sources is the one place left that still renders the whole paragraph as plain text.
Why it matters
A reader who opens Sources to mute one noisy source has to read past the definition to find the sentence that matters: a muted source stays in history but never badges, sounds or banners. Every other Settings section now follows the rule in
website/docs/frontend-conventions.md("Help text:descriptionorInfoTip"), so this one reads as the odd one out.Not a goal
What changed (motivation → approach → change)
Under the Sources heading only one line stays visible: what muting a source does (it stays in history but never badges, sounds or banners). What the section is moves into an info tip beside the heading, the same
SettingsSectionhintother section intros use.The tip shows the existing full paragraph, so Settings search still finds it through the unchanged
notifications.sourcesregistry entry. The visible line is a newmute_notification_sources_or_override_their_prio_summarykey: the second sentence of the existing string, copied from each language's own translation in all 12 catalogs rather than translated again.en-XA.jsonis regenerated.Backwards compatibility
Compatible: no config key, value, default, API or route changes; only where the help text renders moves.
Removes nothing: the full paragraph still renders, in the heading's info tip, and its catalog key keeps both readers (the tip and
settingsManual.ts'snotifications.sourcesentry).Tests
NotificationsPanel.channels.test.tsxadds one case on the Sources view: the consequence line is the visible text under the heading, the definition sentence is not in the body copy, and the full paragraph is the info tip'stitle. It fails on main, where the paragraph renders as one block, and passes here.Determinism: the new case ran 20 times in a row green (
-t 'Sources heading' --maxWorkers=1), and both NotificationsPanel spec files passed shuffled (--sequence.shuffle --sequence.seed=1627, 39 tests).Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
Built the SPA and loaded Settings → Notifications → Sources against fixture API answers in Chromium, in dark and light themes: the heading shows the info icon, one consequence line sits under it, and hovering the icon opens the full paragraph.
Screenshots / video
Dark theme:
Light theme:
Info tip open:
Related Issues
Closes #29729
Sibling sweep
Swept: git grep -n -A2 "<SettingsSection " -- website/src/pages/settings/ (a section whose first child is a muted prose paragraph)
Sibling: website/src/pages/settings/ConnectionsPanel.tsx:297 -- not affected -- setup steps the reader follows on that page, plus which values override the saved ones
Sibling: website/src/pages/settings/SecretsPanel.tsx:392 -- not affected -- says where secrets are kept and who can read them, which the rule keeps visible
Sibling: website/src/pages/settings/PeoplePanel.tsx:140 -- not affected -- one short line naming where access is managed
Sibling: website/src/pages/settings/NotificationsPushSection.tsx:45 -- not affected -- an unsupported or install-needed status line
Sibling: website/src/pages/settings/ComputerUsePanel.tsx:309 -- not affected -- the not-available reason, a status line
Pattern harvest
Not generalizable: the rule is already written down and #29581 applied it page by page; this is the one section that pass left, and telling a definition from a consequence needs a reader, not a lint.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)