Skip to content

fix(settings): move the notification sources intro into its info tip - #31472

Merged
KiroCrewCaptain merged 1 commit into
mainfrom
fix/29729-notifications-sources-tip
Nov 7, 2026
Merged

KiroCrewCaptain merged 1 commit into
mainfrom
fix/29729-notifications-sources-tip

Conversation

@bolichen97

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Settings → Notifications → Sources shows only the line a reader needs to decide under its heading, with what the section is one hover away in an info tip.

The Sources section opens with a two-sentence paragraph: "Mute notification sources or override their priority. Muted notifications stay in history but never badge, sound, or banner." The first sentence says what the section is. Only the second changes the choice. #29581 applied the help-text rule to the other rows this issue quotes (Plain diffs, Show Pasted Text in Full), and the Browser extension-token row it quotes is no longer on main. Sources is the one place left that still renders the whole paragraph as plain text.

Why it matters

A reader who opens Sources to mute one noisy source has to read past the definition to find the sentence that matters: a muted source stays in history but never badges, sounds or banners. Every other Settings section now follows the rule in website/docs/frontend-conventions.md ("Help text: description or InfoTip"), so this one reads as the odd one out.

Not a goal

  • Changing any notification setting, channel, priority, or what muting does.
  • Rewording copy: both sentences keep their existing text in every language.
  • Settings rows outside Notifications → Sources.

What changed (motivation → approach → change)

Under the Sources heading only one line stays visible: what muting a source does (it stays in history but never badges, sounds or banners). What the section is moves into an info tip beside the heading, the same SettingsSection hint other section intros use.

The tip shows the existing full paragraph, so Settings search still finds it through the unchanged notifications.sources registry entry. The visible line is a new mute_notification_sources_or_override_their_prio_summary key: the second sentence of the existing string, copied from each language's own translation in all 12 catalogs rather than translated again. en-XA.json is regenerated.

Backwards compatibility

Compatible: no config key, value, default, API or route changes; only where the help text renders moves.

Removes nothing: the full paragraph still renders, in the heading's info tip, and its catalog key keeps both readers (the tip and settingsManual.ts's notifications.sources entry).

Tests

NotificationsPanel.channels.test.tsx adds one case on the Sources view: the consequence line is the visible text under the heading, the definition sentence is not in the body copy, and the full paragraph is the info tip's title. It fails on main, where the paragraph renders as one block, and passes here.

Determinism: the new case ran 20 times in a row green (-t 'Sources heading' --maxWorkers=1), and both NotificationsPanel spec files passed shuffled (--sequence.shuffle --sequence.seed=1627, 39 tests).

Proof: not provable -- frontend test (prove.py runs Python only)

Manual verification

Built the SPA and loaded Settings → Notifications → Sources against fixture API answers in Chromium, in dark and light themes: the heading shows the info icon, one consequence line sits under it, and hovering the icon opens the full paragraph.

Screenshots / video

Dark theme:

Sources, dark

Light theme:

Sources, light

Info tip open:

Sources tip open

Related Issues

Closes #29729

Sibling sweep

Swept: git grep -n -A2 "<SettingsSection " -- website/src/pages/settings/ (a section whose first child is a muted prose paragraph)
Sibling: website/src/pages/settings/ConnectionsPanel.tsx:297 -- not affected -- setup steps the reader follows on that page, plus which values override the saved ones
Sibling: website/src/pages/settings/SecretsPanel.tsx:392 -- not affected -- says where secrets are kept and who can read them, which the rule keeps visible
Sibling: website/src/pages/settings/PeoplePanel.tsx:140 -- not affected -- one short line naming where access is managed
Sibling: website/src/pages/settings/NotificationsPushSection.tsx:45 -- not affected -- an unsupported or install-needed status line
Sibling: website/src/pages/settings/ComputerUsePanel.tsx:309 -- not affected -- the not-available reason, a status line

Pattern harvest

Not generalizable: the rule is already written down and #29581 applied it page by page; this is the one section that pass left, and telling a definition from a consequence needs a reader, not a lint.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners November 6, 2026 14:59
@bolichen97
bolichen97 requested a review from Zedmor November 6, 2026 14:59
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of cd89b9f989bc1567c74187c40dd362d65437b91c — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: a small copy move that follows the existing hint pattern, with screenshots of this revision attached.

Notes

  • The tip shows the full paragraph, so its second sentence repeats the line already visible under the heading. A hint holding only the first sentence would avoid the repeat, but the PR keeps the full paragraph on purpose so the existing Settings search entry still finds it.

[DESIGN-REVIEWED] cd89b9f

Description read

[DESCRIPTION-READ] 3ca296cfa6c835a89774e1a28dc34182feb5ea32f8c9a80d35a3ee6f1ccbe583

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of cd89b9f989bc1567c74187c40dd362d65437b91c — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. Moving the definition sentence into the tip is what website/docs/frontend-conventions.md § "Help text: description or InfoTip" requires, and issue #29729 asks for it: "A long choice-making paragraph becomes one short description sentence with the full paragraph as the hint."

What this change ships

Inventory (3 items) — 3 justified

Intent: let someone muting a noisy notification source see right away what muting does, with the section's definition one hover away. This is a FIX.

  1. Under the Sources heading, the visible text is now only the consequence line ("Muted notifications stay in history but never badge, sound, or banner."). — justified
  2. The full intro paragraph moves from body text into an info tip beside the Sources heading (SettingsSection hint). — justified
  3. A new catalog string …_prio_summary is added to all 12 catalogs plus the regenerated en-XA, each copied from that language's existing translation; the one place that uses it is the visible line. — justified

[FIRST-PRINCIPLES-REVIEWED] cd89b9f

Description read

[DESCRIPTION-READ] a91d43c169fe8b983a4d060494d30323e1f543d05ae94c656261b436a9496846

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed cd89b9f989bc1567c74187c40dd362d65437b91c — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] cd89b9f

Verdict parsed from the review's SHA-scoped output markers for commit cd89b9f989bc1567c74187c40dd362d65437b91c.

False positive or not applicable? A repository writer can comment:
/ai-review override fable cd89b9f989bc1567c74187c40dd362d65437b91c false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of cd89b9f989bc1567c74187c40dd362d65437b91c — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. The info tip repeats the visible line word for word, which looks messy but makes nothing unreadable.

Notes

  • The SettingsSection hint shows the whole paragraph, so "Muted notifications stay in history but never badge, sound, or banner." appears twice. The blind reader saw this in shot-03: "the same sentence now appears twice… it looks messy", with the bubble covering the line under it. Add a …_intro key holding only "Mute notification sources or override their priority." and use it for the tip. Leave the full key on the settingsManual.ts search entry.
  • In shot-02 the blind reader said the off-state switch for heartbeat in the light theme "is very pale… I could easily miss that it's there at all". That is older styling, outside this PR's surface; fix it in a separate PR.

[UX-REVIEWED] cd89b9f

Description read

[DESCRIPTION-READ] 7ed8a4782b2888867076badba3d4b7a6acc74966652b7d8bca7022c5247a95d6

That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of cd89b9f989bc1567c74187c40dd362d65437b91c and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] cd89b9f

False positive or not applicable? A repository writer can comment:
/ai-review override gpt cd89b9f989bc1567c74187c40dd362d65437b91c false-positive: <reason, 20 to 500 characters>

@bolichen97
bolichen97 enabled auto-merge (squash) November 6, 2026 15:13
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 6, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

[operator: bolichen97] The red Backend Tests (3.12, 2) and Backend Tests (Windows) (2) shards (and the Coverage Gate after them) are main's, not this change's: test/test_security_gate_liveness.py::test_the_package_stays_within_its_line_budget also fails on main since #30774. Waiting for #31625 to merge, then this branch rebases onto it and re-runs.

Settings > Notifications > Sources showed what the section is and what
muting costs as one paragraph under the heading. The section intro now
sits in the heading's info tip, and only the consequence line (muted
notifications keep their history but never badge, sound or banner)
stays visible, the same split the other Settings rows use.

Closes #29729
@bolichen97
bolichen97 force-pushed the fix/29729-notifications-sources-tip branch from 0dc0bb9 to cd89b9f Compare November 7, 2026 02:12
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 7, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for the on-call. Review lanes pass on cd89b9f, no conflict, no open change request.

@KiroCrewCaptain
KiroCrewCaptain merged commit 83b7a6d into main Nov 7, 2026
152 of 155 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the fix/29729-notifications-sources-tip branch November 7, 2026 04:32
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 7, 2026
buluoray pushed a commit that referenced this pull request Nov 9, 2026
…31472)

Settings > Notifications > Sources showed what the section is and what
muting costs as one paragraph under the heading. The section intro now
sits in the heading's info tip, and only the consequence line (muted
notifications keep their history but never badge, sound or banner)
stays visible, the same split the other Settings rows use.

Closes #29729

(cherry picked from commit 83b7a6d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Settings rows still show 2-3 sentences of definition text under the label

2 participants