Repository navigation
fix(doctor): warn, not fail, on a kas engine the first chat downloads - #31731
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the change reuses the existing Notes
[DESIGN-REVIEWED] fb568c8 Description read[DESCRIPTION-READ] 18dfd38d90f9aa698a7b19f774eacb2f5b6b7f685352c80f898062ebb2c1e0a6 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS The fix reuses the existing Notes
What this change shipsInventory (4 items) — 4 justifiedIntent: a fresh install with no kiro-cli passes
[FIRST-PRINCIPLES-REVIEWED] fb568c8 Description read[DESCRIPTION-READ] 37ca757fdf593ea0fa2982eb19acadd0e409c76f5e7689f656d99e03d4b2ab96 That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
f672113 to
f2e6fe8
Compare
f2e6fe8 to
76f6feb
Compare
|
Rebased: main moved in docs/system-specs/modules/cli.md since this head went green (678769e -> e4611c5); CI re-running. The previous head's review lanes and the stub E2E job did not finish (an API rate limit and a job timeout), so this push also re-runs them; the patch itself is unchanged. [operator: bolichen97] |
76f6feb to
2758066
Compare
|
Rebased: main moved in docs/system-specs/modules/cli.md since this head went green (e4611c5 -> 5f7f8d1); CI re-running. The previous head 76f6feb never got verdicts from its review lanes (the CI token ran out of API quota), so this push also gives them a fresh run. The commit is unchanged by the rebase; the related backend tests pass on the new base. [operator: bolichen97] |
|
[operator: bolichen97] The red Backend Tests shard 2 (Linux and Windows, and the Coverage Gate that follows it) is |
|
Re-sync budget reset This head has no green to lose: its only test red is a check that was red on main, which main has since fixed, and its review lanes did not run because of an API rate limit. A pull_request re-run keeps the old merge commit, so only a new head on current main can clear it. Granting one more re-sync for that. [operator: bolichen97] |
2758066 to
eccdc0d
Compare
|
Rebased: main moved in docs/system-specs/modules/ (kas-auth.md and four more specs beside cli.md; no file this PR touches) since this head went green (5f7f8d1 -> f289a6d); CI re-running. The new base carries main's fix for the red line-budget test (#32252), and the commit is unchanged by the rebase; the related doctor tests and the line-budget test pass on the new base. [operator: bolichen97] |
6b19a2a to
89bdd6b
Compare
|
[operator: bolichen97] The red Backend Tests shards 5 and 6 (Linux and Windows), and the Coverage Gate that follows them, are main's, not this PR's. A rerun tests the same merge commit, so taking that fix needs a rebase, and this PR has used its three re-syncs (main keeps moving in |
On a host with no kiro-cli, KAS takes Kiro Crew's own engine on the automatic route, and the gateway downloads the pinned engine at the first chat. kirocrew doctor printed a missing pin there as a warning but also put it in its issue list, so a healthy fresh install ended with "Fix these issues" and exit 1. On the automatic route a missing pin now keeps its warning row and download hint, and is an issue only when the gateway will not install it on this host (an unsupported platform or glibc, or a version override it does not install unattended); the row then says so instead of promising a download. An operator who turned agent.kas_bundle on, an incomplete pinned directory and an unreadable engines directory still count as issues.
89bdd6b to
fb568c8
Compare
|
[operator: bolichen97] Rebased onto main's fix for the red Backend shards 5 and 6 (#32606): 89bdd6b -> fb568c8, onto e9cbb5b. This is a red-main re-sync, not a green-age one; the patch is unchanged. CI re-running. Local gate passed on this tree: the changed and related doctor and kas tests (997 of 998), flake8, isort, black, mypy, the flake-pattern ratchet and semgrep. Local GPT and local Opus review found nothing. The one local red, |
…#31731) On a host with no kiro-cli, KAS takes Kiro Crew's own engine on the automatic route, and the gateway downloads the pinned engine at the first chat. kirocrew doctor printed a missing pin there as a warning but also put it in its issue list, so a healthy fresh install ended with "Fix these issues" and exit 1. On the automatic route a missing pin now keeps its warning row and download hint, and is an issue only when the gateway will not install it on this host (an unsupported platform or glibc, or a version override it does not install unattended); the row then says so instead of promising a download. An operator who turned agent.kas_bundle on, an incomplete pinned directory and an unreadable engines directory still count as issues. (cherry picked from commit d549bec) Original author: @bolichen97 (picked by hand: conflict only in docs/system-specs/modules/cli.md)
…#31731) On a host with no kiro-cli, KAS takes Kiro Crew's own engine on the automatic route, and the gateway downloads the pinned engine at the first chat. kirocrew doctor printed a missing pin there as a warning but also put it in its issue list, so a healthy fresh install ended with "Fix these issues" and exit 1. On the automatic route a missing pin now keeps its warning row and download hint, and is an issue only when the gateway will not install it on this host (an unsupported platform or glibc, or a version override it does not install unattended); the row then says so instead of promising a download. An operator who turned agent.kas_bundle on, an incomplete pinned directory and an unreadable engines directory still count as issues. (cherry picked from commit d549bec) Original author: @bolichen97 (picked by hand: conflict only in docs/system-specs/modules/cli.md)
…#31731) On a host with no kiro-cli, KAS takes Kiro Crew's own engine on the automatic route, and the gateway downloads the pinned engine at the first chat. kirocrew doctor printed a missing pin there as a warning but also put it in its issue list, so a healthy fresh install ended with "Fix these issues" and exit 1. On the automatic route a missing pin now keeps its warning row and download hint, and is an issue only when the gateway will not install it on this host (an unsupported platform or glibc, or a version override it does not install unattended); the row then says so instead of promising a download. An operator who turned agent.kas_bundle on, an incomplete pinned directory and an unreadable engines directory still count as issues. (cherry picked from commit d549bec) Original author: @bolichen97 (picked by hand: conflict only in docs/system-specs/modules/cli.md)
…#31731) On a host with no kiro-cli, KAS takes Kiro Crew's own engine on the automatic route, and the gateway downloads the pinned engine at the first chat. kirocrew doctor printed a missing pin there as a warning but also put it in its issue list, so a healthy fresh install ended with "Fix these issues" and exit 1. On the automatic route a missing pin now keeps its warning row and download hint, and is an issue only when the gateway will not install it on this host (an unsupported platform or glibc, or a version override it does not install unattended); the row then says so instead of promising a download. An operator who turned agent.kas_bundle on, an incomplete pinned directory and an unreadable engines directory still count as issues. (cherry picked from commit d549bec) Original author: @bolichen97 (picked by hand: conflict only in docs/system-specs/modules/cli.md)
…#31731) On a host with no kiro-cli, KAS takes Kiro Crew's own engine on the automatic route, and the gateway downloads the pinned engine at the first chat. kirocrew doctor printed a missing pin there as a warning but also put it in its issue list, so a healthy fresh install ended with "Fix these issues" and exit 1. On the automatic route a missing pin now keeps its warning row and download hint, and is an issue only when the gateway will not install it on this host (an unsupported platform or glibc, or a version override it does not install unattended); the row then says so instead of promising a download. An operator who turned agent.kas_bundle on, an incomplete pinned directory and an unreadable engines directory still count as issues. (cherry picked from commit d549bec) Original author: @bolichen97 (picked by hand: conflict only in docs/system-specs/modules/cli.md)
…#31731) On a host with no kiro-cli, KAS takes Kiro Crew's own engine on the automatic route, and the gateway downloads the pinned engine at the first chat. kirocrew doctor printed a missing pin there as a warning but also put it in its issue list, so a healthy fresh install ended with "Fix these issues" and exit 1. On the automatic route a missing pin now keeps its warning row and download hint, and is an issue only when the gateway will not install it on this host (an unsupported platform or glibc, or a version override it does not install unattended); the row then says so instead of promising a download. An operator who turned agent.kas_bundle on, an incomplete pinned directory and an unreadable engines directory still count as issues. (cherry picked from commit d549bec) Original author: @bolichen97 (picked by hand: conflict only in docs/system-specs/modules/cli.md)
…#31731) On a host with no kiro-cli, KAS takes Kiro Crew's own engine on the automatic route, and the gateway downloads the pinned engine at the first chat. kirocrew doctor printed a missing pin there as a warning but also put it in its issue list, so a healthy fresh install ended with "Fix these issues" and exit 1. On the automatic route a missing pin now keeps its warning row and download hint, and is an issue only when the gateway will not install it on this host (an unsupported platform or glibc, or a version override it does not install unattended); the row then says so instead of promising a download. An operator who turned agent.kas_bundle on, an incomplete pinned directory and an unreadable engines directory still count as issues. (cherry picked from commit d549bec) Original author: @bolichen97 (picked by hand: conflict only in docs/system-specs/modules/cli.md)
Problem / Motivation
Goal: When the gateway will download Kiro Crew's own KAS engine at the first chat,
kirocrew doctorwarns that the engine is not there yet instead of failing, so a fresh install without kiro-cli passes.On a fresh install with no kiro-cli, KAS runs Kiro Crew's own engine (the automatic bundle route), and the gateway downloads the pinned engine at the first chat. Until then
kirocrew doctorprintsbundle: ⚠ not installed yetand also addsKiro Crew's KAS engine is not installed yet (the first chat downloads it)to its issue list. So a healthy fresh install ends with❌ Fix these issues: ...and exit 1. The reporter's re-run on main in #22583 shows this line in the red summary.Why it matters
kirocrew doctoris the first command a new user runs. A red summary for a state the gateway fixes on its own makes a healthy install look broken, and teaches people to ignore doctor.Not a goal
agent.kas_bundleon with no engine installed. A fresh install never takes that route; it stays an issue, unchanged.❌with its issue.What changed (motivation → approach → change)
Symptom: a fresh install's doctor summary is red. Cause: the KAS section counts "the pinned engine is not on disk yet" as an issue on the automatic route, even though the gateway downloads it at the first chat. Change: on the automatic route, a missing pin keeps its
⚠row and its download hint, and is an issue only when the gateway will not install it on this host; the row then says that instead of promising a download. That answer comes frombackend_install._engine_installable_here, the check the dashboard and the gateway start already use: an unsupported platform or glibc, or a version override the gateway does not install unattended. It checks no network, so an offline host still fails at the first chat, as the⚠row warns. This is the same rule #24235 applied to thegitandconfigrows.agent.kas_bundleon, pin missing"Pin missing" covers both an empty engines directory and one holding only an older version. The
kirocrew doctorlist indocs/system-specs/modules/cli.mdstates the rule.Backwards compatibility
Compatible: doctor drops one issue-list entry for a state the gateway resolves at the first chat; every other state still counts as an issue, and the one the gateway will not fix says so in its row and issue text.
Removes nothing: the
bundle:row and its download hint still print; only the summary line and exit code change for that state, and only thekirocrew doctorcommand reads the issue list.Tests
In
test/test_cli_doctor_agent_auth.py::TestDoctorKasBundle, each parametrized over an empty engines directory and one holding only an older version:test_a_pin_the_gateway_downloads_on_the_automatic_route_is_not_an_issue: the⚠row and the first-chat hint print, and the issue list stays empty.test_a_pin_this_host_cannot_download_stays_an_issue: the row says the gateway will not install the engine on this host and makes no download promise, and one issue says the same.The existing
agent.kas_bundle-on tests keep pinning that route's issues unchanged.Proof: PROVEN test/test_cli_doctor_agent_auth.py::TestDoctorKasBundle::test_a_pin_the_gateway_downloads_on_the_automatic_route_is_not_an_issue[on_disk0], test/test_cli_doctor_agent_auth.py::TestDoctorKasBundle::test_a_pin_the_gateway_downloads_on_the_automatic_route_is_not_an_issue[on_disk1], test/test_cli_doctor_agent_auth.py::TestDoctorKasBundle::test_a_pin_this_host_cannot_download_stays_an_issue[on_disk0], test/test_cli_doctor_agent_auth.py::TestDoctorKasBundle::test_a_pin_this_host_cannot_download_stays_an_issue[on_disk1] (head f672113)
Determinism: the new tests passed 20 runs at
-n0, 10 runs at-n 4 --dist loadgroup --max-worker-restart=2besidetest_cli_doctor_parts.pyandtest_cli_doctor_refactor_report.py, and one shuffled run of the whole file (seed 9572).Manual verification
N/A — unit coverage sufficient: the tests run the real
_doctor_kaswith only the route, the engine probes and the installable check pinned.Screenshots / video
N/A — no frontend change.
Related Issues
Part of #22583
Sibling sweep
Swept: git grep -n "issues.append" -- src/kiro_crew/cli_doctor_parts/kas_relay.py
Sibling: src/kiro_crew/cli_doctor_parts/kas_relay.py:157 -- changed here
Pattern harvest
Not generalizable: each doctor row decides its own normal state from its own probe, so there is no shared shape to lint for.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)