Repository navigation
feat(org-chart): offer show all from the filtered empty state - #31790
Conversation
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. This is a small, reversible fix to the empty state. Show all reuses the All pill's own click path, so filtering logic still lives in one place. Before and after screenshots are attached. [DESIGN-REVIEWED] 1a2372d Description read[DESCRIPTION-READ] a40d1d1eceace0414809674b89c63bb4784c6fbe80cbacf4359f73aeb7597949 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
a3242d2 to
cb82e76
Compare
cb82e76 to
f806fdc
Compare
f806fdc to
f55f62e
Compare
|
Rebased: main moved in test/test_builtin_host_grants.py since this head's CI ran (e4611c5 -> 75e43c83); CI re-running. The previous run's red lanes (the AI review lanes, Sensitive Change Review, Dependency License Gate, Publish readiness) again all failed reading the GitHub API under the CI installation rate limit, not on this change. The diff is byte-identical after the rebase; the org-chart backend tests, the builtin tests whose files moved on main, and the org-chart frontend tests pass locally on the new base. [operator: bolichen97] |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS This adds a single-purpose control that a linked issue asked for (#22291). It reuses the All pill's own click handler and doesn't change any default. What this change shipsInventory (4 items) — 4 justifiedIntent: when an Open/Closed filter on the org chart shows nothing, a reader can get back to All in one click. This is an ADDITION.
[FIRST-PRINCIPLES-REVIEWED] 1a2372d Description read[DESCRIPTION-READ] 414c72bd3ae8a5e8fe4cc017360d493e54b88f71f7387ceebdc582f0ff8767d5 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. The screenshots show every new state, and the blind reader correctly read "Show all" as a switch back to the All filter. Notes
[UX-REVIEWED] 1a2372d Description read[DESCRIPTION-READ] 0598007a6957fc54f3fb6e4071aae87e86d0cbf1be753e05e9b44a18e2615062 That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
|
[operator: bolichen97] The red on this head is one test, |
When the org-chart page's Open or Closed filter has nothing to show, the empty line now ends with a Show all button, in English and Simplified Chinese. It presses the All pill and moves focus there, and keeps its own focus across a host push the way the fold buttons do. Closes #22291
f55f62e to
1a2372d
Compare
|
[operator: bolichen97] Rebased onto main (75e43c83 -> f58c3cf) to pick up #32252, which raised the security package line budget to the package's measured size on main. That budget was the only red here ( |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Approved: PR Readiness passed on 1a2372d, and all five review lanes (Opus 5.5, GPT 6.1, Design, UX, First Principles) report no blocking finding on this head. No conflict and no open change request.
Problem / Motivation
Goal: When the org-chart page's Open or Closed filter has nothing to show, the reader can get back to All in one click.
Picking Open or Closed on the org-chart dashboard page draws a plain line when nothing matches ("No open task to show." / "No closed task to show."). The line states the absence and offers no next step: the reader has to notice the filter pills above it and pick All themselves.
Why it matters
A reader who lands on an empty filtered view sees a dead end. A one-click way back is the usual empty-state pattern, and this page's filter was shipped without one (deferred from #21476).
Not a goal
What changed (motivation → approach → change)
The filtered empty line in
org-chart/template.htmlwas a bare textdiv. It now ends with a Show all button, in English and Simplified Chinese, styled as the filter pills are.Pressing it does exactly what pressing the All pill does, because it clicks that pill, and then moves focus to the pill: the button disappears with the line, so without this a keyboard reader would land on the page body. The page already rebuilds the graph on every host push and puts focus back on a fold button that had it; the Show all button gets the same treatment.
Backwards compatibility
Compatible: the button appears only in the filtered empty state, which had no control before; every other render path draws what it drew on main.
Removes nothing: the change adds a button and a string key; no element, key or behaviour is taken away.
Tests
website/src/test/orgChartFilterPage.test.tsadds two jsdom cases that run the page's real script:offers a way back to All from that line, in English and Simplified Chinese: Open with no open task shows aShow allbutton; pressing it presses All, draws the task, removes the empty line and puts focus on the All pill; underzh-CNthe label is the Chinese one.keeps focus on Show all across a host push: with the button focused, akirocrew-dashboardpush rebuilds it and focus is on the new button.Both fail with the production change reverted (main's template), and the second fails with only the focus-restore line removed. Determinism: each passed 20 repeated runs, and the three org-chart / template-i18n spec files passed in a shuffled order (
--sequence.shuffle --sequence.seed=16191, 123 tests). The backend template suites (test_dashboard_templates_builtin.py,test_dashboard_template_views.py, the sink-ban, motion-guide, redraw and page-text suites) pass unchanged.Manual verification
Rendered the template in headless Chromium with a one-board fixture whose only task is accepted, picked Open, and pressed Show all from the keyboard: the All pill is pressed, holds focus with its focus ring, and the graph and card draw.
Screenshots / video
Before (main): the line alone.
After: the line with a Show all button, English and Simplified Chinese.
After pressing Show all with the keyboard: All is pressed and focused, the board is drawn.
Related Issues
Closes #22291
Follows up on #21476.
Sibling sweep
N/A: a
featPR, not a fix.Pattern harvest
N/A: a
featPR, not a fix.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)