Skip to content

fix(onboarding): hold first run behind kiro sign-in when kas_bundle is on - #31793

Open
dodgeblaster wants to merge 2 commits into
mainfrom
feat/first-run-sign-in
Open

dodgeblaster wants to merge 2 commits into
mainfrom
feat/first-run-sign-in

Conversation

@dodgeblaster

@dodgeblaster dodgeblaster commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: With Kiro Crew's own KAS engine switched on, a new user is held on Kiro sign-in at first run instead of landing in a dashboard whose first chat fails.

With agent.acp_backend: "kas" and agent.kas_bundle: true on a fresh data home, first-run setup opens the dashboard without anyone signed in to Kiro Crew. The first chat then fails with "Your session has expired. KAS runs on Kiro Crew's own engine (agent.kas_bundle is on). Not signed in to Kiro. Sign in from Settings → Agent Harness → Kiro sign-in…" — to someone who never signed in. Reproduced on an isolated pod built from main.

Why it matters

On that route Kiro Crew's own sign-in is the only credential a KAS session can use, so every new user on it hits a failed first chat and a misleading "expired" message before they find the sign-in card in Settings. This is the first step of the first-run sign-in work (no kiro-cli in onboarding).

Not a goal

  • Changing first run when agent.kas_bundle is off, including hosts where KAS takes the bundle route automatically because no working kiro-cli runs there: those keep the kiro-cli install and login steps exactly as today.
  • Restyling the sign-in screen or replacing its four sign-in choices with one button (a follow-up PR, behind the same switch).
  • Finishing a Builder ID or organization sign-in picked on Kiro's own sign-in page; that reply carries no code today and is a separate change.
  • Changing agent.kas_bundle's default.

What changed (motivation → approach → change)

Symptom → cause → change: the first-run gate admits KAS on kiro-cli facts only and never asks whether Kiro Crew holds a sign-in, so the bundle route reached the dashboard signed out. The fix holds the existing full-screen Kiro sign-in in front of the dashboard on that route, and only there.

Piece Change
GET /api/kiro-prerequisite (dashboard/handlers/kiro_prerequisite.py) New crew_sign_in field: true exactly when agent.acp_backend is KAS and agent.kas_bundle is on, read from config. False for a non-owner and for an unreadable config, so it can never lock the dashboard. The owner's repair-specs and update-cli answers carry it too, through one shared payload helper, since the gate caches them as the status.
KiroPrerequisiteGate Every dashboard admission, the LTS relock path included, renders through KasLoginGate with hold={crew_sign_in}. Once the dashboard has opened with the hold off, turning the switch on later in that page load does not hold it, so it is not swapped for the sign-in screen with unsaved work in it; the hold applies from the next load. A failed setup-status read that lets a returning browser in counts as such an opening too (shownUnheld).
KasLoginGate New hold prop. Off, it renders its children straight through and reads no sign-in status. It stays mounted either way, so the dashboard keeps its place in the tree and is not mounted a second time when the status arrives. The hold lasts until the first admission: a later read reporting signed out (a sign-out in another tab or from the CLI) leaves the dashboard and its unsaved work mounted. New escapable prop, set only by the first-run hold, gives two exits that need no sign-in so the owner can still reach Settings to switch the engine off: a "Skip for now" button on the signed-out chooser (disabled while a sign-in request is in flight), and opening the app when the sign-in status cannot be read. Either counts as the admission, so the latch keeps the app mounted. The LTS sign-in-only gate leaves it off and keeps its error screen. useKasLoginFlow takes enabled, so with the hold off no sign-in status is read.
components.kasLogin.skip_for_now The button's label, in every shipped catalog.
api/client/onboarding.ts The optional crew_sign_in field on the status type.
kas-auth.md Records the hold and the switch that decides it.

Keying on the switch rather than on "the vault owns the sign-in" follows the maintainer's ask that both first-run experiences sit behind agent.kas_bundle: off means kiro-cli's experience, whatever route the host takes.

Backwards compatibility

Compatible: with agent.kas_bundle off the gate admits exactly as on main. Since #34164 an undeclared agent.kas_bundle is on in nightly builds, so there the hold applies to every signed-out page load, not only the first run, and "Skip for now" is the way past it, and the new status field is optional, so an older dashboard ignores it and an older gateway's missing field reads as off.

Removes nothing: the diff adds a status field, a component prop and a hold that applies only with the switch on.

Tests

  • test/test_kiro_prerequisite_crew_sign_in.py (new): the field follows the switch for the owner (on, off, and on with a non-KAS backend), ignores what the vault says, is false for a non-owner, and is false when the config cannot be read; the repair-specs and update-cli answers carry it with the switch on and off (all 4 fail with those routes' old payload).
  • website/src/test/KiroPrerequisiteGate.crewSignIn.test.tsx (new): signed out with the switch on, the sign-in screen shows and the dashboard does not; signed in, the dashboard opens and the element rendered before the status loaded is the same one afterwards (no second mount); once admitted, a later signed-out read keeps that same element mounted and shows no chooser (fails with the latch removed); opened with the switch off, a later status turning it on keeps that same element mounted and reads no sign-in status (fails with the hold-off latch removed); after a spec repair whose answer has the switch on, the sign-in screen still shows (fails when that answer omits the field); a sign-in status read that fails opens the dashboard and a later signed-out read keeps it (fails without escapable); "Skip for now" opens the dashboard and a later signed-out read keeps it; the skip is disabled while a sign-in request is in flight; a returning browser let in after a failed setup-status read stays mounted when a later status turns the hold on (fails with the old shownUnheld condition); switch off and non-owner, the dashboard opens and no sign-in status is read.
  • Existing suites green: 305 frontend tests across the gate and sign-in files; 400 backend tests across every test_kiro_prerequisite*.py file.
  • Determinism: the backend file passed 20 consecutive runs; the frontend file passed 3 consecutive runs and a run with --sequence.shuffle.

Proof: not provable -- other: prove.py's throwaway worktree errors at collection from this venv; reverting the handler to origin/main by hand fails 5 of 6 new backend tests, and disabling the hold fails both frontend sign-in tests

Manual verification

On an isolated pod from this branch (fresh data home, agent.acp_backend: "kas", agent.kas_bundle: true):

  • Signed out, reload: the full-screen Kiro sign-in shows and the dashboard does not.
  • Google and GitHub through Kiro's sign-in page, and Kiro Crew's own Builder ID and Company SSO buttons: each signs in, the dashboard opens by itself, and chat works.
  • agent.kas_bundle switched off and the pod restarted, signed out of Kiro Crew: no sign-in screen; the dashboard opens and chat runs through kiro-cli, as on main.

Screenshots / video

The "Skip for now" exit on 3c9d270, rendered from the real gate through the capture/setup-check-probe-error.html harness with fixture API answers (KAS, kas_bundle on, signed out): the chooser with the exit, the exit disabled while a Google sign-in request is in flight, and the dashboard after skipping.

Signed-out sign-in chooser with Skip for now
Skip for now disabled while a sign-in request is in flight
Dashboard rendered after Skip for now

Earlier captures (Nov 6, before the exit existed):
Screenshot 2026-11-06 at 12 12 36 PM
Screenshot 2026-11-06 at 12 13 06 PM
Screenshot 2026-11-06 at 12 13 22 PM
Screenshot 2026-11-06 at 12 13 31 PM

Related Issues

Part of #21843

Sibling sweep

Swept: git grep -n "return <>{children}" -- website/src/components/KiroPrerequisiteGate.tsx
Siblings: none -- every dashboard admission in the gate goes through its one app() helper, which the enterprise relock path now uses too

Pattern harvest

Not generalizable: the gate's KAS admission rule predates the bundle route and asked only kiro-cli facts; the fix is specific to where first run admits KAS.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of f14c98eae9598e1dea96f493379d04a9d2d4f9eb — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: it adds one optional status field and a hold behind an existing switch, with a skip exit, and both are easy to undo.

Notes

[DESIGN-REVIEWED] f14c98e

Description read

[DESCRIPTION-READ] 24d4d5bbbee2a49e98d517a9ebb48f87163da681ad66b26e9642e4e5903ebbc2

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of f14c98eae9598e1dea96f493379d04a9d2d4f9eb — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

On nightly builds, where agent.kas_bundle is on unless declared, this adds a skippable sign-in step to every signed-out page load. No base RFC covers that, but treating it as a default change takes judgement, so it stays a note.

Notes

  • Item 2 — inherited: the PR says "Since feat: default agent.kas_bundle on in nightly builds only #34164 an undeclared agent.kas_bundle is on in nightly builds, so there the hold applies to every signed-out page load." The Goal says "at first run". No base RFC covers a first-run sign-in hold: rfc-kas-own-engine-route.md (implemented) covers routing only, and rfc-crew-oauth-sign-in-redesign.md is draft. "the maintainer's ask" is not on record. Subtraction: narrow crewSignIn to browsers that never finished setup, so the hold matches the frozen Goal.

What this change ships

Inventory (6 items) — 5 justified

Intent: a new user on Kiro Crew's own KAS engine signs in before reaching a dashboard whose first chat would fail. This is a FIX.

  1. With KAS and kas_bundle on, a signed-out owner sees the full-screen Kiro sign-in before the dashboard — justified
  2. On nightly, that hold applies to every signed-out page load, not only first run — inherited; declared, but beyond the Goal's "first run"
  3. A "Skip for now" button on the sign-in chooser, disabled while a sign-in is in flight — justified
  4. If the sign-in status cannot be read, the dashboard opens — justified
  5. Once the dashboard is shown, a later sign-out or a later switch-on does not unmount it — justified
  6. New crew_sign_in field on the setup status and on the repair-specs and update-cli answers; false for a non-owner — justified

[FIRST-PRINCIPLES-REVIEWED] f14c98e

Description read

[DESCRIPTION-READ] ba6a35135779ec78fe801f272e6fc16ab003ec30c7ab56a5b8c538e5704e8c77

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed f14c98eae9598e1dea96f493379d04a9d2d4f9eb — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] f14c98e

Verdict parsed from the review's SHA-scoped output markers for commit f14c98eae9598e1dea96f493379d04a9d2d4f9eb.

False positive or not applicable? A repository writer can comment:
/ai-review override fable f14c98eae9598e1dea96f493379d04a9d2d4f9eb false-positive: <reason, 20 to 500 characters>

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

Backend Tests (3.12, 7) is red on test/test_pull_request_target_allowlist.py::test_only_the_allowed_workflows_use_pull_request_target (sensitive-change-review.yml is not in the allowlist). This PR touches neither the workflows nor that test; the same red is on main and is being fixed in #31803. This PR will rebase onto main once that lands.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of f14c98eae9598e1dea96f493379d04a9d2d4f9eb — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. Screenshots 01 and 02 show "Skip for now" in its normal and disabled states, and the blind reader read it correctly ("the app opens without an account").

Notes

  • "Skip for now" (components.kasLogin.skip_for_now) doesn't say what skipping costs. The reader wrote: "I don't know what I'd lose by skipping." Once skipped, chat fails until the user signs in. Fix: rename it to say so, or add one line next to it: "Chat needs a sign-in — you can sign in later in Settings → Agent Harness."
  • Screenshot 02: the reader said "Nothing on screen says why they are dimmed" and saw no spinner. Fix: while a sign-in request is running, show a pending indicator on the provider the user picked. Then the disabled "Skip for now" makes sense next to it.

[UX-REVIEWED] f14c98e

Description read

[DESCRIPTION-READ] 435a8e1117654b1693bbed7c4a97366337e055e7b674fa0e5bde234afbe413f1

That sha256 names everything this verdict read: the PR description, plus the 10 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of f14c98eae9598e1dea96f493379d04a9d2d4f9eb and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] f14c98e

False positive or not applicable? A repository writer can comment:
/ai-review override gpt f14c98eae9598e1dea96f493379d04a9d2d4f9eb false-positive: <reason, 20 to 500 characters>

@dodgeblaster
dodgeblaster force-pushed the feat/first-run-sign-in branch from 96f0351 to ab45acb Compare November 6, 2026 21:38
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 6, 2026
@dodgeblaster
dodgeblaster force-pushed the feat/first-run-sign-in branch from ab45acb to 85ae55a Compare November 6, 2026 23:05
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in .github/workflows and test/test_pull_request_target_allowlist.py (the red-main fix #31803) since this head went green (ea5dedb -> e94281a); CI re-running. This also re-runs the five AI review lanes, which produced no verdict on ab45acb because the shared token hit GitHub's rate limit.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

self-added: yes
mechanism: KasLoginGate hold latches on first admission

  • span=d458296012d0 Preserve dashboard drafts after Kiro sign-out

fixed in ab45acb: the full-screen gate holds the app only until its first admission in a page load; a later status read reporting signed out (another tab, the CLI) keeps the dashboard and its unsaved work mounted instead of rendering the chooser.
The way back in is the chat's existing sign-in error row and the Settings card; the embedded card (renderAuthenticated) never latches, so its own signed-out chooser is unchanged.
Regression test: KiroPrerequisiteGate.crewSignIn.test.tsx "keeps the admitted dashboard mounted when a later read says signed out" asserts the same element survives a signed-out read; it fails with the latch removed.
Repair made in the parent session rather than a model-pinned delegate, at the author's standing preference for small changes; verified by the revert-proof above, 317 related frontend tests, tsc and eslint.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 7, 2026
@dodgeblaster
dodgeblaster force-pushed the feat/first-run-sign-in branch from 85ae55a to 28d8651 Compare November 7, 2026 09:20
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/system-specs/modules/ (same directory as kas-auth.md; no file this PR changes was touched) since this head went green (e94281a -> e30915e); CI re-running. Head 85ae55a -> 28d8651, related backend and frontend tests, tsc and eslint green locally.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

Backend Tests (3.12, 2) is red on test/test_security_gate_liveness.py::test_the_package_stays_within_its_line_budget (package grew to 34855 lines). That is main's red, not this PR's: this PR touches nothing under the security package, and #32183 (auto-merge on) raises the budget to main's measured size. Waiting for it to merge, then rebasing onto it.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 7, 2026
@dodgeblaster
dodgeblaster force-pushed the feat/first-run-sign-in branch from 28d8651 to 64a0e4c Compare November 7, 2026 11:26
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in test/test_security_gate_liveness.py (#32252 raised the security package line budget, superseding #32183) since this head went red on main's budget test (e30915e -> bab2387); CI re-running. Head 28d8651 -> 64a0e4c; the budget test, this PR's backend and frontend tests, tsc and eslint pass locally.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 7, 2026
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 8, 2026
@dodgeblaster
dodgeblaster force-pushed the feat/first-run-sign-in branch from 64a0e4c to f8164aa Compare November 9, 2026 16:05
@github-actions github-actions Bot removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 9, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 19, 2026
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

@bolichen97 the exit you asked for is in 473805e: the held sign-in screen now has a "Skip for now" button that renders the app for that page load and counts as the admission, so the latch keeps it mounted. Covered by lets the owner skip the sign-in, and keeps the dashboard open afterwards in KiroPrerequisiteGate.crewSignIn.test.tsx. ebca523 disables it while a sign-in request is in flight. Could you take another look?

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the skip exit. The code looks sound, but one item blocks this head.

  1. Missing screenshots for the new exit (website/src/components/KasLoginGate.tsx:601-609). This head adds a Skip for now button to the full-screen sign-in chooser. KiroPrerequisiteGate.tsx:1263 passes escapable on every hold, so a signed-out owner sees this button on every page load. The four screenshots in the body are dated Nov 6. They were taken before the button existed. As a result, the Design and UX lanes on c7016b3 both report "cannot evaluate" for this button. Their verdicts were recorded as PASS only because of formatting, so nobody has seen the new control rendered. Smallest fix: take screenshots on c7016b3 and attach them. Show the signed-out chooser with Skip for now visible, the button disabled while a sign-in request is in flight, and the dashboard after a skip. Then re-run the Design and UX lanes.

The earlier change request about the form having no skip action is also still open. Please reply in that thread and name the commit that adds the exit, so it can be re-reviewed on this head.

Optional:

  • The description lags the diff. The KasLoginGate row and the test plan name an openOnStatusError prop that is not in the code (the code ships escapable). They also leave out the skip button, its two tests, and the shownUnheld latch. A body edit fixes this. Please leave Goal, Why it matters and Not a goal unchanged.
  • The Backwards compatibility claim "kas_bundle off (the default)" is out of date. Since #34164, an undeclared agent.kas_bundle is on by default for nightly builds. The hold also applies to every signed-out load, not only the first run.
  • The branch has three commits. The contributing rules allow at most two, so please squash the two follow-up fixes on the next push.

@dodgeblaster
dodgeblaster force-pushed the feat/first-run-sign-in branch from c7016b3 to 3c9d270 Compare November 19, 2026 23:20
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

Addressed on 3c9d270: new screenshots of the Skip for now exit are in the description (chooser with the exit, the exit disabled while a sign-in request is in flight, the dashboard after a skip). The description's KasLoginGate row and test plan now name escapable, the skip button, its tests and the shownUnheld latch, and Backwards compatibility notes the nightly default from #34164; Goal, Why it matters and Not a goal are unchanged. The two follow-up fixes are squashed into one commit (tree unchanged). @bolichen97's exit is in 473805e, as noted above.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: passed Eligible automated validation passed for the current revision readiness: checking Automated validation is still running labels Nov 19, 2026
@KiroCrewCaptain

KiroCrewCaptain commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: A person should decide

Why: the decider thinks the change is probably fine but estimates a 17% chance that this change introduces a defect, above the 12% limit for approving on its own.

The PR adds a crew_sign_in status field. It is true only for the owner, and only when acp_backend is KAS and kas_bundle resolves on; a non-owner or an unreadable config gets false. All three owner routes build it through one shared helper. Every dashboard admission now goes through KasLoginGate with hold set from that field. I checked that every pass-through path keeps the dashboard in the same slot of the same wrapper, and that all hooks run before any early return, so it does not mount twice. The latches work as described: an admitted dashboard survives a later sign-out, and a dashboard opened with the hold off survives the switch turning on. The escape exits (Skip, unreadable status) are limited to the first-run gate, and the enterprise sign-in-only gate is unchanged in effect. With the hold off, the sign-in status query is disabled. The new backend and frontend tests cover each path. The every-page-load hold on nightly is disclosed and skippable, so it is a note, not a blocker.

Tier: 2, held for a person: changes requested.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit f14c98eae9 · 680 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

Follow-up on my change request for c7016b3. Every item from it is resolved on 3c9d270:

  • Screenshots of the new exit: fixed. The description shows three screenshots taken on 3c9d270: the chooser with "Skip for now", the button disabled while a sign-in request is in flight, and the dashboard after a skip.
  • A reply naming the commit that adds the exit: fixed. The author's comment names 473805e and the test that covers it.
  • Optional items: fixed. The description now names escapable, the skip button and the shownUnheld latch. Backwards compatibility mentions the nightly default from feat: default agent.kas_bundle on in nightly builds only #34164. The branch has two commits.

What this review checked on this head:

  • The owner-only crew_sign_in field is true only for the KAS backend with kas_bundle on. It is false for a non-owner and for an unreadable config.
  • The status GET and both remedy POSTs build their answer through one helper, so no cache write drops the field.
  • Every pass-through keeps the app in the same tree slot, and the two latches keep it mounted after a later sign-out or a mid-load switch change.
  • PR Readiness is green and the AI review lanes pass on this head.

One step remains: @bolichen97's change request on e5161ec is still open. It asked for an exit that works without signing in. The "Skip for now" button in 473805e provides that exit, and a test covers it. Could you re-review on this head?

Optional:

  • Two lines in the description no longer match the code. The Proof line still says "5 of 6 new backend tests" and "both frontend sign-in tests", but the head has 9 backend items and 11 frontend tests. The "Removes nothing" line also skips one change: a signed-out owner on the bundle route now reaches the dashboard only through "Skip for now" on every page load. One Reader line would cover it.
  • In KiroPrerequisiteGate.crewSignIn.test.tsx, the no-remount test and the two absence-only tests ("kiro-cli owns the sign-in" and "never holds a non-owner") do not call notifySynchronously() first. A pending render can satisfy their assertions. Calling it at the start, as tests 7 and 8 already do, makes them prove the resolved status rendered.
  • The admitted latch in KasLoginGate.tsx also applies to the LTS sign-in-only gate. That is harmless there because that gateway exits after a sign-in, but kas-auth.md does not say so. One sentence in the doc, or limiting the latch to escapable mounts, would close the gap.

@KiroCrewCaptain
KiroCrewCaptain dismissed their stale review November 20, 2026 01:24

Withdrawn: every item in this review is fixed or answered on the current head (see the follow-up comment). Other holds on this PR are listed there.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: passed Eligible automated validation passed for the current revision readiness: checking Automated validation is still running labels Nov 20, 2026
gjjnn and others added 2 commits November 20, 2026 19:38
Skip for now is disabled while a sign-in begin is in flight, so its answer cannot start a session nobody watches or drop a refusal's notice. A returning browser let in after a failed setup-status read now latches the unheld app, so a later poll that turns the hold on does not replace it. Two tests notify observers synchronously so a render from the first read cannot land after the second.
@dodgeblaster
dodgeblaster force-pushed the feat/first-run-sign-in branch from 3c9d270 to f14c98e Compare November 20, 2026 19:40
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 20, 2026
@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

Follow-up on my earlier change request on c7016b3. Status of each item on this head:

  • Screenshots of the Skip exit: fixed. The description shows the chooser with "Skip for now", the button disabled while a sign-in request is in flight, and the dashboard after a skip. The UX lane read them and passed on this head.
  • Reply naming the commit that adds the exit: fixed. The author's comment names 473805e and the test that covers it.
  • Description lag, the Backwards compatibility wording and the commit count: fixed. The branch now has two commits.

What still holds this PR: @bolichen97's change request on e5161ec is still the latest review from that account. The exit it asked for is in this head. "Skip for now" works without a sign-in, counts as the admission for that page load, and keeps the app mounted. The test "lets the owner skip the sign-in, and keeps the dashboard open afterwards" covers it. Only a re-review from that account can clear it.

One question for the maintainer to decide on that re-review. The hold has no first-run condition: crewSignIn in KiroPrerequisiteGate.tsx:1342 depends only on crew_sign_in, setup_allowed and the LTS state. On nightly, where an undeclared agent.kas_bundle is on, a returning owner who is signed out sees the full-screen chooser on every page load. The Goal says "at first run", and the maintainer decision on #32058 says "First run only: a returning user whose sign-in lapses keeps today's path". If first run only should apply here too, the smallest change is to capture !rememberedSetupComplete() once at mount and AND it into crewSignIn.

Review result on this head: no blocking findings. The new backend test file passes at this head (9 items), and all 9 fail when the handler is reverted to its merge-base version. The owner-only field is false for a non-owner and for an unreadable config. One helper builds the status GET and both remedy POST answers. Every pass-through keeps the app in the same tree slot. Done well: each latch has a test that checks element identity across a later signed-out read, so a remount would fail the test.

Optional:

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants