Repository navigation
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. A maintainer-recorded decision supersedes the old routing, the refusal fires only when kiro-cli lists its engines and v2 is not among them, and the Bot-pin break is listed and accepted. Notes
[DESIGN-REVIEWED] d505d2c Description read[DESCRIPTION-READ] 389c6d6205a99b31925d50e517fa6137ce02de183c4106eeb2e6cba07ceb8ba1 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — 🔴 BLOCKPremise-level review of First-Principles-Verdict: BLOCK Product-shape change without accepted RFC: a stored Kiro CLI pick no longer runs on KAS, sessions on a kiro-cli without v2 are now refused, and the KAS callout and bell note are removed. No RFC on the base commit records this. Notes
What this change shipsInventory (8 items) — 5 justifiedIntent: someone who picks Kiro CLI gets V2 and someone who picks KAS gets V3, with no hidden rerouting. This is an ADDITION (a changed default plus a new refusal).
Blockersproduct-shape change without accepted RFC: what a Kiro CLI pick runs, and the new refusal — product shape [FIRST-PRINCIPLES-REVIEWED] d505d2c Description read[DESCRIPTION-READ] 28662f58223048229ba82048c1ebe27a8cbeb3ef69f3996c3a99e646aee0e52e That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. The blind reader understood the "Use Kiro Agent" fix and said they would click it, and all three new states appear in the screenshots. Notes
[UX-REVIEWED] d505d2c Description read[DESCRIPTION-READ] ed6b585f176e9abc0d31a09937f5a1af34873c2418758d732f599ba028245611 That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — 🔴 changes requested (blocking)GPT 6.1 found at least one blocking issue that must be resolved before merging This comment is updated in place on each push. BLOCKING -- docs/decisions/2026-11-06-kiro-cli-runs-v2-and-kas-runs-v3.md:5 -- Superseding the routing decision requires a maintainer override
[BLOCK-MERGE] d505d2c Adjudication (Opus 5.5) — is blocking on each finding proportionate?F1 (fenced): False positive or not applicable? A repository writer can comment: |
43ee2fe to
6e2bab8
Compare
|
|
|
6e2bab8 to
64a6044
Compare
A Kiro CLI choice always launches kiro-cli acp --agent-engine v2 and never moves onto the KAS path; KAS runs v3 as before. A kiro-cli that lists engines without v2 refuses Kiro CLI sessions with the KAS fix named, and Settings and doctor say the same. Settings names each Kiro harness's engine. Supersedes the 2026-10-28 decision.
64a6044 to
d505d2c
Compare
|
Closing per the maintainer's decision: the Kiro CLI harness choice keeps running on Crew's KAS path (customAgents over the wire) rather than native CLI v2, so this direction is not being pursued. |
Problem / Motivation
Goal: Picking Kiro CLI always runs kiro-cli's V2 engine and picking KAS runs V3, with Settings saying which is which and a clear notice where V2 is gone.
A stored Kiro CLI choice (
agent.acp_backend: "kiro") moved onto Kiro Crew's KAS path whenever the gateway's probe found kiro-cli's v3 engine, so a person who picked Kiro CLI could be running V3 without choosing it. The team decided on 2026-11-06 that each choice means one engine: Kiro CLI is V2, KAS is V3.Why it matters
People pick a harness to get a specific engine. Hidden rerouting made "Kiro CLI" mean V3 on most hosts and gave them no way back to V2 from the UI. kiro-cli supports V2 until the end of January, so a Kiro CLI choice needs to keep working on V2 until then and fail clearly after.
Not a goal
What changed (motivation → approach → change)
Reported symptom: with Kiro CLI selected, sessions ran on KAS, which does not read an agent's
toolsSettings, so the agent's allowed shell commands and write paths stopped applying and every shell command asked for approval. Users said it worked before the update.kiro-cli acp --agent-engine v2(V2)acp, so V3 under the V2 harness, silentlykiro_cli.kiro_acp_engine_argsraisesKiroAcpV2Unavailablewhen the pinned kiro-cli lists--agent-enginevalues withoutv2; both launch sites turn it into the session's start error. An older kiro-cli with no engine selector, a PATH-only kiro-cli, or a probe that could not run keep the bare launch, as today.kiro-cli acp, which kiro-cli 3.x serves on v3 while Crew drives it as the v2 harness (skill-view aliases, thecli.jsonoverlay, re-filtered specs). Refusing with the fix named is the least surprising outcome and switches nothing behind the user's back.GET /api/acp-backendscarrieskiro_cli_v2_missing, read throughagent_sdk.kiro_cli_v2_missing).docs/decisions/2026-11-06-kiro-cli-runs-v2-and-kas-runs-v3.mdsupersedes the 2026-10-28 entry; specs (harness-parity H1/H17, config, acp-client, slack-gateway, crew-mode) and user docs (configuration, coming-from-kiro-cli) updated.builder-security checked:
GET /api/acp-backendsgains one read-only boolean on the existing owner-only route; no listener, bind, auth or route change.Backwards compatibility
Breaking: a stored
agent.acp_backend: "kiro"on a v3 kiro-cli now runs V2 instead of KAS. That is the decision; users who want V3 pick Kiro Agent. A Bot pinned tokironow starts kiro-cli, as such a pin already did on any host where kiro-cli had no confirmed v3:kirois no longer offered as a Bot pin, and a stored one cannot open its own workers until the Bot's harness is changed. Whether a stored Botkiropin should instead run on KAS is open for the maintainer.Reader: website/src/pages/developer/AgentBackendTab.tsx:kiroPickRunsOnKas -- crew page -- removed with the callout it drove; the panel reads
kiro_cli_v2_missinginstead (AgentBackendTab.engineHints.test.tsx)Reader: src/kiro_crew/kiro_on_kas_notice.py:schedule -- release -- removed with its bell note; nothing else imported it
Reader: src/kiro_crew/cli_chat.py:_chat -- chat -- loads the stored pick as Kiro CLI without a probe (
test_a_stored_kiro_pick_runs_kiro_cli_in_cli_chat)Reader: src/kiro_crew/crewmate_harness.py:CrewBackendPin.resolve -- crew page -- a
kiropin resolves to Kiro CLI (TestAKiroPin::test_a_kiro_pin_keeps_the_kiro_cli_launch)Tests
test/test_kiro_acp_engine_pin.py::test_a_kiro_cli_pick_launches_its_agent_on_v2_with_tools_settings_intact: Kiro CLI selected while KAS is selectable loads as Kiro CLI, launches--agent-engine v2 --agent <name>, and the skill view it launches under keeps the agent'stoolsSettings(allowedCommands,allowedPaths) unchanged. Fails when the pick is routed back to KAS.test/test_kiro_acp_engine_pin.py: a kiro-cli whose engine list lacks v2 raises with the KAS fix, and the Kiro harness launch refuses with that text; no selector stays bare; unknown is not "missing".test/test_acp_backend_kas.py::TestAKiroCliPickRunsKiroCli: a stored Kiro CLI pick loads and builds a Kiro CLI provider while KAS is selectable, on the bundle route, and under a KAS denial.test/test_cli_chat.py:kirocrew chatruns a stored Kiro CLI pick on Kiro CLI and spends no v3 probe.test/test_cli_doctor_agent_auth.py::TestDoctorKiroCliPick: the no-v2 row and issue, quiet otherwise.test/test_crewmate_harness.py: akiropin keeps the Kiro CLI launch and is not offered.website/src/test/AgentBackendTab.engineHints.test.tsx: the engine lines beside Kiro CLI and Kiro Agent only, the no-V2 notice and its one-click switch, and no engine line in first-run setup.return [], both refusal tests fail; with a stored Kiro CLI pick routed back to KAS in the loader, all threeTestAKiroCliPickRunsKiroClirouting tests fail.Run locally, one process, no
-n: the backend files above plustest_kas_cli_floor,test_kas_withheld_credentials_notice, the doctor facade/parts tests,test_enterprise_harness_floor,test_kas_permissions,test_harness_parity,test_flake_pattern_ratchet,test_gateway_process_entry,test_kas_route: 1303 passed; 2 failures are host-dependent (a~/.mcp.jsonon this host trips the Copilot launch test, and a configured dashboard port) and touch no changed code. Frontend:tsc, and vitest over the Agent Harness, first-run setup, i18n and settings-registry tests: 3254 passed.Manual verification
Captured Settings → Agent Harness in the three states above against fixture responses, and read each frame.
Screenshots / video
Settings → Agent Harness, fixture-backed capture:
Kiro CLI in use:
Kiro Agent in use:
Kiro CLI on a kiro-cli without V2:
Related Issues
Supersedes the routing from #25350. Overlaps #30683 (the v3 probe for a Kiro CLI pick), which this change makes unnecessary.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.