Skip to content

fix: backport eight user-reported fixes to 0.12.1 (batch 22) - #31987

Merged
buluoray merged 8 commits into
release/0.12.0from
crew/slack/0.12.1-batch-22
Nov 7, 2026
Merged

buluoray merged 8 commits into
release/0.12.0from
crew/slack/0.12.1-batch-22

Conversation

@buluoray

@buluoray buluoray commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Bring eight small fixes for user-reported issues that merged on main after v0.12.0 onto release/0.12.0, one commit per fix, so the 0.12.1 patch ships them and each one can be reverted alone.

Why it matters

PR Reported in What a 0.12.0 user sees today
#31346 #25649 (aeeaeeaeea) On the default memory tier, a Chinese request matches no Chinese lesson, so its findings stay withheld.
#31390 #24616 (cruisercohen) A cron run that lost only some tool calls to the security gate shows "Partial" in the job list but "Error" in Executions and Logs.
#31282 #26862 (billygerhard) The edit-person dialog can drop a chosen picture when Save lands just as the picture finishes loading.
#31347 #25592 (RohanK6) Vector Memory's semantic-entry form shows English error text for its coded refusals in every language.
#31515 #29279 (tim-finnigan) Dictation can end with a stray "you" or "Thank you" after a pause, which submit-on-release sends to the agent.
#31531 #27868 (jongaffen) Papyrus accepts project names Windows cannot keep as a folder (draft., nul).
#31541 #27836 (jongaffen) On platforms other than Linux and macOS, the webapp preview card loses the live-deployment iframe as well as the local preview.
#31329 #26367 (mbriones98) An SSH login refusal is not recognised when the server lists its auth methods in another order, so three diagnostics miss it.

Not a goal

  • No fix that is not already merged on main; nothing is changed only here.
  • No version bump, no tag, no CHANGELOG.md change. Cutting v0.12.1-rc.N and the bare tag follow docs/build/release.md and stay with the maintainers.
  • No pick that touches auth, the sandbox, the hook or permission gate, credential handling, or shared boot or session paths.

What changed (motivation → approach → change)

Each main squash commit was cherry-picked with -x onto release/0.12.0 @ 84a49d097b, one commit each, keeping its original author. The order is merge order except #31329, which was applied last; it touches no file the other picks touch.

# PR main commit release commit Pick
1 #31346 split unspaced CJK runs on the vector lesson read paths c6251c02bc 2e14c5403b clean
2 #31390 show a partly blocked run as partial in the run history 81d3fe3e60 2029d71a27 clean
3 #31282 person edit Save sends the picture it just finished reading 58a121336f 08aa85191d clean
4 #31347 name coded semantic-write refusals in the reader's language 38c0dc5e1e 1548e28b26 clean
5 #31515 stop dictation ending with a stray "you" after a pause cd8f6d9005 0ed028e372 clean
6 #31531 refuse Papyrus project names Windows cannot keep as a folder bf9e89ed0c f9a63669b4 clean
7 #31541 keep the remote preview fallback where the local copy is off 20c71e235e e2d4f71b78 clean
8 #31329 recognise an SSH refusal in any auth method order 07ab5da194 849e2f0769 clean

No hunk was resolved by hand. Every pick's added and removed lines are identical to its main commit. #31531 and #31329 edit the built-in Papyrus and md_notebook apps in place, which AGENTS.md allows until they move out. #31329 changes how an SSH error message is matched for diagnostics; it changes no credential or login handling.

builder-security checked: #31541 edits the webapp_preview handler. It changes no bind, route or auth check. On platforms other than Linux and macOS the local file route still serves nothing; the mint now answers a regular miss there, carrying remote_framable and writing the same denied audit as every other miss, and a caller that is not direct-local still triggers no framability probe. No other pick changes a listener, an ingress rule or a storage grant.

Backwards compatibility

Compatible: each change is the one already merged on main, and each PR's own compatibility note applies unchanged. Papyrus refuses a project name ending in . or naming a Windows device.

Removes nothing: no pick hides, deletes or renames anything 0.12.0 accepts.

Tests

Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs

  • CI does not run the backend suite on PRs into release/*, so the related set was run here: every touched test file plus every test file that imports a touched module, 21 files, one pytest process per batch of 20, -n 0. 1289 passed, none failed.
  • Frontend: every touched test file plus every src/i18n/*.test.ts* catalog test, 59 files, 1179 passed.
  • flake8 passes on the changed Python files.

Manual verification

N/A - every pick was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.

Screenshots / video

Why no screenshot: each frontend change here is applied from main unchanged; its look is reviewed on its own PR, not here.

Related Issues

Backport to the 0.12 line for 0.12.1 of #31346, #31390, #31282, #31347, #31515, #31531, #31541 and #31329. Source issues: #25649, #24616, #26862, #25592, #29279, #27868, #27836, #26367.

Sibling sweep

Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.

Pattern harvest

Not generalizable: this PR only carries fixes already on main. Each source PR has its own harvest.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

…#31346)

The vector store's lesson ranking, findings admission and per-turn
lessons split text on \w+, which keeps an unspaced Chinese sentence as
one token, so a Chinese request shared nothing with a Chinese lesson on
the default memory tier and its findings stayed withheld.

Those read paths now add, on the request and the lesson side, the
non-CJK pieces and two-character pairs split_cjk_word already gives the
JSONL path. Latin text tokenizes as before, and lesson_keywords (the
dedup's overlap) still keeps a CJK run whole.

(cherry picked from commit c6251c0)
#31390)

A cron run that lost some, not all, of its tool calls to the security
gate shows "Partial" in the Schedule page's job list, but the
Executions tab and the job's Logs tab showed the same run as "Error".
The history keeps status "failure" for it on purpose, so both views now
read the refusal from the run's error, the same reason the job row
reads, and show the same Partial badge.

Closes #24616

(cherry picked from commit 81d3fe3)
)

The edit-person dialog could drop a chosen picture when Save landed in
the instant the picture read finished. Two stale views caused it:

- The save mutation read the name and picture from its render, and
  useMutation hands a new mutationFn to its observer only in a passive
  effect. A Save between the commit that enables it and that effect
  sent the form from before the picture.
- An Enter in the name field after the read's promise ended but before
  React rendered it ran the old submit, which saw the read as done and
  saved without the picture.

The form now rides on mutate(), and a submit from a render that still
shows the read is ignored. The first is the race behind the
intermittent PeoplePanel test failure on a loaded shard.

Closes #26862

(cherry picked from commit 58a1213)
)

Adding or editing a semantic entry on the Vector Memory card, and the
global fact form in the memory editor, showed the English error prose of
PUT /api/memory/semantic for its coded refusals. owner_only and
store_unavailable now read from the catalog in every language; any other
refusal keeps its prose.

Closes #25592

(cherry picked from commit 38c0dc5)
Room tone left after a pause in a streaming dictation is loud enough to
pass the digital-silence check, so the trailing utterance is decoded and
whisper turns it into a lone "you" or "Thank you", which lands in the
composer and, with submit-on-release, goes straight to the agent.

A later utterance whose detector never latched speech and whose whole
final is one of those two fillers now yields an empty final. Any other
text is kept, because a short word after a noise-gated pause can also
fail to latch the detector; a session's first utterance and a filler the
detector heard spoken are kept too.

Closes #29279

(cherry picked from commit cd8f6d9)
…31531)

Papyrus accepted a project name ending in '.' and a Windows device name
such as 'nul'. On Windows the first is created, listed and opened under
another name ('draft.' becomes 'draft'), and the second answers 409
"project already exists" because the device exists in every folder.

Create and clone now refuse both on every platform, before the
"already exists" check, with a JSON 400 coded unportable_project_name,
using the shared WINDOWS_DEVICE_STEMS set. Opening an existing project
is unchanged.

Closes #27868

(cherry picked from commit bf9e89e)
…1541)

On a platform where the webapp preview's local copy is not served
(anything but Linux and macOS), the mint endpoint answered
{"available": false} without remote_framable, so the card lost the
live-deployment iframe as well as the local preview.

The platform gate now makes the mint a regular miss after the
direct-local check, so it carries remote_framable and writes the same
denied audit as every other miss, and a caller that is not direct-local
still triggers no framability probe. The local file route stays off
on those platforms.

(cherry picked from commit 20c71e2)
Three diagnostics matched an SSH login refusal only as the fixed text
"Permission denied (publickey". OpenSSH prints the server's auth
methods in the server's own order, so a server answering
"Permission denied (keyboard-interactive,publickey)." got none of
them: the notes app dropped the cause line from its git error, the
prepare-pr push probe gave the fork remedy instead of the credential
one, and the base fetch hint said "permission denied" instead of
"run ssh-add".

Each now accepts any parenthesized, comma-separated list of method
names closed by ")", the rule the app-install clone classifier got in
#26371. A local file error's bare "Permission denied" carries no such
list, so it still does not match. The two prepare-pr scripts share one
pattern, since preflight already imports from push_guard.

Closes #26367

(cherry picked from commit 07ab5da)
@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 7, 2026 02:10
@buluoray
buluoray requested review from tim-finnigan and removed request for a team November 7, 2026 02:10
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 849e2f07690ea7b0b9c8fd11bd6bb79acea9643e — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

This backports eight fixes that are already merged on main. Each one has a linked user report, and none adds surface beyond its own fix.

What this change ships

Inventory (8 items) — 8 justified

Intent: ship eight user-reported fixes from main to 0.12.x users in the 0.12.1 patch. FIX.

  1. Chinese requests now match Chinese lessons on the default memory tier (bug(memory): CJK and mixed Chinese/English queries miss lesson lexical admission and ranking #25649) — justified
  2. A cron run where only some tool calls were blocked now shows "Partial" in Executions and Logs, matching the job list (Schedule Executions tab shows "Error" for a cron run when one tool call is blocked by the security gate #24616) — justified
  3. The edit-person Save keeps a picture that finished loading just as Save was pressed (Flaky: PeoplePanel.test.tsx 'waits for a chosen picture to finish reading before Save can send it' submits before the picture change is processed on a loaded shard #26862) — justified
  4. Vector Memory's semantic-write refusals now show in the reader's language, with two new catalog keys (fix(dashboard): Vector Memory card shows English for coded semantic-write refusals #25592) — justified
  5. Dictation no longer ends with a stray "you" or "Thank you" after a pause (Dictation often ends with a stray "you" after releasing the dictation key (local Whisper) #29279) — justified
  6. Papyrus refuses project names Windows cannot keep as a folder (Papyrus: a project name ending in '.' or named 'nul' does not round-trip on Windows, the name gate has no trailing-dot or device-name check #27868) — justified
  7. On platforms other than Linux and macOS, the preview card keeps its remote-deployment iframe; the rewritten test keeps the pin's stated aim, "so the FE uses the remote fallback" (dashboard: webapp preview is off on Windows behind a stale _PLATFORM_SUPPORTED gate, which also drops the remote_framable fallback #27836) — justified
  8. An SSH refusal is recognised whatever order the server lists its auth methods in, at all three diagnostic sites (Three more SSH refusal matchers require publickey to be listed first #26367) — justified

[FIRST-PRINCIPLES-REVIEWED] 849e2f0

Description read

[DESCRIPTION-READ] d6049271839d603f619205aed59ae8a9675257c832400df7c30f0e0eb2dc9a6e

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of 849e2f07690ea7b0b9c8fd11bd6bb79acea9643e — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing screenshots of the "Partial" badge (Executions and Logs) and the two new Vector Memory error messages. The PR attaches no image, so the blind read was not performed.

Evidence gaps

  • "Partial" badge in ExecutionsView.tsx and LogEntry.tsx. This is a new warn-variant badge for a cron run that was partly blocked. It replaces "Error" and has a hover title made of partial_hint plus the raw e.error. No image shows it. To close: attach a screenshot of a partly blocked run in Executions and in Logs, with the tooltip open, next to the existing "Partial" in the job list.
  • Vector Memory semantic-entry errors. The new strings are semantic_err_owner_only ("Only the dashboard owner can change memory entries.") and semantic_err_store_unavailable ("Memory is not available, so nothing was changed: {{error}}"). They show in the add-entry error notice, the edit-entry error notice and MemoryRecordsEditor's ErrorNotice. No image shows any of them. To close: attach a screenshot of each message rendered in the card, including one in a non-English locale.

Notes

  • The "Partial" tooltip ends with the raw e.error string, which can surface server text the user can't parse. Check it in the screenshot and trim it if it reads as a code.

[UX-REVIEWED] 849e2f0

Description read

[DESCRIPTION-READ] f6e7ba846008899a490b8cc2b470530964dac738b52eae7bdeebb965e89c1979

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 849e2f07690ea7b0b9c8fd11bd6bb79acea9643e — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: these are eight clean cherry-picks of fixes already merged on main, each in its own commit so it can be reverted alone, and none touches auth, the sandbox, credentials or the boot and session paths.

Notes

  • The compatibility section says both "Removes nothing" and "Papyrus refuses a project name ending in . or naming a Windows device". That second line describes a validator that now refuses names it used to accept. No reader breaks, because store.is_unportable_project_name only runs when a project is created or cloned and opening an existing project is unchanged. Still, the section should name that take-away rather than claim none.

[DESIGN-REVIEWED] 849e2f0

Description read

[DESCRIPTION-READ] 1205b103909621a723a12243c1c630328f326a26a330b917298ac83715f1fbb4

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 849e2f07690ea7b0b9c8fd11bd6bb79acea9643e — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 849e2f0

Verdict parsed from the review's SHA-scoped output markers for commit 849e2f07690ea7b0b9c8fd11bd6bb79acea9643e.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 849e2f07690ea7b0b9c8fd11bd6bb79acea9643e false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ human override accepted

Human judgment by @buluoray overrides the GPT 6.1 finding for 849e2f07690ea7b0b9c8fd11bd6bb79acea9643e; the recorded reason is authoritative for this commit.

[GPT-OVERRIDE] 849e2f0

This comment is updated in place on each push.

The model was not re-run because an authorized human decision supersedes it.

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 849e2f07690ea7b0b9c8fd11bd6bb79acea9643e false-positive: <reason, 20 to 500 characters>

@buluoray

buluoray commented Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

/ai-review override gpt 849e2f0 not-applicable: backport of #31390 unchanged; main ships the identical ExecutionsView.tsx:108 and LogEntry.tsx:45 badge tooltip and GPT passed it on main (5dce627). Moving the refusal into ErrorNotice is new release-only code.

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Human judgment recorded

@buluoray recorded a not-applicable release (class not-applicable) for the gpt AI finding on 849e2f07690ea7b0b9c8fd11bd6bb79acea9643e.

backport of #31390 unchanged; main ships the identical ExecutionsView.tsx:108 and LogEntry.tsx:45 badge tooltip and GPT passed it on main (5dce627). Moving the refusal into ErrorNotice is new release-only code.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Nov 7, 2026
@buluoray
buluoray merged commit 2195e01 into release/0.12.0 Nov 7, 2026
20 of 29 checks passed
@buluoray
buluoray deleted the crew/slack/0.12.1-batch-22 branch November 7, 2026 04:53
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants