Repository navigation
feat(chat): show Fork as a reply row button whenever it can run at once - #32013
Pearcekieser wants to merge 1 commit into
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the screenshots were downloaded, the change is a reversible placement change in one component, and Fork's place now follows things the reader can see rather than whether a reply has Notes
[DESIGN-REVIEWED] d8c178f Description read[DESCRIPTION-READ] 5c2de32522a7dc3b26dc02ca74dc1ee60d63bc08b689c749d71a61309e924942 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. Fork's place now depends on whether the fork can run and on the Tail-only Fork setting, not on whether the reply has a message id, so the cause is fixed. The one weak point is Quote losing its row seat on every older reply. Notes
What this change shipsInventory (8 items) — 7 justifiedIntent: fork a long thread from any finished reply in one click. This is an ADDITION (a placement change).
[FIRST-PRINCIPLES-REVIEWED] d8c178f Description read[DESCRIPTION-READ] b2c2c957fcbc9526c006071c7389c7c43bf55fffb408580846b1c8587ad16011 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — 🔴 BLOCKUX-level review of UX-Verdict: BLOCK The new Fork row button is an unlabelled branch glyph that a first-time reader could not identify and would not click. That button is the whole point of this PR. BlockersFork row button is not understood and the reader would not use it Notes
[UX-REVIEWED] d8c178f Description read[DESCRIPTION-READ] 157c7e3bce44b128eca7412ff8b1f7e99da4213e3d3f997f762aeb5b54689715 That sha256 names everything this verdict read: the PR description, plus the 8 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — 🔴 changes requested (blocking)GPT 6.1 found at least one blocking issue that must be resolved before merging This comment is updated in place on each push. BLOCKING -- website/src/pages/chat/AssistantMessage.tsx:452 -- Inline Fork grows the grandfathered newest-reply action row
[BLOCK-MERGE] d8c178f Adjudication (Opus 5.5) — is blocking on each finding proportionate?MEDIUM harm (the rule's row cap, not a functional defect). Confirmed at False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — 🔴 changes requested (blocking)Reviewed This PR adds a fourth button to the newest assistant reply's action row in the main chat, a row the base branch already grandfathers at three controls. BLOCKING — website/src/pages/chat/AssistantMessage.tsx:452 [BLOCK-MERGE] d8c178f Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
|
Stale-PR cleanup check: held for a maintainer. The linked issue #32012 is labeled |
Problem / Motivation
Goal: Fork is one click from a finished reply, as a button in the reply's action row next to Copy, whenever the fork can run at once and Tail-only Fork does not ask which way to fork.
On almost every reply, Fork needs two clicks. The row shows Regenerate, Copy and More on the newest reply, and Quote, Copy and More on older ones. "Fork conversation from here" is the eighth item in More. A reply gets the Fork row button only when it has no stable message id (
meta.mid) and its whole window is loaded. Every reply written since #8047 has an id, so the row button shows only on old history.Why it matters
Fork is the only item in More that starts a new chat, and people who split long threads use it many times a day. Each fork costs an extra click and a scan of the menu. Where Fork appears also depends on a storage detail the reader cannot see: in one chat, an old reply shows Fork in the row and a new reply hides it in More.
Not a goal
chat_fork.py.What changed (motivation → approach → change)
Fork is now a button in the reply's action row on almost every reply, so a fork is one click. Its place depends on two things the reader can see: whether the fork can run now, and whether Tail-only Fork asks for a direction. It no longer depends on whether the row carries a message id. In
AssistantMessage.tsx, Fork is a row button whenever the fork point resolves and Tail-only Fork is off. While Tail-only Fork is on, Fork is not in the row, and More lists "Fork with later messages only" and "Fork with earlier messages". A row button there would fork the tail and would sit dimmed on every newest reply, where no later message exists. Copy stays in the row whenever Fork is a row button. Before, a reply with no Quote seat and Share off moved Copy into More, and Fork would have taken its place.The seat order and the four-control newest row are what #16977 already draws for index-addressed replies. This PR applies them to replies with a message id. The newest reply's four controls are one more than the
max-two-buttons-per-rowruling on #16960 (seat, Copy, More). That needs a maintainer ruling, recorded with/ai-review overrideon the head.history.mddocuments the placement. The Playwright fork tests click the row button. Thefork-menucapture harness takesregen=0to draw an older reply, andcapture-18611-fork-menu.mjschecks the row where it checked the setting-off menu.Backwards compatibility
Compatible: every fork action is still offered, and no prop, API or server contract changes.
Reader: website/src/pages/chat/AssistantMessage.tsx:data-testid="fork-from-here" -- chat -- with Tail-only Fork off, the More item is now the row button with the same test id;
AssistantMessage.test.tsxReader: website/src/pages/chat/AssistantMessage.tsx:data-testid="quote-message" -- chat -- on an older reply Fork takes the seat, and Quote stays in More and in the bubble's right-click menu;
AssistantMessage.quote.test.tsxReader: website/src/pages/chat/page/transcriptRendering.tsx:AssistantMessage -- chat -- the only host that passes fork props; it still passes
forkMessageIdandforkDirectionChoice;ChatPageMoreCoverage.test.tsxReader: website/playwright/fork.spec.ts -- chat -- both fork tests click the row button, changed in this PR
Reader: website/scripts/capture-18611-fork-menu.mjs -- chat -- the setting-off section checks the row, changed in this PR
Tests
AssistantMessage.test.tsx: a reply with a message id draws Fork as a row button beside Copy, forwards the id, and More lists no second fork entry. The row button stays live on the newest reply when no choice is offered. It spins and ignores a second click while its fork runs. With no Quote seat and Share off, Copy stays in the row beside the fork button. With the choice offered, the row has no fork button and More lists both entries. An index-addressed reply with the choice sendsheadwith no id.AssistantMessage.quote.test.tsx: an older reply with a message id reads Fork, Copy, More, and Quote is in More. The newest reads Regenerate, Copy, Fork, More. With Tail-only Fork on, the newest reads Regenerate, Copy, More.AssistantMessage.tsxand pass with this change.--sequence.shuffle, seeds 11, 23, 37, 41 and 59. Each run passed 152 of 152.tsc -p tsconfig.app.jsonpasses. The sixAssistantMessage*test files andChatPageMoreCoverage.test.tsxpass, 272 tests. The scoped frontend set passes.Manual verification
I built
website/capture/fork-menu.htmlwith the repo's vite config and rancapture-18611-fork-menu.mjsin Chromium. The page renders the realAssistantMessagewith dummy data. All 107 checks pass. They include the row order in each state, a hit-tested click on the row button that callsonFork(1, 'm2'), no fork entry in More with the setting off, and the setting-on menu at 320 and 390 px.Screenshots / video
Newest reply, Tail-only Fork off. Main, then this PR:
Older reply, and Tail-only Fork on
Older reply on main, then this PR. Fork takes the seat and Quote moves to More:
Newest reply with Tail-only Fork on, unchanged by this PR:
Related Issues
Fixes #32012
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)