Skip to content

fix: backport eight MCP, Bot and KAS fixes to 0.12.1 (batch 27) - #32155

Merged
buluoray merged 8 commits into
release/0.12.0from
crew/slack/0.12.1-batch-27
Nov 7, 2026
Merged

buluoray merged 8 commits into
release/0.12.0from
crew/slack/0.12.1-batch-27

Conversation

@buluoray

@buluoray buluoray commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Bring eight small MCP, Bot and KAS fixes that merged on main after v0.12.0 onto release/0.12.0, one commit per fix, so the 0.12.1 patch ships them and each one can be reverted alone.

Why it matters

PR Source issue What a 0.12.0 user sees today
#31820 #25717 (pauldell1971) On Windows, a bundled vendor adapter's MCP command resolver still lacks the PATHEXT casing repair, so its server command can fail to resolve.
#31846 #30311 (CrysisDeu) A Bot worker's first work_report after it is bound is refused with crew_log_unit_unknown.
#31999 #29823 (CrysisDeu) The mate editor has no Session color field, so a Bot's color cannot be changed after it is created.
#31573 #27033 (pipelineburst) When an OAuth MCP sign-in is refused, the MCP servers row says only "Could not start the sign-in" and not which endpoint was refused.
#31976 #30352 (CrysisDeu) After "Enable all shareable", the notice lists servers as skipped while the table shows them as shared.
#31476 #19141 (wknight1) Child processes such as pyright-langserver pile up because a dead runtime's kiro-cli tree does not exit when a wrapper sits in front of it.
#31797 #20870 (iamwhatever) A pipeline conductor's patrol cannot outlive one loop, about 25 hours at a 90 s interval.
#32111 #27799 (jongaffen) On Windows, a normal gateway stop hard-kills the MCP gateway daemon and leaves pooled MCP backends running.

Not a goal

What changed (motivation → approach → change)

Each main squash commit was cherry-picked with -x onto release/0.12.0 @ 4d9f6b123e, in merge order, one commit each, keeping its original author.

# PR main commit release commit Pick
1 #31820 heal edition MCP command casing on Windows 6f69f2a5fb 7aaf083bc2 clean
2 #31846 record a worker's first report before its first turn c50773c8b6 71b5f2eda7 clean
3 #31999 show the session color field in the mate editor ab6df81cec 280459d168 clean
4 #31573 name the refused sign-in endpoint on the MCP servers row f52b36b86e a019d27b96 clean
5 #31976 stop naming servers as skipped when Enable all shareable shared them a13dc00715 f0efd13b42 clean
6 #31476 close the stdin of a dead runtime so its kiro-cli tree exits 15ec103647 13990b51ae clean
7 #31797 re-arm the pipeline conductor's patrol past one loop's cycle cap 492f6149d2 1beb1acf5d clean
8 #32111 reap pooled MCP backends after a Windows gateway stop 1c333b964b 1e0b7bae98 clean

No hunk was resolved by hand. Every pick's added and removed lines are identical to its main commit, and every pick carries a test. #31797 changes only the pipeline-conductor skill text plus its test. #31820 is a small edit in agent_parts/spec_build.py; #31476 adds one step to acp/runtime_tree_kill.py.

builder-security checked: no pick changes a bind, a listener, a route, an auth check, an ingress rule or a storage grant.

Backwards compatibility

Compatible: each change is the one already merged on main, and each PR's own compatibility note applies unchanged.

Removes nothing: no pick hides, deletes or renames anything 0.12.0 accepts.

Tests

Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs

  • CI does not run the backend suite on PRs into release/*, so the related set was run here: every touched test file plus every test file that imports a touched module, 73 files, one pytest process per batch of 20, -n 0. 5171 passed, none failed.
  • Frontend: every touched test file plus every test that reads a touched component, 29 files, 601 passed.
  • flake8 passes on the changed Python files.

Manual verification

N/A - every pick was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.

Screenshots / video

Why no screenshot: each frontend change here is applied from main unchanged; its look is reviewed on its own PR, not here.

Related Issues

Backport to the 0.12 line for 0.12.1 of #31820, #31846, #31999, #31573, #31976, #31476, #31797 and #32111. Source issues: #25717, #30311, #29823, #27033, #30352, #19141, #20870, #27799.

Sibling sweep

Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.

Pattern harvest

Not generalizable: this PR only carries fixes already on main. Each source PR has its own harvest.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

bolichen97 and others added 8 commits November 7, 2026 06:48
#31846)

Co-authored-by: w <w@k.local>
(cherry picked from commit c50773c)
The mate editor lost its Session color field when the New editor
replaced the classic dialog, so a mate's color could only be picked at
create time. useCrewEditor still loads, dirty-tracks and saves
session_color, so render the shared SessionColorField on General under
Display name. Tests cover changing and clearing the stored color.

Closes #29823

(cherry picked from commit ab6df81)
…31573)

When the credential gate refuses a minted approval URL, the mint ends
with reason mint_url_rejected and, when it can, a copy-ready
rejected_endpoint. The Connections card already turns that into the
endpoint to list in oauth_endpoints.json plus a link to the guide; the
MCP Servers row ignored both and always said "Could not start the
sign-in. Try again.", a retry that can never clear the refusal.

The row now shows the same copy, remedy line and guide link as the
card. Its error renders through ErrorNotice, whose agent hand-off is
withheld while the MCP table holds unapplied edits, as MCP Management
already does. The guide URL moves to utils/docsLink so both surfaces
share it, and the guide and security spec name the row.

Closes #27033

(cherry picked from commit f52b36b)
…ared them (#31976)

Co-authored-by: w <w@k.local>
(cherry picked from commit a13dc00)
…1476)

When the process Kiro Crew spawned for a kiro-cli session is not the
one that reads its stdin (a wrapper or launcher sits in front of
kiro-cli) and it dies before its tree does, for example killed during
the initialize handshake, the descendants keep the write ends of
stdout and stderr. asyncio's subprocess transport then never sees
every pipe close, never finishes, and never closes stdin, so kiro-cli
reads no EOF. On macOS no member of the leaderless group can vouch for
it and no descendant was recorded yet, so nothing signals the tree
either: kiro-cli, its engine and any MCP server it had started keep
running after the session is closed, for the life of the gateway.

AcpRuntime's POSIX kill now aborts its own write end of the root's
stdin before it drops the handle. It signals nothing: only holders of
the pipe's other end, which are this spawn's own tree, see the EOF. It
uses the stdin pipe's abort rather than close, which waits for buffered
bytes to drain, and never the subprocess transport's close, which
kills a root that is still running.

Part of #19141

(cherry picked from commit 15ec103)
…31797)

A patrol loop's max_cycles counts its whole life and the server caps it
at 1000, so at the 90 s interval one loop lasts about 25 hours,
renewals included, and the skill gave no way past it. A wake cannot
re-arm its own loop: while it runs monitor_start is refused, and once
the wake stops it the server refuses the replacement, which leaves no
patrol at all.

The arm step and the standing instruction now have the conductor ask
in its reply on the "10% or less left" budget line while work is live,
and re-arm (autonudge_stop, then monitor_start with the same interval,
bounds and instruction) in the turn the person's own message starts.
The spec states the limit as a failure mode and why the work-ledger
watch's bound extension is not used, and the contract test pins the
clause and the server's budget-line wording.

(cherry picked from commit 492f614)
@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 7, 2026 06:56
@buluoray
buluoray requested review from tim-finnigan and removed request for a team November 7, 2026 06:56
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 7, 2026
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of 1e0b7bae98ed4f1d26e0e4bc228a086cc3cd9253 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing screenshots. This backport changes three dashboard surfaces, the PR attaches no image, and the blind read was not performed.

Evidence gaps

  • Mate editor, new Session color field (CrewEditorNextDialog.tsx: <SessionColorField … subject="member" /> under the display name). Needs a screenshot of the dialog with the field closed and with its picker open.
  • MCP servers row, refused sign-in error. The error now renders through ErrorNotice variant="inline" with an ask-agent action. Below it is a muted line, mint_failure_url_rejected_endpoint_detail, with a "Documentation" link. Needs screenshots of three states: a refusal that names the endpoint, a refusal with no endpoint, and the generic sign_in_mint_failed failure.
  • "Enable all shareable" result notice. The skipped-servers sentence is now worked out from settleSkipped. Needs a screenshot after enable-all where core-following servers count as shared, and one where a real skip is still named.

Notes

  • The refused-endpoint branch names the endpoint twice: once in the error (mint_failure_url_rejected_endpoint) and again in the muted detail line. Check that the detail line adds the remedy and does not repeat the error.

[UX-REVIEWED] 1e0b7ba

Description read

[DESCRIPTION-READ] f123198a112076a8f62f6358856e99e3a7a42f7427b35e8d60cfdc48f02240ff

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

Design-level review of 1e0b7bae98ed4f1d26e0e4bc228a086cc3cd9253 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Cannot evaluate: missing a screenshot of the new mate-editor Session color field and the reshaped MCP-row sign-in error. Windows verification is also missing for the two Windows-only picks, and no CI run on this branch covers them.

Blockers

Missing evidence for this revision (UI and Windows)
Trigger: the diff adds "<SessionColorField value={sessionColor} onChange={setSessionColor} subject="member" />" to CrewEditorNextDialog and swaps McpRowSignIn's bare "<p … role="alert">" for "<ErrorNotice variant="inline" …>" plus an endpoint line and a docs link. The evidence list shows 0 images and 0 recordings, and the description says "its look is reviewed on its own PR, not here". Separately, "Manual verification: N/A" covers #32111 and #31820, which only run on Windows, and "CI does not run the backend suite on PRs into release/*".
Outcome: the field and error notice land in the 0.12.0 tree, whose layout and context differ from main's → nobody has seen them render there → layout or i18n-key drift ships unseen in 0.12.1. The Windows daemon-stop and PATHEXT paths have never run on this base → a Windows gateway stop or MCP command resolution could regress in a patch release, with no remedy short of a revert.
Fix: attach screenshots of both surfaces rendered from this branch's build, and run a Windows gateway stop on this branch (or point to a Windows CI run at this head).
Clears when: the description carries a github.com/user-attachments screenshot of the mate editor's Session color field and of the MCP-row refused-endpoint error from this branch, plus a Windows manual-verification note (or a Windows CI run at 1e0b7bae) showing the pooled backends reaped after a stop.

[DESIGN-REVIEWED] 1e0b7ba

Description read

[DESCRIPTION-READ] 11896bb931fb93ef20034e5ab9ac34bd52bea9daf1db3e8cfd65f25461b601c7

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 1e0b7bae98ed4f1d26e0e4bc228a086cc3cd9253 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Each item is an unchanged cherry-pick of a fix already merged on main, and each has its own source issue and test. No item adds surface that this backport's Goal doesn't cover.

Notes

What this change ships

Inventory (8 items) — 7 justified

Intent: ship eight fixes already merged on main to 0.12.x users in the 0.12.1 patch. This is a FIX (a backport).

  1. On Windows, the MCP command an edition adapter contributes gets its PATHEXT casing repaired in every derived spec — justified
  2. A Bot worker's first work_report before its first turn is recorded against the board's unit — justified
  3. The mate editor shows a Session color field — justified
  4. The MCP row's sign-in error names the refused endpoint and links the allowlist guide; it also gains an ask-agent hand-off — undeclared
  5. "Enable all shareable" stops listing servers as skipped once they end up stubbed — justified
  6. When a runtime is killed, its stdin is closed so an orphaned kiro-cli tree exits — justified
  7. The conductor skill asks once to renew its patrol near the cycle cap, and re-arms in the person's own turn — justified
  8. A Windows gateway stop reaps the pooled MCP backends that TerminateProcess left behind — justified

[FIRST-PRINCIPLES-REVIEWED] 1e0b7ba

Description read

[DESCRIPTION-READ] 1833f487dad1033077c19a238e75e2a6ccc579ed248dc37ff57e315018e2359f

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 1e0b7bae98ed4f1d26e0e4bc228a086cc3cd9253 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 1e0b7ba

Verdict parsed from the review's SHA-scoped output markers for commit 1e0b7bae98ed4f1d26e0e4bc228a086cc3cd9253.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 1e0b7bae98ed4f1d26e0e4bc228a086cc3cd9253 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 7, 2026
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 1e0b7bae98ed4f1d26e0e4bc228a086cc3cd9253 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 1e0b7ba

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 1e0b7bae98ed4f1d26e0e4bc228a086cc3cd9253 false-positive: <reason, 20 to 500 characters>

@buluoray
buluoray merged commit 476d5bb into release/0.12.0 Nov 7, 2026
20 of 25 checks passed
@buluoray
buluoray deleted the crew/slack/0.12.1-batch-27 branch November 7, 2026 09:34
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants