Repository navigation
Conversation
The Refresh buttons on the Skills and Steering tabs used a native disabled while their refetch ran. A disabled button leaves the tab order, so a keyboard press dropped focus to the page for the whole refresh. Mark the busy button aria-disabled and ignore a second press instead, the way the Ops Mission Control refresh already does.
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. Both Refresh buttons now use What this change shipsInventory (4 items) — 4 justifiedIntent: let a keyboard or screen-reader user press Refresh on the Skills or Steering tab without losing focus while it runs (FIX, #32162).
[FIRST-PRINCIPLES-REVIEWED] 1766582 Description read[DESCRIPTION-READ] e090604167ee2beae8f8145db487e812de0ef4c15844cebf49cba2b2f861fff7 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the fix targets the real cause (native Notes
[DESIGN-REVIEWED] 1766582 Description read[DESCRIPTION-READ] dc46485a0e3848b3e6b288e6f5b4b19cfab79a98904569d0484c8f2935156310 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing changes visually: the busy Refresh button stays at the same 30% opacity with the same label. The change is focus retention and ARIA state, and the tests cover both. Notes
[UX-REVIEWED] 1766582 Description read[DESCRIPTION-READ] aa50da4aae283f82d3346adbf0a194464ca4f2aab6416546fbe260754ab1b0ff That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
|
Closing as a duplicate of #32163, which makes the same Skills and Steering refresh focus change and was opened first. |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Problem / Motivation
Goal: pressing Refresh on the Skills or Steering tab from the keyboard keeps focus on the button while the refresh runs, instead of dropping it to the page.
Both icon Refresh buttons took a native
disabledwhile their refetch ran. A disabled button leaves the tab order, so focus fell to the page for the whole refresh.Why it matters
A keyboard or screen-reader user who refreshes loses their place and has to tab back from the top of the page every time.
Not a goal
What changed (motivation → approach → change)
Symptom: focus drops on Refresh. Cause: native
disabledwhile busy. Change:website/src/pages/overview/SkillsTab.tsxandwebsite/src/pages/overview/SteeringTab.tsxmark the busy buttonaria-disabledwith the same dimmed style and guard the click, so a second press does nothing, the way the Ops Mission Control refresh does (#32049). The busy accessible name ("Refreshing skills…") is unchanged.Backwards compatibility
Compatible: the button looks and is named as before; a second press while busy still does nothing.
Removes nothing.
Tests
website/src/test/SkillsTab.test.tsxandwebsite/src/test/SteeringTab.test.tsx: the existing busy-refresh test now focuses the button, presses it, and checks it isaria-disabledand notdisabled, keeps focus, ignores a second press, and keeps focus once the read lands. Both fail on main (the busy button wasdisabled). All 256 tests in the Skills, Steering and list-pane suites pass.Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
N/A — unit coverage sufficient: the change is focus and ARIA state, covered by the tests above.
Why no screenshot: the busy button keeps the same dimmed look and label; only its focusability and ARIA state change.
Related Issues
Fixes #32162
Deferred: #32164 (the Retry and Load-more buttons on the other Capabilities and Memory tabs)
Sibling sweep
Swept: git grep -n "disabled={isFetching}" -- website/src/pages/overview
Sibling: website/src/pages/overview/SkillsTab.tsx -- fixed -- Refresh skills
Sibling: website/src/pages/overview/SteeringTab.tsx -- fixed -- Refresh steering files
Sibling: website/src/pages/overview/PromptsTab.tsx -- deferred -- Retry read, Deferred: #32164
Sibling: website/src/pages/overview/WorkflowLibraryTab.tsx -- deferred -- Retry, Deferred: #32164
Pattern harvest
Not generalizable: the remaining sites are listed in #32164.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the Apache-2.0 license of this project.