Skip to content

fix: backport five user-reported fixes to 0.12.1 (batch 30) - #32194

Merged
buluoray merged 5 commits into
release/0.12.0from
crew/slack/0.12.1-batch-30
Nov 7, 2026
Merged

buluoray merged 5 commits into
release/0.12.0from
crew/slack/0.12.1-batch-30

Conversation

@buluoray

@buluoray buluoray commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Bring five small user-reported fixes that merged on main after v0.12.0 onto release/0.12.0, one commit per fix, so the 0.12.1 patch ships them and each one can be reverted alone.

Why it matters

PR Reported in What a 0.12.0 user sees today
#28985 #27796 (jongaffen) Sent-message attachment cards and inline chips show the full Windows path instead of the file name.
#30999 #16574 (chenmingwei23) A Bot's crew log can record a host decision as a person's, at turn 0, and blame a hook that never ran.
#31215 #27792 (jongaffen) An app's file-menu extension filter and the app-SDK tool-pill chip split Windows paths on / only.
#31205 #27866 (jongaffen) On Windows, kirocrew cloud doctor never names a missing credential_process helper.
#31375 #24655 (mbriones98) A model wait's WORKING reading is never bounded by the tool-stall hard cap, so the chat watchdog can wait on it without end.

Not a goal

  • No fix that is not already merged on main; nothing is changed only here.
  • No version bump, no tag, no CHANGELOG.md change. Cutting v0.12.1-rc.N and the bare tag follow docs/build/release.md and stay with the maintainers.

What changed (motivation → approach → change)

Each main squash commit was cherry-picked with -x onto release/0.12.0 @ 4d9f6b123e, in merge order, one commit each.

# PR main commit release commit Pick
1 #28985 label Windows attachment paths by file name 2c109f6117 e776f64f18 clean
2 #30999 skip the turn-0 spawn approval pair and stop blaming a hook 041f98d623 f807a2549a clean
3 #31215 read a Windows path's file name in two more sites 1e191512ed d8f66bcc56 clean
4 #31205 name the missing credential helper in cloud doctor on Windows 0eecd845d1 0fc18a14b7 clean
5 #31375 cap model-wait WORKING deferrals at the tool-stall hard cap db1c79baca 6a38cb495d one doc hunk resolved by hand

The one hand-resolved hunk is documentation. In #31375, docs/system-specs/modules/metrics.md conflicted in one table row; it was resolved by keeping this branch's row and applying #31375's rewrite of its working_cap phrase, and the result is identical to main's line. #31375's other changes (watchdog code, two config help texts and config-baseline.json) applied with no conflict; its config edits change help text only, not a setting. That commit is authored with the public identity the push guard requires and names Bolin Chen as the original author in its message; the other four keep their original authors. Every pick's added and removed lines are identical to its main commit.

#28985 comes before #31215 because #31215's tests expect app-sdk/messageRenderers.tsx to use pathBasename, which #28985 adds. #31205 reads the AWS credential_process setting only to name a missing helper in cloud doctor; it changes no credential handling.

builder-security checked: no pick changes a bind, a listener, a route, an auth check, an ingress rule or a storage grant.

Backwards compatibility

Compatible: each change is the one already merged on main, and each PR's own compatibility note applies unchanged.

Removes nothing: no pick hides, deletes or renames anything 0.12.0 accepts.

Tests

Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs

  • CI does not run the backend suite on PRs into release/*, so the related set was run here: every touched test file plus every test file that imports a touched module or reads the touched config, 47 files, one pytest process per batch of 20, -n 0. 2631 passed. 1 failed: test_file_line_cap.py::TestTheCheckout::test_the_change_keeps_the_cap_and_its_baseline_rows, which fails the same way on a clean release/0.12.0 checkout because dashboard/handlers/agents.py is 2,002 lines there; refactor: backport the agents.py effort-levels split to 0.12.1 (batch 29) #32184 clears it.
  • Frontend: every touched test file, windowsBasenameSites.test.tsx, AppSdkMessageRenderersCov80.test.tsx, and every test that reads a touched module, 46 files, 1000 passed.
  • flake8 passes on the changed Python files.

Manual verification

N/A - every pick was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.

Screenshots / video

Why no screenshot: each frontend change here is applied from main unchanged; its look is reviewed on its own PR, not here.

Related Issues

Backport to the 0.12 line for 0.12.1 of #28985, #30999, #31215, #31205 and #31375. Source issues: #27796, #16574, #27792, #27866, #24655.

Sibling sweep

Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.

Pattern harvest

Not generalizable: this PR only carries fixes already on main. Each source PR has its own harvest.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

mbriones98 and others added 5 commits November 7, 2026 07:30
* fix(chat): label Windows attachment paths by file name

Sent-message attachment cards, inline file chips and the pinned prompt
preview on a Windows gateway showed the whole native path, because the
labels split paths on `/` alone and a path like
`C:\Users\me\report.docx` was one segment.

buildFileLabels splits a Windows-shaped path (drive-rooted or UNC) on
both `\` and `/`, using the same backslashIsSeparator rule as
pathBasename, so a POSIX path keeps `\` inside its file name. Same-
named files still widen by parent folder until unique, and labels join
with `/` like the composer's. A chip whose path is missing from the
attachment list falls back to its file name; a label another chip
already holds uses the full path instead, and optimistic-mention
recovery leaves a marker's own entry in place. The embedded transcript
tool-pill button and promptPreview use pathBasename for the same reason.

Fixes #27796

* fix(chat): show a chipped attachment once in a sent message

A mixed-separator Windows path such as `C:/repo\src\a.ts` labels its
inline chip `@a.ts`, but the unreferenced-attachment check reads the
rewritten text and splits paths on `/` only, so it missed that chip and
drew a second card for the same file. A file the message already shows
as an inline chip now counts as referenced, so it gets no extra card.

Part of #27796

---------

Co-authored-by: Matt Briones <mdbrio@amazon.com>
(cherry picked from commit 2c109f6)
#30999)

Co-authored-by: Zejiang Guo <zejiangg@amazon.com>
(cherry picked from commit 041f98d)
…1215)

An app's extension-scoped file-menu row matched a Windows dotfile
(C:\repo\.gitignore for "gitignore") because fileMenuItemMatches took
the name with a /-only split, so the whole native path came through
and its last dot sat past index 0. The app-SDK tool pill's open-file
chip showed the whole C:\... path for the same reason.

Both sites now take the name through pathBasename, which is
byte-identical to the old split for every POSIX path, and both files
join the windowsBasenameSites source scan.

Closes #27792

(cherry picked from commit 1e19151)
…31205)

On Windows the AWS CLI reports a credential_process program it cannot
start as "[WinError 2] The system cannot find the file specified", with
no program name. The detector only read the POSIX "[Errno 2] ... '<name>'"
text, so cloud doctor told the user to re-run SSO setup instead of giving
the helper an absolute path.

When the stderr carries that Windows text, read the program from the
profile's own credential_process setting (aws configure get): a leading
double-quoted program is read whole, spaces included, as the CLI on
Windows reads it, otherwise its first word. It keeps the bare-name rule
the POSIX detector keeps: a name with a path separator, an unset value,
or an agent session that may not run the call keeps today's generic
note.

(cherry picked from commit 0eecd84)
…#31375)

The chat watchdog's model-wait branch deferred every WORKING reading with
no upper bound. That reading is CPU or IO movement anywhere in the
runtime's process tree, which a busy MCP server also produces, so a turn
that streamed nothing was never probed until the prompt timeout.

Defer it only while the stale idle is within
watchdog.tool_stall_hard_cap_secs, as the tool branch already does for
its tree-wide readings, then send the existing non-lethal stale probe,
labelled window=working_cap.

Closes #24655

(cherry picked from commit db1c79b)

Release backport: docs/system-specs/modules/metrics.md conflicted in
one table row; resolved by keeping release's text and applying this
change's rewrite of the working_cap phrase. Code, config and tests
applied unchanged.

Original author: Bolin Chen (#31375).
@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 7, 2026 07:39
@buluoray
buluoray requested review from tim-finnigan and removed request for a team November 7, 2026 07:39
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 7, 2026
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 6a38cb495dd44ed7e83371359da1535a1689d3e6 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this PR copies five fixes already merged on main, one commit each, and any of them can be reverted alone.

Notes

  • The release branch runs no backend CI. The watchdog change can now end a stalled chat turn that used to wait forever, so test it during the 0.12.1 RC soak, not just in the 2631-test local run.

[DESIGN-REVIEWED] 6a38cb4

Description read

[DESCRIPTION-READ] 2fea3b343e1cefe4484420fffd42f78b9939d46c40932ba4bb3db6ea454dc3cf

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of 6a38cb495dd44ed7e83371359da1535a1689d3e6 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Cannot evaluate: missing screenshots of the Windows attachment and file-chip labels this backport changes. No image is attached, so the blind read was not performed.

Evidence gaps

  • Sent-message attachment cards and inline file chips (ChatPageMessageContent.tsx, buildFileLabels): Windows paths like C:\…\report.docx now show the file name instead of the full path. A file that appears as an inline chip no longer also gets a duplicate card. Two files that share a name now get distinct labels, with the full path on one of them. Needs a before/after still of a sent message on Windows that has a card and an inline chip.
  • Tool-call pill file chip (messageRenderers.tsx, pathBasename(filePath)): needs a still of the chip for a Windows-path tool call.
  • Pinned-prompt preview (promptPreview): needs a still of a pinned prompt with a Windows [attached_file] showing only the file name.
  • Closing the gaps: attach these as github.com/user-attachments images in this PR's description. Stills from fix(chat): label Windows attachment paths by file name #28985 or fix(dashboard): read a Windows path's file name in two more sites #31215 count only if they are re-attached here.

[UX-REVIEWED] 6a38cb4

Description read

[DESCRIPTION-READ] 6893bed6ef226a2173c49da0cbc34c7a5a89f467d6534ca252268e4dd745f94f

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 6a38cb495dd44ed7e83371359da1535a1689d3e6 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks: this is five cherry-picks of fixes already merged on main, and each one is tied to a linked user report and a test it adds.

What this change ships

Inventory (8 items) — 8 justified

Intent: ship five user-reported fixes already merged on main to 0.12.0 users in the 0.12.1 patch. FIX.

  1. Sent-message attachment cards and inline chips show the file name of a Windows path, not the full path (chat: sent-message attachment cards and inline chips show the full Windows path, buildFileLabels splits on / only #27796). — justified
  2. When two attached files share a file name, each chip keeps its own path instead of opening whichever file won. — justified
  3. A file shown as an inline chip no longer also shows as an attachment card. — justified
  4. The app file-menu extension filter, the app-SDK tool-pill chip and the pinned-prompt preview read Windows file names correctly (Dashboard: app file-menu extension filter and app-SDK tool-pill chip split Windows gateway paths on / only, two sites #17512 did not list #27792). — justified
  5. A spawn replayed at turn 0 no longer writes a half approval pair to the crew log (crew log: spawn approval entries can record a host decision as a person, turn 0, and a hook that never ran #16574). — justified
  6. An approval callback that raises is now logged as "approval undeliverable", not as a hook error (crew log: spawn approval entries can record a host decision as a person, turn 0, and a hook that never ran #16574). — justified
  7. On Windows, cloud doctor names the missing credential_process helper (cloud doctor: a missing credential_process helper is never named on Windows, the detector matches only the POSIX [Errno 2] text #27866). — justified
  8. A model wait's WORKING reading past the tool-stall hard cap now gets the non-lethal cancel probe and a working_cap metric. Two config help texts are updated to match (Chat watchdog: cap model-wait WORKING deferrals at the tool-stall hard cap #24655). — justified

[FIRST-PRINCIPLES-REVIEWED] 6a38cb4

Description read

[DESCRIPTION-READ] 2683769e3de89bca11d1d6b2a07ee3ed88dae30eeb68932818374ef07de91a69

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 6a38cb495dd44ed7e83371359da1535a1689d3e6 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 6a38cb4

Verdict parsed from the review's SHA-scoped output markers for commit 6a38cb495dd44ed7e83371359da1535a1689d3e6.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 6a38cb495dd44ed7e83371359da1535a1689d3e6 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 6a38cb495dd44ed7e83371359da1535a1689d3e6 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 6a38cb4

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 6a38cb495dd44ed7e83371359da1535a1689d3e6 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 7, 2026
@buluoray
buluoray merged commit ca12cbd into release/0.12.0 Nov 7, 2026
20 of 23 checks passed
@buluoray
buluoray deleted the crew/slack/0.12.1-batch-30 branch November 7, 2026 09:17
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants