Repository navigation
feat(connections): move the Crew GitHub sign-in switch into Feature previews - #32216
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the switch moves into the existing preview mechanism, every caller already goes through Notes
[DESIGN-REVIEWED] f2c85fe Description read[DESCRIPTION-READ] a6b557ec1a6fe23d1292e5e7199ffd6acc54cebfe38e943515755099df85fab7 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. The flag still defaults to off. The old key that is now ignored was never in the schema and could only be set by hand-editing, and the description declares the break and gives the two-key mismatch as the reason. What this change shipsInventory (7 items) — 7 justifiedIntent: the owner turns Crew's GitHub sign-in on and off from Settings > Feature previews instead of hand-editing
[FIRST-PRINCIPLES-REVIEWED] f2c85fe Description read[DESCRIPTION-READ] ec51d099377e0fb88b956854ebff1180e554fc7fde858eff1ce1928c57f620cb That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ human override accepted@iamwhatever overrode this lane for |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
01b19ad to
ce68672
Compare
ce68672 to
6af8a24
Compare
6af8a24 to
22dacbd
Compare
22dacbd to
f9d72f5
Compare
f9d72f5 to
c1735a7
Compare
bolichen97
left a comment
There was a problem hiding this comment.
Approving c1735a7.
What I checked on this head:
- All 99 checks are green and none is pending. The Design, First Principles and UX lanes pass, and the Opus and GPT lanes have no blocking findings.
- The switch moves and nothing else about the feature changes.
crew_oauthjoinsFEATURE_PREVIEW_FLAGS, sodashboard.feature_previews.crew_oauthis a schema path thatconfig setand the dashboard accept.enabled()reads only that path, and only a literaltruecounts. A missing, non-dict or unreadable config reads as off, and Windows still reads it as off. Every caller already goes throughenabled(), andmanages()still needs the flag and the KAS backend, so custody is not widened. - The feature stays off by default. The old hand-edited
connections.crew_oauthis now ignored, which the description states as a deliberate small break for a trial that had no product way to set it, so no setting is made stricter for anyone who did not edit the file by hand. - The card follows the existing preview pattern (one name, one key in
previewFlags.ts, one toggle inFeaturePreviewsSection.tsx). The three copy keys are in all 12 catalogs, and the generated files are part of the diff. I relied on the green checks for those and did not regenerate them. - No regex in the added product code.
I set auto-merge on this head.
93c0dc0 to
203a9b9
Compare
|
UX Review, on "cannot find the Connections page" (head 93c0dc0, and the earlier ask for an "Open Connections" link): This PR does not add a link from the card, on purpose (owner ruling).
The scope is frozen after this push. Later UX notes get answers here, not code. |
|
UX Review on 203a9b9 ("the next step points to a page the reader cannot find"): answered here, with no code change. The owner froze this PR's scope after the last push.
|
…reviews connections.crew_oauth was a hand-edited config.json key that kirocrew config set refuses as an unknown key. It is now the default-off Feature Preview dashboard.feature_previews.crew_oauth (Settings > Developer > Feature previews). The legacy key still turns it on; either true is on. A Windows gateway reads both as off. Custody is unchanged: manages() still needs the flag AND KAS. Refs #29543 #31149
203a9b9 to
f2c85fe
Compare
|
/ai-review override ux f2c85fe owner-decision: Owner decision. The preview switch shares nothing by itself; GitHub access starts only after Connect on Customize > Connections, which is in the left nav. A link from the card is refused by the Feature Previews ingress pin (only hiddenFromNav pages get a door), and the PR is scope-frozen. Accepting the remaining UX span as answered in-thread. |
|
AI-review override not recorded: class |
|
Owner decision (UX Review on f2c85fe): I accept the remaining UX span as answered. The preview switch shares nothing by itself; GitHub access starts only after Connect on Customize > Connections, which is in the left nav. A link from the preview card is refused by the Feature Previews ingress pin (only hiddenFromNav pages get a door), and this PR is scope-frozen. No further copy change on this PR. |
|
/ai-review override ux f2c85fe owner-decision: Owner decision #32216 (comment) - the switch shares nothing until Connect on Customize > Connections (left nav); a card link is refused by the Feature Previews ingress pin; PR is scope-frozen. |
Human judgment recorded@iamwhatever recorded a owner-decision release (class
This decision applies only to this commit. A new push requires a new judgment. |
bolichen97
left a comment
There was a problem hiding this comment.
A correction to my approval at f2c85fe. I wrote that the range-diff showed only a rebase. That is right against the head we approved earlier, c1735a7: the move from connections.crew_oauth to dashboard.feature_previews.crew_oauth was already in that head and is accepted. The only differences since are the same key name updated in docs and comments that main added after c1735a7, plus main's own changes to the surrounding code. No migration of the old key is needed: the product never had a UI to set it, and the preview defaults to off. All checks pass.
Problem / Motivation
Goal: The owner turns Crew's own GitHub sign-in on and off from Settings > Developer > Feature previews, instead of hand-editing
config.json.Today the switch is
connections.crew_oauth(connections/crew_oauth.pyFLAG_KEY,enabled()). It is not in the config schema, sokirocrew config set connections.crew_oauth trueanswers❌ Unknown key: connections.crew_oauth. The only way to turn it on is to edit the file by hand. Owner request.Why it matters
A switch nobody can set through the product is a switch only people who read the code can use. The owner wants the Crew OAuth trial (#29543, #31149) behind the same preview mechanism every other unreleased feature uses.
Not a goal
manages()stays "flag AND chat backend is KAS". Other harnesses get bridges in a later PR.What changed (motivation → approach → change)
Followed the Explore preview (#27449) exactly: one name in
FEATURE_PREVIEW_FLAGS, one key inpreviewFlags.ts, one card inFeaturePreviewsSection.tsx, then the generated files.src/kiro_crew/config/sections_dashboard.py:crew_oauthadded toFEATURE_PREVIEW_FLAGS. That makesdashboard.feature_previews.crew_oautha schema path, soconfig set, the dashboard PATCH and change cards accept it. Default off (absent).src/kiro_crew/connections/crew_oauth.pyenabled(): on only whendashboard.feature_previews.crew_oauthis literaltrue, read from the loaded config (KiroCrewConfig.load(), so aconfig.local.jsonoverlay decides exactly as the dashboard switch shows; GPT review). The old hand-editedconnections.crew_oauthis now ignored (conductor ruling after the UX review: with two keys the switch could show Off while the feature was on; this is a personal tool, so the owner flips the switch once). Every caller (manages,owns,status.py,warm.py, handlers, KAS projection) already goes throughenabled(), so nothing else changes.manages()still needs the flag AND KAS.website/src/utils/previewFlags.ts:PREVIEW_CREW_OAUTH(mc-preview-crew-oauth) inPREVIEW_FLAGS. The dashboard does not read it; it only writes the gateway path.website/src/pages/settings/FeaturePreviewsSection.tsx: one plain toggle card, like Ultra Mode's, plus itspreviewFlagLabelcase (previewSurfaces.test.tsxnow counts 10 ⓘ tips). Copy, after three UX reviews:read:user,read:org,public_repo)hiddenFromNav, e.g. Webhooks), and Connections is in the nav.Windows: main's feat(connections): Crew OAuth and kirocrew-secrets on Windows over verified loopback TCP #32221 serves Crew OAuth on Windows over verified loopback TCP, so
enabled()has no Windows gate and the copy states no Windows limit.{{productName}}for the product name), each language's register rule (du/tu/ты/तुम/তুমি),en-XAregenerated withnpm run i18n:pseudo.config-baseline.json,settingsRegistry.gen.ts+settings-registry.generated.json(npm run gen:settings),ui-index.generated.json(npm run gen:ui).src/kiro_crew/docs/configuration.mdlists the new name and says the old key is ignored; docstrings, the feature-map row and the phase-1 row ofdocs/request-for-change/rfc-crew-owned-oauth.md(beside main's phase-1b Windows row, which keeps "same flag"), and the comments indocs/architecture/mcp.md,docs/system-specs/modules/connections.md,status.py,mcp_discovery_server_info.pyand two dashboard type comments name the preview path.Backwards compatibility
Breaking (small, deliberate): a config with only
connections.crew_oauth: truenow reads as off; turn on Settings > Developer > Feature previews > GitHub sign-in by Kiro Crew once. Writer sweep on origin/main: the key has no writer in the product (kirocrew config setrefused it); only hand edits set it.Reader: src/kiro_crew/connections/crew_oauth.py:enabled -- entry: chat|crew page -- now reads only the preview path (
test_only_the_feature_preview_turns_it_on)Tests
test_only_the_feature_preview_turns_it_on[...](test/test_crew_oauth_mvp.py, realconfig.jsonin a temp home): preview on → True; preview false → False;"yes"→ False; a non-object value → False; oldconnections.crew_oauth: truealone → False.test_the_config_local_overlay_decides_like_the_dashboard[...]: base on +config.local.jsonoff → False (True before this fix); base empty + overlay on → True.test_windows_reads_the_flag_like_posix(main's, kept): Windows with the preview on → True.test_the_flag_is_off_unless_config_says_true: empty config off, preview on → on.test/test_feature_previews_config.pyandwebsite/src/test/previewFlagServerSync.test.tsx.Local runs on the head rebased onto origin/main
bc6579b4a4(touched/covering only, under the test lock): crew OAuth (incl.test_crew_oauth_windows_tcp.py), disconnect, preview-config, configuration-doc and config-baseline Python tests 183 passed, 4 skipped; vitestsrc/i18n(withI18N_BASE_REF=origin/main),previewSurfaces(link census unchanged: only Open Webhooks),previewFlagServerSync,featurePreviewsSectionNotice,settingsRegistry1280 passed;npm run i18n:check,tsc, the brand gate and the comment-history gate clean.Proof: not provable -- other: new behavior on a new config path (
dashboard.feature_previews.crew_oauth)Manual verification
On a throwaway data home:
kirocrew config set dashboard.feature_previews.crew_oauth true→✅ dashboard.feature_previews.crew_oauth = true, written underdashboard.feature_previews.Screenshots / video
Built SPA from this head, stubbed API. The card, off by default:
The ⓘ hint open:
Related Issues
Refs #29543, #31149
Checklist
Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.