Skip to content

docs: record the quiet-end token decision superseding the turn-end entry - #32257

Merged
bolichen97 merged 1 commit into
mainfrom
docs/19276-quiet-end-token-entry
Nov 18, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
docs/19276-quiet-end-token-entry

Conversation

@bolichen97

@bolichen97 bolichen97 commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Record the maintainer's decision that after nothing_to_do the model writes only a fixed end token that Kiro Crew drops, as a new entry that supersedes the 2026-10-03 turn-end entry.

The 2026-10-03 entry says a quiet turn ends on "a nothing_to_do call with nothing after it". That leaves the backend's history ending on a tool result, which the backend fills with its own placeholder; the model then copies the placeholder after later quiet ends. #19276 asks for a quiet end that leaves the history on a real assistant message, and the maintainer decided how on the issue. Changing a recorded decision takes a new entry in its own pull request (docs/decisions/README.md, rule 3).

Why it matters

Without the superseding entry, the code change for #19276 reverses a recorded decision, and the recorded-decisions-are-not-regressions rule rightly blocks it. With it, the ledger says what the product does, so later reviews and triage hold the new turn-end shape instead of the old one.

Not a goal

What changed (motivation → approach → change)

One new entry, docs/decisions/2026-11-07-a-quiet-turn-ends-with-an-end-token-kiro-crew-drops.md, with a partial Supersedes: line naming 2026-10-03-every-agent-turn-ends-with-text-or-nothing-to-do.md (in part: "a nothing_to_do call with nothing after it"), and its index row in docs/decisions/README.md. The entry's decision: after nothing_to_do the model writes only a fixed end token, which Kiro Crew drops where the model's text first arrives, so no chat, channel, cron or sub-agent result shows it; every other rule of the superseded entry stands, including the recovery ladder for a bare stop after an ordinary tool. Its evidence is the maintainer's decision comment on #19276.

The shipped 2026-10-03 entry is not edited (entries are immutable; scripts/check_decisions_history.py passes).

Backwards compatibility

Compatible: a documentation entry only; nothing that runs reads it.

Removes nothing: the superseded entry stays in the ledger byte-identical, and this pull request only adds a file and one index row.

Tests

Proof: not provable -- docs or config only

DECISIONS_BASE_REF=origin/main python3 scripts/check_decisions_history.py and scripts/docs-lint.sh pass.

Manual verification

N/A — a documentation entry; the two gates above are its checks.

Related Issues

Part of #19276

Maintainer decision: #19276 (comment)

This pull request carries the superseding entry, so the recorded-decisions-are-not-regressions lane blocks it by design (docs/decisions/README.md, rule 3); a maintainer override is what lets it land.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners November 7, 2026 10:32
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 7, 2026
@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 00dde568fec05abff9d33b993c72f2a99842e419 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 00dde568fec05abff9d33b993c72f2a99842e419 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 00dde568fec05abff9d33b993c72f2a99842e419 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

This adds one decision entry and its index row and changes no code, so nothing needs a design check.

[DESIGN-REVIEWED] 00dde56

Description read

[DESCRIPTION-READ] a44b85682c785bb8012286d62c6f29eb82632b6e39a8128196f0bfaf1d2fcaa1

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ human override accepted

Reviewed 00dde568fec05abff9d33b993c72f2a99842e419 — this comment is updated in place on each push.

Human judgment by @bolichen97 overrides the Opus 5.5 finding for 00dde568fec05abff9d33b993c72f2a99842e419; the recorded reason is authoritative for this commit.

[OPUS-OVERRIDE] 00dde56

Verdict recorded from an authorized human decision for commit 00dde568fec05abff9d33b993c72f2a99842e419.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 00dde568fec05abff9d33b993c72f2a99842e419 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 00dde568fec05abff9d33b993c72f2a99842e419 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 00dde56

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 00dde568fec05abff9d33b993c72f2a99842e419 false-positive: <reason, 20 to 500 characters>

@bolichen97
bolichen97 enabled auto-merge (squash) November 7, 2026 10:44
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 7, 2026
@bolichen97
bolichen97 force-pushed the docs/19276-quiet-end-token-entry branch from 8dce55c to bb64218 Compare November 7, 2026 12:15
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 7, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

self-added: no

  • Superseding a recorded decision requires a maintainer override (span=419c83cd76d9)

Intended: this PR is the path docs/decisions/README.md rule 3 sets for a change of mind: a new entry with a Supersedes: line, shipped in its own pull request, which this rule blocks by design until a maintainer overrides it.
The diff is that one entry plus its README index row; the superseded 2026-10-03 entry stays byte-identical (check_decisions_history.py passes in Fast Gate), and nothing that runs reads either file.
The entry names the deciding maintainer and links the on-record decision, #19276 (comment) (rule 4).
No change to the diff: the block clears through a maintainer's owner-decision override at this head that links that comment.

[operator: bolichen97]

@bolichen97

Copy link
Copy Markdown
Contributor Author

self-added: no

  • Supersedes line partly reverses the 2026-10-03 turn-end entry (span=61695ee649f0)

Intended: this PR is the path docs/decisions/README.md rule 3 sets for a change of mind: a new entry with a Supersedes: line, shipped in its own pull request, which this rule blocks by design until a maintainer overrides it.
The supersession is partial and says so: only "a nothing_to_do call with nothing after it" is replaced; every other rule of the 2026-10-03 entry stands, including the recovery ladder for a bare stop after an ordinary tool, and that file stays byte-identical.
The cited comment, #19276 (comment), is the deciding maintainer's own statement of the decision, posted from the account the entry names.
No change to the diff: the block clears through a maintainer's owner-decision override at this head that links that comment.

[operator: bolichen97]

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 7, 2026
@bolichen97
bolichen97 force-pushed the docs/19276-quiet-end-token-entry branch from bb64218 to 7853422 Compare November 7, 2026 20:34
@bolichen97

Copy link
Copy Markdown
Contributor Author

[operator: bolichen97] Rebased onto main a0d9a5a at 7853422 to clear the conflict in docs/decisions/README.md: main added the 2026-11-07 Measure-button row in the same spot, so both rows are kept, main's first. The entry file is unchanged; check_decisions_history.py reports the 57 entries on main intact at head.

The GPT and Opus BLOCKs on bb64218 are the recorded-decisions-are-not-regressions rule, which flags every Supersedes: entry by design. Local GPT and Opus reviews at 7853422 found no wording, accuracy or link problem (checked: the quoted phrase is verbatim in the 2026-10-03 entry; @CrysisDeu opened #19276 and decided that entry; the cited comment #19276 (comment) is the deciding maintainer's statement). The block clears only through a maintainer's override at this head.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 7, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 11, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

self-added: no

  • Supersedes line partly reverses the 2026-10-03 turn-end entry (span=61695ee649f0)

Rebutted (intended): this PR is the path docs/decisions/README.md rule 3 sets for a change of mind, a new entry with a Supersedes: line in its own pull request, which recorded-decisions-are-not-regressions blocks by design until a maintainer overrides it.
The supersession is partial and says so: only "a nothing_to_do call with nothing after it" is replaced; the rest of the 2026-10-03 entry stands and that file stays byte-identical (check_decisions_history.py passes).
The maintainer's decision is #19276 (comment), restated on this PR at #32257 (comment).
No change to the diff: the entry is the same 22 docs lines as the first judged head, and the block clears through a maintainer's owner-decision override at this head that links that decision.

[operator: bolichen97]

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 11, 2026
@bolichen97
bolichen97 force-pushed the docs/19276-quiet-end-token-entry branch from b9c8551 to 63f7e01 Compare November 12, 2026 01:58
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/decisions/README.md (a merge conflict: main appended an index row where this entry's row sat) and other docs/decisions/ entries since this head went green (265b3ac -> ce89396); CI re-running. The entry file is byte-identical; its index row now sits directly under the 2026-10-03 row it supersedes, off the table tail other decision PRs append to, and check_decisions_history.py reports the 91 entries on main intact.
[operator: bolichen97]

@bolichen97

Copy link
Copy Markdown
Contributor Author

self-added: no
resolution: narrowed -- the forced rebase moves the index row off the README table tail every decision PR edits to directly under the 2026-10-03 row it supersedes; the 21-line entry is unchanged

  • Supersedes line partly reverses the 2026-10-03 turn-end entry (span=61695ee649f0)

Kept as is: the entry stays byte-identical in 63f7e01 (same patch as this head); the Supersedes BLOCK is the rule-3 path and clears only through a maintainer override at the current head.
The three pushes after this blocked head were conflict re-syncs at the bottom row of the docs/decisions/README.md table, which every decision PR appends to; the row now sits under the 2026-10-03 row, as other superseding rows do, so later appends no longer collide with it.

[operator: bolichen97]

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 12, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

Re-sync budget reset: this PR is inside its 48-hour watch window, and its only reds on 63f7e01 (Backend Tests 3.12 shards 5 and 6, Windows shards 2 and 4, and the Coverage Gate that follows them) are main's own: test/test_wait_discipline_ratchet.py::test_the_scan_matches_known_sites and test/test_updates_handlers_facade.py::test_every_name_served_from_outside_the_family_is_visible_to_type_checkers fail the same way on main at ce89396, and #35625 fixed both on main after this head's base. So it re-syncs once more to pick up that fix.
[operator: bolichen97]

Add the maintainer's decision for #19276 as a new docs/decisions entry:
after nothing_to_do the model writes only a fixed end token, which Kiro
Crew drops where the model's text first arrives. It supersedes, in part,
the 2026-10-03 turn-end entry, which stays byte-identical, and is
indexed beside it.
@bolichen97
bolichen97 force-pushed the docs/19276-quiet-end-token-entry branch from 63f7e01 to 00dde56 Compare November 12, 2026 06:39
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/decisions/README.md and two other docs/decisions/ entries since this head went green (ce89396 -> 2f7e9f2); CI re-running. The re-sync picks up #35625, which fixes the two Backend Tests reds main carried at ce89396 (test_wait_discipline_ratchet.py::test_the_scan_matches_known_sites, test_updates_handlers_facade.py::test_every_name_served_from_outside_the_family_is_visible_to_type_checkers). The entry and its index row are unchanged (same patch), and check_decisions_history.py reports the 93 entries on main intact at head.
[operator: bolichen97]

@bolichen97

Copy link
Copy Markdown
Contributor Author

self-added: no

  • Supersedes line partly reverses the 2026-10-03 turn-end entry (span=61695ee649f0)

Rebutted (intended): this PR is the path docs/decisions/README.md rule 3 sets for a change of mind, a new entry with a Supersedes: line in its own pull request, which recorded-decisions-are-not-regressions blocks by design until a maintainer overrides it.
The supersession is partial and says so: only "a nothing_to_do call with nothing after it" is replaced; the rest of the 2026-10-03 entry stands and that file stays byte-identical (check_decisions_history.py passes).
The maintainer's decision is #19276 (comment), restated on this PR at #32257 (comment).
No change to the diff: the re-synced head carries the same patch (patch-id 9a319ac015), and the block clears through a maintainer's owner-decision override at the current head that links that decision.

[operator: bolichen97]

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 12, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

/ai-review override fable 00dde56 owner-decision: agent: this entry deliberately supersedes, in part, the 2026-10-03 turn-end decision, as docs/decisions/README.md rule 3 requires for a change of mind; the 2026-10-03 entry stays byte-identical. Decision: #32257 (comment)

[operator: bolichen97]

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@bolichen97 recorded a owner-decision release (class owner-decision) for the fable AI finding on 00dde568fec05abff9d33b993c72f2a99842e419.

agent: this entry deliberately supersedes, in part, the 2026-10-03 turn-end decision, as docs/decisions/README.md rule 3 requires for a change of mind; the 2026-10-03 entry stays byte-identical. Decision: #32257 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention labels Nov 17, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of head 00dde56. The diff is docs only: one new decision entry and one index row in docs/decisions/README.md. The 2026-10-03 entry has no hunk, so it stays byte-identical. The Supersedes: line quotes the replaced clause word for word and uses the existing partial-supersede form. Each Evidence link resolves to a record that matches the entry: the 190 and 323 counts in #27655, and the decision comment on #19276 from a listed maintainer. The entry also ships in its own PR, apart from the code change, as rule 3 asks. PR Readiness is green on this head.
Done well: the supersession is narrow. It replaces one quoted clause and says that the rest of the earlier contract, including the recovery ladder, still holds.
Optional: the override that clears the rule-3 flag on this head carries the agent: prefix. A maintainer may want to restate it in person. An acknowledgement from @CrysisDeu, who decided the earlier entry, would also make the record clearer.
Optional: until #32302 lands, the ledger describes end-token behaviour that main does not have yet. #32302 now has a merge conflict, so it is best to land the two close together.

@bolichen97
bolichen97 merged commit b1c1b97 into main Nov 18, 2026
101 of 105 checks passed
@bolichen97
bolichen97 deleted the docs/19276-quiet-end-token-entry branch November 18, 2026 00:31
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants