Skip to content

docs(rfc): propose a two-way Feishu link, numbered-text approval and owner-only group resume - #32260

Open
jhua-labs wants to merge 1 commit into
kirodotdev:mainfrom
jhua-labs:docs/rfc-feishu-two-way-link
Open

jhua-labs wants to merge 1 commit into
kirodotdev:mainfrom
jhua-labs:docs/rfc-feishu-two-way-link

Conversation

@jhua-labs

@jhua-labs jhua-labs commented Nov 7, 2026 •

Copy link
Copy Markdown

Problem / Motivation

Goal: Put the design for #31448 up for review as an RFC, so a maintainer can decide whether the Feishu owner may drive a dashboard session or a Bot from a Feishu DM or group.

Connect to a channel to Feishu is outbound-only, so a reply in Feishu never reaches the linked session or Bot. On 2026-11-14 a reply to a Bot's report in the DM was taken by the main session that owns the DM and read as an answer to its own options. Feishu also has no approval decider, and B4 lists Feishu as a sink but not as a reply transport.

Why it matters

Feishu is the only channel some users have. A maintainer asked on #31448 for the design as its own docs-only PR before any code.

Not a goal

What changed (motivation → approach → change)

The revision re-audits the RFC at dc4692c96f and reshapes it into four phases:

Phase What it does
1 Two-way owner DM, following Telegram's may_resume_from
2 Numbered-text approval for turns on the Feishu path, following WhatsApp
3 Answer bridged approvals from Feishu by joining B4 (#32902), instead of the first draft's own registry
4 Owner-only group resume, one group per Bot; depends on Phase 1 and on Q3 (private context in a group)

The README index row is updated to match.

Backwards compatibility

Compatible: documentation only; no code, config or behaviour changes.

Removes nothing: the diff adds one document and one index row.

Tests

Proof: not provable -- docs or config only

./scripts/docs-lint.sh passes.

Manual verification

N/A — documentation only.

Related Issues

Part of #31448

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@jhua-labs
jhua-labs requested review from a team and KiroCrewCaptain as code owners November 7, 2026 10:39
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 7, 2026
@jhua-labs
jhua-labs force-pushed the docs/rfc-feishu-two-way-link branch from 1b4e83c to 1b00c1d Compare November 8, 2026 00:21
@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 8, 2026
@jhua-labs
jhua-labs force-pushed the docs/rfc-feishu-two-way-link branch from 1b00c1d to 2a46f72 Compare November 9, 2026 14:53
@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 9, 2026
@jhua-labs
jhua-labs force-pushed the docs/rfc-feishu-two-way-link branch from 2a46f72 to 8fa22eb Compare November 15, 2026 12:03
@jhua-labs jhua-labs changed the title docs(rfc): propose a two-way Feishu dashboard link and numbered-text approval docs(rfc): propose a two-way Feishu link, numbered-text approval and owner-only group resume Nov 15, 2026
@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 15, 2026
@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: Approve

Why: the decider estimates a 12% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes.

This PR adds only docs: a draft RFC and one README index row. No code, config or behaviour changes. I checked the RFC's code claims against the head and they hold:

  • FEISHU_CAPABILITIES (feishu/transport.py) does not set supports_session_resume, so it defaults to False.
  • Telegram's may_resume_from is the one-owner-DM rule the RFC quotes.
  • REPLY_TRANSPORTS is (discord, telegram, webex), while TRANSPORT_SINKS also includes feishu.
  • The Feishu group gates hold: allow_group, then allowed_group_ids, then an @-mention, then authorize, in that order.
  • Group turns use minimal_context.
  • feishu/gateway.py has _resolve_approval_mode and installs no decider.
  • WhatsApp sets up TextReplyApprovalDecider only for an operator sender.
  • The rows it cites in channel-capabilities.md are there, and the linked RFCs exist.

Trust check: the design keeps owner-only admission for binding, approving and resuming. A second allow-listed open_id makes every link one-way again. Phase 3 hands admission to B4 rather than adding a new seam. Phase 4 (group resume) is the one real move of a trust boundary, and the RFC says outright that it does not ship until Q3, the private

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 8fa22ebce9 · 164 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 18, 2026
@jhua-labs
jhua-labs force-pushed the docs/rfc-feishu-two-way-link branch from 8fa22eb to 83f1df1 Compare November 19, 2026 09:43
@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 19, 2026
@jhua-labs
jhua-labs force-pushed the docs/rfc-feishu-two-way-link branch from 83f1df1 to 9d8ed2a Compare November 19, 2026 16:52
@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 19, 2026
@jhua-labs
jhua-labs force-pushed the docs/rfc-feishu-two-way-link branch from 9d8ed2a to 3360fe4 Compare November 19, 2026 21:07
@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 19, 2026
@jhua-labs
jhua-labs force-pushed the docs/rfc-feishu-two-way-link branch from 3360fe4 to 24fb139 Compare November 19, 2026 23:22
@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 19, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants