Repository navigation
fix: 0.12.1 batch 36 - KAS unattended MCP wait, sign-in wording, withheld-env notice - #32349
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: these are clean cherry-picks of fixes already merged on Notes
[DESIGN-REVIEWED] 24760e8 Description read[DESCRIPTION-READ] 92b14d8ee42e82bb357662b3a307b35df09387cfeeda1482d00fd4d3b358fb32 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Every item is a straight cherry-pick of a fix already merged on Notes
What this change shipsInventory (7 items) — 6 justifiedIntent: backport four KAS fixes from
[FIRST-PRINCIPLES-REVIEWED] 24760e8 Description read[DESCRIPTION-READ] 9faeba2c8132bcf38f54318b623c1bc6c9034211ffb729e5d5c0077cbf4125b2 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — 🔴 BLOCKUX-level review of UX-Verdict: BLOCK cannot evaluate: missing screenshots of the rewritten chat notices. The PR changes four user-facing messages and supplies no image, so the blind read was not performed. The new withheld-env line also says "may be missing" about settings the code knows were dropped. BlockersThe withheld-env notice is vague about settings the code knows were dropped Evidence gaps
[UX-REVIEWED] 24760e8 Description read[DESCRIPTION-READ] 69c9ac863dd86c7302ea9c318aae8ab60fa4abeec9080dc3b6e1394e449e6753 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
…30719) On KAS a new chat listed every MCP server that lost an env value on the wire, with key names and a vault and secret:// recipe. Users saw the settings of servers the edition ships, none of which they can change. The notice is now one line with no config terms. It names only a local server Crew and the edition do not ship, only when turning on Share in MCP Management would give it its full env (the rewriter's own count of withheld keys), and points there. Everything else stays in the log. (cherry picked from commit 77606ac)
…0898) A cron or webhook run on the default KAS backend sent its first prompt before a slow MCP server was up, so the run silently had no tools. The wait only declared servers on kiro-cli. KAS reports each wire server in _kiro/mcp/status, so declare the spec servers the wire array carries. Fixes #30325 (cherry picked from commit 120d913) Original author: Ray Xu (#30898). Applied on top of #31562 (batch 28), so runtime_session_setup.py matches main for this change.
When kiro-cli or KAS is signed out, the chat banner, the Settings remedy, the translated KAS chat row and the doctor steps told the user to start a new chat after signing in. Signing in again keeps the chat: its next message succeeds, so the advice threw away a conversation for nothing. The kiro-cli and KAS sentences now end at "send your message again", and the session-expired banner's closing warning drops "Retrying", which contradicted that. A KAS row with no notice token, saved or from the side panel, is still recognised in either ending, so it keeps its translated card. Harnesses whose sign-in needs a fresh session, and the fallback for a harness with no recorded sign-in, keep their wording. Builds on #21481 by @dodgeblaster. (cherry picked from commit 674ee76)
…30928) The sign-in error arm put "Your session has expired." in front of the signed-out message, but the same signals fire for a host that was never signed in, so a first chat after install said the session expired. The signed-out message alone is true in both cases. Fixes #29699 (cherry picked from commit f289a6d)
ade13f4 to
24760e8
Compare
Problem / Motivation
Goal: Bring three KAS fixes that merged on
mainafterv0.12.0(#30719, #30898, #30928), plus #31812, the prerequisite #30928 needs, ontorelease/0.12.0as one commit each in a PR of its own.Why it matters
Not a goal
main; nothing is changed only here.CHANGELOG.mdchange. Cuttingv0.12.1-rc.Nand the bare tag follow docs/build/release.md and stay with the maintainers.What changed (motivation → approach → change)
Each main squash commit was cherry-picked with
-xontorelease/0.12.0@344cc7ca44, in commit order onmain, one commit each.77606acb4b7bd3ba20bc120d913e87c9d7959aa5674ee76a233cc5e53cf4f289a6d2a824760e8f02Prerequisite. #30928 conflicted in
acp/transport_errors.pyandtest/test_acp_refactor_error_surface.pyon the signed-out wording ("start a new chat. Retrying or switching" against "send your message again. Switching").git log -Straces that wording to #31812. It is a small KAS/kiro-cli sign-in wording fix with its own tests (25 files, 12 of them one-line locale edits), so it is picked first, and #30928 then applies cleanly.No hunk is resolved by hand: every commit has added and removed lines identical to its main commit. #30898's commit is authored with the public identity the push guard requires and names its original author in its message.
builder-security checked: no bind, listener, route, auth mechanism or storage grant changes.
Backwards compatibility
Compatible: each change is the one already merged on
main, and their compatibility notes apply unchanged.sign_in_neededis a new attribute onAcpErrordefaulting toFalse;auth_requiredkeeps its meaning.Removes nothing: the changes drop a misleading "Your session has expired." lead and "start a new chat" advice, and no setting, key or caller.
Tests
Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs
release/*, so the related set was run here: every touched test file plus every test file that imports a touched module, 67 files, one pytest process per batch of 20. 4186 passed. 6 failed, all failures this branch already carries:test_acp_copilot_backend.py(3),test_acp_agent_env.py::test_every_backend_launch_carries_agent_env[copilot],test_acp_harness_contract.py::test_a_missing_self_served_binary_names_its_install_command[copilot]andtest_harness_parity.py::test_is_kiro_cli_is_positive.vitest run src/i18n(67 files, 1173 tests) and thegatewayNotice/transcriptRendererstests (5 files, 220 tests) pass.Manual verification
N/A - each fix was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.
Screenshots / video
Why no screenshot: the frontend change is locale text only; the rows that render it are unchanged.
Related Issues
Backport to the 0.12 line for 0.12.1 of #30719, #30898, #31812 and #30928. Source issues: #30325, #29699, #20829.
Sibling sweep
Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.
Pattern harvest
Not generalizable: this PR only carries fixes already on
main. The source PRs have their own harvest.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.