Skip to content

fix: 0.12.1 batch 36 - KAS unattended MCP wait, sign-in wording, withheld-env notice - #32349

Merged
buluoray merged 4 commits into
release/0.12.0from
crew/slack/0.12.1-batch-36
Nov 7, 2026
Merged

buluoray merged 4 commits into
release/0.12.0from
crew/slack/0.12.1-batch-36

Conversation

@buluoray

@buluoray buluoray commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

#31812 is pulled in as a prerequisite of #30928; see What changed.

Problem / Motivation

Goal: Bring three KAS fixes that merged on main after v0.12.0 (#30719, #30898, #30928), plus #31812, the prerequisite #30928 needs, onto release/0.12.0 as one commit each in a PR of its own.

Why it matters

PR Reported What a 0.12.0 user sees today
#30719 KAS UX On KAS, the withheld-env notice is shown even when the user can do nothing about it, in several lines that bury the one thing to do.
#30898 #30325 (CrysisDeu) On the default KAS backend a cron or webhook run sends its first prompt before a slow MCP server is up, so the run silently has no tools.
#31812 prerequisite of #30928 After a kiro-cli or KAS sign-in, the banner, the Settings remedy and the translated KAS row tell the user to start a new chat, which throws away a conversation whose next message would succeed.
#30928 #29699 (CrysisDeu) A user who never signed in is told "Your session has expired" on their first chat.

Not a goal

What changed (motivation → approach → change)

Each main squash commit was cherry-picked with -x onto release/0.12.0 @ 344cc7ca44, in commit order on main, one commit each.

# PR main commit release commit Pick
1 #30719 show the withheld-env notice only when the user can fix it 77606acb4b 7bd3ba20bc clean
2 #30898 wait for a slow MCP server before an unattended KAS run 120d913e87 c9d7959aa5 clean on top of #31562, now on this branch
3 #31812 signed-out remedy says send again, not start a new chat 674ee76a23 3cc5e53cf4 clean, prerequisite of #30928
4 #30928 stop telling a never-signed-in user their session expired f289a6d2a8 24760e8f02 clean once #31812 is in

Prerequisite. #30928 conflicted in acp/transport_errors.py and test/test_acp_refactor_error_surface.py on the signed-out wording ("start a new chat. Retrying or switching" against "send your message again. Switching"). git log -S traces that wording to #31812. It is a small KAS/kiro-cli sign-in wording fix with its own tests (25 files, 12 of them one-line locale edits), so it is picked first, and #30928 then applies cleanly.

No hunk is resolved by hand: every commit has added and removed lines identical to its main commit. #30898's commit is authored with the public identity the push guard requires and names its original author in its message.

builder-security checked: no bind, listener, route, auth mechanism or storage grant changes.

Backwards compatibility

Compatible: each change is the one already merged on main, and their compatibility notes apply unchanged. sign_in_needed is a new attribute on AcpError defaulting to False; auth_required keeps its meaning.

Removes nothing: the changes drop a misleading "Your session has expired." lead and "start a new chat" advice, and no setting, key or caller.

Tests

Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs

  • CI does not run the backend suite on PRs into release/*, so the related set was run here: every touched test file plus every test file that imports a touched module, 67 files, one pytest process per batch of 20. 4186 passed. 6 failed, all failures this branch already carries: test_acp_copilot_backend.py (3), test_acp_agent_env.py::test_every_backend_launch_carries_agent_env[copilot], test_acp_harness_contract.py::test_a_missing_self_served_binary_names_its_install_command[copilot] and test_harness_parity.py::test_is_kiro_cli_is_positive.
  • Frontend: vitest run src/i18n (67 files, 1173 tests) and the gatewayNotice / transcriptRenderers tests (5 files, 220 tests) pass.
  • flake8 passes on the changed Python files.

Manual verification

N/A - each fix was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.

Screenshots / video

Why no screenshot: the frontend change is locale text only; the rows that render it are unchanged.

Related Issues

Backport to the 0.12 line for 0.12.1 of #30719, #30898, #31812 and #30928. Source issues: #30325, #29699, #20829.

Sibling sweep

Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.

Pattern harvest

Not generalizable: this PR only carries fixes already on main. The source PRs have their own harvest.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 7, 2026 13:24
@buluoray
buluoray requested review from tim-finnigan and removed request for a team November 7, 2026 13:24
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 7, 2026
@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 24760e8f02e4ed3c0243237d8985e912cc521b20 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: these are clean cherry-picks of fixes already merged on main, with identical hunks, and the frontend change is locale text only.

Notes

  • CI does not run the backend suite on release/*, so the local 67-file run is the only proof for this branch. Re-run it on the final head SHA before the RC is cut.

[DESIGN-REVIEWED] 24760e8

Description read

[DESCRIPTION-READ] 92b14d8ee42e82bb357662b3a307b35df09387cfeeda1482d00fd4d3b358fb32

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 24760e8f02e4ed3c0243237d8985e912cc521b20 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Every item is a straight cherry-pick of a fix already merged on main, and each has a linked issue or a test that pins it. The one rider is mentioned in the description and has a consumer.

Notes

  • Item 6 — rides along: the PR is framed as a sign-in wording fix, but the fix(acp): stop telling a never-signed-in user their session expired #30928 pick also changes task-queue behaviour. classify now fails a row as auth_failed "for every harness", through getattr(exc, "sign_in_needed", False). The description says only "sign_in_needed is a new attribute on AcpError" and never says the retry behaviour of non-Kiro harnesses changes. It has exactly 1 consumer (grep sign_in_needed src/: taskq/adapters/acp_provider.py:189), and a test pins it.

What this change ships

Inventory (7 items) — 6 justified

Intent: backport four KAS fixes from main onto release/0.12.0 for 0.12.1. This is a FIX.

  1. On KAS, the withheld-env chat notice now appears only for a stdio server the user can fix with Share, as one line — justified
  2. Remote/sse servers, servers Crew or the edition ship, and malformed-env servers are no longer named in chat, only in the log — justified
  3. On KAS, a cron or webhook run now waits for the MCP servers that were actually delivered before its first prompt (On the default backend a scheduled run does not wait for a slow MCP server and silently runs without its tools #30325) — justified
  4. Sign-in remedies say "send your message again" instead of "start a new chat", across the backend and 14 locales — justified
  5. The signed-out error no longer opens with "Your session has expired" (A user who never signed in is told "Your session has expired" #29699) — justified
  6. A signed-out frame from any harness now classifies a task as auth_failed — rides along, under-described in the description
  7. The dashboard recognises token-less KAS signed-out rows with the new ending — justified

[FIRST-PRINCIPLES-REVIEWED] 24760e8

Description read

[DESCRIPTION-READ] 9faeba2c8132bcf38f54318b623c1bc6c9034211ffb729e5d5c0077cbf4125b2

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — 🔴 BLOCK

UX-level review of 24760e8f02e4ed3c0243237d8985e912cc521b20 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: BLOCK

cannot evaluate: missing screenshots of the rewritten chat notices. The PR changes four user-facing messages and supplies no image, so the blind read was not performed. The new withheld-env line also says "may be missing" about settings the code knows were dropped.

Blockers

The withheld-env notice is vague about settings the code knows were dropped
Trigger: on KAS, a user's own local MCP server loses its env settings, which is the only way it gets into _share_notice (stdio and "env" in fields).
Outcome: the code knows the env was withheld, but the chat shows "ℹ {label} may be missing some of its settings in this chat." The user is left unsure whether anything is wrong, so the remedy reads as optional and the server keeps running without its settings. Severity: every KAS session with an affected server × silent tool failure × every chat.
Fix: state it as fact, for example "{label} is running without some of its settings in this chat. To fix it, turn on Share for it in Customize → Connections → MCP Management."

Evidence gaps

  • The rewritten withheld-env notice line (kas_withheld_notice.py, _share_notice) rendered in a chat row. Close with a screenshot attached to the PR description.
  • The signed-out error row after the "Your session has expired." lead was dropped (transport_errors.py), which now reads "…then send your message again. Switching models will not help — this is a sign-in issue, not a backend error." Close with a screenshot.
  • The kas_signed_out and kas_signed_out_sign_in_below banner text ("…then send your message again."), including the sign-in card beside it. Close with a screenshot.
  • The description says no screenshot is needed because only locale text changed, but changed text on a visible row still needs a screenshot.

[UX-REVIEWED] 24760e8

Description read

[DESCRIPTION-READ] 69c9ac863dd86c7302ea9c318aae8ab60fa4abeec9080dc3b6e1394e449e6753

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 24760e8f02e4ed3c0243237d8985e912cc521b20 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 24760e8

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 24760e8f02e4ed3c0243237d8985e912cc521b20 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 24760e8f02e4ed3c0243237d8985e912cc521b20 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 24760e8

Verdict parsed from the review's SHA-scoped output markers for commit 24760e8f02e4ed3c0243237d8985e912cc521b20.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 24760e8f02e4ed3c0243237d8985e912cc521b20 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 7, 2026
buluoray and others added 4 commits November 7, 2026 16:04
…30719)

On KAS a new chat listed every MCP server that lost an env value on the
wire, with key names and a vault and secret:// recipe. Users saw the
settings of servers the edition ships, none of which they can change.

The notice is now one line with no config terms. It names only a local
server Crew and the edition do not ship, only when turning on Share in
MCP Management would give it its full env (the rewriter's own count of
withheld keys), and points there. Everything else stays in the log.

(cherry picked from commit 77606ac)
…0898)

A cron or webhook run on the default KAS backend sent its first prompt
before a slow MCP server was up, so the run silently had no tools. The
wait only declared servers on kiro-cli. KAS reports each wire server in
_kiro/mcp/status, so declare the spec servers the wire array carries.

Fixes #30325

(cherry picked from commit 120d913)

Original author: Ray Xu (#30898). Applied on top of #31562 (batch 28),
so runtime_session_setup.py matches main for this change.
When kiro-cli or KAS is signed out, the chat banner, the Settings remedy,
the translated KAS chat row and the doctor steps told the user to start a
new chat after signing in. Signing in again keeps the chat: its next
message succeeds, so the advice threw away a conversation for nothing.

The kiro-cli and KAS sentences now end at "send your message again",
and the session-expired banner's closing warning drops "Retrying",
which contradicted that. A KAS row with no notice token, saved or from
the side panel, is still recognised in either ending, so it keeps its
translated card. Harnesses whose sign-in needs a fresh session, and the
fallback for a harness with no recorded sign-in, keep their wording.

Builds on #21481 by @dodgeblaster.

(cherry picked from commit 674ee76)
…30928)

The sign-in error arm put "Your session has expired." in front of the
signed-out message, but the same signals fire for a host that was never
signed in, so a first chat after install said the session expired. The
signed-out message alone is true in both cases.

Fixes #29699

(cherry picked from commit f289a6d)
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 7, 2026
@buluoray
buluoray force-pushed the crew/slack/0.12.1-batch-36 branch from ade13f4 to 24760e8 Compare November 7, 2026 16:09
@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 7, 2026
@buluoray
buluoray merged commit b91dae3 into release/0.12.0 Nov 7, 2026
24 of 48 checks passed
@buluoray
buluoray deleted the crew/slack/0.12.1-batch-36 branch November 7, 2026 17:46
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants