Repository navigation
fix(meetings): ask before an exit drops unsent chat or quick-add text - #32625
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: every exit already went through Notes
[DESIGN-REVIEWED] 9dff399 Description read[DESCRIPTION-READ] 1f8b27f282c7a517cf6058ebb06b059f31159a7b57c509dbefcfc151684a637c That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. One gap in coverage: navigating out through the app shell still drops unsent text without asking, and the description leaves those exits out. Notes
What this change shipsInventory (8 items) — 8 justifiedIntent: let a user leave a meeting without silently losing typed-but-unsent text or unsaved minutes edits. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] 9dff399 Description read[DESCRIPTION-READ] 84ef86fa6cd7bbf3d86dd5b281f4b694dbe3cc0e63c7dc154d80a799a09dd220 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: every dialog wording and the typed-text-then-Back path are pictured, and the blind reader read "Cancel" and "Discard and leave" correctly. Notes
[UX-REVIEWED] 9dff399 Description read[DESCRIPTION-READ] 4525d4948a33be783f3b933a4dcc3503d3005ad964031862b7bb2e4b3e362f7a That sha256 names everything this verdict read: the PR description, plus the 12 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
[operator: bolichen97] Rebased: main moved in the Backend Tests shard 5 and 6 tests since this head ran (4048364 -> 390fc5d, onto main with #32606); CI re-running. This head also answers the UX blocker: per a maintainer ruling, unsent text now gets its own "Leave with unsent text?" dialog that names what is lost, with "Discard and leave" as the confirm label, in every locale. A minutes draft alone keeps the "Discard unsaved changes" dialog. The "new dialog wording" bullet is removed from Not a goal, and the screenshots show the new dialog. |
4048364 to
390fc5d
Compare
390fc5d to
ee3ac95
Compare
|
span=1ceeaf61a008
|
ee3ac95 to
08b3602
Compare
|
[operator: bolichen97] Fixed the Frontend Tests (3) red on ee3ac95: |
08b3602 to
06eda36
Compare
|
self-added: yes
|
|
self-added: yes
|
06eda36 to
3d0eded
Compare
|
[operator: bolichen97] Rebased onto main to clear a merge conflict in AI-assisted, posted on behalf of bolichen97 |
Text typed into an agent's chat line, the broadcast bar or quick add, and not yet sent, vanished when the user pressed Back, opened Settings, followed the transcription notice's Voice settings action or opened the meeting a refused Start names. A minutes draft was only guarded on the last of those. Every exit now goes through the one `leave` path: it saves the note, then asks when a marked input holds non-blank text or a minutes draft is unsaved. The Voice settings action becomes a button that leaves through `leave` and navigates with the SDK's `useNavigate`, so the local `host/Link.tsx` is unused and removed. The six new strings are in every ui/i18n catalog and the committed bundle is rebuilt. Carries kirodotdev/KiroCrew#32625 (closes kirodotdev/KiroCrew#30636).
Back, Settings, the streaming-off notice's Voice settings action and opening the meeting a refused Start names all unmount the meeting view, and with it the text typed into an agent's chat line, the broadcast bar or quick add that was never sent. Every one of these exits now saves the note first and then asks with the existing "Discard unsaved changes" dialog when such text, or an unsaved minutes draft, would be lost; with nothing unsent it leaves as before. Closes #30636
3d0eded to
9dff399
Compare
|
[operator: bolichen97] Rebased onto main for the Backend Tests shard 6 red on 3d0eded (Linux and Windows): The external Meetings repository now carries the same fix: KiroCrewCaptain/kirocrew-app-meetings commit Retrospective for this round (run in-line: no model-pinned subagent facility in this driver): the three declared mechanisms (exit check over AI-assisted, posted on behalf of bolichen97 |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Approved on head 9dff399: PR Readiness is green, every AI review lane on this head passes with no blocking findings, and no change request stands.
Problem / Motivation
Goal: Leaving a meeting never silently throws away text the user typed but did not send.
In a meeting, text typed into an agent's chat line, the broadcast bar or the quick-add field, and not yet sent, vanished when the user pressed Back, opened Settings, or followed "Open that meeting" on a refused Start. Nothing asked first. An unsaved minutes draft was only guarded on the last of those exits.
Why it matters
A user who types a correction, an aside to the agents or an action item, then clicks Back or the agent settings button, loses that text with no warning and no way back. The issue asks that every exit treat unsent text the way it treats unsaved minutes: keep it, or ask before dropping it.
Not a goal
An earlier version of this PR also listed "new dialog wording" here and reused the minutes "Discard unsaved changes" dialog. A maintainer ruled that the question must say what is lost and that confirming leaves the meeting, so that bullet is gone: every exit dialog gets leave wording below.
What changed (motivation → approach → change)
Exits of the meeting view go through one
leavefunction. It saved the note, then navigated. Only the "Open that meeting" path also checked minutes drafts, none checked the one-line inputs, and the transcription notice's "Open Voice settings" link skippedleavealtogether.leavenow runs one check after the note save. It asks when a minutes draft is unsaved (Back and Settings used to drop one silently), or when an agent's chat line, the broadcast bar or quick add holds non-blank text. The Voice settings link becomes a button that leaves throughleave, like "Open that meeting". Those three inputs are uncontrolled, so their text exists only in the DOM. Each is markeddata-unsent, and the check reads their values under the view's root at the moment of exit. With nothing unsent, every exit leaves exactly as before. The six new strings live underapps.meetings.meetingin every locale catalog (website/src/i18n/locales/en.jsonand its translations), with theen-XApseudolocale regenerated. The meetings spec (docs/system-specs/modules/meetings.md) describes the exit rule and lists the new test.The external Meetings repository carries the same fix: KiroCrewCaptain/kirocrew-app-meetings commit
9b63fe85ef435790b05839f1d3e82dde22756004ports it into that repository'sui/with the same test, all twelveui/i18ncatalogs and a rebuiltui/dist/index.mjs, and its CI is green. Meetings is not pinned to that repository yet, so nothing here depends on the commit.Backwards compatibility
Compatible: no API, route or stored data changes; an exit with nothing unsent behaves as before.
Removes nothing: the change only adds a confirmation before an exit that would drop typed text.
Tests
MeetingsExitUnsent.test.tsxrendersMeetingViewwith the session hook stubbed and pins:data-unsentattribute on adivdoes not block the exit: the check reads onlyinput[data-unsent].Ten of the twelve cases fail on
main; the blank-text and agent-output cases pass on both, as they should. The agent-output case fails when the selector is widened back to[data-unsent].MeetingsNote.test.tsx's source pin ofleaveis updated to the new shape (note save first, then the check). Thesrc/i18ncatalog suites (parity, placeholders, per-locale style) pass with the new strings.Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
Ran the built SPA against stubbed meeting APIs in Chromium (the repository's meetings capture-harness pattern): typed into the broadcast bar and pressed Back, saw "Leave with unsent text?"; with an edited agent output as well, saw the body that names both; with only an edited output, the earlier build showed "Discard unsaved changes"; this head shows "Leave with unsaved edits?" (frames below).
Screenshots / video
Unsent broadcast-bar text, then Back asks (dark):
Unsent text and an unsaved edit to an agent's output: the body names both.
An unsaved edit alone now says that confirming leaves the meeting. The dialog is rendered by a capture entry through the same
useConfirmcall and catalog keysMeetingViewpasses:The streaming-off notice's "Open Voice settings" action keeps its look (an underlined text action, the same element as "Open that meeting"); it is not pictured because that notice needs a live transcription refusal the stubbed harness does not produce. Its behaviour is pinned by
MeetingsExitUnsent.test.tsx.Before the dialog: typed text, Cancel, and the empty case
Related Issues
Closes #30636
Sibling sweep
Swept: git grep -nE "<Input|<textarea|<input" -- website/src/apps/meetings/
Sibling: website/src/apps/meetings/components/AgentPanel.tsx -- changed here
Sibling: website/src/apps/meetings/components/BroadcastBar.tsx -- changed here
Sibling: website/src/apps/meetings/components/TaskSidebar.tsx -- changed here
Sibling: website/src/apps/meetings/components/MeetingTitle.tsx -- not affected -- the title saves on blur, which the exit click triggers first
Sibling: website/src/apps/meetings/components/NoteSidebar.tsx -- not affected -- the note is saved by the exit before anything else runs
Pattern harvest
Not generalizable: the fix routes this view's existing single exit through one unsaved-text check; other views keep their own drafts in their own ways.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project's Apache-2.0 license (see the Licensing section of CONTRIBUTING.md).