Skip to content

fix: backport 0.12.1 batch 43 (10 user-reported fixes) - #32641

Merged
buluoray merged 10 commits into
release/0.12.0from
crew/slack/0.12.1-batch-43
Nov 7, 2026
Merged

buluoray merged 10 commits into
release/0.12.0from
crew/slack/0.12.1-batch-43

Conversation

@buluoray

@buluoray buluoray commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Bring ten small user-reported fixes that merged on main after v0.12.0 onto release/0.12.0, one commit each, in a PR of its own.

Why it matters

Each fix closes an issue a user filed. Each faulty line was checked on release/0.12.0 before the pick; the right-hand column names it.

PR Reported by What a 0.12.0 user sees today Faulty code on release
#30950 Helgiorn (#25248) A blocked command's notice does not say that none of the command ran. deny_notice.py:57
#31206 billtarr-aws (#27147) A Slack thread gets a transport error reply after its answer was already delivered. slack/transport_dispatch.py:1469
#31248 rohnkum (#26827) On Windows, app storage reads a stored key as missing. apps/app_storage.py:179
#31414 peepeepopapapeepeepo (#22137) A worktree cannot start from a repo nested in another session's project. dashboard/handlers/worktree.py:841
#31924 tmack8001 (#30745) Open Approvals has no visible resting style in the Crew worker kit. crew/WorkerKitPane.tsx:227
#31955 Zedmor (#31911) After service install, nothing says how to open the dashboard. service/controller.py:136
#32142 jongaffen (#27851) On Windows, a % in a path breaks the pi gate launcher. acp/harness/pi.py:559
#32311 Monky1989 (#25166) The composer's list hint overlaps the typed text. ChatInput.tsx:1440
#32177 cpedia (#16887) The sandbox mount-source janitor's pin scan uses up its sweep budget, so reclaim stalls. sandbox_mount_sweep.py:811
#32132 jongaffen (#27855) On Windows, a data home spelled with the \\?\ prefix cannot be exported. portability_export.py:325

Not a goal

  • No fix that is not already merged on main; nothing is changed only here.
  • No version bump, no tag, no CHANGELOG.md change.

What changed (motivation → approach → change)

Each main squash commit was cherry-picked with -x onto release/0.12.0 @ 04891384c7, in merge order on main, one commit each. Every pick applied cleanly; every file has added and removed lines identical to its main commit.

# PR main commit release commit
1 #30950 say that none of a blocked command ran in the deny notice bc3d9cc31e 4995ebc893
2 #31206 skip the transport error reply once the answer was delivered 406e8c6e7d de7020dda5
3 #31248 app storage no longer reads a stored key as missing on windows f7078c0f6c fe5e1a4c7f
4 #31414 start a worktree from a repo nested in another session's project 678769e234 fab603e90a
5 #31924 give Open Approvals a visible resting style 93c7820f07 d285a144cf
6 #31955 tell the user how to open the dashboard after service install 1109563a0e bf26029c6a
7 #32142 escape % in the pi gate launcher's cmd paths on windows 1ab5673b17 4955445787
8 #32311 keep the composer list hint from overlapping the typed text 4a0b1392d4 e49a84b5ff
9 #32177 keep the pin scan out of the mount-source sweep budget 727392d0d0 bb0bad8f55
10 #32132 export a data home spelled with the \\?\ prefix 6f63fe7b6d 15b2303cee

#31924 and #31955 carried a co-author trailer with an internal address, which the push guard refuses, so those two commits are authored with the public identity and name their original author in the message; the trailer line is removed. The other eight keep their original author.

builder-security checked: no bind, listener, route, auth mechanism or storage grant changes.

Backwards compatibility

Compatible: each change is the one already merged on main, and its compatibility note applies unchanged.

Removes nothing: no setting, key or caller is removed.

Tests

Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs

  • CI does not run the backend suite on PRs into release/*, so the related set was run here: every touched test file plus every test file that imports a touched module, 46 files, -n 4 --dist loadgroup. 2056 passed, 67 skipped, 0 failed.
  • Frontend: tsc -p tsconfig.app.json --noEmit passes. vitest run ChatInput WorkerKitPane: 75 files, 1060 passed, 3 failed. The 3 are in ChatInput.approval.test.tsx and fail the same way on a clean release/0.12.0 @ 04891384c7.
  • flake8 passes on the changed Python files.

Manual verification

N/A - each fix was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.

Screenshots / video

Why no screenshot: the two frontend picks (#31924, #32311) carry the same rendered change as their main PRs, whose screenshots show it.

Related Issues

Backport to the 0.12 line for 0.12.1 of #30950, #31206, #31248, #31414, #31924, #31955, #32142, #32311, #32177 and #32132. Source issues: #25248, #27147, #26827, #22137, #30745, #31911, #27851, #25166, #16887, #27855.

Sibling sweep

Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.

Pattern harvest

Not generalizable: this PR only carries fixes already on main. The source PRs have their own harvest.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

bolichen97 and others added 10 commits November 7, 2026 21:24
When a safety policy blocks a shell call that chains several commands
(git add && git commit && git push), nothing in it runs, including the
steps before the one that was refused. The host notice named the rule
but not that, so the model could assume the commit had landed. The
policy notice, and the fallback recovery prompt a harness without steer
gets, now say no part of the call ran, a chained command's earlier
steps included. No matcher changes.

Closes #25248

(cherry picked from commit bc3d9cc)
…31248)

AppStorage.get() read each value file with a bare read_text() and turned
any OSError into None. On Windows a read that overlaps a concurrent
set()'s atomic replace raises a sharing violation, so get() answered
"absent" for a key that is present, and a get-or-default caller then
overwrote the live value with its default.

_read now goes through read_bytes_with_retry, as its sibling
_read_digest_key already does, so that window is retried off the event
loop. An absent or damaged file still reads as None; the write and
delete paths are unchanged.

Builds on #26839.

Closes #26827

(cherry picked from commit f7078c0)
The Add abilities success banner offered Open Approvals as a stock Btn:
a transparent fill with a --border edge. On the banner's translucent
ok tint that edge measures 1.08:1 (light) and 1.21:1 (dark), so the
control only read as a button on hover. It now rests on --bg-elevated
with a --border-strong edge; hover is unchanged. The shared Btn is not
touched.

Fixes #30745

## Pattern harvest

Not generalizable: one call site places a default Btn on a tinted
banner; other banners already style their buttons per site.

(cherry picked from commit 93c7820)

(cherry picked from commit 909165ce7518d6c5bbc1f0f887a8e0255f33381a)

Original author: Matthew Briones (#31924).
…nstall (#31955)

A service never opens a browser, so the install success block is the only
guide a new user gets. Add an 'Open: kirocrew token' line ahead of the
status/logs/remove hints on both systemd and launchd.

Fixes #31911

(cherry picked from commit 1109563)

(cherry picked from commit ba85997898619677046baee4dfbca42f5fc4215f)

Original author: Zezhen Xu (#31955).
)

A composer the user had resized by hand kept its height when the
list-indent hint row appeared. The text column shrank below the
textarea's 44px floor, so the textarea overflowed onto the hint and
the typed prompt and the hint were painted in the same place.

With the plain textarea, the manually sized box now never goes below
what its rows need: the wrapper takes a min-content floor and the text
column carries the textarea's 44px, so a row shown inside the box
grows it instead of sitting under the text. A taller manual height and
the auto-sized composer keep their sizes. The rich-text editor, which
never shows the hint, keeps min-h-0: its draft would otherwise count
toward the floor and grow the box line by line.

Closes #25166

(cherry picked from commit 4a0b139)
…32177)

On a busy host the keyed mount-source sweep's host-wide pin scan took
longer than the whole 10 s pass budget. The scan runs lazily at the
first directory candidate inside that budget, so the next budget check
ended the pass and each pass reclaimed one batch, fewer entries than
the readiness probes stage between passes.

Take the scan's own duration off the budget clock, as the legacy pass
already does by starting its clock after its scan. The scan still runs
at most once per pass and only when a directory candidate exists, and
the directory gate is unchanged.

Closes #16887

(cherry picked from commit 727392d)
…2132)

* fix(portability): export a data home spelled with the \\?\ prefix

* fix(portability): keep fenced files out under a \\?\ data home

The fence builds its targets from the root's own spelling, so ask it about that spelling as well as the folded real path.

Refs #27855

(cherry picked from commit 6f63fe7)
@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 7, 2026 21:34
@buluoray
buluoray requested review from tim-finnigan and removed request for a team November 7, 2026 21:34
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Sensitive Change Review

Sensitive files changed:

  • src/kiro_crew/sandbox_mount_sweep.py

  • No reasoning template for 15b2303 yet.

How to clear this check:

  1. The PR author posts the template below as a PR comment, with
    every field filled (N/A needs a reason). Keep the
    Head commit line: it must name the current head SHA.
  2. The check turns green within a minute, with no push.
  3. A new push resets this check: post it again for the new head.

Only the author's comment counts this way. A reviewer can instead
paste the filled template into an "Approve" review on this head.
Merging still needs a reviewer's approval.

## Sensitive change review
- Head commit: 15b2303ceed41616311ced5bac8ba31fcfb763e1
- What rule changed:
- Before -> after (what was allowed/blocked, now):
- Worst case if wrong (breaks commands / leaks secret / locks user out):
- Evidence checked (which sandbox result proves it):
- No regression:
  - Tools still work (which tools/commands were run, result):
  - Backward compatible (old config / old data / old callers still work, how checked):
  - Existing tests (which suites passed on this head):
- How to undo:

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 7, 2026
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of 15b2303ceed41616311ced5bac8ba31fcfb763e1 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing screenshots of the two dashboard fixes, the restyled "Open Approvals" button and the composer list-indent hint. The PR attaches no image, so the blind read was not performed.

Evidence gaps

  • "Open Approvals" button in the Crew worker kit's done row (WorkerKitPane.tsx, new border-border-strong bg-bg-elevated). The whole point of the fix is that the button is visible at rest on the translucent ok tint, and that only shows in pixels. To close: attach a still of the done row with approvals pending, in light and dark themes.
  • Composer list-indent hint after a manual resize (ChatInput.tsx, min-h-min / min-h-[44px] with the textarea). The claim is that the hint grows the box instead of the text covering it. To close: attach a still of the manually resized composer showing the hint and the typed text, with no overlap.

Notes

  • The deny notice now reads "…before any of it ran: if it chained several shell commands, none of them ran, the earlier ones included". It repeats itself. Suggest: "…before it ran. None of a chained command's parts ran."

[UX-REVIEWED] 15b2303

Description read

[DESCRIPTION-READ] e377d5c0e94780935236b16f94e9804406e5dd0e49586296d5e41a20c85a890c

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 15b2303ceed41616311ced5bac8ba31fcfb763e1 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks. These are ten clean cherry-picks of fixes that already merged on main, and their Windows and frontend changes already went through CI and review on their own PRs.

Notes

[DESIGN-REVIEWED] 15b2303

Description read

[DESCRIPTION-READ] e37060669e1b2d316b2d24f6fe1b8ed5077c32fcd8392f91482b56e0861c4021

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 15b2303ceed41616311ced5bac8ba31fcfb763e1 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

This is a backport of ten fixes already merged on main. Each one cites a user-filed issue and a faulty line on release, and none adds surface beyond its fix.

Notes

What this change ships

Inventory (10 items) — 10 justified

Intent: give 0.12.x users ten user-reported fixes that already merged on main — FIX.

  1. A blocked-command notice and the recovery prompt now say none of a chained command ran — justified
  2. A Slack thread no longer gets a transport-error reply after its answer was delivered — justified
  3. On Windows, app storage retries a sharing violation instead of reading a key as missing — justified
  4. Worktree creation uses the most specific project root that contains the repo — justified
  5. The Open Approvals button has a visible resting style — justified
  6. service install prints a kirocrew token hint for opening the dashboard — justified
  7. On Windows, the pi gate launcher escapes % in paths and refuses quotes and newlines — justified
  8. The composer's list hint no longer overlaps typed text — justified
  9. The mount-sweep pin scan no longer counts against the sweep time budget — justified
  10. A data home spelled with the \\?\ prefix can be exported — justified

[FIRST-PRINCIPLES-REVIEWED] 15b2303

Description read

[DESCRIPTION-READ] a60a30a8d024bc3a6c0e5b9df07ba7c546ce019972df655801fb041571053355

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 15b2303ceed41616311ced5bac8ba31fcfb763e1 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 15b2303

Verdict parsed from the review's SHA-scoped output markers for commit 15b2303ceed41616311ced5bac8ba31fcfb763e1.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 15b2303ceed41616311ced5bac8ba31fcfb763e1 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 15b2303ceed41616311ced5bac8ba31fcfb763e1 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 15b2303

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 15b2303ceed41616311ced5bac8ba31fcfb763e1 false-positive: <reason, 20 to 500 characters>

@buluoray
buluoray merged commit b80bdd7 into release/0.12.0 Nov 7, 2026
19 of 23 checks passed
@buluoray
buluoray deleted the crew/slack/0.12.1-batch-43 branch November 7, 2026 21:40
@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Nov 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants