Repository navigation
fix: backport 0.12.1 batch 44 (10 user-reported fixes) - #32647
Conversation
…30578) on_app_enable and boot recorded the loaded hook signature only when ctx.health was healthy, so an app whose successful on_startup called ctx.health.mark_degraded was torn down and re-enabled every reconcile tick. Gate the record on the wiring itself: routes registered without a failure mark and on_startup returned normally. Health is still published. (cherry picked from commit f8c4df6) Original author: Zezhen Xu (#30578).
(cherry picked from commit b764e20)
…ds (#31571) The shared place_single_binary_array admitted the gateway's session-bound kirocrew-work broker stub only behind an opt-in keyword that opencode alone passed. goose, copilot, deepseek and strands place their mcpServers array through the same function, so a worker on any of them got no work_brief, work_report or work_ledger_record, and its conductor could not tell it from a dead one. The stub is safe to mount for a reason that does not depend on the harness: gatewayd checks its stub token on every call, and only the exact gateway shape bound to this session's token is admitted. Drop the keyword so the admission applies on every caller. A narrowed server is still withheld whole on the harnesses without a per-tool deny channel, the tools allowlist and disabled still apply, and every other identity-bound server stays withheld. Builds on #27066 by leonlaiyc. Closes #27064 (cherry picked from commit a119f8a)
#31727) A file search for the text `-d @` or `-F x=@` was refused by the exfil gate: with no command, the only text a grep or glob call is judged on is its title, which is the text it searches for, and the curl rows read it as a command line. A call whose host-trusted identity names the grep or glob built-in, with no MCP server and no command of any kind, runs no shell, so the exfil rule no longer judges it. Every other tier still does; an untrusted or MCP-served name, the code built-in and any call carrying a command keep the rule. Builds on #23845. (cherry picked from commit de98390)
…24742) _resolve_project_relative and the path-completion witness check tested containment with startswith(root + os.sep). realpath keeps the separator of a root, so for a project at H:\ or / the prefix became a doubled separator and every relative path or subdirectory under the project was refused as outside it. Both now ask sandbox_plan.path_within, the helper the validate_cwd and terminal sites use. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit eaf92fc)
A temporary chat promises no memory reads, but a legacy member's session-start, slim-resume and post-compaction sections still read the agent-writable briefing into [CURRENT ASSIGNMENT]. Pass include_briefing=not blocks_reads at those three sites, as the private-member envelope already does for temporary turns, so the section carries the withheld placeholder instead. Builds on #21630. (cherry picked from commit 9b6af7a)
The Channels page followed new messages with scrollIntoView on an empty end-of-list sentinel, and scrollIntoView scrolls every scrollable ancestor, not only the list. The channel pane was sized h-full inside the page's overflow-y-auto content container, so anything shown above it (an error notice) made the container overflow: an agent reply then scrolled the page and the notice out of view, and the notice pushed the composer below the bottom edge. Scroll the message list element itself, and make the channel pane a shrinking flex child of the standard content container, so a new message moves only the list and the composer stays in view. On a phone the pane's existing -mb-8 now cancels the container's bottom padding, as it was written to, so the composer sits on the bottom edge. Builds on #29402 by JuntaoMei. Co-authored-by: Juntao Mei <14120031+JuntaoMei@users.noreply.github.com> (cherry picked from commit a65bf4c)
…#32403) A cron job's advertised next run and its timer boundary were computed by handing croniter an aware start in the job's zone. croniter 2 then shifts any run that lies past a DST change by the offset change a second time: a 03:00 job read 04:00 PST the day before the fall-back, a 22:00 job 21:00 PDT the day before the spring-forward, and is_due refused the advertised instant. Step the zone's naive wall clock instead and attach the zone to the result, as the schedule label already does. A repeated wall time whose first instant is not after now takes its second; a spring-forward gap resolves as fold=0 does, as before. Builds on #24864. Closes #24853 (cherry picked from commit 83ec532)
(cherry picked from commit 430c260)
Sensitive Change ReviewSensitive files changed:
How to clear this check:
Only the author's comment counts this way. A reviewer can instead |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. The only website change is a scroll fix in [UX-REVIEWED] 344cc30 Description read[DESCRIPTION-READ] 78050fab4081367e08905862bc3a7b31f4712b2734a496b99617d7edcd1725b6 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks: ten cherry-picks from What this change shipsInventory (10 items) — 10 justifiedIntent: give 0.12.x users ten bug fixes already merged on
[FIRST-PRINCIPLES-REVIEWED] 344cc30 Description read[DESCRIPTION-READ] f0314807ee34948cf084ed1ee11dde10e8e5357d72b995946518098a39a076c2 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)Design-level review of Design-Verdict: PASS cannot evaluate: missing screenshot or recording of the Channels page at this revision. The #32391 pick changes the page's layout, and the workflow's evidence list is empty: 0 attachments and 0 committed images. BlockersThe ChannelPage layout change has no rendered evidence of this revision Notes
[DESIGN-REVIEWED] 344cc30 Description read[DESCRIPTION-READ] d124c1d7a571017a77daf157786684d26e14f42fb3f42c47cf27c76d48bee78c That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Security Scope Review -- ✅ PASSWhich legitimate operations does Verdict basis: adjudicated, zero confirmed regressions. Security scope review -- adjudicated candidates
No candidate flipped from allowed to refused. Scope-Verdict: PASS Reason: The only change in the shell deny composite loosens it. TIGHTENING: No shell-tier tightening. The ADJUDICATED: 18 candidates, 0 confirmed newly-refused PLATFORM COVERAGE: posix and windows. The posix rows cover these neighbours of the UNADJUDICATED:
[SCOPE-REVIEWED] 344cc30 |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
Problem / Motivation
Goal: Bring ten small user-reported fixes that merged on
mainafterv0.12.0ontorelease/0.12.0, one commit each, in a PR of its own.Why it matters
Each fix closes an issue a user filed. Each faulty line was checked on
release/0.12.0before the pick; the right-hand column names it.apps/hooks_integration.py:560packaging/build-desktop.sh:871providers/mirrors/opencode.py:340(place_single_binary_array)hook_runtime/gate_tiers.py:618dashboard/file_api/pinned_io.py:430embeddings_model.py:294context_assembly/session_start.py:409ChannelPage.tsx:918cron_service/schedule.py:642cli_server_restart.py:386Not a goal
main; nothing is changed only here.CHANGELOG.mdchange.What changed (motivation → approach → change)
Each main squash commit was cherry-picked with
-xontorelease/0.12.0@b80bdd7f7d, in merge order onmain, one commit each. Every pick applied cleanly; every commit has added and removed lines identical to its main commit.f8c4df63ee630d0ac35fb764e20635ae455253d0a119f8acbe78d933a027de983908adfae3e2c9e6eaf92fc277f235468c5609b795325c3dbd46fb4b9b6af7a19fee8b60c402a65bf4c55d8380d550b483ec53299b8e610c7005430c260549344cc309c8#30578 carried a co-author trailer with an internal address and a non-public author email, and #30690 a non-public author email, which the push guard refuses. Those two commits are authored with the public identity and name their original author in the message; the internal trailer line is removed. The other eight keep their original author.
builder-security checked: #24742 changes the file API's project-containment check, the same change already merged on
main; no bind, listener, route, auth mechanism or storage grant changes.Backwards compatibility
Compatible: each change is the one already merged on
main, and its compatibility note applies unchanged.Removes nothing: no setting, key or caller is removed.
Tests
Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs
release/*, so the related set was run here: every touched test file plus every test file that imports a touched module, 52 files,-n 4 --dist loadgroup. 1893 passed, 26 skipped, 0 failed.tsc -p tsconfig.app.json --noEmitpasses.vitest run ChannelPage channelNarrow: 8 files, 154 passed.node --test electron/test/packaging.test.js: 48 passed, 3 failed. The same 3 (Linux desktop naming,first-download installer design contract) fail on a cleanrelease/0.12.0@b80bdd7f7d.Manual verification
N/A - each fix was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.
Screenshots / video
Why no screenshot: the one frontend pick (#32391) carries the same rendered change as its main PR, whose screenshots show it.
Related Issues
Backport to the 0.12 line for 0.12.1 of #30578, #30496, #31571, #31727, #24742, #30690, #31791, #32391, #32403 and #32087. Source issues: #30510, #14618, #27064, #23586, #24475, #29048, #21617, #29400, #24853, #27775.
Sibling sweep
Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.
Pattern harvest
Not generalizable: this PR only carries fixes already on
main. The source PRs have their own harvest.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.