Repository navigation
fix: backport 0.12.1 batch 45 (9 user-reported fixes) - #32653
Conversation
…30912) A script cron's ctx.call_tool() runs the credential scan over its arguments and sends the redacted copy. When the scan replaced a whole argument, such as an opaque mail id the bare-secret pass mistakes for a key, the server got only the placeholder and answered with its own error ("Id is malformed"), so the script could not see the cause. The call is now refused inside the audited call, with a ValueError naming the argument's path and never its value. A credential-shaped span inside a longer string is still sent with the span redacted, and kirocrew cron preview runs the same scan. Nothing that was redacted is sent unredacted. Closes #26246 (cherry picked from commit 71f6de0)
When the security event log could not open its own file at startup (another process held it without sharing, or EACCES), the chain tip read returned "" as if the log were empty. The next record then landed mid-file with an empty prev_hash, and `kirocrew security verify` reported the honest log as compromised. Only an absent or empty log, or one with no parseable record, now starts the chain from genesis. Any other read failure raises: construction still succeeds and marks the tip unknown, and the first append reads it again under its locks. A re-anchor whose read fails keeps the identity it compared against, so the next append reads the tip again too. While the read keeps failing the append fails like any unwritable audit: a critical audit is denied and a best-effort batch takes the writer's existing failure path. (cherry picked from commit cfdec3b)
…26789) * fix(artifacts): restore the target version's render kind on revert update() records version_kinds so a revert restores the right render-mode, but on a revert it stamped the CURRENT kind: reverting to a pre-pull widget snapshot left the artifact as html -- the raw inner fragment the recorded kind exists to prevent. The revert callers send no kind, so the store is the only place that can honour it. On event_type=="reverted" with from_version, restore art.kind from version_kinds[from_version] before stamping the new version. Closes #26784 * fix(artifacts): never restore a dashboard or webapp kind on revert The revert kind restore runs after the dashboard fence and write gate, which saw the current kind. Restoring into or out of dashboard/webapp there would skip them, so those kinds stay as they are. --------- Co-authored-by: iamwhatever <12429733+iamwhatever@users.noreply.github.com> (cherry picked from commit 820ec27) Original author: rohnkum (#26789).
(cherry picked from commit e51597a)
AcpProvider.__init__ wrote the effort and Tool Search overlays itself. The session allocator builds the provider on the event loop, where a cli.json lock acquire makes one attempt and never waits, so a sibling session holding the lock for a moment refused the write and logged a WARNING traceback at gateway restart. start() already writes both overlays before every spawn, the first one included, from a worker thread where the lock wait is real. The constructor's write was a duplicate of it, so it is removed. Closes #20451 (cherry picked from commit bd49ea0) Original author: Bolin Chen (#31813). docs/system-specs/modules/harness-parity.md H6 row hand-resolved: the same phrase edit applied to the release wording.
Every gateway unit this repo writes left RLIMIT_CORE at systemd's default, which is unlimited wherever core_pattern pipes to systemd-coredump. A fatal signal then streams the whole multi-GB gateway into systemd-coredump, the process cannot finish exiting until that is done, and systemd-coredump stops at its 5-minute runtime cap, so the dashboard and sessions stay down for about five minutes. Set LimitCORE=0 in the unit `kirocrew service install` renders (user and system scope), the pod template unit (and require it, so pod up re-renders an installed pod unit without it), the EC2 bootstrap unit and the two documented hand-written units. The faulthandler stack dump stays the crash record; processes the gateway starts inherit the limit, and a drop-in restores core files. Closes #26092 (cherry picked from commit c40e8b7) Original author: Bolin Chen (#31607). test/test_pod_systemd.py docstring hand-resolved: kept main's docstring, which names the LimitCORE check.
Inside the agent sandbox memory_stores is read-only by design, and member backups are written inside it, so `kirocrew memory backup` and the pre-update copy of `kirocrew update` run there failed every member store with bare EROFS tracebacks. The seal stays. The backup pass logs one line per member store instead: member stores are read-only in the sandbox, back up from the dashboard or your own terminal, plus the errno. It is decided from the refused write's path, the way `kirocrew config set` already does, and the store-use lock no longer tries to tighten its directory on a read-only mount, so no traceback comes first. (cherry picked from commit 8237603) Original author: Bolin Chen (#31510). test/test_member_memory_backup.py import hand-resolved: added only import errno; release never imported gc.
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: each of the nine hunks backports a fix already merged on Notes
[DESIGN-REVIEWED] 0122dc6 Description read[DESCRIPTION-READ] d0a8453f3474bafae8e1465c84f7b9ee9aeff3edfedd404929a2f3ff11289ae1 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks: this backports nine fixes already merged on What this change shipsInventory (10 items) — 10 justifiedIntent: give 0.12.x users nine user-reported fixes that
[FIRST-PRINCIPLES-REVIEWED] 0122dc6 Description read[DESCRIPTION-READ] 53be4ee00c48c0594158162ea94bd69d818c47856a4ea79a932d9b9457de9d3b That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
9b6303f to
0122dc6
Compare
|
Goal edited at the maintainer's request: ten fixes -> nine. #32396 is removed from this PR (head 9b6303f -> 0122dc6) because Opus 5.5's finding on |
Problem / Motivation
Goal: Bring nine small user-reported fixes that merged on
mainafterv0.12.0ontorelease/0.12.0, one commit each, in a PR of its own.Why it matters
Each fix closes an issue a user filed. Each faulty line was checked on
release/0.12.0before the pick; the right-hand column names it.cron_script_context.py:321sel.py:305artifacts_writes.py:706artifacts_parts/publish_sharing.py:53cli.jsonlock.providers/acp.py:318service/linux_unit.py:388member_memory_backup.py:93messaging/dispatch.py:1071\\?\path fails the containment check.dashboard/file_api/workspaces.py:148Not a goal
main; nothing is changed only here.CHANGELOG.mdchange.dashboard/chat_turn/stream_chunks.py:220), so the saved and shown transcript is out of order.mainhas the same code. fix: drop post-quiet-end text held for a steer the turn requeues #32396 ships in its own later batch together with themainfix for that ordering.What changed (motivation → approach → change)
Each main squash commit was cherry-picked with
-xontorelease/0.12.0@b80bdd7f7d, in merge order onmain, one commit each.71f6de026e205386f04ccfdec3bbd0ba4cf93e15820ec27645d57065bb6ce51597aa10751dff8e6fbd49ea0a870a0ccceb3fc40e8b7b7adabf1598d38237603a5f9aec0780b405603c85764467e609bc\\?\prefix in dashboard copy_from containment checks7a2bf865140122dc6bbeHand-resolved hunks, docs and tests only:
docs/system-specs/modules/harness-parity.mdH6 rowtest/test_pod_systemd.pydocstringLimitCOREcheck.test/test_member_memory_backup.pyimportsimport errno; release never importedgc.Every other file has added and removed lines identical to its main commit. #32082 also carries its one-row update to
.github/sync-io-in-async-fs-baseline.txt(a line count forworkspaces.py).The three hand-resolved commits, #26789 (non-public author email) and #31746 (non-public author email) are authored with the public identity and name their original author in the message. The other four keep their original author.
builder-security checked: #30900 tightens a channel sender access check and #32082 a file-API containment check, the same changes already merged on
main; no bind, listener, route, auth mechanism or storage grant changes.Backwards compatibility
Compatible: each change is the one already merged on
main, and its compatibility note applies unchanged.Removes nothing: no setting, key or caller is removed.
Tests
Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs
release/*, so the related set was run here: every touched test file plus every test file that imports a touched module, 348 files,-n 4 --dist loadgroup, run on the first head that still carried fix: drop post-quiet-end text held for a steer the turn requeues #32396 (dropping it removes only its own files and tests). 12594 passed, 12 skipped, 8 failed. The same 8 fail on a cleanrelease/0.12.0@b80bdd7f7don this host (real-sandbox tests intest_snapshot_read_only_real_view.py,test_cron_run_scratch.py,test_app_script_cron_sibling_import.py, plustest_auto_improvement_membersandtest_harness_parity.py::test_is_kiro_cli_is_positive).Manual verification
N/A - each fix was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.
Screenshots / video
N/A - no frontend file changes.
Related Issues
Backport to the 0.12 line for 0.12.1 of #30912, #30970, #26789, #31746, #31813, #31607, #31510, #30900 and #32082. Source issues: #26246, #27810, #26784, #20451, #26092, #29365, #29463, #27830.
Sibling sweep
Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.
Pattern harvest
Not generalizable: this PR only carries fixes already on
main. The source PRs have their own harvest.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.