Skip to content

fix: backport 0.12.1 batch 53 (9 user-reported fixes) - #32791

Merged
buluoray merged 9 commits into
release/0.12.0from
crew/slack/0.12.1-batch-53
Nov 8, 2026
Merged

buluoray merged 9 commits into
release/0.12.0from
crew/slack/0.12.1-batch-53

Conversation

@buluoray

@buluoray buluoray commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Bring nine user-reported fixes that merged on main after v0.12.0 onto release/0.12.0, one commit each, in a PR of its own.

Why it matters

Each fix closes a problem a user reported. Each faulty line was checked on release/0.12.0 @ 7ea28ed960 before the pick; the right-hand column names it.

PR Reported by What a 0.12.0 user sees today Faulty code on release
#30065 denisp12 (#19538) A connection's warm token mint spawns with native skill projection and fails. connections/warm.py:995
#30430 chenmingwei23 (#30428) A Bot's team lead has no widget skills and tool_search asks for approval. agent_materialization/service_agents.py:679
#29847 marwen-benzarti (#29662) A worker's quiet nothing_to_do turn still wakes its Bot with an empty report. dashboard/mate_thread_wakes.py:529
#24862 leonlaiyc (#24861) A session-detached child keeps running after its call is cancelled. apps/lifecycle_scripts.py:140
#31642 gwapoats (#24923) The Subagents panel's reconnect replay holds the default executor, stalling chat turns. dashboard/ws.py:1542
#31455 tim-fin (#26059) iMessage replies to a late self-chat copy of its own send. imessage/client.py:418
#32234 jhua-labs (#32141) A PDF attachment is read with a byte-scan extractor that misses its text. doc_parser.py:120
#32455 chriscouldridge (#29678) An agent rebuild keeps an MCP server's old command after it changes. agent_materialization/mcp_sources.py:263
#32518 plasene (Slack) A chat cut off by a planned restart (update apply) does not resume. dashboard/handlers/updates_apply.py:305

Not a goal

  • No fix that is not already merged on main; nothing is changed only here.
  • No version bump, no tag, no CHANGELOG.md change.
  • Not fix: launch root-owned apps under a stock /Applications #31408 (launch root-owned apps under a stock /Applications). It was in this PR's first head and is removed: GPT 6.1's security-class finding on computer_use/launch_macos.py:354, upheld by adjudication, holds. The stock-parent exemption checks only the bundle's own directories, and an admin user (the macOS default) can rename entries in /Applications, so an agent could swap the bundle between the check and the launch and run its own code outside the sandbox. main has the same code.

What changed (motivation → approach → change)

Each main squash commit was cherry-picked with -x onto release/0.12.0 @ 7ea28ed960, in merge order on main, one commit each.

# PR main commit release commit
1 #30065 spawn the warm mint without native skill projection 2df95d317d 8a26e87a95
2 #30430 give the team lead the widget skills and an auto-approved tool_search 4194602e66 ced92862ad
3 #29847 skip the worker report for a quiet nothing_to_do turn 1b4b566257 bbdaf2b6ca
4 #24862 kill a session-detached child when its call is cancelled 61d5dff13b e526c6b053
5 #31642 keep subagent panel folds off the default executor 9eaff06a39 5b55ab289f
6 #31455 drop late self-chat copies of own sends e9e94fddc4 098f7c569d
7 #32234 read PDF attachments through the bounded pdfplumber child 4f63b4e495 7f5d50127b
8 #32455 rewrite a changed MCP command on agent rebuild 0693a32730 9d63273a32
9 #32518 resume chats a planned restart cut off cc5398d76b 55978bed2a

Hand-resolved hunks, docs and tests only:

PR File Resolution
#30430 test/test_agent_refactor_spec_bytes.py (8 golden digests) Kept release's pins and re-pinned only kirocrew-team-lead.json in each of the 8 scenarios to the bytes this tree writes. The team-lead spec's diff against release is exactly tool_search in allowedTools plus the widgets, living-ui and artifacts skills; the other specs and the audit events are unchanged. The resulting pins equal main's.
#29847 docs/system-specs/modules/crew-mode.md (2 hunks) Main's two additions applied to release's "crewmate" wording.
#31642 docs/architecture/resource-protection.md Added only this PR's paragraph; the neighbouring discovery_executor paragraph belongs to a main change not on release.

Every other file has added and removed lines identical to its main commit.

The three hand-resolved commits, #32234 (co-author trailer with an internal address, non-public author email) and #32518 (non-public author email) are authored with the public identity and name their original author in the message; the internal trailer line is removed. The other four keep their original author.

builder-security checked: #31408, the one pick that touched a sandbox boundary, is not in this PR. #24862 kills a cancelled child, #30065 drops a projection from a sandboxed spawn, #32518 adds a resume record on restart; no bind, listener, route, auth mechanism or storage grant changes.

Backwards compatibility

Compatible: each change is the one already merged on main, and its compatibility note applies unchanged.

Removes nothing: no setting, key or caller is removed.

Tests

Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs

  • CI does not run the backend suite on PRs into release/*, so the related set was run here: every touched test file, every test file that imports a touched module, and the tests that read the touched docs, 189 files, -n 4 --dist loadgroup, run on the first head that still carried fix: launch root-owned apps under a stock /Applications #31408. 6504 passed, 12 skipped, 2 failed. Both are in test_apps_registry_identity_admission.py (test_install_script_rewriting_manifest_is_refused, test_provenance_signer_uses_post_script_manifest) and fail the same way on a clean release/0.12.0 @ 7ea28ed960 on this host (the sandbox refuses the test's missing policy_cache directory).
  • After fix: launch root-owned apps under a stock /Applications #31408 was removed: every computer-use test plus the test files of the four commits re-picked after it, 92 files, 5418 passed, 0 failed.
  • test_agent_refactor_spec_bytes.py: 8 of 8 pass with the re-pinned digests.
  • flake8 passes on the changed Python files.

Manual verification

N/A - each fix was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.

Screenshots / video

N/A - no frontend file changes.

Related Issues

Backport to the 0.12 line for 0.12.1 of #30065, #30430, #29847, #24862, #31642, #31455, #32234, #32455 and #32518. Source issues: #19538, #30428, #29662, #24861, #24923, #26059, #32141, #29678.

Sibling sweep

Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.

Pattern harvest

Not generalizable: this PR only carries fixes already on main. The source PRs have their own harvest.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

bolichen97 and others added 5 commits November 7, 2026 23:54
… tool_search (#30430)

The kirocrew-team-lead spec mapped only the team-lead, goal-conductor and
dashboard skills. It is a custom template, so its skill search scope is only
what is mapped: widgets, living-ui and artifacts could not be found, and
WIDGET_BLOCK_AGENTS left it without the per-surface widget pointer. Map the
three skills the conductor maps and add the team lead to WIDGET_BLOCK_AGENTS.

The spec mounted tool_search but did not auto-approve it, while its dispatch
verbs are deferred under MCP Tool Search. Every load that reaches
session_create prompted first in Normal permission mode. Grant tool_search
beside the dispatch verbs in _mount_team_lead_dispatch, only when the
inherited tools mount it; the governance ceiling still filters it in
write_governed_spec.

Only kirocrew-team-lead.json changes: three skill resources and one
allowedTools entry. The spec-byte goldens for that file are re-pinned.

Co-authored-by: Raymond Chen <chenmingwei23@users.noreply.github.com>

(cherry picked from commit 4194602)

Original author: Raymond Chen (#30430). test/test_agent_refactor_spec_bytes.py hand-resolved: the kirocrew-team-lead.json golden digests are re-pinned to the bytes this tree writes (release pins differ from main's in unrelated specs); the team-lead spec diff against release is only tool_search in allowedTools and the widgets, living-ui and artifacts skills.
)

A crewmate's worker session reported back after every top-level turn
end, including a turn that ended through nothing_to_do with no reply
text. note_turn_end recorded a report whenever reply_text was not None,
so an empty string still woke the crewmate's thread with a hidden
"It ended with no reply text." turn. A worker patrolling with
monitor_start ends most cycles that way, so the crewmate spent a full
turn, with its whole context, on each quiet cycle, and those turns
queued ahead of the person's own messages.

The turn's outcome now carries quiet_end: the turn's
_terminal_directive_applied, the applier's verdict that kirocrew-core's
nothing_to_do ended the turn, with an empty _turn_full_reply_text. The
verdict holds for a backend that names no tool on its frame. The text
check reads the turn's whole reply, not the trailing segment, because a
tool call flushes the text written before it out of that segment; it is
the same quiet-end test the Slack mirror applies. note_turn_end records
no report and wakes nobody on a quiet end with an empty reply, and a
report already pending for that worker stays as it was.

A worker that writes and then calls nothing_to_do still reports, an
empty reply without nothing_to_do still reports, and the crewmate
thread's own turn end still delivers what is pending.

(cherry picked from commit 1b4b566)

Original author: Wen Lin (#29847). docs/system-specs/modules/crew-mode.md hand-resolved: main's two additions applied to release's crewmate wording.
The app build, the enable/disable/uninstall lifecycle scripts and the
office-slides soffice conversion each spawn their child in its own
session and killed the tree only when their wait timed out. A cancel
(the gateway shuts down or restarts, including during a first-boot
default install) re-raised with the child still running: third-party
app code, or LibreOffice parsing an untrusted deck, with no deadline
left.

Add the CancelledError arm papyrus uses: kill and reap the tree through
the shielded platform_compat.kill_and_reap, then let the cancel
propagate. The install script's own arm landed separately in #25535.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 61d5dff)
…31642)

Every dashboard tab replays the Subagents panel's history on connect
and on each reconnect. That read ran on the event loop's default
executor, so a few tabs could hold every worker and leave /api/health,
chat switching and every other asyncio.to_thread caller waiting.

The replay now runs on a two-worker pool of its own, in a copy of the
request's context so its audited denials keep their SEL provenance.
The shared discovery pool is not used because chat turns wait on it.

(cherry picked from commit 9eaff06)

Original author: Bolin Chen (#31642). docs/architecture/resource-protection.md hand-resolved: added only this PR's paragraph; the neighbouring discovery_executor paragraph belongs to a main change not on release.
@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 8, 2026 00:06
@buluoray
buluoray requested review from tim-finnigan and removed request for a team November 8, 2026 00:06
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 55978bed2a20e892c61a0a0240dc836279efbf25 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 55978bed2a20e892c61a0a0240dc836279efbf25 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: these are byte-identical picks of fixes already on main, the hand-resolved hunks are only docs and test pins, and the removed internals (_extract_pdf byte-scan, _safe_decompress) have no readers left outside the patch.

Notes

  • The only platform-specific code is the iMessage echo fix (macOS) and the sandboxed pdfplumber child that replaces the stdlib PDF scan on every OS. Neither was tried on this branch, and CI doesn't run the backend suite on release/*. Name these two in the 0.12.1 RC soak checklist so "the soak is the end-to-end check" covers them.
  • The run of 6504 tests was on a head that still carried fix: launch root-owned apps under a stock /Applications #31408. Re-running the full set of related tests on this head would retire that caveat cheaply.

[DESIGN-REVIEWED] 55978be

Description read

[DESCRIPTION-READ] e530bb0b41376c7018bffaddbb69e3c9737722333f6a06dc8466bda320d0adb8

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 55978bed2a20e892c61a0a0240dc836279efbf25 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nine already-merged main fixes, each with a reported issue and a test. No item is new surface beyond its source fix.

Notes

  • Item 9 — inherited: the defect's only cited source is "plasene (Slack)", with no linked issue. Its provenance is the regression test it adds to test/test_chat_resume_all.py, not a record anyone can check.

What this change ships

Inventory (9 items) — 8 justified

Intent: bring nine user-reported fixes from main to 0.12.x users in 0.12.1. FIX.

  1. A connection's warm token mint no longer fails from native skill projection — justified
  2. The Bot team lead gets the widget skills and runs tool_search without asking for approval — justified
  3. A worker's quiet nothing_to_do turn no longer wakes its Bot with an empty report — justified
  4. A detached app child is killed when its call is cancelled — justified
  5. The Subagents panel's reconnect replay no longer stalls chat turns on the default executor — justified
  6. iMessage stops replying to late self-chat copies of its own sends — justified
  7. PDF attachments are read through the bounded pdfplumber child, so their text is found — justified
  8. An agent rebuild picks up a changed MCP server command, and an unresolvable one keeps the old command and logs a warning — justified
  9. A chat cut off by a planned restart (update apply, the Slack restart path) now resumes — inherited: reporter cited only as "plasene (Slack)"

[FIRST-PRINCIPLES-REVIEWED] 55978be

Description read

[DESCRIPTION-READ] 5d038077f7bd56f530bc46d94ae7367eab522e0cfa143724df9db072d71e33b3

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 55978bed2a20e892c61a0a0240dc836279efbf25 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 55978be

Verdict parsed from the review's SHA-scoped output markers for commit 55978bed2a20e892c61a0a0240dc836279efbf25.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 55978bed2a20e892c61a0a0240dc836279efbf25 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 55978bed2a20e892c61a0a0240dc836279efbf25 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 55978be

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 55978bed2a20e892c61a0a0240dc836279efbf25 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 8, 2026
bolichen97 and others added 4 commits November 8, 2026 00:57
In a self-chat on an account with other devices, Messages can write
extra is_from_me=0 copies of a sent message hours or days later. Each
copy has a new guid and ROWID but the sent row's date. The echo ledger
matches for 30 s after the send resolves and is consumed on its first
match, so every late copy reached the agent as a new user message, and
the answer to it got late copies too.

Recognise a copy by when the agent sent it instead of when it arrives.
Each possibly delivered send also goes into a bounded, never-consumed
history of (body key, wall-clock send time). When no ledger record
matches, a row with that body whose bridge created_at is within
ECHO_TTL_S of the send is the echo. The ledger, the gate order in
transport.receive, the TTL and the window size are unchanged, so the
accepted false positive stays the exact text dated within 30 s of the
send. Nothing old is dropped by age, which keeps the cursor's restart
replay working.

The body key the ledger and the history retain is a SHA-256 digest of
the normalized handle and body, so each entry has one size however
long the message is.

The user guide and the messaging spec describe the date-keyed match.

(cherry picked from commit e9e94fd)
…child (#32234)

doc_parser regex-scanned every stream, font programs included, and returned
their ( ... ) byte runs as text, while hex-string glyph ids under subset /
CID fonts were never decoded. Route PDFs through pdf_extract's memory-bounded
pdfplumber child (already used by file-grep and knowledge ingest) so only
page text comes back and a failed parse yields "".

Fixes #32141

(cherry picked from commit 4f63b4e)

Original author: Zezhen Xu (#32234).
A server already in the agent spec kept its old command forever when
~/.kiro/settings/mcp.json switched it to another program: the rebuild
merged onto its own previous output and never reconciled `command`, and
the stored absolute path resolved as-is on every pass.

The reconcile now moves `command`, `args` and `env` as one unit when the
source names a different program. The replaced unit is the last
resolution candidate, so a new command that does not resolve keeps the
old launch with a warning instead of dropping the server. An entry with
a provenance record, and a command the ~/.kiro/crew/mcp.json store
declares, keep their program as before.

Closes #29678

(cherry picked from commit 0693a32)
A dashboard Restart, an update apply or the Slack restart command cuts
every running turn with close_all() before it execs or exits. The next
boot showed those chats as interrupted, the same as after a crash, so
the owner had to press Resume on each one.

Each planned restart (_restart_gateway, the gateway's update restart
and the Slack restart command) now writes the names of the slots that
carry a turn-in-flight marker to resume-after-restart.json in the data
home, just before close_all(). Once the next dashboard boot is ready,
it reads and deletes that file, then resumes only those chats through
the Resume-all run (start_resume_all with only=), so its concurrency
bound and refusals (pending approval, queued message, running
sub-agents) still apply. The file is deleted before the attempt, so a
boot tries once and never loops. A restart with no running chat
removes an earlier file, and a file older than 30 minutes resumes
nothing, so a record from a restart that never ran is not replayed.
A crash writes no file and stays manual.

(cherry picked from commit cc5398d)
@buluoray
buluoray force-pushed the crew/slack/0.12.1-batch-53 branch from 35a0dd5 to 55978be Compare November 8, 2026 01:01
@buluoray buluoray changed the title fix: backport 0.12.1 batch 53 (10 user-reported fixes) fix: backport 0.12.1 batch 53 (9 user-reported fixes) Nov 8, 2026
@buluoray

buluoray commented Nov 8, 2026

Copy link
Copy Markdown
Contributor Author

Goal edited at the maintainer's request: ten fixes -> nine. #31408 is removed from this PR (head 35a0dd5 -> 55978be) because GPT 6.1's security-class finding on computer_use/launch_macos.py:354 holds: an admin user can rename the bundle inside stock /Applications between the check and the launch. main has the same code. The other nine commits are unchanged in content.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 8, 2026
@buluoray
buluoray merged commit 24a7f63 into release/0.12.0 Nov 8, 2026
25 of 37 checks passed
@buluoray
buluoray deleted the crew/slack/0.12.1-batch-53 branch November 8, 2026 01:26
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants