Repository navigation
fix: backport 0.12.1 wide batch 2 (8 user-facing fixes + 2 prerequisites) - #32808
Conversation
Sensitive Change ReviewSensitive files changed:
How to clear this check:
Only the author's comment counts this way. A reviewer can instead |
UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing a screenshot of the discard-comment prompt that now opens from an artifact tab's ×. The PR attaches no image, so the blind read never ran on the one UI behaviour this diff changes. Evidence gaps
Notes
[UX-REVIEWED] 2525ddb Description read[DESCRIPTION-READ] 00fe415c5ea1945054be49eac845cbcfdba85362d092b2c83d8c91210ebc6b3b That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS This PR backports eight fixes already merged on What this change shipsInventory (10 items) — 10 justifiedIntent: give 0.12.0 users eight bug fixes that already landed on
[FIRST-PRINCIPLES-REVIEWED] 2525ddb Description read[DESCRIPTION-READ] dd67239d77fb59bde717f62ad40ad3668db6cf2ee002884e9ef33d79f10b9211 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: all nine commits are cherry-picks of fixes already merged on Notes
[DESIGN-REVIEWED] 2525ddb Description read[DESCRIPTION-READ] 78c11592b7f7d4c7033d9e89f74c5ac648dae37ed2f2b9660bf47033eac3bfa7 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Security Scope Review -- ✅ PASSWhich legitimate operations does Verdict basis: adjudicated, zero confirmed regressions. Security scope review -- adjudicated candidates
No candidate flipped from allowed to refused. Scope-Verdict: PASS Reason: No script-confirmed regression. Nothing in this diff changes the shell deny composite: TIGHTENING: Claude zero-tool session composition ( ADJUDICATED: 17 candidates, 0 confirmed newly-refused PLATFORM COVERAGE: Candidates were written for posix, windows and any. The posix and windows rows are paired for the spec read ( UNADJUDICATED:
[SCOPE-REVIEWED] 2525ddb |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
A spec declaring "tools": [] was not a ban on claude: the session got only strictMcpConfig, so claude-agent-acp kept Claude Code's built-in preset, and an allow rule in the user's or the project's settings ran Bash, Write or WebFetch unasked. The kirocrew-lite helpers ran with those tools, and the knowledge pool fell back to kiro-cli on claude. A zero-tool claude session now sends options.tools empty beside strictMcpConfig with bypass off, refuses a non-empty wire array, and is stopped before its first prompt on an adapter below the session-options floor. A live capture on claude-agent-acp 0.93.0 shows the adapter reads the empty list as "no tool": under allow rules for all three, no tool_call, no permission request, nothing on disk. On that evidence claude joins ACP_BACKENDS_HONOR_ZERO_TOOL_BAN, which also binds _deny_zero_tools there, and the knowledge pool keeps claude. Closes #30057 (cherry picked from commit 515f616) Originally authored on main by Bolin Chen (bolichen97); authored here with the public identity because the commit guard refuses the original address.
kiro-cli expands ${VAR} and ${env:VAR} in an MCP server's env, and
the agent materializer leaves those references for it. The harnesses
that take Crew's session mcpServers array start the server with the
element as written, so on codex, opencode, DeepSeek, Copilot CLI and
Strands (and ${env:VAR} on Claude Code) the server got the literal
text and a server that reads a token or URL from it listed no tools.
Resolve both forms in the shared session projection with the KAS
launcher's expander (same filtered view, same miss rule). goose writes
each server's env into its own session database, so its mirror keeps
the reference unresolved rather than put the value on disk.
(cherry picked from commit 2fa4077)
# Conflicts:
# docs/system-specs/modules/agent-host-contract.md
#31147) The side panel's tab-strip × and middle-click on an artifact tab closed it directly, so an open inline comment draft was dropped without the "Discard your unsaved comment?" prompt the panel's own close asks. ArtifactPanel now exposes the same requestClose handle MarkdownPanel does, running its comment-draft guard (and the host's beforePrompt only when that guard asks), and the side panel registers it for artifact tabs, so the chip close asks before discarding a draft. Closes #28446 (cherry picked from commit e4f2a38) Originally authored on main by Bolin Chen (bolichen97); authored here with the public identity because the commit guard refuses the original address.
…30833) The substring and topic-overlap dedup branches of write_lesson retired a stored lesson on text alone, so a consolidation rewording that shared half its keywords with a user_explicit lesson replaced it and dropped the user's specifics. Only the semantic branch weighed authority. Every dedup delete site now applies the same authority rule the semantic branch uses (user_explicit over another source, or strictly higher stored confidence): an outranking row is kept and the submission is stored beside it. A user_explicit write is unaffected. Closes #9163 (cherry picked from commit f54bb35) Originally authored on main by Bolin Chen (bolichen97); authored here with the public identity because the commit guard refuses the original address.
…-in roots (#31730) The namespace launcher created every mask stand-in directly under a host-shared root (/run/user/$UID or /dev/shm). On a host where the user has no login session, systemd-logind's RemoveIPC=yes deletes the uid's /dev/shm entries at the next session close, directories included. Deleting a stand-in removed the private-window mount points inside it, which detached the scratch window in the running sandbox, so $TMPDIR vanished and every create under it failed with ENOENT. The launcher now mounts a tmpfs on one stage directory in its own mount namespace and creates every stand-in inside it through a descriptor on the tmpfs root. Once the masks are placed it detaches the stage and removes the empty host directory. A refused tmpfs mount keeps the old host-root behaviour with a warning. Co-authored-by: w <w@k.local> (cherry picked from commit 782fcbd) Originally authored on main by Bolin Chen (bolichen97); authored here with the public identity because the commit guard refuses the original address.
* fix(agents): send proxy-unsafe crew names in the request body Fixes #19976 When a crew's config.json key contains a space (e.g. 'My Agent'), saving from the dashboard editor calls PUT /api/agents/My%20Agent. A reverse proxy that normalises percent-encoded paths decodes %20 to a literal space, which is the HTTP request-line delimiter and causes a 502. Fix: add PUT /api/agents (no path variable) that reads the crew name from a 'name' field in the JSON body. The frontend uses this body-form route automatically when encodeURIComponent(name) !== name, so a space-containing key is never placed in a URL path segment a proxy can misinterpret. The existing PUT /api/agents/{name} is unchanged for slug-keyed agents. The api_kirocrew_agent_update handler now serves both routes: it reads the name from the URL path when present, or from the request body when the path-variable route is not matched. The body name is used verbatim (never stripped) so a stored key that differs only by edge whitespace is not silently overwritten. Both forms share all update logic including _require_owner, so auth and owner checks are identical. change_card_catalog: add PUT /api/agents to HOOKED_ROUTES and describe_manual_change so memory events are recorded for body-form saves the same way they are for path-form saves. Security: test_agents_endpoints_owner_auth.py already walks all routes and verifies owner-gating; PUT /api/agents is added to its floor set. test_agent_update_body_form.py pins auth parity between both routes. * docs: add PUT /api/agents body-form route to crew-mode, learn-cron-dashboard, and feature map; update Pattern harvest and #20083 action * fix(agents): keep proxy-unsafe crew names out of every agent route path (#28628) Every crew route that names the crew in its URL path also answers under /api/agents/b64/{name_b64}..., an unpadded base64url segment, so a path-normalising proxy has no %20 to decode into a bare space (502). The twins reach the same handlers behind the same owner gate. The dashboard (delete, avatar upload and image, capabilities, worker kit) and change-card Apply/Undo steps use the twin or the body-form PUT for such names; the card hook reads a twin as its path-form route. Fixes #20083 --------- (cherry picked from commit 4d0ae46) Originally authored on main by Zezhen Xu (CrysisDeu); authored here with the public identity because the commit guard accepts only that identity.
…ec (#32224) A member start (session_capabilities.prepare_runtime, run under asyncio.to_thread) resolves its workspace, its agent spec's name and the spec's descriptor itself, then asks whether each path is sensitive. Three of those checks handed the canonical path to is_sensitive_path, which resolves it again on the bounded mc-pathres pool and fails closed. On macOS the pool has no syscall sample, so one resolver child that misses its deadline on a loaded runner is charged as a mount stall, and every path under that prefix then reads as sensitive for 30 s. The member start refused its own healthy spec as source_unreadable. The three checks now use the canonical-path gate, which answers inline off the event loop and stays bounded on it, with the same gate list: - agent._spec_path_shape_refusal judges the spec's Path.resolve() with is_sensitive_canonical_path. - config.loader_pipeline.default_project_dir judges the workspace's realpath with is_sensitive_canonical_path. - hooks.safe_read_file_bytes_nolink takes canonical_gate, as safe_read_file already does: the realpath from validate_file_path and the descriptor's kernel path (identity and within-root checks) use the canonical gate. agent_capabilities._read_spec passes it. The keyword is passed on only when set, and the identity comparison itself is unchanged. A sensitive path is refused exactly as before. Closes #27388 (cherry picked from commit 123cc51) Originally authored on main by Bolin Chen (bolichen97); authored here with the public identity because the commit guard refuses the original address.
…#32210) On a Linux host whose libcups lacks the symbols the full Chrome for Testing build imports (Amazon Linux 2: cups-libs 1.6.3), Kiro's Chromium exits 127 at load and Browser Harness reports a 60 s daemon timeout instead. Pick the same version's chrome-headless-shell there, which links no libcups. Download, state and launch all follow chromium.wanted_build, so a full build already on disk reads as not downloaded and the startup auto-install fetches the shell. The probe reads libcups' ELF dynamic symbol table from the linker's system directories, so the status path still launches nothing. Closes #32197 (cherry picked from commit 23b4795)
b23d90f to
2525ddb
Compare
Problem / Motivation
Goal: Bring eight fixes for problems a 0.12.0 user can hit, merged on
mainafterv0.12.0, ontorelease/0.12.0, with the two main commits they need first, one commit each, in a PR of its own.Why it matters
Each fix changes behaviour a 0.12.0 user can run into today. Every pick applied to
release/0.12.0with only the doc or test hunks listed under "What changed" resolved by hand, so the code each one replaces is on release; the right-hand column names where.kirocrew-lite, the knowledge workers,kirocrew-guest) can run shell commands, write files and fetch URLs whenever a~/.claudeallow rule covers them.acp/client_claude_session.py:423,knowledge/llm_pool.py${VAR}gets the literal text and its tools are lost, silently.acp/session_mcp.py:91pages/chat/SidePanel.tsx:50vector_memory_runtime/lesson_write.py:49/dev/shm, so work breaks mid-task, again every few minutes.sandbox_launcher_program.py:216dashboard/agent_admin/crew_update.py,dashboard/routes/agents.pyhook_runtime/safe_reads.py,agent_capabilities.py:17browsertool, Settings' Test and the live view all fail, because Chromium cannot load libcups 1.6.3.browser_harness/chromium.py:14Not a goal
main; nothing is changed only here.CHANGELOG.mdchange.What changed (motivation → approach → change)
Each main squash commit was cherry-picked with
-xontorelease/0.12.0@052ce87b11, in merge order onmain, one commit each. A prerequisite sits right before the fix that needs it.515f616cd670acf3b05b${VAR}in MCP env for third-party harnesses2fa4077886eb11317013e4f2a382cd19667b9868f54bb352fd3757050028782fcbd918cfce6703e34d0ae46a5ce2c29c66f59f8d7d61edaf6e19edb3canonical_gatekeyword #32224 extends123cc51aed5d12bf3e6123b4795f782525ddb10cHand-resolved hunks, none of them in product code:
docs/system-specs/modules/knowledge.md, the backend paragraph. Release has extra sentences that main had not yet. The pick's three edits were applied to the release text: claude joins the zero-tool list, the "claude's routing is declared but not enforced" clause goes, and the intersection reads{kiro, claude, opencode, goose, deepseek, pi, strands}. That matchesACP_BACKENDS_HONOR_ZERO_TOOL_BAN ∩ ACP_BACKENDS_ACP_CLIENT_SPAWNABLEon this tree. Alsotest/fixtures/acp_frames/README.md, theclaude/row: the pick'szero-tools-refused-live.jsonlsentence was appended to the release row. Theeffort-clear-live.jsonlsentence from a later commit was left out, because that capture is not on release.docs/system-specs/modules/agent-host-contract.md. Kept the release "Per-tool MCP deny" row and took main's "Env expansion" row, the only row the pick changes.docs/system-specs/modules/learn-cron-dashboard.md. Added the pick's one sentence about the chip × to the release paragraph.test/test_vector_memory_coverage_vector_space.py, one docstring. Took main's wording..github/workflows/ci.yml. Added the pick'stest/test_stand_in_stage_real_sandbox.pyto the real-sandbox list. Left outtest_seal_parent_pin_real_sandbox.py, which comes from a commit not on release.docs/feature-map/README.md. Added the pick'sPUT /api/agentsphrase to the release Crew Members row, which still uses the older "mate" wording. The pick's two other phrases, about the b64 routes, landed with no conflict.test/test_hooks_composition_contract.py. Added each pick's comment line, and set_BASE_SHAPE_DIGESTto the value the test computes on this tree (24ab41da95after perf(config): judge each agent spec on the canonical sensitive-path gate in the snapshot scan #30909,ca8d9a0f07after fix(capabilities): a resolver stall cannot refuse a member its own spec #32224). Main's digest differs because main's facade has other signatures.#30093, #31147, #30833, #31730, #30909 and #32224 are authored with the public identity, and each message names its original author, because the commit guard refuses the original address on a hand-resolved pick. #19981 and #32210 keep their original author.
#30755, the prerequisite of #32210, landed on
release/0.12.0in another batch (7782dbb73c) while this PR was open, so it is no longer carried here.Left out on purpose:
tools_settings_reach.py,test_tools_settings_notice.py), so that chain is too wide.Backwards compatibility
Compatible: each change is the one already merged on
main, and its compatibility note applies unchanged.Removes nothing: no setting, key or caller is removed. #30093 narrows behaviour on the claude backend only, for the agents whose spec already declares
"tools": []. Those agents now get no tool there, as on every other backend.Tests
Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs
release/*, so the related set was run here after each pick: each touched test file, plus the test modules that import the touched source, about 10,000 tests in total.test_harness_parity.py::test_is_kiro_cli_is_positivefails on a cleanrelease/0.12.0@1e56b25e49.test_stand_in_stage_real_sandbox.pycases fail at fix(sandbox): keep the scratch window when the host empties the stand-in roots #31730's own main commit782fcbd918. This host's sandbox refuses to pin a directory the test removes.tsc -p tsconfig.app.json --noEmitpasses. vitest for fix(dashboard): close an artifact tab's chip × through its draft guard #31147 (side panel and artifact panel, 437 passed) and fix(agents): send proxy-unsafe crew names in the request body #19981 (agent path, API client, roster, capabilities, 912 passed).mypy src/kiro_crew,gen-ui-index --checkandcheck_harness_parity.pypass.check_file_line_capfails only ondashboard/chat_api/resume.py, which is already over the cap on release and is not touched here.Manual verification
N/A - each fix was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.
Screenshots / video
Why no screenshot: the two frontend picks (#31147, #19981) carry the same rendered change as their main PRs, which show it.
Related Issues
Backport to the 0.12 line for 0.12.1 of #30093, #30616, #31147, #30833, #31730, #19981, #30909, #32224 and #32210. Source issues: #30057, #28446, #9163, #31716, #19976, #20083, #30908, #27388, #32197.
Sibling sweep
Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.
Pattern harvest
Not generalizable: this PR only carries fixes already on
main. The source PRs have their own harvest.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.