Skip to content

fix: backport #32387, #32434 and #32833 to 0.12.1 - #32823

Merged
buluoray merged 3 commits into
release/0.12.0from
crew/slack/0.12.1-batch-55
Nov 8, 2026
Merged

buluoray merged 3 commits into
release/0.12.0from
crew/slack/0.12.1-batch-55

Conversation

@buluoray

@buluoray buluoray commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Bring two user-reported fixes, #32387 and #32434 with #32434's follow-up #32833, that merged on main after v0.12.0 onto release/0.12.0, one commit each, in a PR of their own.

Why it matters

Each fix closes a problem a user reported. Each faulty line was checked on release/0.12.0 @ 052ce87b11 before the pick.

PR Reported by What a 0.12.0 user sees today Faulty code on release
#32387 jeeshofone (#23495) A dashboard tab's returned subagent results are settled while its own turn can still be stopped, so a Stop after the reply reached kiro-cli loses them. dashboard/messaging_api/run_control.py:465
#32434 ThR3742 (#25341) An app's embedded chat panel (or an artifact's companion chat) switches the main chat to its session, and keeps pointing at a session that was deleted. website/src/components/ArtifactChatPanel.tsx:63 (dispatch(switchSlot(slotKey)))

Not a goal

  • No fix that is not already merged on main; nothing is changed only here.
  • No version bump, no tag, no CHANGELOG.md change.

What changed (motivation → approach → change)

Each main squash commit was cherry-picked with -x onto release/0.12.0 @ 052ce87b11, in merge order on main.

# PR main commit release commit
1 #32387 settle a dashboard tab's returned results at its turn's release 2a4fb38447 b4e796281a
2 #32434 keep embedded chat panels on their own session 3fc6ab4f91 218c3908e0
3 #32833 ignore a session-gone answer after its panel closed cfca397e0f 57288b4191

Hand-resolved hunks, docs only:

PR File Resolution
#32387 docs/system-specs/modules/subagent.md (one paragraph) Removed the "a dashboard-born tab parent still acknowledges a returned result while its own turn can be stopped" sentence this PR makes untrue, and kept the rest of release's paragraph; main's #25261 sentence in the same spot belongs to a main change not on release.
#32434 website/src/i18n/en.context.json Appended only this PR's appSdk.chatPanel.session_gone translator note after release's last entry; the notes between belong to main changes not on release. The file parses as JSON with no duplicate key.

Every other file has added and removed lines identical to its main commit.

#32833 is the main fix for the one finding GPT 6.1 raised on #32434 (website/src/hooks/useOwnSlotChat.ts:115): a "session not found" answer that lands after the panel unmounted no longer calls onSessionGone. It picked cleanly.

All three commits are authored with the public identity (#32387 and #32434 are hand-resolved and #32387 carried a co-author trailer with an internal address; #32833's author email is not a public one), so they are authored with the public identity and name their original author (Bolin Chen) in the message; the trailer line is removed.

builder-security checked: #32387 changes when the gateway settles a returned result inside existing routes; no bind, listener, new route, auth mechanism or storage grant changes.

Backwards compatibility

Compatible: each change is the one already merged on main, and its compatibility note applies unchanged. On a dashboard tab a returned result whose turn did not end on end_turn now gets its completion turn (one duplicate at worst, never a loss), where before it was dropped.

Reader: src/kiro_crew/parent_turns.py:settles_at_release -- chat -- removed by #32387; every caller (run_control, subagent_injection, and the gateway and messaging re-exports) is changed here, and git grep finds no other reader in src/ or test/ on this branch
Reader: src/kiro_crew/dashboard/messaging_api/run_control.py:api_spawn_mark_collected -- chat -- a dashboard tab's queued completion is no longer settled at mark time; the landed release settles it (test_collecting_a_member_whose_announce_already_queued_settles_it)
Reader: src/kiro_crew/slack/gateway_runtime/subagent_injection.py:_route_subagent_to_tab -- chat -- skips only a confirmed mark and parks a pending one (test_a_tab_parents_landed_turn_plays_no_duplicate_and_settles_at_its_release[dashboard-tab])

Tests

Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs

  • CI does not run the backend suite on PRs into release/*, so the related set was run here: every touched test file, every test file that imports a touched module, and the tests that read the touched docs, 154 files, -n 4 --dist loadgroup. 5158 passed, 2 skipped, 1 xfailed, 0 failed.
  • Frontend, on this head with fix(chat): ignore a session-gone answer after its panel closed #32833: tsc -p tsconfig.app.json --noEmit passes. vitest run ArtifactChatPanel AppSdk appSdk ChatPanel useOwnSlotChat switchSlotCallsiteClassification ArtifactDetailPage.companionChat i18n locale context: 151 files, 2635 passed, 0 failed.
  • flake8 passes on the changed Python files.

Manual verification

N/A - each fix was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.

Screenshots / video

Why no screenshot: the embedded chat panel's "session gone" notice is the same rendered change as on the main PR, whose screenshots show it.

Related Issues

Backport to the 0.12 line for 0.12.1 of #32387, #32434 and #32833. Source issues: #23495, #25341.

Sibling sweep

Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.

Pattern harvest

Not generalizable: this PR only carries fixes already on main. The source PRs have their own harvest.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

…32387)

A dashboard tab whose turn called spawn_sub_agents acknowledged each
returned child on the mark, so a turn the user stopped before it landed
lost the result. Every parent now holds the mark pending under the
spawning attempt and settles it at that attempt's release, as cron and
channel parents already do (#27508): a landed turn confirms it, any
other end delivers it. The specs and the brokered-delivery RFC no
longer describe the removed dashboard-born exception.

Builds on #28576 by @cruisercohen.

Closes #23495

(cherry picked from commit 2a4fb38)

Original author: Bolin Chen (#32387). docs/system-specs/modules/subagent.md hand-resolved: removed the dashboard-born-tab sentence this PR makes untrue and kept the rest of release's paragraph; main's #25261 sentence belongs to a main change not on release.
@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 8, 2026 01:15
@buluoray
buluoray requested review from Zedmor and removed request for a team November 8, 2026 01:15
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of 57288b41912956c5e38543a519fedf38dc1ad1f6 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing screenshots of the embedded chat panel's new "session gone" notice and its "Try again" failure state. The PR attaches no image, so the blind read was not performed.

Evidence gaps

  • App chat panel, session-gone notice (ChatPanel.tsx, ErrorNotice showing "This session no longer exists. Open or start a session from the app."). No screenshot shows it. A still of an app's embedded chat after its session is deleted would close this.
  • App chat panel and artifact companion chat, failure notice with "Try again" (ErrorNotice + Btn with components.webPreviewPanel.try_again, in ChatPanel.tsx and ArtifactChatPanel.tsx). No screenshot shows it. A still of each panel when the session fails to open would close this.
  • Both panels, the state before the chat is ready (showChat ? <ChatPage/> : null). No screenshot shows what the panel looks like while the session opens. A still of each panel at that moment would close this.
  • Main-PR screenshots. The description's "the main PR's screenshots show it" is not evidence for this revision. Attach those images to this PR's description.

Notes

  • While the session opens, both panels render nothing (the null branch), so the user sees an empty area. Show something, like the existing starting_session line in ArtifactChatPanel.

[UX-REVIEWED] 57288b4

Description read

[DESCRIPTION-READ] fad95cf01463731f605d815dc32c4254b090948dc357e24144ca4533c7985b31

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

Design-level review of 57288b41912956c5e38543a519fedf38dc1ad1f6 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

cannot evaluate: missing screenshot or recording of the embedded ChatPanel's "session gone" notice and the new failure/Try-again state in ChatPanel and ArtifactChatPanel, captured on this revision.

Blockers

The reshaped embedded-chat surfaces have no rendered evidence from this PR
Trigger: the diff replaces the always-mounted ChatPage in website/src/app-sdk/ChatPanel.tsx and website/src/components/ArtifactChatPanel.tsx. It now shows "<ErrorNotice … message={i18nT('appSdk.chatPanel.session_gone')} />", a failure notice with a "Try again" Btn, or nothing at all ("showChat ? <ChatPage …/> : null") while the switch loads. The evidence file lists 0 downloaded attachments and 0 committed images. The description only points at "the main PR, whose screenshots show it".
Outcome: these are new states on a release line, and a backport whose hand-resolved hunks touch the i18n context file can render differently from main → screenshots hosted on another PR are not evidence of this revision → the review cannot check the notice placement, the Try-again layout, or the blank panel during loading on the release/0.12.0 base.
Fix: attach screenshots of both panels in the session-gone state and the failure state, taken on this head. Committing them under .github/screenshots/ also counts.
Clears when: the description has github.com/user-attachments images (or this PR commits images) that show the session-gone notice and the failure/Try-again notice, rendered from this revision.

Notes

  • While a switch is in flight, the embedded panel now renders nothing (: null). On a slow gateway that looks like a broken panel. Main shows the same behaviour, so if it needs fixing, fix it there first and backport it.

[DESIGN-REVIEWED] 57288b4

Description read

[DESCRIPTION-READ] 721b8dc8510777fc0ed3bbdb2d05b3d1060fa25455cdea2df085f39725b770a0

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 57288b41912956c5e38543a519fedf38dc1ad1f6 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

This backports three fixes already merged on main. Each fix links its user issue (#23495, #25341), and the backend change mostly deletes code (settles_at_release is removed). No item adds new scope.

What this change ships

Inventory (8 items) — 8 justified

Intent: let 0.12.x users get the fixes for lost subagent results and for embedded chat panels that take over or stick on the main chat's session. This is a FIX (a backport).

  1. On a dashboard tab, a returned subagent result is settled when its turn is released, not when it is marked, so pressing Stop no longer loses it — justified
  2. settles_at_release is removed, along with the early-settle branches in run_control and subagent_injection — justified
  3. An app's embedded ChatPanel no longer switches the main chat to its own session — justified
  4. An artifact's companion chat stays on its bound session through useOwnSlotChat — justified
  5. A panel whose session is gone shows a "session gone" notice, and the companion chat drops that session's row — justified
  6. If a session fails to open, the panel shows the error with Try again instead of a different conversation — justified
  7. A "session not found" answer that arrives after the panel closed is ignored (fix(chat): ignore a session-gone answer after its panel closed #32833) — justified
  8. The session_gone string and the locale entries are added, and the app-kit, subagent, artifacts and RFC docs are synced — justified

[FIRST-PRINCIPLES-REVIEWED] 57288b4

Description read

[DESCRIPTION-READ] dfeb26738c4175041c717c4eb40bd9286fee52645cd4e27395176aba9c5c172b

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 57288b41912956c5e38543a519fedf38dc1ad1f6 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 57288b4

Verdict parsed from the review's SHA-scoped output markers for commit 57288b41912956c5e38543a519fedf38dc1ad1f6.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 57288b41912956c5e38543a519fedf38dc1ad1f6 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 57288b41912956c5e38543a519fedf38dc1ad1f6 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 57288b4

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 57288b41912956c5e38543a519fedf38dc1ad1f6 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 8, 2026
@buluoray
buluoray force-pushed the crew/slack/0.12.1-batch-55 branch from 84e8c14 to b4e7962 Compare November 8, 2026 01:59
@buluoray buluoray changed the title fix: backport #32387 and #32434 to 0.12.1 fix: backport #32387 to 0.12.1 (settle a tab's results at its turn's release) Nov 8, 2026
@buluoray

buluoray commented Nov 8, 2026

Copy link
Copy Markdown
Contributor Author

Goal edited at the maintainer's request: two fixes -> #32387 alone. #32434 is removed from this PR (head 84e8c14 -> b4e7962) because GPT 6.1's first-run finding on website/src/hooks/useOwnSlotChat.ts:115 holds: a 404 that lands after the panel unmounts still calls onSessionGone and removes a session the user reopened meanwhile. main has the same code; #32434 ships later with the main fix.

The artifact companion and the app SDK ChatPanel embed ChatPage, which
renders the dashboard's active slot, and they switched to their session
without waiting for the answer. A deleted session or a failed open left
the previously open chat on screen, and messages typed in the panel went
to that other session.

Both now use useOwnSlotChat, the guard the Papyrus co-author panel has
had since #22460: the chat shows only while the panel's own session is
active, a 404 is reported to the host as a gone session, and any other
failure shows an ErrorNotice with Try again. Switching back to the
panel's session waits for another session's switch to finish and runs as
a transition, so a control that opens another session and navigates
away keeps the session it opened.

Closes #25341

(cherry picked from commit 3fc6ab4)

Original author: Bolin Chen (#32434). website/src/i18n/en.context.json hand-resolved: appended only this PR's appSdk.chatPanel.session_gone translator note after release's last entry; the notes between belong to main changes not on release.
An embedded chat panel opens its session with switchSlot and, on a
404, has the host forget that session. The 404 was acted on even when
it arrived after the panel had closed, so a session the user reopened
from History in the meantime was removed and switched away from.

A late answer to a closed panel's open is now ignored, as a late
success and a late failure already were.

Refs #32434

(cherry picked from commit cfca397)
@buluoray buluoray changed the title fix: backport #32387 to 0.12.1 (settle a tab's results at its turn's release) fix: backport #32387, #32434 and #32833 to 0.12.1 Nov 8, 2026
@buluoray

buluoray commented Nov 8, 2026

Copy link
Copy Markdown
Contributor Author

Goal edited at the maintainer's request: #32434 is back, together with its main fix #32833 (merged as cfca397), which closes GPT 6.1's useOwnSlotChat.ts:115 finding. Head b4e7962 -> 57288b4.

@buluoray
buluoray merged commit f369fcf into release/0.12.0 Nov 8, 2026
12 of 23 checks passed
@buluoray
buluoray deleted the crew/slack/0.12.1-batch-55 branch November 8, 2026 03:34
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant