Skip to content

fix: backport 0.12.1 fast batch v1b-1 (23 user-facing fixes) - #32840

Merged
buluoray merged 23 commits into
release/0.12.0from
crew/slack/0.12.1-fast-v1b-1
Nov 8, 2026
Merged

buluoray merged 23 commits into
release/0.12.0from
crew/slack/0.12.1-fast-v1b-1

Conversation

@buluoray

@buluoray buluoray commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Bring twenty-three fixes for problems a 0.12.0 user can hit, merged on main after v0.12.0, onto release/0.12.0, one commit each, in a PR of its own.

Why it matters

Each fix changes behaviour a 0.12.0 user can run into today. Every pick applied to release/0.12.0 cleanly, so the code each one replaces is on release.

PR Area What a 0.12.0 user sees today
#30152 cron Infinite cron timeout accepted instead of refused
#30069 command-palette Global shortcuts fire behind the open search palette
#30436 browser Browser worker that fails to import exits with no reason shown
#30615 dashboard Branding route rebuilds config on every request, slowing dashboard
#30894 apps Desktop-only Enable button label run together
#30657 gateway Startup misreports a stray gateway.lock holder as a gateway
#31166 settings Dashboard config saves keep retired browser keys around
#31314 apps exiting incident chat in an app pop-out returns to main window
#31353 dashboard closing a not-found placeholder tab no longer warns it's the last copy
#31297 chat rename failure notice names the refused title
#31840 mcp settings inner MCP tab named Per-server sharing, no longer confused with Servers
#31295 chat a deliberate force stop shows as force stopped, not failed
#31961 issue radar empty-pane sentences read correctly in translated languages
#32091 i18n Cron folder toggle label reads as one translated sentence
#32051 a11y Vector Memory filter chips announce selected state
#32046 a11y Auto-research report toggle announces expanded state
#31883 i18n artifact pending-comments label reads as one sentence
#31630 auth doctor shows OIDC client registration expiry date
#31728 update First Escape does nothing on the update modal/banner
#32385 chat folders Folder icon regenerate fails or stays busy forever
#32389 i18n 24 Portuguese/Spanish strings shown in English
#32428 onboarding Import review shows read/parse failures as muted notes, not errors
#31042 webhooks i18n Webhooks page stored context size not translated

Not a goal

  • No fix that is not already merged on main; nothing is changed only here.
  • No version bump, no tag, no CHANGELOG.md change.
  • Rows whose pick conflicts; they go in a later batch.

What changed (motivation → approach → change)

Each main squash commit was cherry-picked with -x onto release/0.12.0 @ aa7dfb4aae, in merge order on main, one commit each. Every pick applied cleanly, and every commit keeps its original author.

# PR main commit release commit
1 #30152 refuse an infinite timeout with ValueError, as every_secs is 66d2f06498 46372f47fd
2 #30069 keep global shortcuts from firing behind it 3736af2d38 e495b2125a
3 #30436 surface a worker's import-failed reply when it exits before reading stdin 360372b51c 5ed5cbebab
4 #30615 serve branding from the live config snapshot 34e8a26a03 3f38ff4817
5 #30894 name the desktop-only Enable button by its visible label 5c9a750b6f 457a674112
6 #30657 name a stray gateway.lock holder as not a gateway 47386d66b8 17871ac7f4
7 #31166 drop retired browser keys on dashboard config saves d3549e537a d842a49b37
8 #31314 hand incident chat exits in an app pop-out to the main window 57030af8c6 98b9ab4fb7
9 #31353 a not-found placeholder tab is never a last copy c2dc4e4ba3 eb8df4a84a
10 #31297 name the refused title in the rename failure notice f949d8cbb0 d479456ab6
11 #31840 rename the inner servers view to per-server sharing 1f819b880a 233c094b52
12 #31295 show a deliberate force stop as force stopped, not failed 58c02b0f4a 56b2c2afb3
13 #31961 keep the noun inside one sentence on Issue Radar's empty panes a5664ddbd6 e3ffa82b48
14 #32091 put the cron folder name inside its toggle label sentence 5f464a7181 aff148842b
15 #32051 expose the Vector Memory filter chips' selected state 26f71547a4 5cbf590094
16 #32046 mark the report toggle as a disclosure 85441273f8 f8fba88d05
17 #31883 word the pending-comments label as one sentence d382c63fc8 5b0737af68
18 #31630 keep the oidc client registration expiry so doctor dates it 4312d22e40 f7f8c5db1f
19 #31728 arm escape in the commit that shows the update modal and banner a254f30cf5 070df3a86f
20 #32385 prune chat folder icon tasks a torn-down loop left behind a8d25e5f61 a780f24a7c
21 #32389 translate 24 English passthrough values in pt and es 0c2c67f8a9 4e65f89623
22 #32428 show caught scan failures as errors in import review 8bf2eca3de 4fcce096e1
23 #31042 translate the stored context size on the Webhooks page 2f652722a3 49a8cfa1e2

Three picks carried co-author trailers with internal addresses; each is rewritten as a plain "Co-author on main: " line, because the commit guard refuses the address.

#30624 (skip the claude-not-found warning when the SDK ships its binary) was dropped: review found its new SDK-binary scan runs filesystem calls on the gateway event loop. It stays on main only until that is fixed there. #31427 (offer workflows in the + menu once the chat has a run) was dropped too: review found a failed workflow-list read in the side panel shows no error.

Backwards compatibility

Compatible: each change is the one already merged on main, and its compatibility note applies unchanged.

Removes nothing: no setting, key or caller is removed. #31166 drops browser config keys that 0.12.0 no longer reads, on the next dashboard save, as it does on main.

Tests

Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs

  • CI does not run the backend suite on PRs into release/*, so the direct test modules were run here: the 14 Python test files these picks touch gave 560 passed.
  • Frontend: tsc -p tsconfig.app.json --noEmit passes; the 26 vitest files these picks touch gave 702 passed; lint:i18n passes at the same count as clean release.
  • flake8, isort, the black gate and mypy src/kiro_crew pass. i18n:check without a base reports the same findings class as a clean release/0.12.0 on this host, and fewer of them.

Manual verification

N/A - each fix was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.

Screenshots / video

Why no screenshot: the frontend picks carry the same rendered change as their main PRs, which show it.

Related Issues

Backport to the 0.12 line for 0.12.1 of #30152, #30069, #30436, #30615, #30894, #30657, #31166, #31314, #31353, #31297, #31840, #31295, #31961, #32091, #32051, #32046, #31883, #31630, #31728, #32385, #32389, #32428, #31042.

Sibling sweep

Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.

Pattern harvest

Not generalizable: this PR only carries fixes already on main. The source PRs have their own harvest.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

RohanK6 and others added 4 commits November 8, 2026 02:09
…is (#30152)

The cron store documents ValueError for every refused field, and
every_secs already maps int(float('inf'))'s OverflowError to it. The
timeout and timeout_secs checks on add (validate_create_timeouts) and
update (apply_job_update) caught ValueError and TypeError only, and the
app cron SDK converted both with int() before the store saw them, so an
infinite value raised OverflowError instead. One helper,
fields.whole_seconds, now reads both fields on all three paths and
refuses an unreadable value with ValueError. Nothing is written either
way.

(cherry picked from commit 66d2f06)
…0069)

The Search Everywhere palette is aria-modal, but keys pressed in it that
its own capture-phase listeners do not handle bubbled to the page's
document shortcut listeners, so Alt+, or Ctrl+1 acted behind it. The
panel now stops every key except the quick-search gesture, whose window
listener toggles the palette shut, as the Command Bar does since #29718.

The toggle test the Command Bar used moves to lib/quickSearchShortcut so
both overlays share one copy.

Fixes #29998

## Pattern harvest

Rule candidate: review-prompt
Pattern: an aria-modal overlay that lets non-Escape keys bubble to
document-level shortcut listeners

Co-author on main: Matt Briones
(cherry picked from commit 3736af2)
…exits before reading stdin (#30436)

When a worker with a broken harness install writes its {"id": null,
"error": "import failed ..."} reply and exits without reading stdin, the
supervisor's drain() of the request can lose the race and raise
ConnectionResetError. The except branch then returned "helper worker is gone"
without ever reading the reply the worker already wrote.

Read stdout after a write failure and surface that reply; fall back to
"helper worker is gone" only when stdout has nothing. Closes #30253.

Co-authored-by: kirocrew-agent <agent@kirocrew.local>
(cherry picked from commit 360372b)
@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 8, 2026 02:27
@buluoray
buluoray requested review from Zedmor and removed request for a team November 8, 2026 02:27
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of 49a8cfa1e2d4184b7e71fa9dde1d1de41510eae5 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing screenshots for every changed control. The blind read was not performed because this revision attaches and commits no image. Pointing to the source PRs on main doesn't close the gap, because those images aren't admissible for this revision.

Evidence gaps

  • StopEventCard, new force_stopped row ("Force stopped, session reset") next to the failed-stop alert. Needs a screenshot of a chat after a second Stop press.
  • MCP Management inner tab renamed to "Per-server sharing", plus the "Open Per-server sharing" link on the Sharing assessment view. Needs a screenshot of both tabs.
  • AgentImportFlow review step: a failed skip now renders as an inline ErrorNotice next to the muted note rows. Needs a screenshot of a review that shows both.
  • AppListRow / FeaturedSpotlight desktop-only Enable button label. Needs a screenshot.
  • SessionTitleControl rename-failure notice that names the refused title. Needs a screenshot.
  • CronFolderHeader toggle label, the ArtifactSubmitBar pending-comments label, the Issue Radar empty panes and the Webhooks stored context size, which are reworded or newly translated. Each needs a screenshot in English and in one translated locale, such as pt or es.
  • The Vector Memory filter chips' selected state and the Auto-research report toggle's expanded state. Each needs a screenshot of both states.

[UX-REVIEWED] 49a8cfa

Description read

[DESCRIPTION-READ] 514c285a6340f80dc2bca6614398cf5028903cbc1a8dca72ad589cfa5e1a9310

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 49a8cfa1e2d4184b7e71fa9dde1d1de41510eae5 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Every item is a pick of a fix already merged on main, listed by PR and commit, and each hunk I read matches its row in the table.

What this change ships

Inventory (10 items) — 10 justified

Intent: give 0.12.1 users the user-facing fixes main already shipped after v0.12.0. This is a FIX (backport).

  1. Cron refuses an infinite timeout instead of accepting it (fix(cron): refuse an infinite timeout with ValueError, as every_secs is #30152) — justified
  2. A deliberate second stop shows "force stopped", not "failed", and replay treats it as resolved (fix(chat): show a deliberate force stop as force stopped, not failed #31295) — justified
  3. The gateway.lock refusal says a stray holder is not a gateway (fix(gateway): name a stray gateway.lock holder as not a gateway #30657) — justified
  4. Doctor shows the date the OIDC client registration expired, and asks you to sign in again (fix(auth): keep the oidc client registration expiry so doctor dates it #31630) — justified
  5. Folder icon regenerate no longer stays busy after a loop is torn down (fix: prune chat folder icon tasks a torn-down loop left behind #32385) — justified
  6. Closing a "file not found" placeholder tab no longer warns it is the last copy (fix(dashboard): a not-found placeholder tab is never a last copy #31353) — justified
  7. Leaving incident chat in an app pop-out goes back to the main window (fix: hand incident chat exits in an app pop-out to the main window #31314) — justified
  8. Inner MCP tab is relabelled "Per-server sharing" (fix(dashboard): rename the inner servers view to per-server sharing #31840) — justified
  9. Import review shows read and parse failures as errors (fix(onboarding): show caught scan failures as errors in import review #32428) — justified
  10. Batch of i18n and a11y fixes: Webhooks size, pt/es strings, cron and Issue Radar sentences, filter-chip, disclosure and Enable button names (fix(i18n): translate the stored context size on the Webhooks page #31042, fix(i18n): translate 24 English passthrough values in pt and es #32389, fix(i18n): put the cron folder name inside its toggle label sentence #32091, fix(i18n): keep the noun inside one sentence on Issue Radar's empty panes #31961, fix(website): expose the Vector Memory filter chips' selected state #32051, fix(auto-research): mark the report toggle as a disclosure #32046, fix(apps): name the desktop-only Enable button by its visible label #30894, fix(artifacts): word the pending-comments label as one sentence #31883) — justified

More than 10 items: also #30069, #30436, #30615, #31166, #31297 and #31728, all listed in the description.

[FIRST-PRINCIPLES-REVIEWED] 49a8cfa

Description read

[DESCRIPTION-READ] 36fca9b037411bad2b005a2292a224629291c5c681c4899618afe26261a393b6

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 49a8cfa1e2d4184b7e71fa9dde1d1de41510eae5 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: these are clean cherry-picks of fixes already reviewed on main. None of them adds a surface or a persisted-data one-way door, and the only removal drops config keys nothing reads.

Notes

  • The Windows shlex.split(posix=False) branch in gateway_lock._command_line_is_not_a_gateway only changes the wording of a refusal, and it answers False when unsure. "Manual verification: N/A" is acceptable here, but the 0.12.1 RC soak should cover a Windows host.
  • KasToken.client_secret_expires_at is safe to downgrade from: from_json drops unknown keys, so 0.12.0 still loads a token that 0.12.1 wrote.
  • Two pick rows add a rendered variant: StopEventCard's force_stopped row, and import-review skips shown as ErrorNotice. The evidence for both lives on the main PRs, not this revision. Link those PRs' screenshots in the description so the release reviewer can see them.

[DESIGN-REVIEWED] 49a8cfa

Description read

[DESCRIPTION-READ] b9646975056e594ceab2cfe14dddcce71eb7dca102a8c70ad3a8df469140916d

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 49a8cfa1e2d4184b7e71fa9dde1d1de41510eae5 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 49a8cfa

Verdict parsed from the review's SHA-scoped output markers for commit 49a8cfa1e2d4184b7e71fa9dde1d1de41510eae5.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 49a8cfa1e2d4184b7e71fa9dde1d1de41510eae5 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 49a8cfa1e2d4184b7e71fa9dde1d1de41510eae5 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 49a8cfa

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 49a8cfa1e2d4184b7e71fa9dde1d1de41510eae5 false-positive: <reason, 20 to 500 characters>

RohanK6 and others added 9 commits November 8, 2026 02:42
A process that took <home>/gateway.lock without being a gateway (for
example `flock -x gateway.lock sleep 3000`) was reported as "another
gateway already owns <home>; stop it first (kirocrew stop)". kirocrew
stop cannot stop it, so the hint pointed the operator the wrong way.

When the acquirer does not hold the dashboard port and its command line
was read and names no Kiro Crew program at all (no `kirocrew` token and
no `-m` of a gateway module root), the refusal now says the holder is
not a Kiro Crew gateway and offers `ps -f -p <pid>`. Any Kiro Crew
launch, flags before the subcommand included (`kirocrew -v gateway`),
and an unreadable command line keep the old wording. The exit status is
unchanged.

Fixes #30407

## Pattern harvest

Not generalizable: the wording depends on this refusal's own facts
(port ownership plus command line), not on a repeatable code shape.

Co-author on main: Matt Briones
(cherry picked from commit 47386d6)
* fix: drop retired browser keys on dashboard config saves

* test: state current behavior in retired browser key test docstring

---------

Co-author on main: Jacob Largent
(cherry picked from commit d3549e5)
…31314)

The ops-mission-control incident chat panel leaves through a full page
load. Inside an app pop-out that load ran in the pop-out itself, which
turned the window into a second dashboard and dropped its pop-out
registration.

The panel now leaves through hardNavigate, which uses the hard exit an
app pop-out installs and keeps the full page load everywhere else. The
pop-out's hard exit takes the destination, so it hands the panel's
path and query to the main window the way the frame's other exits do.

Closes #26430

(cherry picked from commit 57030af)
)

A file tab opened on a path that is already gone holds the localized
"file not found" sentence. The panel told that placeholder from a real
last copy by comparing the buffer with the sentence in the current
language, so after a language switch the old-language sentence read as
a real copy: the banner offered it for download and the close guard
asked to keep it. The batch close preflight never excluded it at all.

Carry the verdict on the tab as PanelTab.placeholder, set where the
sentence is seeded (chip open, working-tree diff open, cold-tab and
restored-tab hydration) and cleared by an edit or any disk refresh,
and read that flag instead of the sentence.

Part of #14449

(cherry picked from commit c2dc4e4)
A refused rename of the session title said only "Couldn't rename the
session" while the header reverted to the previous title, so a reader
could not tell which name was rejected or whether it stuck. The notice
now names the refused title, as the header showed it, and says the
previous title stays, in the main header, the split-view pane header
and the mobile top bar.

The regenerate button's tooltip and accessible name in de, bn and hi
now hold the button's visible label, as the other locales already do.
In hi the quoted Undo label and the Undo button use the informal form
the catalog's register gate requires.

Closes #10152

(cherry picked from commit f949d8c)
…31840)

MCP Management sits below the servers list on the MCP Servers sub-tab,
and its own view switcher labelled the per-server share switches
"Servers". Two near-identical labels on one screen let the inner tab
read as a way back to the outer list.

The tab now reads "Per-server sharing" in every shipped language, and
the assessment view's lede and "Open ..." button name it the same way.
The view's `servers` key is unchanged.

(cherry picked from commit 1f819b8)
…31295)

Pressing Stop a second time hard-kills the turn on purpose, but the stop
card settled as "[Stop Failed, Session Reset]" because every hard outcome
mapped to stop_failed_reset. The card the user escalated now settles as
force_stopped with its own status label, whichever hard callback lands
first; an unasked-for kill after the cooperative cancel times out keeps
the failed label. A force-stopped card still gives the model its
"user stopped the previous turn" note.

Closes #29706

(cherry picked from commit 58c02b0)
…anes (#31961)

The pull request pane and the crews pane each show a placeholder built
as "Select a" + noun + "to see its details.", three pieces glued in
code. Languages that place the noun elsewhere read it out of order:
Japanese showed "を選択 Pull Request その詳細を表示するには", and Hindi
and Korean broke the same way.

Give both one sentence key with a {{subject}} placeholder and a whole
translation, and drop the two fragment keys.

(cherry picked from commit a5664dd)
@buluoray
buluoray force-pushed the crew/slack/0.12.1-fast-v1b-1 branch from f3507b2 to 1e4f653 Compare November 8, 2026 02:49
@buluoray buluoray changed the title fix: backport 0.12.1 fast batch v1b-1 (25 user-facing fixes) fix: backport 0.12.1 fast batch v1b-1 (24 user-facing fixes) Nov 8, 2026
RohanK6 and others added 5 commits November 8, 2026 03:16
…32091)

The Schedule page folder toggle was named by a translated verb phrase
with the folder name glued on after a space, so verb-final languages
read the name after the verb (German "Ordner aufklappen Nightly").
The name is now a placeholder in the catalog sentence, so each language
places it; English reads exactly as before.

(cherry picked from commit 5f464a7)
The campaign detail's View report button opens and closes the report
section in place, but it carried no aria-expanded, so a screen reader
heard only a label change with no open or closed state. Give it
aria-expanded and aria-controls pointing at the section.

(cherry picked from commit 8544127)
The comment submit bar built its label from two translated parts joined
with an English space: "{count} comments" and "to send to this chat".
Every language then got English word order, so Japanese read
"3 コメント このチャットに送信" and Korean, Chinese, Hindi and Bengali
were glued the same way.

The label is now one plural key, comments_to_send, with the count
inside each translation. The two keys only this label used are gone,
and the plural registry names the new key.

(cherry picked from commit d382c63)
#31630)

A Builder ID or IAM Identity Center sign-in stores the SSO-OIDC client
that RegisterClient issued, but dropped its clientSecretExpiresAt. Once
that registration lapsed (about 90 days), every refresh failed with a
bare invalid_client and nothing could say why.

The expiry is now kept on the stored token and carried through every
refresh, and kirocrew doctor's crew vault line names the date it lapsed
with a "cannot renew" verdict. The refresh is still attempted, so the
issuer's refusal still records the marker the sign-in card reads.

Part of #24640

(cherry picked from commit 4312d22)
bolichen97 and others added 5 commits November 8, 2026 03:16
…31728)

The update-found modal and the notification banner attached their
window Escape listener in a passive effect. When either opens from a
default-priority update whose render runs past the scheduler's 5 ms
slice, React paints it and yields before running passive effects, so
an Escape pressed in that gap was dropped and the first press did
nothing.

Both listeners now attach in a layout effect, the shape #24284 gave the
shared Modal and useDialogFocusTrap. Each component gets a test that
opens it outside act() with a slow render and presses Escape from the
MutationObserver callback that first sees it; both fail before the
change and pass after.

(cherry picked from commit a254f30)
The chat folder icon registries hold one generation task per folder, and
only the task's own done callback removes its entry. A task whose event
loop was torn down (a test loop per test, or an embedded gateway
restart) never runs that callback, so its entry stayed:

- regenerate, both folder delete paths and the folder cleanup cancelled
  it, which schedules onto the dead loop and raises "Event loop is
  closed";
- the icon preview answered icon_busy for that folder forever;
- the strong-reference task set kept the dead task for good.

Each of those entry points now first drops icon tasks bound to a loop
other than the running one, the remedy the artifact folder icons,
chat_nav and hook_reconcile already use.

The app startup-hook and unadmitted-turn registries named alongside get
the per-test clear in their owning test modules instead of a production
change. A startup task on a dead loop must keep counting: closing a loop
does not stop a worker thread the hook started with asyncio.to_thread,
which is why a cancelled startup task leaves a residual marker. The
unadmitted-turn map is restored by its context manager's finally, so a
dead entry only exists when a test closes its loop mid-turn, and
cancel_unadmitted has no caller.

Closes #28511

(cherry picked from commit a8d25e5)
Twenty-four values outside apps.* in pt.json and es.json were the
English text word for word, so Portuguese and Spanish dashboards showed
English in the YOLO timer line, the hook form, the Dev Fleet cutover
text, the Knowledge Library settings, the cloud deployment notice and
the Remote Crew panel. Translate those values in place; keys,
placeholders and the other catalogs are unchanged.

The wording is carried over from #25761.

Part of #25624

Co-authored-by: thalisantunes <6085020+thalisantunes@users.noreply.github.com>
(cherry picked from commit 0c2c67f)
…#32428)

The import review listed every skipped row as a muted note, so a file
that could not be read or parsed looked the same as an item left out
on purpose. The scan now marks each diagnostic raised from a caught
read, parse or open failure with failed: true, the scan endpoint
passes it through, and the review renders those rows as an inline
ErrorNotice while deliberate skips stay notes.

Closes #29216

(cherry picked from commit 8bf2eca)
…1042)

A webhook context's detail pane shows its stored size twice: in the
Stored size row as an English template "12,345 chars", and in the
summary badge as the number glued to a single-form "chars" key. So
one character read "1 chars", and the row stayed English in every
language.

Use one plural key with the formatted number inside for both, with
the forms each language needs, and drop the unused "chars" key.

(cherry picked from commit 2f65272)
@buluoray
buluoray force-pushed the crew/slack/0.12.1-fast-v1b-1 branch from 1e4f653 to 49a8cfa Compare November 8, 2026 03:19
@buluoray buluoray changed the title fix: backport 0.12.1 fast batch v1b-1 (24 user-facing fixes) fix: backport 0.12.1 fast batch v1b-1 (23 user-facing fixes) Nov 8, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 8, 2026
@buluoray
buluoray merged commit 9613d90 into release/0.12.0 Nov 8, 2026
26 of 37 checks passed
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants