Skip to content

fix: backport 0.12.1 batch 58 (25 wide-bar fixes) - #32855

Merged
buluoray merged 25 commits into
release/0.12.0from
crew/slack/0.12.1-batch-58
Nov 8, 2026
Merged

buluoray merged 25 commits into
release/0.12.0from
crew/slack/0.12.1-batch-58

Conversation

@buluoray

@buluoray buluoray commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Bring 25 small fixes that merged on main after v0.12.0 onto release/0.12.0, one commit each, in a PR of their own.

Why it matters

Each row is a user-visible fix from the 0.12.1 wide-bar list (Ray, 11-07). Every pick applied cleanly onto release.

PR Area What a 0.12.0 user sees today
#30394 dashboard Sidebar session preview shows the internal steer-ack marker
#30492 slack Slack shows Not connected with no reason
#30523 knowledge Uploaded knowledge file titled by its staging name
#30581 subagents Two different memory cost figures shown for a subagent runtime
#30647 snapshot Full snapshot restore refusal shows wrong wording
#30577 i18n French command bar strings missing accents
#31021 a11y Cron folder toggle does not expose its open state
#30953 dashboard Collapsed nav rail rows have the wrong height
#31187 a11y Screen readers not told which issue radar section is open
#31010 cron cron list shows default approval mode as "" instead of null
#31367 a11y md notebook shortcut button announces when it is recording
#31499 a11y session storage sort dropdown has an accessible name
#31228 a11y logs page Matches only toggle announces its on/off state
#31214 apps featured app card category shown in the reader's language
#31486 a11y screen readers hear whether a skill folder row is open
#31870 knowledge screen readers hear whether a knowledge folder is expanded
#31683 issue radar screen readers hear which filter rows are on
#31871 design tweak app screen readers hear whether History and Dimensions are open
#31947 issue radar screen readers hear which label pills are selected
#31927 find bar screen readers hear whether case-sensitive search is on
#32054 a11y Open Issue Radar dashboard marked as current page
#32045 a11y Memory graph filter chips announce selected state
#31776 chat Post-turn refusal note leads with what the work achieved
#32276 a11y schedule message toggle announces open/closed
#32166 a11y screen readers hear which workflow is selected in the library

Not a goal

  • No fix that is not already merged on main; nothing is changed only here.
  • No version bump, no tag, no CHANGELOG.md change.

What changed (motivation → approach → change)

Each main squash commit was cherry-picked with -x onto release/0.12.0 @ aa7dfb4aae, in merge order on main, one commit each. Every pick applied cleanly, with no prerequisite and no hand-resolved hunk; every commit has added and removed lines identical to its main commit.

# PR main commit release commit
1 #30394 drop the steer-ack marker from the sessions sidebar preview 0006912d23 54a6fc3029
2 #30492 say why Slack is not connected when startup disables it ee76465382 2bf97c5521
3 #30523 title an uploaded file by its own name, not the staging copy b66e026877 4f78c69f7a
4 #30581 use the measured 0.55 GB runtime cost everywhere f2ac71e46d 7cc513ea4a
5 #30647 word the restore size refusal for full snapshots d34fe7e4a4 96da5b854c
6 #30577 restore French accents in the command bar strings dbb65c5664 dd63779c52
7 #31021 expose open state on the cron folder collapse toggle 42e5c9a6ec e970c0329c
8 #30953 give collapsed nav rail rows the same 36px height as expanded 722b07e794 d2c109b28e
9 #31187 announce which issue radar rail section is open a3a0917fa7 b20c8405ac
10 #31010 list a cron job's default approval mode as "" instead of null 72478abfeb c8dc175dcd
11 #31367 announce when the md notebook shortcut button is recording d8d4b05bfc e5a00741e2
12 #31499 name the session storage sort dropdown 175e470bfc b3bfe8a016
13 #31228 expose on state of the logs page Matches only toggle 8f8b7ecf91 42358d75b5
14 #31214 show the featured app card category in the reader language 8095bc3e70 1459bc9b88
15 #31486 announce whether a skill folder row is open 92e76f7d64 f57eee0205
16 #31870 mark knowledge folder disclosure buttons as expanded 73889c1bed bf35342b7d
17 #31683 announce which issue radar filter rows are on 2217bd2f5b fb4d23e463
18 #31871 expose open state on design tweak history and dimensions a47c2d4eff e026def468
19 #31947 announce which issue radar label pills are selected 5cae4a9129 a5121a8c86
20 #31927 expose on state of the find bar case-sensitive toggles 78cae1341e bb94327b8c
21 #32054 mark the open issue radar dashboard as the current page f6cfe99856 55eb5c5a4d
22 #32045 expose the selected state of memory graph filter chips 3e3ae0a701 c12eeacf8b
23 #31776 lead the post-turn refusal note with the work's outcome f980022355 0c92b20623
24 #32276 expose open state on the schedule job message toggle 0600f3b411 553a388e4b
25 #32166 expose the selected workflow in the library list a1d4896ef1 db12756756

22 commits carried a non-public author email or an internal co-author trailer, which the push guard refuses, so they are authored with the public identity and name their original author in the message; internal trailer lines are removed. The other 3 keep their original author.

builder-security checked: each change is the one already merged on main; no bind, listener, new route, auth mechanism or storage grant is added.

Backwards compatibility

Compatible: each change is the one already merged on main, and its compatibility note applies unchanged.

Removes nothing: no setting, key or caller is removed.

Tests

Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs

  • CI does not run the backend suite on PRs into release/*, so the direct test modules were run here: every touched test file plus every test file that imports a touched module, 55 files, -n 4 --dist loadgroup. 2684 passed, 0 failed.
  • Frontend: tsc -p tsconfig.app.json --noEmit passes. vitest run on every touched test file and every touched component name: 62 files, 686 passed, 3 failed. The 3 are in src/pages/SchedulePage.secrets.test.tsx and fail the same way on a clean release/0.12.0 @ aa7dfb4aae.
  • flake8 passes on the changed Python files.

Manual verification

N/A - each fix was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.

Screenshots / video

Why no screenshot: each frontend pick carries the same rendered change as its main PR, whose screenshots show it.

Related Issues

Backport to the 0.12 line for 0.12.1 of #30394, #30492, #30523, #30581, #30647, #30577, #31021, #30953, #31187, #31010, #31367, #31499, #31228, #31214, #31486, #31870, #31683, #31871, #31947, #31927, #32054, #32045, #31776, #32276, #32166.

Sibling sweep

Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.

Pattern harvest

Not generalizable: this PR only carries fixes already on main. The source PRs have their own harvest.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

bolichen97 and others added 25 commits November 8, 2026 02:41
…30492)

With Slack tokens set but no KIROCREW_OWNER_ID, or a workspace that
fails enterprise validation, init_socket_mode disables Slack and only
logs the reason. The connect error stays empty, so System > Services
shows a bare Not connected. Record the reason as the connect error so
the status surfaces show it.

(cherry picked from commit ee76465)

Original author: Rohan Khanderia (#30492).
…ng copy (#30523)

(cherry picked from commit b66e026)

Original author: Javen Cinocca (#30523).
)

The spawn note and the Subagent Model/Effort help say a dedicated
subagent runtime costs about 0.55 GB, the figure measured in #23510.
The Session Sharing help, the spawn tool descriptions, the llm-council
skill and the subagent spec still said ~400MB, so one runtime showed
two figures. They now all use the measured one.

Fixes #30362

(cherry picked from commit f2ac71e)

Original author: Zezhen Xu (#30581).
Restoring a full snapshot of a home over 4 GiB without
--max-archive-gib is refused with a message saying such an archive is
one "which no memory bundle produces". A whole-home bundle reaches the
same bound, so the wording reads wrong for the most common case.

Both refusals in _refuse_oversized_archive now name the restore bound
instead: the entry-count one matches the writer-side message ("which
`kirocrew restore` refuses"), and the byte one says the archive is over
the bound restore holds it to, then keeps the --max-archive-gib hint.

Fixes #30398

## Pattern harvest
Not generalizable: a one-off wording slip in two refusal strings.

(cherry picked from commit d34fe7e)

Original author: Matthew Briones (#30647).
The French Command Bar catalog had four values typed without accents,
so an accented search for "Changer de thème" found nothing and the
retry and no-match texts read as misspelled.

(cherry picked from commit dbb65c5)

Original author: Zezhen Xu (#30577).
The chevron that collapses a cron folder on the Schedule page carries
no aria-expanded, so a screen reader cannot tell whether the folder's
jobs are showing. The button now reports it.

(cherry picked from commit 42e5c9a)

Original author: Rohan Khanderia (#31021).
…30953)

The collapsed rail drew 20px icons in 32px rows, so the icons sat
close together and the narrow rail read crowded. Collapsed rows now use
the expanded rows' vertical padding, so both are 36px tall. Expanded
rows are unchanged.

Closes #30932

Co-authored-by: CrysisDeu <crysisdeu@users.noreply.github.com>
(cherry picked from commit 722b07e)

Original author: Zezhen Xu (#30953).
Each Issue Radar left-rail accordion header opens its section and
shows a rotating chevron, but the header button never exposed whether
its section was open. Add aria-expanded from the section expanded prop
and pin it in the left rail test.

(cherry picked from commit a3a0917)

Original author: Rohan Khanderia (#31187).
…31010)

GET /api/crons turned the stored default approval_mode "" into null,
so a job read from the list could not be sent back to PATCH, which
accepts only "" or "auto". The list now returns the stored value.

Closes #29825

(cherry picked from commit 72478ab)
…#31367)

The sync shortcut button in MD Notebook settings toggles key recording
on and off, but its fixed aria-label hides the Recording text and it
carries no pressed state, so a screen reader never hears that recording
started. Add aria-pressed from the recording state and pin both states.

(cherry picked from commit d8d4b05)

Original author: Rohan Khanderia (#31367).
(cherry picked from commit 175e470)

Original author: Rohan Khanderia (#31499).
The Matches only button on the Logs page turns a filter on and off but
shows its state only by color, and its label never changes, so a
screen reader cannot tell whether it is on. It now carries
aria-pressed.

(cherry picked from commit 8f8b7ec)

Original author: Rohan Khanderia (#31228).
…#31214)

The single-app featured card in Discover printed the category id, which
is the English CATEGORY_ORDER value, so every language saw Research &
Writing or Developer Tools in English. The Discover list row already
renders the catalog label through categoryLabel; the featured row now
does the same.

(cherry picked from commit 8095bc3)

Original author: Rohan Khanderia (#31214).
Folder rows in the skill directory browser show and hide their
children, but the row button never exposed whether the folder was
open. Add aria-expanded from the open state and pin both states in
the existing expand test.

(cherry picked from commit 92e76f7)

Original author: Rohan Khanderia (#31486).
The two buttons that toggle a Knowledge folder source's inline scan
panel -- the chevron button and the "N files failed" link -- flip a
chevron and swap their label but never set aria-expanded, so a screen
reader cannot tell the control is a disclosure or whether its panel is
open. Set aria-expanded on both, reflecting the open state, matching
the sibling folder-picker button and the SourceGroup folder header.

No behaviour or input handling changes.

Fixes #31865

(cherry picked from commit 73889c1)

Original author: Rohan Khanderia (#31870).
Issue Radar filter rows (Open, Merged, Draft, Assigned to me and the
rest) show they are on only by colour, so assistive tech hears a plain
button either way. Add aria-pressed from the row active prop and pin
the on and off states in the PR filters test.

(cherry picked from commit 2217bd2)

Original author: Rohan Khanderia (#31683).
…31871)

The Design Tweak History toggle and the preview Dimensions dropdown
open and close a region, but neither button said whether it was open.
Their labels stay the same in both states, so a screen reader user
could not tell. Both buttons now carry aria-expanded with their open
state.

(cherry picked from commit a47c2d4)

Original author: Rohan Khanderia (#31871).
Issue Radar label pills filter the list on and off, but a selected
pill shows it only by its fill colour and bold text, so assistive
tech hears the same button either way. Add aria-pressed from the
selected prop and pin both states in the label palette test.

(cherry picked from commit 5cae4a9)

Original author: Rohan Khanderia (#31947).
…1927)

The chat and document find bars each have a Case sensitive button that
shows its state only by color, so a screen reader cannot tell whether
case-matching is on. Both now carry aria-pressed.

(cherry picked from commit 78cae13)

Original author: Rohan Khanderia (#31927).
…32054)

The Issue Radar rail Dashboards rows mark the dashboard on screen only
by colour, bold text and an accent icon, so assistive tech cannot tell
which one is open. Set aria-current="page" on that row and pin it, and
its absence while another view is on screen, in the rail entry tests.

(cherry picked from commit f6cfe99)

Original author: Rohan Khanderia (#32054).
…2045)

The Memory graph tab's group filter is a row of toggle chips -- an "All"
button plus one per group. The active chip is shown only through accent
styling, with no aria-pressed, so a screen reader announces each as a
plain button and cannot convey which filter is applied. Set aria-pressed
on every chip, reflecting the active filter ("All" pressed when no group
filter is set).

No behaviour or layout change.

Fixes #32023

(cherry picked from commit 3e3ae0a)

Original author: Rohan Khanderia (#32045).
On a harness without mid-turn steer, a block in a turn that already
answered is explained afterwards by the refusal continuation. Its
finished-task instruction asked for one short line noting the block,
so that line became the user's last message and buried the summary;
collapse-all mode showed only the block.

The finished task now opens with a one-line recap of the outcome,
named as the one restatement the "do not repeat" rule allows, then
one short line noting the block.

Closes #21962

(cherry picked from commit f980022)
Each Schedule page job row shows its message as a preview button that
expands the full text, but it carries no aria-expanded, so a screen
reader cannot tell whether the full message is showing. It now does.

(cherry picked from commit 0600f3b)

Original author: Rohan Khanderia (#32276).
The Workflows library shows the saved workflows as a list of buttons,
and marks the open one with accent styling alone -- no aria-pressed. A
screen reader announces each as a plain button and cannot convey which
workflow is open in the editor, including the row auto-selected on load.
Set aria-pressed on each list button, reflecting the selected definition.

No behaviour or layout change.

Fixes #32161

(cherry picked from commit a1d4896)

Original author: Rohan Khanderia (#32166).
@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 8, 2026 02:46
@buluoray
buluoray requested review from Zedmor and removed request for a team November 8, 2026 02:46
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of db127567566394a74f11fc698809fb4082d3bf39 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. Every item is a cherry-pick of a fix already merged on main, and each one names a defect a user could see. Nothing here is new to this branch.

What this change ships

Inventory (10 items) — 10 justified

Intent: a FIX. It brings 25 small fixes from main to 0.12.0 users through release/0.12.0. The change has more than 10 items, so this list keeps the 10 a person is most likely to notice.

  1. The sidebar session preview no longer prints the raw [STEERING steer-…] marker — justified
  2. When Slack is disabled at startup, System > Services now says why ("KIROCREW_OWNER_ID is not set" or "enterprise validation") — justified
  3. An uploaded knowledge file is titled by its own name, not by the kn_<hex> staging copy — justified
  4. Every place that quotes the memory cost of a dedicated subagent process now says 0.55 GB, not 400 MB — justified
  5. The snapshot restore size refusal no longer says "no memory bundle produces" — justified
  6. A finished post-turn refusal reply now opens with what the work achieved before it notes the block — justified
  7. The cron list API now returns the default approval_mode as "" instead of null — justified
  8. The French command bar strings get their accents back — justified
  9. Rows in the collapsed nav rail are now 36px tall, the same as expanded rows — justified
  10. Screen readers now hear the open, pressed or current state on about 16 toggles, disclosures and list rows, and the session storage sort dropdown gets a name in 13 locales — justified

[FIRST-PRINCIPLES-REVIEWED] db12756

Description read

[DESCRIPTION-READ] 6c7e0af7ee96ba77789cd3276d4116038229db80b45cef3277068de6d5faa1dd

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of db127567566394a74f11fc698809fb4082d3bf39 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing screenshots of the visible frontend picks. This PR attaches and commits no image, so the blind read was not performed.

Evidence gaps

  • Collapsed nav rail rows (navRow.tsx, appRail.tsx): collapsed rows now use py-2 instead of py-1.5. Closed by a before/after still of the collapsed rail.
  • Featured app card category (FeaturedSpotlight.tsx): the category is now shown through categoryLabel(...), in the reader's language. Closed by a still of the card in a non-English locale.
  • French command bar strings (fr.json): "Aucun résultat", "Réessayer", "Changer de thème" and the failure line. Closed by a still of the French command bar showing them.
  • Slack connect reason in System > Services: shows "KIROCREW_OWNER_ID is not set" or "workspace failed enterprise validation" instead of a bare "Not connected". Closed by a still of System > Services with the reason showing.
  • The description says "each frontend pick carries the same rendered change as its main PR, whose screenshots show it". Those screenshots are attached to other PRs, not to this one, so they are not evidence for this revision. Re-attaching them to this PR's description would close these gaps.

[UX-REVIEWED] db12756

Description read

[DESCRIPTION-READ] f4367737c4a972c9fafc47e0a7c7d386883d7e2d414ab480c08fd6d28ccc47ca

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of db127567566394a74f11fc698809fb4082d3bf39 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: these are clean cherry-picks of fixes already merged on main. The diff stays in scope, and the only wire change (approval_mode sent as "" instead of null) is still falsy to its string? reader.

Notes

  • The collapsed nav-rail padding change (py-1.5 → py-2) and the featured-card category text are the only visual changes, and neither has a screenshot from this revision. Both are small and easy to revert, so this is not a blocker, but the 0.12.1 RC soak should look at them.

[DESIGN-REVIEWED] db12756

Description read

[DESCRIPTION-READ] bc7148aa4a68a415902d53f2650e6d0508f73f14b2562285a67620a861943968

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed db127567566394a74f11fc698809fb4082d3bf39 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] db12756

Verdict parsed from the review's SHA-scoped output markers for commit db127567566394a74f11fc698809fb4082d3bf39.

False positive or not applicable? A repository writer can comment:
/ai-review override fable db127567566394a74f11fc698809fb4082d3bf39 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of db127567566394a74f11fc698809fb4082d3bf39 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] db12756

False positive or not applicable? A repository writer can comment:
/ai-review override gpt db127567566394a74f11fc698809fb4082d3bf39 false-positive: <reason, 20 to 500 characters>

@buluoray
buluoray merged commit aed03d0 into release/0.12.0 Nov 8, 2026
20 of 23 checks passed
@buluoray
buluoray deleted the crew/slack/0.12.1-batch-58 branch November 8, 2026 03:15
@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants