Skip to content

fix: backport 0.12.1 batch 59 (25 wide-bar fixes) - #32856

Merged
buluoray merged 25 commits into
release/0.12.0from
crew/slack/0.12.1-batch-59
Nov 8, 2026
Merged

buluoray merged 25 commits into
release/0.12.0from
crew/slack/0.12.1-batch-59

Conversation

@buluoray

@buluoray buluoray commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Bring 25 small fixes that merged on main after v0.12.0 onto release/0.12.0, one commit each, in a PR of their own.

Why it matters

Each row is a user-visible fix from the 0.12.1 wide-bar list (Ray, 11-07). Every pick applied cleanly onto release.

PR Area What a 0.12.0 user sees today
#30210 a11y Show-resolved toggles do not announce open state
#30285 a11y Artifact Deploy toggles do not announce open state
#29944 settings Default agent model pin notice says the wrong thing
#30535 personal-shopper Non-ASCII group names create duplicate groups
#30489 a11y Pending-skill Review toggle does not announce open state
#30610 transfer Full import slot cap answers 429 instead of 409
#30582 knowledge Dedup audit line names the wrong removed document
#30699 sessions Keyboard focus lost when arming or cancelling trash batch delete
#31038 a11y Channel settings id-list add box has no name
#31025 a11y Decisions API key Remove/Keep drops keyboard focus
#30830 i18n Sidebar Thinking status not localized
#31184 a11y Store refresh button loses focus while refreshing
#31061 chat not-yet-started subagent no longer shows a running elapsed timer
#31380 a11y board column popover name box has an accessible name
#31699 sidebar screen readers name the folder rename box
#31824 file search both file search engines show the same line numbers and previews
#31825 UI Pinned side panel tabs stay visible with many tabs open
#30146 sandbox ssh-agent notice shows even if consent file is not UTF-8
#32279 a11y focus stays on project export button while it runs
#32170 i18n task depends-on list joined per locale
#32413 a11y/sidebar Open session archive row not marked current
#32471 acp Foreign settings.local.json created in a race makes seed decline
#32405 a11y/deploy Focus lost from deploy profile Verify while it checks
#32496 sidebar Drag-only folder rows show a click pointer
#32539 knowledge a11y Keyboard focus lost when knowledge Generate now runs

Not a goal

  • No fix that is not already merged on main; nothing is changed only here.
  • No version bump, no tag, no CHANGELOG.md change.

What changed (motivation → approach → change)

Each main squash commit was cherry-picked with -x onto release/0.12.0 @ aa7dfb4aae, in merge order on main, one commit each. Every pick applied cleanly, with no prerequisite and no hand-resolved hunk; every commit has added and removed lines identical to its main commit.

# PR main commit release commit
1 #30210 expose open state on the two show-resolved toggles dabc20a658 2feb8f8a0f
2 #30285 expose open state on the Artifact Deploy page toggles f81f7b29f9 bb6011b46c
3 #29944 correct the default agent model pin notice 7720e97448 18031791b2
4 #30535 match group names case-insensitively for non-ASCII letters aa56e70eee b0bfd792d1
5 #30489 expose open state on the pending-skill Review toggle d4c35f448f e1942d976c
6 #30610 answer 409 when the import slot cap is full 664015f4ed ad99da467c
7 #30582 name the removed document in the dedup audit line 304669f5ea 1949c33561
8 #30699 keep keyboard focus when arming or cancelling a trash batch delete 133555fd42 f0c832bf80
9 #31038 name the channel settings id-list add box a188c567f3 5ae7a207fc
10 #31025 keep focus on the Decisions API key Remove/Keep it handoff e935ab1f69 d1e0e74ffd
11 #30830 localize the generic thinking status in the session row b5ce1fc3a5 73e751ea79
12 #31184 keep focus on the store refresh button while it refreshes 823d9eb48a cb40916cea
13 #31061 hide the elapsed timer on a subagent that has not started 7ff9157d70 0a1bcc5e28
14 #31380 name the board column popover's name box b548559352 1422e2d840
15 #31699 name the sidebar folder rename box 594344f11b 948f69e523
16 #31824 give both file search engines the same line numbers and previews 9610bf85d6 a3c9c933d5
17 #31825 keep pinned side panel tabs visible when many tabs are open fdb1454cfc 86ac18bd81
18 #30146 read a non-UTF-8 ssh-agent consent file as not granted 8e500260ab af16ae7a7d
19 #32279 keep focus on the project export button while it runs ccb85f3c85 d93b1d5782
20 #32170 join a task's depends-on list by locale 251efa59a1 4136629682
21 #32413 mark the open session archive row as current e356cc632a e1c870d3f6
22 #32471 exclude a foreign settings file that wins the create race ca77d758eb 0abff6f59a
23 #32405 keep focus on a deploy profile's Verify while it checks b94163e3dd 752e2a1fd5
24 #32496 show the drag cursor, not a click pointer, on drag-only handles 94bee0d409 c0fdbbb265
25 #32539 keep focus on the knowledge Generate now while it runs e492bc02cb 8a2c2eca53

21 commits carried a non-public author email or an internal co-author trailer, which the push guard refuses, so they are authored with the public identity and name their original author in the message; internal trailer lines are removed. The other 4 keep their original author.

builder-security checked: each change is the one already merged on main; no bind, listener, new route, auth mechanism or storage grant is added.

Backwards compatibility

Compatible: each change is the one already merged on main, and its compatibility note applies unchanged.

Removes nothing: no setting, key or caller is removed.

Tests

Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs

  • CI does not run the backend suite on PRs into release/*, so the direct test modules were run here: every touched test file plus every test file that imports a touched module, 13 files, -n 4 --dist loadgroup. 427 passed, 14 skipped, 0 failed.
  • Frontend: tsc -p tsconfig.app.json --noEmit passes. vitest run on every touched test file and every touched component name: 168 files, 2146 passed, 0 failed.
  • flake8 passes on the changed Python files.

Manual verification

N/A - each fix was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.

Screenshots / video

Why no screenshot: each frontend pick carries the same rendered change as its main PR, whose screenshots show it.

Related Issues

Backport to the 0.12 line for 0.12.1 of #30210, #30285, #29944, #30535, #30489, #30610, #30582, #30699, #31038, #31025, #30830, #31184, #31061, #31380, #31699, #31824, #31825, #30146, #32279, #32170, #32413, #32471, #32405, #32496, #32539.

Sibling sweep

Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.

Pattern harvest

Not generalizable: this PR only carries fixes already on main. The source PRs have their own harvest.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

buluoray and others added 25 commits November 8, 2026 02:46
The pull-request review panel and the artifact comments sidebar each
show or hide resolved threads with a button that had no aria-expanded,
so a screen reader could not tell whether resolved threads were
showing. The sidebar's check icon was also exposed to assistive tech.

Both buttons now carry aria-expanded, and the sidebar icon is
aria-hidden.

(cherry picked from commit dabc20a)

Original author: Rohan Khanderia (#30210).
)

The Getting started and How this is secured cards on the Artifact
Deploy page each open and close with a clickable header that had no
aria-expanded, so a screen reader could not tell whether the section
was open. Their chevron and title icons were also exposed to
assistive tech.

Both headers now carry aria-expanded, and their icons are aria-hidden.

(cherry picked from commit f81f7b2)

Original author: Rohan Khanderia (#30285).
The Settings model pin notice read "New chats on the <agent> agent use
its own pinned model <model>, not this setting." A plain new chat does
not use that pin: the New chat button starts a default-template session,
and its model resolves through the template tier, which skips the
crewmate pin and falls to the Default Model setting. The pin only decides
the model of a chat pointed at that agent with Switch agent.

Reword the notice to say that a chat pointed at the agent with Switch
agent runs its pin, and that the New chat button uses this setting, so
the setting no longer reads as a no-op. Update every locale. Wording
only: no backend, resolver, or model-resolution change, and no new
option, so the model a chat runs on is unchanged.

The sibling template notice was already correct: the template's own
model is what a plain new chat runs, so it is left unchanged.

Update the ChatPanel notice test to the corrected copy; it fails on the
old string and passes with the reword.

Closes #29725

Co-authored-by: kirocrew-agent <agent@kirocrew.local>
(cherry picked from commit 7720e97)

Original author: Raymond Chen (#29944).
…SCII letters (#30535)

PreferenceStore.add_group promised a case-insensitive match on the trimmed name, but it compared with SQLite's lower(), which folds ASCII letters only. Adding "Électronique" and then "électronique" created two groups with the same name, splitting the user's preferences.

The lookup now reads the group names and compares them with str.casefold in Python, under the same lock. A regression test adds French and Russian names in two cases and checks that the second add returns the first group.

Closes #30534

(cherry picked from commit aa56e70)

Original author: rohnkum (#30535).
On the Skills tab, each pending skill candidate opens its review panel
with a Review / Hide button that had no aria-expanded, so a screen
reader could not tell whether the panel was open.

The button now carries aria-expanded.

(cherry picked from commit d4c35f4)

Original author: Rohan Khanderia (#30489).
(cherry picked from commit 664015f)

Original author: Joe Guo (#30610).
…0582)

A dedup loser is always one document. For an artifact or upload with no
file path the knowledge.dedup.collapse SEL event said
loser_file=(whole-source), which reads as the whole source being
removed. It now names the document by its label.

Fixes #30344

(cherry picked from commit 304669f)

Original author: Zezhen Xu (#30582).
…batch delete (#30699)

(cherry picked from commit 133555f)

Original author: Rohan Khanderia (#30699).
(cherry picked from commit a188c56)

Original author: Rohan Khanderia (#31038).
…doff (#31025)

(cherry picked from commit e935ab1)

Original author: Rohan Khanderia (#31025).
…ow (#30830)

Co-authored-by: kirocrew-agent <agent@kirocrew.local>
(cherry picked from commit b5ce1fc)

Original author: Raymond Chen (#30830).
…31184)

(cherry picked from commit 823d9eb)

Original author: Rohan Khanderia (#31184).
A subagent waiting on its spawn approval has not launched, but its row
in the subagent progress bar still drew a ticking elapsed timer next to
"Waiting for your approval to start", so it read as a running agent.
The row now skips the timer while the run is pending, both while it
awaits approval and while it checks whether a gone approval started.
Running, tool and finished rows keep it, matching the sidebar card.

Closes #29812

(cherry picked from commit 7ff9157)
(cherry picked from commit b548559)

Original author: Rohan Khanderia (#31380).
(cherry picked from commit 594344f)

Original author: Rohan Khanderia (#31699).
)

With a dozen tabs open, the side panel's pinned tabs (Changes,
Artifacts, Files) were squeezed to a sliver: both tab groups shrank
with the same flex factor, and flex takes overflow from each item in
proportion to its size, so the much wider open-tabs group dragged the
pinned group down with it.

The open-tabs group now gives up its width first, down to nothing when
the pinned chips alone fill the strip, and is clipped to its wrapper
instead of spilling a chip fragment under the + button. Its tabs stay
in the "List all tabs" menu. The pinned group keeps the default factor,
so at the narrowest widths it still yields after that and the trailing
strip controls stay on screen.

Closes #22006

(cherry picked from commit fdb1454)
…30146)

is_granted() promises to fail closed on an unreadable consent store, but
_read_all caught only OS errors and bad JSON. A store whose bytes are not
UTF-8 (a UTF-16 save of {"enabled": true} is the likely one) raised
UnicodeDecodeError instead. Every caller already catches that and keeps
the socket scrubbed, so nothing was forwarded; but the consent notice and
the doctor line that tell the operator how to grant it went silent, and
the unreadable-store warning was never logged.

Such a store now reads as no consent, like bad JSON: the socket stays
scrubbed and the notice is shown.

(cherry picked from commit 8e50026)

Original author: Rohan Khanderia (#30146).
)

The project detail Export YAML button used a native disabled while the
export ran, which takes the focused button out of the tab order and
drops a keyboard user to the page. Make it inert with aria-disabled and
a guard instead, and pin focus and the ignored second press.

(cherry picked from commit ccb85f3)

Original author: Rohan Khanderia (#32279).
The task detail panel lists the tasks a finished task depended on as
one sentence. It joined those translated "Task N (title)" labels with
a hard-coded ", ", so German read "A, B, C" instead of "A, B und C"
and Chinese got an English comma instead of "A、B和C".

The list now goes through fmtList, so it follows the active language.

Fixes #32165

(cherry picked from commit 251efa5)

Original author: Rohan Khanderia (#32170).
(cherry picked from commit e356cc6)

Original author: Rohan Khanderia (#32413).
…32471)

A project-owned settings.local.json that appears right before Crew's
O_EXCL create made the seed decline outright, while the same file
present a moment earlier took the guarded exclusion. The create-race
branch now tries that exclusion too, so both timings get one outcome.
Bypass mode, project hooks and old adapters stay refused as before.

Fixes #30918

(cherry picked from commit ca77d75)

Original author: Joe Guo (#32471).
…32405)

Each AWS profile row's Verify button took a native disabled while its
reachability check ran. A disabled button leaves the tab order, so a
keyboard press dropped focus to the page until the check settled.
Mark the busy row aria-disabled and ignore a second press instead, the
way the Ops Mission Control refresh does.

(cherry picked from commit b94163e)

Original author: Rohan Khanderia (#32405).
…32496)

With Compact Empty Folders on, an empty folder's row is only a drag
handle, but its header shell carries role="button" for keyboard
reordering, and the base rule in index.css paints every enabled
role="button" with cursor: pointer. The row looked clickable while a
click did nothing. The shell now inherits the row's drag cursor.

The layout editor's pane bar has the same shape: its role="button"
drag handle covers the whole bar and took the same pointer over the
bar's grab cursor. It inherits the bar's cursor too.

Closes #30320

(cherry picked from commit 94bee0d)
…2539)

The smart-search banner's Generate now button took a native disabled
while its embedding run was in flight. A disabled button leaves the
tab order, so a keyboard press dropped focus to the page until the
run settled. Mark the busy button aria-disabled and ignore a second
press instead, the way the Ops Mission Control refresh does.

(cherry picked from commit e492bc0)

Original author: Rohan Khanderia (#32539).
@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 8, 2026 02:51
@buluoray
buluoray requested review from tim-finnigan and removed request for a team November 8, 2026 02:51
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of 8a2c2eca5304a75bb8016ee826b910140064fa74 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing screenshots for this revision. The PR changes visible copy and layout, the blind read was not performed, and the screenshots from the source PRs were never attached here.

Evidence gaps

  • Default-model pin notice: the rewritten agent_model_pin_overrides_default in all 13 locales. Needs a screenshot of the notice on the settings page.
  • Pinned tabs in SidePanel.tsx with many tabs open. Needs a screenshot of the overflow state.
  • SubagentProgressBar.tsx for a subagent that has not started. Needs a screenshot showing no elapsed timer.
  • The "Thinking" status in the session row in a non-English locale. Needs a screenshot.
  • The depends-on list in TaskDetailPanel.tsx, joined per locale. Needs a screenshot.
  • The drag cursor on drag-only folder and board rows in folderBlocks.tsx and boardLane.tsx. Needs a screenshot.
  • The current-row marking on the open session in SessionArchive.tsx. Needs a screenshot.
  • Saying the source PRs' screenshots show the change does not close a gap: none of those images is attached to this PR.

Notes

  • In en.json, "The New chat button does not." has no object and reads as a fragment. Replace it with "Chats started with the New chat button use this setting instead."

[UX-REVIEWED] 8a2c2ec

Description read

[DESCRIPTION-READ] 57f08d26fc26c0b8f25e4cbb5cf26d37ee5124f64e191f5fb49e0a40b5c49381

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 8a2c2eca5304a75bb8016ee826b910140064fa74 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

No blocker: this is a cherry-pick of 25 fixes already merged on main, so each one rests on its own source PR and none adds new surface here.

Notes

  • Item 4: undeclared, a status contract change. The diff rewrites the pinned assert resp.status == 429 to 409 on a public import route. The description gives the reason only through the main PR (fix(transfer): answer 409 when the import slot cap is full #30610). Any client outside the repo that keys on 429 for transfer_slot_cap sees different behaviour on a patch release.

What this change ships

Inventory (10 items, list capped) — 9 justified

Intent: give 0.12.x users the 25 user-visible fixes that already landed on main in a 0.12.1 point release. FIX.

  1. Disclosure toggles (show-resolved, Deploy, pending-skill Review) announce their open state — justified
  2. The default agent model pin notice gives the correct text — justified
  3. Personal-shopper group names with non-ASCII letters no longer duplicate when only the case differs — justified
  4. A full import slot cap now answers 409 instead of 429 — undeclared contract change (see Notes)
  5. The dedup audit line names the removed document instead of "(whole-source)" — justified
  6. Keyboard focus is kept on Generate now, export, Verify, refresh and the Remove/Keep handoff — justified
  7. The sidebar Thinking status is localized, and the depends-on list is joined per locale — justified
  8. Both file search engines number lines by \n alone and strip the trailing \r — justified
  9. A non-UTF-8 ssh-agent consent file reads as not granted instead of raising — justified
  10. A foreign settings.local.json that wins the create race gets the guarded exclusion — justified

[FIRST-PRINCIPLES-REVIEWED] 8a2c2ec

Description read

[DESCRIPTION-READ] 8cbdcfe17476d7f4d71856b6b6f19f81880b480a392507b5659c13a738927361

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 8a2c2eca5304a75bb8016ee826b910140064fa74 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: these are 25 clean cherry-picks of fixes already merged on main. Nothing in the tree reads the import slot-cap status by its old 429 value.

Notes

  • The 429 → 409 change on transfer_slot_cap changes a status code that other programs see. Nothing in this repo checks for 429, but a remote sender that retries on 429 will now stop at the cap. That is the intended behaviour, and it is worth a line in the 0.12.1 release notes.

[DESIGN-REVIEWED] 8a2c2ec

Description read

[DESCRIPTION-READ] e0d60b48f4733a7f01b5c2e180d52b69438e63bc43ee36459b2e7f1bd476ea3f

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 8a2c2eca5304a75bb8016ee826b910140064fa74 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 8a2c2ec

Verdict parsed from the review's SHA-scoped output markers for commit 8a2c2eca5304a75bb8016ee826b910140064fa74.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 8a2c2eca5304a75bb8016ee826b910140064fa74 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 8a2c2eca5304a75bb8016ee826b910140064fa74 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 8a2c2ec

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 8a2c2eca5304a75bb8016ee826b910140064fa74 false-positive: <reason, 20 to 500 characters>

@buluoray
buluoray merged commit 2e1fff0 into release/0.12.0 Nov 8, 2026
20 of 23 checks passed
@buluoray
buluoray deleted the crew/slack/0.12.1-batch-59 branch November 8, 2026 03:16
@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants