Skip to content

fix: backport 0.12.1 batch 60 (24 wide-bar fixes) - #32860

Merged
buluoray merged 24 commits into
release/0.12.0from
crew/slack/0.12.1-batch-60
Nov 8, 2026
Merged

buluoray merged 24 commits into
release/0.12.0from
crew/slack/0.12.1-batch-60

Conversation

@buluoray

@buluoray buluoray commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Bring 24 small fixes that merged on main after v0.12.0 onto release/0.12.0, one commit each, in a PR of their own.

Why it matters

Each row is a user-visible fix from the 0.12.1 wide-bar list (Ray, 11-07). Every pick applied cleanly onto release.

PR Area What a 0.12.0 user sees today
#30142 website Artifact comment boxes have no accessible name
#29925 dashboard Approval-wait phrase shows wrong unit and plural
#30139 schedule Focus lost after cancelling an empty folder's delete
#30207 website Comment reply and pending-edit boxes have no accessible name
#30505 files-app File search says results capped when nothing was dropped
#31068 artifacts Unreadable artifact returns a bare 500
#31105 dashboard Feature video fails with 416 on a malformed Range header
#31056 i18n Library uninstall note split into broken translated pieces
#31157 voice Mic dialog does not say speech recognition is off
#31127 issue-radar issue radar card stays open on a scroll that keeps the link
#31480 subagents subagent result paths shown under the declared KIROCREW_HOME
#31508 gateway shutdown log names writes still in flight when teardown is cut
#31876 logs page screen readers announce the log level choice as a radio group
#31992 session storage empty-trash job reports the full space it freed
#32070 a11y Chosen DAG or Phased task layout is announced
#32057 i18n share warning sensitive kinds joined per locale
#32269 a11y focus stays on artifacts Load more while loading
#32357 remote crew Cancelled token mint leaves an ssh process running
#32077 chat Tool-risk badge label repeats a word, not saying vote is feedback
#32494 artifacts/chat "Draft a prompt in chat" opens a new chat with empty composer
#32511 KAS/MCP MCP menu shows tools as loaded after use on the KAS backend
#32506 chat/goals Composer goal button hover now shows the next-cycle countdown
#32480 chat Sending under a long reply briefly opens a big blank gap
#32529 voice Busy-mic note claims another chat holds the mic when none does

Not a goal

  • No fix that is not already merged on main; nothing is changed only here.
  • No version bump, no tag, no CHANGELOG.md change.
  • Not fix(doctor): fail when the selected kiro-cli backend has no kiro-cli #31027 (fail when the selected kiro-cli backend has no kiro-cli). It picked without a conflict but reads a cfg name that release's cli_doctor.py does not define (flake8 F821 at line 654; 83 doctor tests fail), so it needs a prerequisite and is left for a later round.

What changed (motivation → approach → change)

Each main squash commit was cherry-picked with -x onto release/0.12.0 @ aa7dfb4aae, in merge order on main, one commit each. Every pick applied cleanly, with no prerequisite and no hand-resolved hunk; every commit has added and removed lines identical to its main commit.

# PR main commit release commit
1 #30142 name the artifact comment boxes ffdfa4aa7d ab0e7e6edd
2 #29925 correct unit and plural in approval-wait phrase 68c7f65d24 b49e4744bf
3 #30139 return focus to the folder menu when an empty folder's delete is cancelled d10a48b0fa 4e88c6ba13
4 #30207 name the comment thread reply and pending-comment edit boxes d5e25625bd dac869bb5a
5 #30505 report search as truncated only when matches were dropped 3adab5e0c4 acce790ee1
6 #31068 answer an unreadable artifact with a json error ded740cacb 077c8590eb
7 #31105 serve the whole feature video on a malformed range header 305c6d26c1 46bac6c4ad
8 #31056 word the Library uninstall registry note as one message de9ed9b233 5746935c18
9 #31157 say speech recognition is off in the mic dialog for provider off b83ae4fae5 fa8cb41548
10 #31127 a scroll that leaves the link in place keeps its card ccc2167cc1 9fd13339db
11 #31480 show result paths under the declared KIROCREW_HOME a31eccd7b5 60abbdd479
12 #31508 name in-flight writes when shutdown is cut during teardown 787818992e f92ede2bd7
13 #31876 announce the chosen log level as a radio group c77ef4ba24 97681d7943
14 #31992 count everything empty trash frees in the job's total 6385b99540 06a7ce0883
15 #32070 announce the chosen DAG or Phased task layout ecd76bf1d3 477b11783f
16 #32057 join share-warning sensitive kinds by locale 69bdcd6e9a 7907978530
17 #32269 keep focus on the remote artifacts Load more while it loads ecddebbe00 5c305532a5
18 #32357 kill the ssh child when a token mint is cancelled 0db79190ae b29f72c6af
19 #32077 say the tool-risk badge's vote is feedback only 84be3f274d 1fdbc078d4
20 #32494 fill the composer when draft a prompt in chat opens a new chat bcc5647049 39f6a81831
21 #32511 mark MCP tools loaded once called on the default backend 113ff88c51 266e940b5e
22 #32506 show the next-cycle countdown on the composer goal button hover f5deb9c2fb 80909c68d9
23 #32480 keep a sent prompt's estimate out of the bottom spacer c48df8254e 44234913ce
24 #32529 stop saying another chat holds the mic when none is named d9768f8adc cd3370363f

11 commits carried a non-public author email or an internal co-author trailer, which the push guard refuses, so they are authored with the public identity and name their original author in the message; internal trailer lines are removed. The other 13 keep their original author.

builder-security checked: each change is the one already merged on main; no bind, listener, new route, auth mechanism or storage grant is added.

Backwards compatibility

Compatible: each change is the one already merged on main, and its compatibility note applies unchanged.

Removes nothing: no setting, key or caller is removed.

Tests

Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs

  • CI does not run the backend suite on PRs into release/*, so the direct test modules were run here: every touched test file plus every test file that imports a touched module, 22 files, -n 4 --dist loadgroup. 1143 passed, 3 skipped, 0 failed.
  • Frontend: tsc -p tsconfig.app.json --noEmit passes. vitest run on every touched test file and every touched component name: 60 files, 997 passed, 3 failed. The 3 are in src/pages/SchedulePage.secrets.test.tsx and fail the same way on a clean release/0.12.0 @ aa7dfb4aae.
  • flake8 passes on the changed Python files.

Manual verification

N/A - each fix was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.

Screenshots / video

Why no screenshot: each frontend pick carries the same rendered change as its main PR, whose screenshots show it.

Related Issues

Backport to the 0.12 line for 0.12.1 of #30142, #29925, #30139, #30207, #30505, #31068, #31105, #31056, #31157, #31127, #31480, #31508, #31876, #31992, #32070, #32057, #32269, #32357, #32077, #32494, #32511, #32506, #32480, #32529.

Sibling sweep

Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.

Pattern harvest

Not generalizable: this PR only carries fixes already on main. The source PRs have their own harvest.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

buluoray and others added 24 commits November 8, 2026 02:58
(cherry picked from commit ffdfa4a)

Original author: Rohan Khanderia (#30142).
_approval_wait_phrase always wrote a plural suffix and never used
seconds, so a sub-minute window read 'waited 1 minutes' and a one-hour
window read '1 hours'. Pick seconds below a minute and the singular unit
for a count of one, matching the minute/minutes choice
format_background_turn_abandoned_card already makes.

Closes #29735

Co-authored-by: kirocrew-agent <agent@kirocrew.local>
(cherry picked from commit 68c7f65)

Original author: Raymond Chen (#29925).
… delete is cancelled (#30139)

(cherry picked from commit d10a48b)

Original author: Rohan Khanderia (#30139).
…boxes (#30207)

(cherry picked from commit d5e2562)

Original author: Rohan Khanderia (#30207).
… dropped (#30505)

The /search handler set truncated whenever the result list reached
MAX_SEARCH_RESULTS. Both search collectors stop at that cap, so a folder
with exactly 500 matches looked the same as one with more. The panel then
showed "500 results (capped)" even though every match was listed.

The ripgrep and Python collectors now keep one result past the cap. The
handler sets truncated only when that extra result is present, and trims
the reply back to MAX_SEARCH_RESULTS.

Closes #30503

(cherry picked from commit 3adab5e)

Original author: rohnkum (#30505).
Opening an artifact whose files the store refuses or cannot read
returned aiohttp's plain-text 500, which the detail page cannot show.
The detail, version and event-log reads answer that failure with the
same JSON error body the list route already returns.

(cherry picked from commit ded740c)
A Range header aiohttp cannot parse (a reversed range, several ranges,
another unit) on GET /feature-videos/<release>/<file> was answered 416.
RFC 9110 section 14.2 says such a header is ignored and the whole file
sent with 200, as the file-stream and outbox routes already do. Only a
well-formed range that starts past the end of the file stays 416.

Closes #28959

(cherry picked from commit 305c6d2)
…31056)

(cherry picked from commit de9ed9b)

Original author: Rohan Khanderia (#31056).
…rd (#31127)

The issue-radar reference hover card closed on every scroll event in
the page, captured from any element. A scroll that does not move the
hovered link (another pane, a nested list, a scroll that ends where it
began) therefore dismissed a card the pointer was still on.

The card now compares the link's position with the one captured when
it opened and closes on scroll only when the link moved. A resize
still closes it. This is the same rule the chat link-preview layer
follows since #28498.

(cherry picked from commit ccc2167)
…1480)

With KIROCREW_HOME set to a symlink, a subagent's result path was
handed out under the symlink's target, because data_home() resolves
the override. #4047 kept the declared spelling for a symlinked $HOME
but not for this override, so a reader keyed on the configured path
did not recognize the file it was told to read.

agent_dir_for_display now rebuilds the run directory on the absolute
KIROCREW_HOME value when that override is the active home. Validation
and every file operation still use the resolved _agent_dir, and
data_home() is unchanged.

(cherry picked from commit a31eccd)
When the graceful shutdown bound cancels the gateway teardown, the
wait for admitted AutoNudge writes that follows it never ran, so the
warning naming a write left in flight at the deadline was skipped.
Run that wait in a finally around the teardown, so a cancelled or
failed teardown still waits out the graceful budget and logs what
is left.

(cherry picked from commit 7878189)
The four log level buttons showed the chosen level by colour alone. A screen reader heard four plain buttons and was never told which level is on. Wrap them in the shared RadioChipGroup, named by the Log Level label, and mark each with radioChip so the chosen level reads as checked.

(cherry picked from commit c77ef4b)

Original author: Rohan Khanderia (#31876).
An "Empty trash" job could finish reporting more bytes freed than its
own total. The delete counts the files a batch's manifest lists, the
manifest itself and the batch's staged crew logs, while the job's total
counted only the files the manifest lists. The total now counts the
same three things, the manifest's size read through the descriptor the
approval already pins. The comments and the spec that describe the
total say so.

Closes #29749

(cherry picked from commit 6385b99)
The DAG / Phased switcher on a project page showed the chosen layout by colour alone. Wrap the pair in the shared RadioChipGroup with a translated group name, and mark each button with radioChip so the chosen layout reads as checked.

(cherry picked from commit ecd76bf)

Original author: Rohan Khanderia (#32070).
The share dialog's pre-share warning lists every sensitive kind it
found, such as an AWS key and a local path. It joined those translated
labels with a hard-coded ", ", so German read "A, B, C" instead of
"A, B und C" and Chinese got an English comma instead of "A、B和C".

Both the card and the post-text warnings now go through fmtList, so
the list follows the active language.

Fixes #32037

(cherry picked from commit 69bdcd6)

Original author: Rohan Khanderia (#32057).
#32269)

The Load more button under a remote provider's artifacts used a native
disabled while the next page loaded. A disabled button leaves the tab
order, so a keyboard press dropped focus to the page for the whole
load. Mark the busy button aria-disabled and ignore a second press,
the way the Ops Mission Control refresh does.

(cherry picked from commit ecddebb)

Original author: Rohan Khanderia (#32269).
mint_remote_token killed and reaped its ssh child only when its wait
timed out. A cancelled mint (an instance edit stopping the refresh
loop, a gateway shutdown) left ssh running to mint a token nothing
would store. The cancel arm now runs the same kill_and_reap and
re-raises.

Builds on #25162 by @leonlaiyc.

(cherry picked from commit 0db7919)
The risk badge's thumbs carried the label "Jev", repeating the word the
line opens with, and nothing visible said a vote is only feedback: that
meaning lived in the buttons' title and aria-label, which a sighted
reader on touch or keyboard never sees.

The label now reads "Feedback only". The key is renamed from rate_jev
to rate_label because its meaning changed, and all twelve catalogs, the
pseudolocale and the translator context carry the new value. The badge
row wraps, so on a phone-width pane the note and the thumbs take their
own lines instead of the note being squeezed to a narrow column. The
decisions spec states the label.

Closes #12298

(cherry picked from commit 84be3f2)
…32494)

"Draft a prompt in chat" on an artifact with no chat yet opened the new
chat with an empty message box. The gateway lists a new session in its
slots frame before it answers the create request, so the panel mounted
the embedded chat and activated the session from that frame. The prompt
is staged only once the create returns, and the chat reads a staged
prompt only when it mounts or switches session, so it was never read.

The panel now waits for the create to return before showing the new
session, which is the order the flow already assumed.

Closes #30338

(cherry picked from commit bcc5647)
…32511)

The session MCP servers menu built its "loaded this session" set only
from kiro-cli's tool_search result JSON. The default backend (KAS)
reaches deferred tools through its own tool_load / tool_call pair and
never sends that output, so every tool stayed "deferred" and each
server read 0/N even after its tools ran.

A tool message that records an MCP call now counts as loaded too,
named by its mcp_server / tool_name meta, else by its @server/tool
title.

(cherry picked from commit 113ff88)
…32506)

The composer passes its own trigger to the goal popover, and the popover
put the "Next cycle in ..." title and its hover refresh only on its
built-in button, so hovering the composer goal button showed the cycle
without the countdown. A supplied trigger now gets the same title and
refresh while a goal loop is active, and its accessible name stays
countdown-free. A loop held for an approval or waiting on a person
shows the cycle only, matching the popover's status line.

Closes #30329

(cherry picked from commit f5deb9c)
…2480)

Sending at the bottom of a chat whose last reply is long briefly opened
a gap below the last row, the height of a whole estimated row (about
2,300px under a long reply), until the prompt's row mounted.

The transcript reaches the virtualizer through a deferred value, so
React can render the longer list and then throw that render away. The
height tree is synced to the row count in render, so the thrown-away
render left it holding the new row; the next render, on the list still
on screen, reused the memo and drew a bottom spacer for a row that was
not committed. Nothing pinned across it because no row was appended in
that commit.

The height owner now re-syncs the tree whenever it holds a different
row count than the render reading it.

Closes #29719

(cherry picked from commit c48df82)
A document comment box takes the same one-mic lock as the chat
composer but has no chat behind it, so a blocked chat fell back to
"Microphone in use in another chat" for a holder that is not a chat.
The fallback key already says "elsewhere" in its name; its text now
reads "Microphone in use elsewhere" in English and all translations,
which is true for every holder the chat cannot name. A chat the
session list knows is still named, with its jump button.

Closes #30383

(cherry picked from commit d9768f8)
@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 8, 2026 03:02
@buluoray
buluoray requested review from tim-finnigan and removed request for a team November 8, 2026 03:02
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of cd3370363f5337658289b5a09aed6c5759a13092 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing screenshots. The PR changes user-visible copy and controls on several surfaces but attaches no image, so the blind read was not performed.

Evidence gaps

  • Mic dialog: the new text "Speech recognition is turned off: no speech provider is selected…" (VoiceDisabledModal). A still of the dialog with no speech provider selected would close this gap.
  • Busy-mic note: the text changed from "Microphone in use in another chat" to "Microphone in use elsewhere" (VoiceStatusBar). A still of the note would close this gap.
  • Tool-risk badge: the thumbs label changed to "Feedback only", and the row now wraps (flex-wrap, ToolRiskBadge). Stills at desktop width and at phone width would close this gap.
  • Library uninstall note: the message is now one string (LibraryPage). A still of the uninstall confirmation would close this gap.
  • Composer goal button: the hover now shows the next-cycle countdown (AutoNudgePopover). A still of the hover would close this gap.
  • Task layout: the chosen DAG or Phased layout control now carries the label "Task layout" (ProjectDetailPage). A still of that control would close this gap.
  • Share warning: the list of sensitive kinds is now joined by locale (ShareMessageModal). A still of the warning would close this gap.
  • "Draft a prompt in chat": the new chat now opens with the composer filled. A still of that state would close this gap.
  • MCP tools panel: tools now show as loaded once they are called on the KAS backend (McpToolsPanel). A still of that state would close this gap.
  • Approval-wait phrase: the unit and plural changed. A still of the phrase would close this gap.

Notes

  • The description says no screenshot is needed because each source PR has one. Those images belong to other PRs and are not evidence for this revision. Attach them to this PR's description so the blind read can run.

[UX-REVIEWED] cd33703

Description read

[DESCRIPTION-READ] 3f6ea641f85b61b044a80d9999b9852440c28e07a1df00234d9e8a499d033749

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of cd3370363f5337658289b5a09aed6c5759a13092 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this carries 24 fixes already merged on main, applied unchanged. None of them adds or reshapes a page, panel or control set, and none removes a reader.

Notes

  • ## Backwards compatibility has both a Compatible: line and a Removes nothing: line. Choose one: the only take-aways are comment and docstring rewrites, so Removes nothing alone is accurate.
  • CI does not run the backend suite on release/*. Run the full backend suite once on the RC, not just the 22 modules picked by hand. Several of these fixes change shared seams (the chat virtualizer, MCP loaded-tools, slack exit_path), and their callers may sit outside the files that were run.

[DESIGN-REVIEWED] cd33703

Description read

[DESCRIPTION-READ] ea24ea163629cb6512f7497372741e55933cb1708aca98c4a794c49977e39e6c

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of cd3370363f5337658289b5a09aed6c5759a13092 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

This backports 24 fixes that already merged on main, one commit each. No item adds anything beyond its main PR, and none changes a default.

What this change ships

Inventory (10 items) — 10 justified

Intent: give 0.12.x users the user-visible fixes that already shipped on main, without waiting for 0.13. This is a FIX (a backport). The change has 24 items; the 10 a person is most likely to notice are listed.

  1. "Draft a prompt in chat" now fills the composer of the new chat (fix: fill the composer when draft a prompt in chat opens a new chat #32494) — justified
  2. The MCP menu marks tools as loaded once they are called on the KAS backend (fix(chat): mark MCP tools loaded once called on the default backend #32511) — justified
  3. Hovering the composer goal button shows the next-cycle countdown (fix: show the next-cycle countdown on the composer goal button hover #32506) — justified
  4. Sending under a long reply no longer opens a big blank gap (fix(chat): keep a sent prompt's estimate out of the bottom spacer #32480) — justified
  5. The busy-mic note no longer names a chat that does not hold the mic (fix: stop saying another chat holds the mic when none is named #32529) — justified
  6. Cancelling a token mint kills its ssh child process (fix: kill the ssh child when a token mint is cancelled #32357) — justified
  7. An unreadable artifact returns a JSON error instead of a bare 500 (fix(artifacts): answer an unreadable artifact with a json error #31068) — justified
  8. A malformed Range header serves the whole feature video instead of a 416 (fix: serve the whole feature video on a malformed range header #31105) — justified
  9. The tool-risk badge says a vote is feedback only (fix(chat): say the tool-risk badge's vote is feedback only #32077) — justified
  10. Comment boxes, log-level choice and task layout get accessible names and announcements (fix(website): name the artifact comment boxes #30142, fix(website): name the comment thread reply and pending-comment edit boxes #30207, fix(a11y): announce the chosen log level as a radio group #31876, fix(a11y): announce the chosen DAG or Phased task layout #32070) — justified

[FIRST-PRINCIPLES-REVIEWED] cd33703

Description read

[DESCRIPTION-READ] 7d0a0052c6d9300aff027d742db51b79bcdadf3c966a197e31f61ee15214a948

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 8, 2026
@buluoray
buluoray merged commit 5d9e4a9 into release/0.12.0 Nov 8, 2026
18 of 23 checks passed
@buluoray
buluoray deleted the crew/slack/0.12.1-batch-60 branch November 8, 2026 03:36
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of cd3370363f5337658289b5a09aed6c5759a13092 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] cd33703

False positive or not applicable? A repository writer can comment:
/ai-review override gpt cd3370363f5337658289b5a09aed6c5759a13092 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed cd3370363f5337658289b5a09aed6c5759a13092 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] cd33703

Verdict parsed from the review's SHA-scoped output markers for commit cd3370363f5337658289b5a09aed6c5759a13092.

False positive or not applicable? A repository writer can comment:
/ai-review override fable cd3370363f5337658289b5a09aed6c5759a13092 false-positive: <reason, 20 to 500 characters>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants