Repository navigation
fix: backport 0.12.1 fast batch v1b-2 (22 user-facing fixes) - #32864
Merged
Merged
Conversation
A credential-free app clone that an SSH server refuses got the
credentials explanation only when the refusal read
"Permission denied (publickey...". OpenSSH prints the server's own
method list in the server's order, so a server answering
"Permission denied (keyboard-interactive,publickey)." got a bare
"git clone failed".
The SSH refusal is now recognized by a small character-level scanner:
after "permission denied (", the text must be a comma-separated list of
method names that start with a-z and use only a-z, 0-9 and "@._+-",
closed by ")". The scanner reads the list once and stops at the first
character that cannot continue it, so its work stays linear in the
length of git's output. A local filesystem "Permission denied" has no
such list, so it still does not count as an auth failure. The same
classifier decides when an anonymous registry clone is shown as needing
sign-in, so that state now follows any method order too.
Fixes #26365
## Pattern harvest
Rule candidate: review-prompt -- matching an SSH refusal by a fixed
prefix of its method list, which the server orders as it likes.
Co-author on main: Matt Briones
(cherry picked from commit ce40cec)
…nent (#30077) kirocrew doctor printed the Claude Code row as an optional backend whatever the selection, so with agent.acp_backend or agent.member_acp_backend set to claude and claude-agent-acp or the claude CLI absent it reported ready and exited 0 while every session on that role failed to spawn. The row now takes the issues list and a required flag, decided by a positive test on the two selected roles. Required and MISSING prints a failing row naming the components and records an issue; unselected, the row keeps its optional wording. UNKNOWN or a raising probe is never an issue. The config is loaded once before the Dependencies section so the row and the later sections read the same selection. Closes #30050 (cherry picked from commit 857e6b3)
(cherry picked from commit 888c8c6)
…ess filter (#30835) The sidebar "In progress" filter and the board's state lanes derive goal-loop membership from the Redux automation collection (selectSidebarAutomationRunningKeys). The cold seed (seedAutomations) is the one place that feeds that collection on every connect: it fetches the authoritative loop list and reconciles it against live frames and per-slot cold reads. A per-slot read in flight when the snapshot lands used to "protect" its slot purely on a fetch-state change, with no resolved data behind it. That dropped the slot's authoritative list record from the seeded records AND left the carry-across nothing to carry (the per-slot cache held no record yet), so the loop never reached Redux. The open session hits this on every connect, because its composer re-reads the per-slot key: its armed loop fell out of the In-progress count and list while the composer above it still showed the loop. Protect a slot from the snapshot only when its per-slot read has actually RESOLVED (a record or a null tombstone), never while it is still pending. A pending read is not fresher than the list, so the list record now lands. This changes only whether the open slot's already-armed loop is present in the set; every other reader (composer, board) and every other reconcile path is unchanged. Co-authored-by: kirocrew-agent <agent@kirocrew.local> (cherry picked from commit 4efadc1)
…ts (#30941) Four requests are refused to every app token whatever its app.json declares: the question-card routes under /api/ask-question, the mobile sign-in link, dismissing a subagent run the gateway no longer tracks, and stopping all of a chat's subagents. Their 403 said "app token not permitted for this endpoint", "app token not allowed" or just "app_token_forbidden". The first is the same text as the API scope refusal, which a permissions.api entry clears, so an app developer would add an entry that can never help. app_token_refusal builds the 403 for all four. error names the action, says no permission in app.json lets an app token do it, and says who can do it instead. For question cards it points an app at its own session's /api/chat/slots/{slot}/question routes, which need permissions.sessionApproval and a permissions.api entry. The code stays app_token_forbidden. (cherry picked from commit 44166e6)
GET /api/deploy/pending now returns expires_at_epoch on each entry (created_at_epoch + 1 hour, derived, not stored), and both deploy_artifact replies (preview and scan-blocked) say to confirm within 1 hour, by a UTC time, worded apart from the site TTL. The 1-hour window is unchanged. Part of #17022 Co-author on main: Zejiang Guo (cherry picked from commit ad90ef6)
…#31244) The context breakdown shows sizes as a formatted number next to the single-form unit_chars or unit_tokens word: the start-row picker, the engine rows and chars caption, and the hover readout. One therefore read "1 characters" or "1 tokens", and no translation could choose a plural form or place the number. Read each size from one plural key (n_chars, n_tokens) with the formatted number inside and the plural chosen from the raw count, the pattern WorldsPage already uses. unit_chars and unit_tokens stay for the caption under the large total, which shows no number of its own. (cherry picked from commit a95ac05)
The banner shown after adding a trusted registry was five catalog pieces joined in code with English spaces. No language could order the sentence its own way, and Japanese and Simplified Chinese got ASCII spaces between full-width text. It is now one catalog message per host count, with the host list as a placeholder, in all shipped catalogs. English reads the same. (cherry picked from commit 9597d17)
#31325) The handler returns before the panel map while a text field has focus, so Alt+C/N/P/S do nothing from the composer and the shortcuts list did not say so. Add "(outside text fields)" to the four panel row values in every shipped catalog, the same wording the Alt+arrow and prompt-step rows use. Handler behaviour is unchanged. Fixes #28422 Co-author on main: Jacob Largent (cherry picked from commit af8341d)
…2043) The General and repo settings intros built a sentence from two catalog fragments with the provider or repo name glued between them, so no language could reorder the sentence and zh-CN spelled GitHub into its fragment. Each is now one key with {provider} and {repo} placeholders, and the four fragment keys are gone. (cherry picked from commit c814b3a)
#31471) A rail selection lands on a tab's root, but Overview keeps its drill-in in ?view=/?store=/?focus=, which a tab change copied along, so clicking Overview from the Memory view kept the Memory view. A tab can now declare its drill-in params and every rail selection drops them; a re-click that drops the shown tab's drill-in asks the pane's leave guard first, since it now unmounts that pane. (cherry picked from commit bb189b3)
#31884) Four controls are drawn only on mouse hover (opacity-0 with group-hover:opacity-100): the copy-command button on an app's detail page, the delete-key button on Settings > Developer > Storage, a Library folder row's menu, and the edit-theme pencil. Tab still lands on each one, so a keyboard user focuses something they cannot see. Each now also shows on keyboard focus, the way the session and history rows already do: focus-visible on a button, has-[:focus-visible] on a wrapper that holds one. A source guard keeps any new hover-only control of this shape from shipping without the focus reveal; it skips an adopted app's wheel copy, whose fix lands in the app's own repository. (cherry picked from commit 6b1c426)
After Allow for this host from one entry of a blocked-link card, the other entries kept a live Allow button and the card kept its "blocked" title, and a reply with no message time lost its Allowed / Undo line when the card closed. The card now reads the host's one allow outcome: no entry offers Allow once the host is allowed, and the title says the host is allowed. A reply with no message time keeps that outcome in its own provider, so it survives the card closing and reopening. Undo's clear-out timer clears only the Undone line, so a quick re-Allow keeps its Undo. (cherry picked from commit e3a289c)
Stop and Take over took native disabled while the action request was pending, which blurs the pressed button to the body. A keyboard user lost their place before the failure notice rendered. Hold them with aria-disabled and refuse the second press in the handler instead. Fixes #32272 (cherry picked from commit 2180fea)
The Retry buttons on the Overview memory cards lost keyboard focus as soon as they were pressed. Each one was disabled while its read ran, and each rendered only while the query held an error, which React Query clears when a query with no data refetches. So the pressed button left the tab order and then unmounted for the whole retry. Keep the failure surface up through the retry with a small queryReadFailed helper (the rule CreatorFilter already applies), and mark the busy state with aria-disabled plus a guard in the click handler, as the Apps store Refresh does. (cherry picked from commit 4ceb565)
The four Try again buttons in the Dashboard tab error bands took native disabled while their re-ask was out. Each band stays on screen, so the pressed button blurred to the body and a keyboard user lost their place. Hold them with aria-disabled and refuse a second press in the handler instead. Fixes #32406 (cherry picked from commit 37f53e4)
(cherry picked from commit b0ffbf6)
The project board's three column headings ("To do", "In progress",
"Done") were English literals in a module-level table, so they stayed
English in every language while the Failed, Skipped and Cancelled
groups under them were translated.
Each heading now reads a catalog key through a getter, so it follows
the active language and re-resolves after a switch. The three keys
are added to all twelve catalogs and the pseudolocale.
Fixes #32440
(cherry picked from commit 5c5c677)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / Motivation
Goal: Bring twenty-two fixes for problems a 0.12.0 user can hit, merged on
mainafterv0.12.0, ontorelease/0.12.0, one commit each, in a PR of its own.Why it matters
Each fix changes behaviour a 0.12.0 user can run into today. Every pick applied to
release/0.12.0cleanly, so the code each one replaces is on release.Not a goal
main; nothing is changed only here.CHANGELOG.mdchange.What changed (motivation → approach → change)
Each main squash commit was cherry-picked with
-xontorelease/0.12.0@aa7dfb4aae, in merge order onmain, one commit each. Every pick applied cleanly, and every commit keeps its original author.ce40cec9c97f3dd2d1ed857e6b3d16635f8f9cd9888c8c6feae648d9281b4efadc110c3a11eff8b444166e6c7447252d024bad90ef699d54517d83e4a95ac0555d7cb715654a9597d17c6c668f107388af8341daf6489afa3c69cd168b4a4b43b0d44851c814b3a0f6ab231cbe30bb189b368a24b4e122eef9c20829684af0bb3a0e6b1c426f2ca277cdc552e3a289cd4b2459dc6ef92180fea4848e6dce34e44ceb5659c69608cee00e37f53e446b15128e5bd5b0ffbf69acb3a573d8a75c5c67735a490cf0a8857a2738a1b71cb47ed81764fade422936682e97fbThree picks carried co-author trailers with internal addresses; each is rewritten as a plain "Co-author on main: " line, because the commit guard refuses the address.
Left out of this batch: #30189 and #30110 now conflict, in a test file and a spec doc only, so they go to the docs/tests batch. #32417 picks cleanly but needs a
useEffectimport that release does not have, so tsc fails; it stays onmainonly.Backwards compatibility
Compatible: each change is the one already merged on
main, and its compatibility note applies unchanged.Removes nothing: no setting, key or caller is removed.
Tests
Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs
release/*, so the direct test modules were run here: the 12 Python test files these picks touch gave 451 passed.tsc -p tsconfig.app.json --noEmitpasses; the 25 vitest files these picks touch gave 446 passed;lint:i18npasses at the same count as clean release.mypy src/kiro_crewpass.i18n:checkwithout a base reports the same findings class as a cleanrelease/0.12.0on this host, and fewer of them.Manual verification
N/A - each fix was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.
Screenshots / video
Why no screenshot: the frontend picks carry the same rendered change as their main PRs, which show it.
Related Issues
Backport to the 0.12 line for 0.12.1 of #26371, #30077, #30493, #30835, #30941, #31006, #31244, #31493, #31325, #31687, #32043, #31471, #32052, #31884, #32292, #32274, #32186, #32410, #31800, #32456, #32436, #32508.
Sibling sweep
Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.
Pattern harvest
Not generalizable: this PR only carries fixes already on
main. The source PRs have their own harvest.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.