Skip to content

fix: backport 0.12.1 fast batch 1 (21 fixes) - #32866

Merged
buluoray merged 21 commits into
release/0.12.0from
crew/slack/0.12.1-fast-1
Nov 8, 2026
Merged

buluoray merged 21 commits into
release/0.12.0from
crew/slack/0.12.1-fast-1

Conversation

@buluoray

@buluoray buluoray commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Bring 21 fixes merged on main after v0.12.0 onto release/0.12.0 for 0.12.1, one commit each, in a PR of its own.

Why it matters

Each fix changes behaviour a 0.12.0 user can hit today: claude-harness hooks, steering and /clear, app install and skill copies, cron ack lists, the Board's worker list, offline rename and library writes, heredoc commands the rm floor misread, and a terminal stop the disabled panel refused. They come from the value-2 rows of the 0.12.1 wide-bar list, second half by rank, freeze 2026-11-08 16:00Z.

Not a goal

  • No fix that is not already merged on main; nothing is changed only here.
  • No version bump, no tag, no CHANGELOG.md change.
  • No row that needs a prerequisite or a hand port of production code; those are listed under What changed.

What changed (motivation → approach → change)

Each main squash commit was cherry-picked onto release/0.12.0 @ aa7dfb4aae, in merge order on main, one commit each, with the (cherry picked from commit …) trailer. The repository's leak guard requires the public identity, so every commit is authored as Ray Xu and names its original author on an Original author: line.

# PR Original author main release
1 #30134 fire a spec's non-gating hooks on claude sessions Bolin Chen eb966e8bf1 4c24370dc4
2 #30107 clear claude effort live with the adapter's default value Bolin Chen 7970989c1f 8708bbcb98
3 #29926 scope the crewmate conductor to its mapped skills only Joe Guo 556ad1710e be257e5b28
4 #30072 stop rewriting Kiro Crew and ~/.kiro paths in claude prompts Bolin Chen 4fbcb71f8f 2ea62dcc09
5 #30074 re-inject claude steering resources after a compaction Bolin Chen 2a1c4b4020 f8f95781c7
6 #30080 answer /clear locally on the claude harness Bolin Chen 691fb422cf 938674dee3
7 #30609 hide and stop syncing adopted apps' packaged skill copies Bolin Chen 9b34938e58 18cf34fcc3
8 #30628 register an installed app's resources only once it is enabled Bolin Chen 2c733d14a6 549f2bf62b
9 #30435 keep the Board's worker list read and push its refresh Raymond Chen 1f44d3a942 095f1e2d98
10 #31031 load a non-list stored ack list as no items Rohan Khanderia f8be84a1e3 8b50d8097b
12 #30974 keep the skills menu within laya's 100-option limit Bolin Chen 9a9f5b6424 054a596b1c
13 #10920 gate session rename while the gateway is offline Robert Noack 573a1928c8 2e91cf0a0a
14 #31008 treat a chat option tap as the answer, never a command Bolin Chen 5cccf3c421 343fbb42db
15 #30967 tighten an allowed-command entry check Bolin Chen 7137647c3b 874f78ad0d
16 #30730 a failing slots flush no longer 500s a committed create Bolin Chen 31aa5b11ee 0f51820733
17 #30688 make a merge restore import only the memory it checked Bolin Chen 4f5e21977c 0d26e9e500
18 #30877 closing a conductor closes the workers it manages Joe Guo 40e8300aff ac162631d0
19 #30600 read heredoc bodies in the shared shell reader and the rm floor Joe Guo b4943da199 ce93577267
20 #31382 let an owner stop a session while the panel is disabled Bolin Chen e934e280fa 1a427a6395
21 #31539 ask before raw mouse back or forward drops a draft Bolin Chen 6a38a1eb88 f015031a06
22 #31842 refuse app library writes while the gateway is offline Bolin Chen 46b858ce79 44e369128c

Every production-code hunk applied cleanly except one comment. The hand-resolved hunks:

Left out of this batch:

PR Why
#31016 Dropped after review: Opus 5.5 found that agent_ipc.py's weakref.finalize callback _retire takes the store's non-reentrant threading.Lock, so a GC that runs it on a thread already holding that lock (inside issue or redeem) deadlocks the event loop or executor. main has the same code.
#31400 Its UI reads expires_at_epoch, from the pending-confirmation expiry release does not have.
#30131 Its new test needs claude MCP-grant code from #30241 / #30108, which release does not have.
#30163, #30045, #30102, #30105, #30082, #30112, #30185, #30083 Already in #32836.

Backwards compatibility

Breaking: #30628 an installed but disabled app no longer has its agents, skills, MCP servers or crons registered until it is enabled. #30967 an allowedCommands entry in the refused spelling no longer grants its command on KAS or allows it under denyByDefault. Writer sweep: each source PR's own sweep on main (#30628 @ 0b18d86432); not re-run on release.

Reader: src/kiro_crew/apps/default_installs.py:_install_transaction -- release -- default installs still enable and register (#30628's test_default_app_installs.py)
Reader: src/kiro_crew/cli_commands_app.py:_handle_app -- release -- app enable registers (#30628's test_app_cli.py)
Reader: src/kiro_crew/skill_runtime/catalog.py:_iter_visible -- chat|subagent|crew page -- an adopted app's packaged copy is listed once (#30609's tests)
Reader: src/kiro_crew/decisions/points/skills_select.py:candidates_from_loader -- chat -- the menu is cut at MAX_CANDIDATES after ranking (#30974's tests)
Reader: the KAS grant list and denyByDefault allowlist (src/kiro_crew/acp) -- chat|cron|subagent -- the refused entry allows nothing, like any unreadable entry (#30967's tests)

Tests

Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs

  • CI does not run the backend suite on PRs into release/*, so the related set ran here, one pytest process at a time with no xdist: every test file the batch changed, plus test/test_<module>*.py for each changed source module (1,139 files, rebased onto release/0.12.0 @ 989d318f81). 13 failed, and each also fails on a clean release/0.12.0 @ 989d318f81 on this host: copilot-backend cases in test_acp_agent_env.py, test_acp_copilot_backend.py, test_acp_harness_contract.py, test_acp_launch_goldens.py, plus test_acp_tool_gate.py::test_every_enforced_harness_reaches_the_spawn_preflight, test_gateway_secret_senders_prove_peer.py::…::test_list_goes_through_the_proof, test_harness_parity.py::test_is_kiro_cli_is_positive, test_auto_improvement_members.py (1) and test_folder_steering_provider_dedup.py (2).
  • Frontend: tsc -p tsconfig.app.json --noEmit passes; vitest on the changed test files plus the tests named after each changed source file, 272 files, all passed.
  • Rebased onto release/0.12.0 @ dc384c6114 (head c362e6b76b): the batch's changed test files, the new release commits' test files, the importers of source files both sides touch and every test/test_apps*.py (182 files) reran sequentially. The only failures (test_acp_harness_contract.py::…[copilot], test_apps_registry_identity_admission.py ×2) also fail on a clean release checkout here. tsc passes; vitest on the src/i18n, App* and changed test files (174 files) passes.
  • After dropping fix(acp): let kirocrew-core reach the gateway under an enforced harness #31016 (head c1f4ffd43b), the test files that import any module fix(acp): let kirocrew-core reach the gateway under an enforced harness #31016 touched (188 files) reran sequentially and all passed, as did test_security_gate_liveness.py, test_dashboard_server_composition_contract.py, test_pid_reader_ratchet.py and the docs-lint tests.
  • flake8 passes on the 130 changed Python files. check_file_line_cap fails only on dashboard/chat_api/resume.py, which is already 2,008 lines on release.

Manual verification

N/A - each fix was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.

Screenshots / video

Why no screenshot: the frontend picks (#10920, #30435, #31539, #31842) carry the same rendered change as their main PRs, which show it.

Related Issues

Backport to the 0.12 line for 0.12.1 of #30134, #30107, #29926, #30072, #30074, #30080, #30609, #30628, #30435, #31031, #30974, #10920, #31008, #30967, #30730, #30688, #30877, #30600, #31382, #31539 and #31842.

Sibling sweep

Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.

Pattern harvest

Not generalizable: this PR only carries fixes already on main. The source PRs have their own harvest.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 8, 2026 03:07
@buluoray
buluoray requested review from tim-finnigan and removed request for a team November 8, 2026 03:08
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 8, 2026
@buluoray
buluoray force-pushed the crew/slack/0.12.1-fast-1 branch from 44e3691 to fe8bff3 Compare November 8, 2026 07:51
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Sensitive Change Review

Sensitive files changed:

  • src/kiro_crew/security/argv_rules.py

  • src/kiro_crew/security/rm_floor.py

  • src/kiro_crew/security/shell_commands.py

  • No reasoning template for c362e6b yet.

How to clear this check:

  1. The PR author posts the template below as a PR comment, with
    every field filled (N/A needs a reason). Keep the
    Head commit line: it must name the current head SHA.
  2. The check turns green within a minute, with no push.
  3. A new push resets this check: post it again for the new head.

Only the author's comment counts this way. A reviewer can instead
paste the filled template into an "Approve" review on this head.
Merging still needs a reviewer's approval.

## Sensitive change review
- Head commit: c362e6b76b259bfca7996c29debc7968db2810d4
- What rule changed:
- Before -> after (what was allowed/blocked, now):
- Worst case if wrong (breaks commands / leaks secret / locks user out):
- Evidence checked (which sandbox result proves it):
- No regression:
  - Tools still work (which tools/commands were run, result):
  - Backward compatible (old config / old data / old callers still work, how checked):
  - Existing tests (which suites passed on this head):
- How to undo:

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 8, 2026
@buluoray

buluoray commented Nov 8, 2026

Copy link
Copy Markdown
Contributor Author

Taken over from the previous worker to clear the conflict. Rebased all 22 picks onto release/0.12.0 @ 989d318f81; no pick came out empty, so all 22 stay, #31016 included (it is not on release yet). New hand resolutions are listed in the body: the context-management.md steering row, the agent-host-contract.md /clear and slash-command rows, the learn-cron-dashboard.md bullets and terminal row, the #30600 line budget (34,694 → 34,831) and the #30107 binding hash. Related backend tests were rerun sequentially (1,139 files); the 13 failures also fail on a clean release checkout. Frontend tsc and vitest pass.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings (all downgraded on adjudication)

GPT 6.1 flagged blocking issues on c362e6b76b259bfca7996c29debc7968db2810d4; Opus 5.5 adjudication downgraded every one of them. Downgraded: the remedy each one needs is disproportionate to the harm it prevents. Adjudication downgraded all 1 blocking finding(s): the remedy each one requires is disproportionate to the harm it prevents.

This comment is updated in place on each push.

Review details

BLOCKING -- src/kiro_crew/security/rm_floor.py:235 -- Only scan a piped heredoc when its body reaches the shell

return (argv_rules._program_args(words) or ("",))[0] in ("cat", "tee")
Trigger: An agent submits cat /dev/null <<'EOF' | bash\nrm --recursive -f /\nEOF; PreToolUse → is_denied → _rm_wipe_targets_nested → _heredoc_payloads treats cat as forwarding its heredoc.
Outcome: This previously allowed, non-destructive command is refused, although cat /dev/null ignores stdin and Bash receives an empty script.
Anchor: defect
Fix: Check producer arguments and effective stdout redirections before treating its heredoc as the receiving shell’s script.
Sites: The same pipeline branch at src/kiro_crew/security/rm_floor.py:222 also misclassifies cat <<'EOF' > /dev/null | bash and tee <<'EOF' > /dev/null | bash with the same body; their stdout never reaches Bash.
[BLOCK-MERGE-DOWNGRADED] c362e6b
[GPT-REVIEWED] c362e6b

Adjudication (Opus 5.5) — is blocking on each finding proportionate?

F1 is LOW harm. The failure is a false refusal, and it needs every one of these at once: a piped heredoc on cat or tee (src/kiro_crew/security/rm_floor.py:218-222), a producer chosen only by program name with its file operands and stdout redirects ignored (rm_floor.py:235), a receiving shell that reads stdin (rm_floor.py:220, _runs_shell at rm_floor.py:260), and a body that itself holds a root-wipe rm (rm_floor.py:368).
Commands written like this are contrived and rare. The refusal is visible, nothing is lost and no security boundary is crossed, and the agent clears it by dropping a no-op pipeline that runs nothing.
The real fix costs more than that: argument parsing for cat/tee operands, -, and >/>& stdout redirects in a security matcher. That is another per-spelling guard, which AGENTS.md calls a review smell, and every future reader would carry it.

[ADJUDICATION] c362e6b76b259bfca7996c29debc7968db2810d4 total=1 uphold=0 downgrade=1
DOWNGRADE F1 src/kiro_crew/security/rm_floor.py:235 reason=disproportionate-remedy
[GPT-ADJUDICATED] c362e6b76b259bfca7996c29debc7968db2810d4

False positive or not applicable? A repository writer can comment:
/ai-review override gpt c362e6b76b259bfca7996c29debc7968db2810d4 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of c362e6b76b259bfca7996c29debc7968db2810d4 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

This backports fixes already merged on main, and their decisions were made there. The release diff adds no new surface of its own.

Notes

What this change ships

Inventory (10 items, 21 fixes) — 9 justified

Intent: give 0.12.1 users 21 fixes already merged on main; a FIX (a backport).

  1. Claude sessions now fire spec hooks, re-send steering after compaction, answer /clear locally and keep paths in prompts as written — justified
  2. Clearing claude effort live uses the adapter's default — justified
  3. Installed apps register their resources only once enabled; adopted apps' packaged skill copies are hidden and no longer synced — inherited, writer sweep not re-run on release
  4. The crewmate conductor is scoped to its mapped skills, and closing a conductor closes its workers — justified
  5. The Board's worker list keeps reading and pushes its refresh — justified
  6. A non-list stored cron ack list loads as no items, and a failing slots flush no longer 500s a committed create — justified
  7. Session rename and app library writes are refused while the gateway is offline — justified
  8. A Slack option tap counts as the answer, and the skills menu stays within the 100-option limit — justified
  9. The rm floor and shell reader read heredoc bodies, and an allowed-command entry check is tightened — justified
  10. An owner can stop a session while the panel is disabled; raw mouse back/forward asks before dropping a draft; a merge restore imports only the memory it checked — justified

[FIRST-PRINCIPLES-REVIEWED] c362e6b

Description read

[DESCRIPTION-READ] a69593d80fa197ba00a6314ad36f2a36a6783666b9f366293c49ed11b81013f8

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Security Scope Review -- ✅ PASS

Which legitimate operations does c362e6b76b259bfca7996c29debc7968db2810d4 newly refuse? Updated in place on each push. A script-confirmed regression blocks; the model proposes candidates and never decides a refusal.

Verdict basis: adjudicated, zero confirmed regressions.

Security scope review -- adjudicated candidates

  • macos-latest (platform posix): 30 classified, 0 newly refused, 23 still allowed.
  • ubuntu-latest (platform posix): 30 classified, 0 newly refused, 23 still allowed.
  • windows-latest (platform windows): 6 classified, 0 newly refused, 5 still allowed.

No candidate flipped from allowed to refused.

Scope-Verdict: PASS

Reason: The tightening sits in the rm floor and the argv wrapper table, both inside the shell deny composite, so every boundary was submitted as a shell candidate and no confirmed regression was handed back. One change is outside the composite and nothing classifies it: the kiro-cli allowed-command grant parser now rejects non-ASCII escapes. It is named under UNADJUDICATED. A second untested path is the new fail-closed walk budget.

TIGHTENING: The rm floor (rm_floor._rm_wipe_targets_nested, _segments, _command_lines) now reads past heredocs through read_commands(..., heredocs=True). It also reads a \n inside $'…' as a real newline, and unwraps nsenter/unshare/flock/taskset/chrt as wrappers in argv_rules._WRAPPERS. The one threat it refuses is a recursive-force rm of root or home that the old reader never saw because it stopped at <<: a body fed to a shell, a command after a heredoc, a substitution in an unquoted body, or a $'\n' line given to -c. From the hunk: + for payload in _heredoc_payloads(source) if "<<" in source else (): and + """Each heredoc body a shell reads as its script (``bash <<EOF``, ``cat <<EOF | sh``),.

ADJUDICATED: 36 candidates, 0 confirmed newly-refused

PLATFORM COVERAGE: posix (30 rows). These cover what the diff assumes about bash: quoted, unquoted and <<- tags; the agent-standard "$(cat <<'EOF' … EOF)" commit and PR-body form; commands after the closing tag; bash/sh/bash -s/sudo -u … bash/cat | bash fed bodies whose rm targets are relative, under /tmp, or under ~/$HOME but not the directory itself; $'…\n…' given to bash -c and given to non-shells; and each new wrapper in its ordinary form, including flock … -c, taskset -p and chrt -p with no program after them. windows (6 rows). The heredoc reader is the same code reading the same text on Windows, so these probe Git Bash spellings: bash.exe, drive-letter and \ paths in a body, and a command after the tag. They also probe the PowerShell here-string @'…'@ and a $env:USERPROFILE subpath, which contain no << and must stay untouched. any: none. Every row names a shell or an executable. Not probed: a .exe shell (for example C:\…\bash.exe <<EOF) being recognized as a shell that reads stdin. That is an under-refusal question for the other lanes, not an over-refusal.

UNADJUDICATED:

  • Guard: platform/allowed_commands.py::_literal_segments. It now returns None for \ followed by a non-ASCII character (if not nxt or not nxt.isascii() or nxt.isalnum() or nxt.isspace()).
    • Call path: an agent spec's allowed-commands entry → allowed_command_pattern(entry) → _literal_segments. The kiro-cli grant is then dropped, so that command needs approval again. This is a grant gate, not the deny composite, so no classifier verdict exists.
    • Inputs I would have submitted:
      • an entry echo \“hi\” (curly quotes escaped), written by a maintainer who copied a command out of docs that use typographic quotes;
      • git commit -m \“.*;
      • grep \é.* on a localized repo.
    • The diff's test pins the first two as granting nothing. The unescaped form still grants. I cannot confirm whether any committed spec holds such an entry.
  • Guard: rm_floor._WALK_BUDGET_CHARS. It raises RuntimeError past 16 × MAX_SCANNABLE_COMMAND_CHARS and fails closed, giving a refusal with no cause.
    • Call path: deny_gate → _rm_wipe_targets_nested.
    • Inputs I would have submitted: a near-cap provisioning script (~18 KB) fed as bash <<'EOF', with many bash -c '…' lines inside it. A row's 512-character cap cannot hold that input, so whether a real long script trips the budget is unmeasured.

[SCOPE-REVIEWED] c362e6b

@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed c362e6b76b259bfca7996c29debc7968db2810d4 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] c362e6b

Verdict parsed from the review's SHA-scoped output markers for commit c362e6b76b259bfca7996c29debc7968db2810d4.

False positive or not applicable? A repository writer can comment:
/ai-review override fable c362e6b76b259bfca7996c29debc7968db2810d4 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 8, 2026
@buluoray
buluoray force-pushed the crew/slack/0.12.1-fast-1 branch from fe8bff3 to c1f4ffd Compare November 8, 2026 08:26
@buluoray buluoray changed the title fix: backport 0.12.1 fast batch 1 (22 fixes) fix: backport 0.12.1 fast batch 1 (21 fixes) Nov 8, 2026
@buluoray

buluoray commented Nov 8, 2026

Copy link
Copy Markdown
Contributor Author

Dropped #31016 from this batch (new head c1f4ffd43b, 21 picks). Opus 5.5 blocked it on fe8bff358d: in dashboard/agent_ipc.py the weakref.finalize callback _retire takes the capability store's non-reentrant threading.Lock, and the finalizer is registered while issue holds that lock, so a cyclic GC that runs _retire on a thread already holding it (inside issue, or redeem on the executor) blocks forever. main has the same code, so this is a real finding on the fix itself, not on the backport. The other 21 picks are unchanged; the Goal line, title and body now say 21. #31016 can come back once main has its fix.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of c362e6b76b259bfca7996c29debc7968db2810d4 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the four take-aways I traced (install no longer registers, the slot-push flush no longer raises, the Claude prompt keeps the Kiro name, the mate-conductor skill flag) have every in-tree reader updated.

Notes

  • The description is empty for a 21-fix, 195-file batch. No hunk can be matched to a stated fix, and there is no ## Backwards compatibility section. Fresh app install (CLI and route) now registers nothing until app enable. Name that change and its readers, default_installs._install_transaction and cli_commands_app._handle_app.
  • The committed screenshots cover only the offline session rename. The new offline states on LibraryPage and LaunchpadTile (dimmed verbs, the OfflineReasonRow menu row) have no rendered evidence in this revision.
  • MATE_CONDUCTOR_INHERITS_USER_SKILLS = True depends on a promised flip "next release". Link a tracking issue so the deprecation doesn't become permanent.

[DESIGN-REVIEWED] c362e6b

Description read

[DESCRIPTION-READ] 9783ad01056f74be703b9cc4d7b55122c6bda846b4f8fd4bf44d23363134f085

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of c362e6b76b259bfca7996c29debc7968db2810d4 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing screenshots of the App Library's offline state. The batch adds new dimmed controls and an offline notice to the Library page and its app-tile menu, and none of the seven supplied screenshots shows them.

Evidence gaps

  • App Library page while offline (LibraryPage.tsx, from fix: refuse app library writes while the gateway is offline #31842). The Disable and Uninstall buttons and the uninstall dialog's confirm button are now disabled offline, with a reason on hover. Every supplied screenshot comes from temp-screenshots/10920-offline-rename/, so none shows this page. Close it with a screenshot of the Library page offline, with an installed app's actions visible.
  • App tile menu while offline (LaunchpadTile.tsx). The Enable, Update, Sync, Disable and Uninstall items are dimmed, and the menu gains a last row, OfflineReasonRow (app-tile-offline-reason). The tile's Enable button gets opacity-30 cursor-not-allowed. None of these appears in any screenshot. Close it with a screenshot of that menu open while offline.
  • New Agent Backend notice (AgentBackendTab.tsx): "The preToolUse hooks your agent config file defines — they will not run". No screenshot shows it where it renders. Close it with a screenshot of the Agent Backend tab on a backend that reports this.

Notes

  • Sidebar rename (shot-07): after the editor closes, "Gateway offline — reconnect to rename sessions" stays under the session's entry, and the blind reader read it as "it seems to stay after I stop renaming". Clear the notice once the editor closes, not only when the connection comes back (rename.ts only clears it on reconnect).
  • In shots 01 and 06 the reader said: "I don't know if my typing will be lost". The draft is kept, but the notice never says so. Consider "Gateway offline — your new name is kept; reconnect to save it".

[UX-REVIEWED] c362e6b

Description read

[DESCRIPTION-READ] 0b6cd7a72b28ddc93368be2d6935f26de9acb549aada95460fdaf1c69b3a5284

That sha256 names everything this verdict read: the PR description, plus the 10 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 8, 2026
@buluoray
buluoray force-pushed the crew/slack/0.12.1-fast-1 branch from c1f4ffd to a81f4f1 Compare November 8, 2026 09:04
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 8, 2026
…30074)

On the Claude Code backend, session start delivers the agent config's
file:// steering resources as prompt text, because claude-agent-acp does
not read an agent's resources itself. A compaction drops that text, and
post-compaction re-injection never sent it back, so the session lost its
global steering silently. kiro-cli keeps its natively loaded resources.

Session start and post_compaction_parts now share one gate,
inclusion.steering_resources_part (Claude Code by positive identity,
default agent, project group, not a member chat). The first turn after a
compaction re-sends the text as a REINJECTED block with its payload
scrubbed of structural markers; minimal-context turns, custom agents,
member chats and the kiro and KAS paths get nothing.

Closes #30054

(cherry picked from commit 2a1c4b4)
Original author: Bolin Chen
A dashboard /clear on a claude session went to claude-agent-acp as
session/prompt text. The adapter sends no clear status frame and has
no _kiro.dev/commands/execute, so Crew never saw a clear it may have
run: the todo pill, the pending reset_conversation discard and the
next turn's replay all stayed. Add claude to ACP_BACKENDS_LOCAL_CLEAR
so the slash gate runs the dashboard's own reset, as on the other
harnesses without an observable /clear. claude runs one adapter per
session, so the discard drops that adapter's conversation either way.

Closes #30058

(cherry picked from commit 691fb42)
Original author: Bolin Chen
#30609)

(cherry picked from commit 9b34938)
Original author: Bolin Chen
…led (#30628)

A fresh registry, streamed or local-path install writes its record
disabled, yet _app_may_run_after_install answered True for every fresh
install, so the route registered the disabled app's agents, skills, MCP
servers and crons and started its backend. GET /api/apps showed the app
off while its agent specs sat in the agents directory until the next
enable or disable. This is the reinstall path for the former built-ins.

The gate now reads the live enabled flag for fresh installs and updates
alike, so resources arrive at the guarded enable transition. Registry
default installs, which enable right after installing, read the new
_app_may_enable_after_install (record present, no consent pending)
instead. The file-only `kirocrew app install` follows the same rule.

Part of #26967

(cherry picked from commit 2c733d1)
Original author: Bolin Chen
…sh (#30435)

* perf(crew-mode): keep the Board's worker list read and push its refresh

GET /api/chat/slots/{root}/crew-workers walked the session tree, read every
closed worker's saved title and every crew member's ledger store on each call,
and the Board polled it every 5 s (15 s for the sidebar row and breadcrumb).
At 3000 descendants one read took about 650 ms.

The handler now keeps, per root, the closed list (walked again only when the
session tree's nodes object or the live keys change), each closed worker's title
(dropped once the key is seen live) and each ledger store's facts (read again
only when that store's change mark moves). The work-ledger store gives a store a
fresh mark at the end of every conductor or item lock hold, which every write,
rebuild and purge takes. Kept answers older than 300 s are read again, which
bounds what a write from another process can leave stale. Live rows are read
fresh on every call.

The website re-reads a root's list when the slot store says its crew moved: a
crew row's state, title or parent (the lineage push), or the root's crew_work
(its ledger push). Bursts coalesce into one re-read; the poll drops to 60 s.

* perf(crew-mode): push a sub-conductor's ledger report to the Board

A grandchild's report lands on its sub-conductor's ledger, which no slot row carried, so the root's worker list waited for the 60 s fallback. The slot frame now follows each sub-conductor's board and puts its crew_work on its row, and the push key includes it.

---------

Co-authored-by: Raymond Chen <chenmingwei23@users.noreply.github.com>

(cherry picked from commit 1f44d3a)
Original author: Raymond Chen
The cron store read acked_items as stored, while acked_item_ids beside
it already loads a non-list as empty. A null from an imported archive
or a hand edit, or a number, made the next ack of that job answer 500,
and a string or object was split into characters or keys. Load a
non-list as no items; a list loads as before.

(cherry picked from commit f8be84a)
Original author: Rohan Khanderia
…30974)

skills.select sent one Choice of up to 100 skills plus "none". Laya's
local server refuses a Choice of more than 100 options, so with 100 or
more eligible skills every call was a provider error and selection fell
back to trigger matching. Cap the menu at 99 skills so the Choice is at
most 100 options. Strands Decider 2B is not affected: its shipped
checkpoint reads options through a pointer head, which has no slot cap.

(cherry picked from commit 9a9f5b6)
Original author: Bolin Chen
A rename typed while the gateway was down was accepted and silently lost, and a
late reply could overwrite a newer title. Split from a larger sweep.

Co-authored-by: m <m@e>

(cherry picked from commit 573a192)
Original author: Robert Noack
Tapping an option button the agent offered in a chat-app thread could
run the option's text as a command instead of answering the agent. A
tap now always sends the option to the agent as the answer, as the
other chat channels already do. Typed messages are unchanged.

(cherry picked from commit 5cccf3c)
Original author: Bolin Chen
On the KAS backend, one spelling of a toolsSettings.shell.allowedCommands
entry was read as granting a command, where kiro-cli rejects the same
entry and grants nothing. Crew now reads that spelling the way kiro-cli
does: the entry grants nothing and the session-start notice names it, so
Crew never answers a command without a prompt that kiro-cli would prompt
for. The security spec describes the reading.

Closes #28518

(cherry picked from commit 7137647)
Original author: Bolin Chen
…te (#30730)

A slot create that had already committed answered 500 when the slots
broadcast after it failed on the coalescing window's leading edge,
while inside the window the same failure was only logged and the
create answered 200. The caller's answer was decided by a timer.

suspend_slots_push now logs a failing exit flush instead of raising
it, so every block's caller is answered as when the trailing timer
carries the failure, and the flush cannot hide the body's own
exception. A committed resume or import publishes its final push
through such a block, so neither turns into a 500 after it landed.
A direct push_slots_update() still raises, so callers that audit and
retry a failed publication keep that signal.

Closes #8745

(cherry picked from commit 31aa5b1)
Original author: Bolin Chen
A merge restore imports memory only from the database its own validation
checked, and the snapshot spec records the posture.

Closes #8725

(cherry picked from commit 4f5e219)
Original author: Bolin Chen
…0877)

Original co-author: Joe Guo

(cherry picked from commit 40e8300)
Original author: Joe Guo
… rm floor (#30600)

Original co-author: Zejiang Guo

(cherry picked from commit b4943da)
Original author: Joe Guo
#31382)

DELETE /api/terminal/sessions/{id} answered 403 "Terminal panel
disabled" once dashboard.terminal.enabled was false, so a shell opened
before the setting changed kept running and its owner could not stop
it from the dashboard. The delete route drops only that feature check;
sign-in, owner, session-id and still-opening checks stay, and
creation, the WebSocket, completion and redaction stay gated.

Builds on #21415 by ktreharrison.

(cherry picked from commit e934e28)
Original author: Bolin Chen
)

In the macOS desktop app a mouse's raw Back and Forward side buttons
reached the dashboard only as Chromium's own history pop. The draft
guard catches that pop only through NavigationBackGuard's best-effort
trap, which stays out of the stack while a Forward branch exists and
is not re-armed after a reload until it recalibrates. In those states
one press of the Back button left an open Bot editor and threw its
unsaved edits away without asking, while Cmd+Left and the header
arrow asked first.

useNativeHistoryStep listens for mouseup with button 3 or 4 in the
macOS desktop app, beside the swipe relay. When the dashboard has a
route entry that way, it cancels the press so Chromium does not step,
and takes the same guarded step the swipe relay takes, which asks
first. A press with no route entry that way keeps Chromium's own
step: after a gateway reconnect the window's history still holds the
routes of the dashboard's earlier load, and only that step reaches
them. It stays inert on a narrow viewport, like the chords and the
swipe.

Part of #8258

(cherry picked from commit 6a38a1e)
Original author: Bolin Chen
The Library page's app management controls fired their gateway writes
even while the dashboard was disconnected, so a click looked like it
started and only failed later. Each one now uses the refusal the
sidebar surfaces already use: dimmed, an offline reason in its own
tooltip, and no request.

Part of #10463

(cherry picked from commit 46b858c)
Original author: Bolin Chen
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 8, 2026
@buluoray
buluoray force-pushed the crew/slack/0.12.1-fast-1 branch from a81f4f1 to c362e6b Compare November 8, 2026 10:57
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 8, 2026
@buluoray
buluoray merged commit c87b986 into release/0.12.0 Nov 8, 2026
28 of 47 checks passed
@buluoray
buluoray deleted the crew/slack/0.12.1-fast-1 branch November 8, 2026 11:32
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 8, 2026
KiroCrewCaptain pushed a commit that referenced this pull request Nov 8, 2026
…ck (#33057)

The capability store's weakref.finalize callback took the store's
non-reentrant lock. The cyclic garbage collector can run that callback
on a thread that already holds the lock (inside issue, or redeem's
locked liveness check), and the thread then waits on itself forever,
hanging the event loop or the subprocess executor.

The finalizer now only queues the pickup's digest; the next issue,
redeem or verify drops every queued pickup and its capability under
the lock before it reads, so a retired pickup is never served.

Refs #31016, #32866
buluoray added a commit that referenced this pull request Nov 8, 2026
…ck (#33057)

The capability store's weakref.finalize callback took the store's
non-reentrant lock. The cyclic garbage collector can run that callback
on a thread that already holds the lock (inside issue, or redeem's
locked liveness check), and the thread then waits on itself forever,
hanging the event loop or the subprocess executor.

The finalizer now only queues the pickup's digest; the next issue,
redeem or verify drops every queued pickup and its capability under
the lock before it reads, so a retired pickup is never served.

Refs #31016, #32866

(cherry picked from commit 1d9a632)

Original author: Ray Xu (#33057).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant