Skip to content

fix: backport 0.12.1 batch 62 (10 wide-bar fixes) - #32891

Merged
buluoray merged 10 commits into
release/0.12.0from
crew/slack/0.12.1-batch-62
Nov 8, 2026
Merged

buluoray merged 10 commits into
release/0.12.0from
crew/slack/0.12.1-batch-62

Conversation

@buluoray

@buluoray buluoray commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Bring 10 small fixes that merged on main after v0.12.0 onto release/0.12.0, one commit each, in a PR of their own.

Why it matters

Each row is a user-visible fix from the 0.12.1 wide-bar list (Ray, 11-07). Every pick applied cleanly onto release.

PR Area What a 0.12.0 user sees today
#30273 updates Update popup names the wrong version on a behind-only checkout
#30441 desktop Desktop app metrics not found on Windows and Linux
#30452 telemetry One bad metrics shard line breaks telemetry metrics read
#30881 a11y App Store install-from-path box has no name
#31360 a11y focus stays on PR/issue Refresh buttons while they refresh
#31377 i18n watch list clear-completed confirm uses correct plural
#32049 a11y Focus stays on Refresh and Poll now in Ops Mission Control
#31887 i18n channel mention and preset role lists joined per locale
#32435 a11y/sidebar Focus lost when a creator filter paging button disappears
#32520 mobile dashboard Closed mobile drawer pops back open after a late animation

Not a goal

  • No fix that is not already merged on main; nothing is changed only here.
  • No version bump, no tag, no CHANGELOG.md change.
  • Not fix(issue-radar): keep focus on the Refresh issues buttons while they refresh #31481 (keep focus on the Issue Radar Refresh buttons while they refresh). It was in this PR's first head and is removed: GPT 6.1's upheld finding on website/src/apps/issue-radar/components/IssueList.tsx:233 holds. The touched refresh still fails silently (the mutation error never reaches an ErrorNotice), which the blocking errors-use-error-notice rule requires of a touched request. main has the same code.

What changed (motivation → approach → change)

Each main squash commit was cherry-picked with -x onto release/0.12.0 @ 8e72744cbb, in merge order on main, one commit each. Every pick applied cleanly, with no prerequisite and no hand-resolved hunk; every commit has added and removed lines identical to its main commit.

# PR main commit release commit
1 #30273 name no version when a behind-only checkout reports the running one a858681d45 3703ab701b
2 #30441 find desktop metrics where the app writes them on windows and linux 74513752f0 002c94c600
3 #30452 skip a metrics shard line that is not an export cycle 8402a1bcd9 9f30ebf010
4 #30881 name the App Store install-from-path box d84616c94e 8935c06913
5 #31360 keep focus on the PR and issue Refresh buttons while they refresh bc7f7974be 3d63cb845e
6 #31377 pluralize the watch list clear-completed confirm f73f4faf19 e840d02c7c
7 #32049 keep focus on Refresh and Poll now while they run 3e4954a7b8 cac364b0f4
8 #31887 join channel mentions and preset roles by locale ecb3d6225a b31a5b521e
9 #32435 keep focus when a creator filter paging button leaves 5843f47824 a6fc1a9a7f
10 #32520 keep a drawer shut when a stale settle finishes late 4e8702c8c1 1288121a48

7 commits carried a non-public author email or an internal co-author trailer, which the push guard refuses, so they are authored with the public identity and name their original author in the message; internal trailer lines are removed. The other 3 keep their original author.

builder-security checked: each change is the one already merged on main; no bind, listener, new route, auth mechanism or storage grant is added.

Backwards compatibility

Compatible: each change is the one already merged on main, and its compatibility note applies unchanged.

Removes nothing: no setting, key or caller is removed.

Tests

Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs

  • CI does not run the backend suite on PRs into release/*, so the direct test modules were run here: every touched test file plus every test file that imports a touched module, 3 files, -n 4 --dist loadgroup. 99 passed, 0 failed.
  • Frontend: tsc -p tsconfig.app.json --noEmit passes. vitest run on every touched test file and every touched component name (first head, with fix(issue-radar): keep focus on the Refresh issues buttons while they refresh #31481): 40 files, 769 passed, 0 failed; on this head the Issue Radar tests pass.
  • flake8 passes on the changed Python files.

Manual verification

N/A - each fix was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.

Screenshots / video

Why no screenshot: each frontend pick carries the same rendered change as its main PR, whose screenshots show it.

Related Issues

Backport to the 0.12 line for 0.12.1 of #30273, #30441, #30452, #30881, #31360, #31377, #32049, #31887, #32435, #32520.

Sibling sweep

Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.

Pattern harvest

Not generalizable: this PR only carries fixes already on main. The source PRs have their own harvest.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 8, 2026 03:31
@buluoray
buluoray requested review from tim-finnigan and removed request for a team November 8, 2026 03:31
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 1288121a48b1145648806aa3f6843edbb929b2c3 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

This PR only moves fixes that are already merged on main onto release/0.12.0, one cherry-pick each. Every item is a reported defect, and its decision was made on its own main PR.

What this change ships

Inventory (10 items) — 10 justified

Intent: give 0.12.x users ten small fixes that already shipped on main (FIX).

  1. Update popup no longer names the wrong version on a checkout that is only behind — justified
  2. kirocrew desktop metrics finds artifacts in the npm-name directories on Windows and Linux. The tracked gap kirocrew desktop metrics probes product-name dirs the app never writes on Windows/Linux #13105 closes, which replaces the old product-name probe pins. — justified
  3. One malformed metrics shard line no longer breaks the whole telemetry read — justified
  4. The App Store install-from-path box gets an accessible name — justified
  5. Keyboard focus stays on the PR and issue Refresh buttons while they refresh — justified
  6. The watch-list clear-completed confirm uses plural forms — justified
  7. Focus stays on Refresh and Poll now in Ops Mission Control while they run — justified
  8. Channel mention and preset role lists are joined per locale — justified
  9. Focus is kept when a creator-filter paging button disappears — justified
  10. A closed mobile drawer no longer pops back open when a stale animation settles late — justified

[FIRST-PRINCIPLES-REVIEWED] 1288121

Description read

[DESCRIPTION-READ] b7a94709c5c607594bd26912e25e78676744902c9fc0be24f1063dea7d29ae89

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 1288121a48b1145648806aa3f6843edbb929b2c3 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

There are no design-level concerns. Each pick is a small fix already merged on main. The new desktop log paths match website/electron/package.json and the nightly extraMetadata.name override, and no surface is reshaped.

[DESIGN-REVIEWED] 1288121

Description read

[DESCRIPTION-READ] ca4759a8e7d8faa98b16ce16d8a1ad86f35c96b0bc9603459930a00ca7939a40

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of 1288121a48b1145648806aa3f6843edbb929b2c3 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing screenshots of the changed update copy, the Update button label, the pluralized clear confirm and the locale-joined lists. No image was supplied, so the blind read was not performed.

Evidence gaps

  • Update popup (UpdateFoundModal.tsx): on a behind-only checkout it now shows "A newer version is available" with no version number. Needs a screenshot of the modal in that state.
  • Settings › About (AboutPanelGatewayUpdate.tsx): on a behind-only checkout the status line drops "(vX)", the button changes from "Update to vX" to "Update now", and the confirm heading changes from "Update to vX" to "Update". Needs a screenshot of the panel and one of the confirm dialog.
  • Watch list clear-completed confirm (WatchlistPanel.tsx): now says "Deletes 1 completed item." or "Deletes N completed items." Needs a screenshot of the dialog with a count of 1 and with a larger count.
  • Channel page (ChannelPage.tsx): the channel-mention and preset-role lists are now joined per locale. Needs a screenshot of the joined list.
  • Mobile drawer (useDrawerSwipe.ts): the drawer now stays shut when a late animation finishes. Needs a recording of a close followed by the late animation finishing.
  • The description says the main PRs' screenshots show these changes. Those PRs' images are not evidence for this revision. Attaching them, or new ones, to this PR's description closes the gaps.

[UX-REVIEWED] 1288121

Description read

[DESCRIPTION-READ] 163950473367c4f696d569f039cddbf1c2e4e4ad598f02e400161583a9c3876e

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 1288121a48b1145648806aa3f6843edbb929b2c3 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 1288121

Verdict parsed from the review's SHA-scoped output markers for commit 1288121a48b1145648806aa3f6843edbb929b2c3.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 1288121a48b1145648806aa3f6843edbb929b2c3 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 1288121a48b1145648806aa3f6843edbb929b2c3 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 1288121

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 1288121a48b1145648806aa3f6843edbb929b2c3 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 8, 2026
bolichen97 and others added 10 commits November 8, 2026 03:49
… running one (#30273)

Co-authored-by: w <w@k.local>
(cherry picked from commit a858681)
…nux (#30441)

On Windows and Linux the desktop app writes desktop-metrics.json to
<userData>/logs, and Electron names userData after the npm package
(kirocrew-desktop, kirocrew-desktop-nightly), not the product name.
kirocrew desktop metrics probed the product-name directories there, so
it never found an artifact the app had recorded and told the user to
restart with KIROCREW_DEBUG=1, which they had already done.

The Windows and Linux branches now probe the npm-name directories; the
macOS branch is unchanged. A test pins both names to the Electron
package and the nightly packaging override, and the profiling note and
the brand-name gate's comment stop describing the old probe.

Closes #13105

(cherry picked from commit 7451375)
…#30452)

(cherry picked from commit 8402a1b)

Original author: Javen Cinocca (#30452).
(cherry picked from commit d84616c)

Original author: Rohan Khanderia (#30881).
…refresh (#31360)

(cherry picked from commit bc7f797)

Original author: Rohan Khanderia (#31360).
Clearing completed items from the pet's watch list asks first with
"Deletes {{count}} completed item(s). This cannot be undone." The
key had one form and the count was passed as a string, so one item
read "1 completed item(s)", and Spanish, French, Italian and
Portuguese copied the shortcut.

Pass the count as a number and give the key the plural forms each
language needs, so one item reads "Deletes 1 completed item."

(cherry picked from commit f73f4fa)

Original author: Rohan Khanderia (#31377).
…ey run (#32049)

(cherry picked from commit 3e4954a)

Original author: Rohan Khanderia (#32049).
The Channels page joined two natural-language lists with a hard-coded
", ": the @mentions a message was addressed to and the roles a New
Channel preset brings. A CJK reader saw an English comma-space instead
of the list separator their language uses (zh-CN reads A、B和C).

Both lists now go through fmtList, which the page already uses for the
clear-context roster, so they follow the active locale.

Fixes #31877

(cherry picked from commit ecb3d62)

Original author: Rohan Khanderia (#31887).
…32435)

In the sidebar's creator-filtered session list, Back is shown only past
the first page and More only while another page exists. Pressing Back
onto the first page, or More onto the last, removed the pressed button
and dropped keyboard focus to the page body. Once the new page lands,
focus now goes to the pressed button if it is still there, else to the
other paging button.

(cherry picked from commit 5843f47)

Original author: Rohan Khanderia (#32435).
…2520)

A drawer settle that runs on the main thread is stopped when a new
gesture takes the panel over. When the settle's time had already run
out before its last frame (a busy main thread), framer's stop completes
it instead, and animate() delivers onComplete a microtask later, after
the new gesture has committed. On the Bots page that stale "opened"
report published the side panel open after a closing drag, and the
panel slid back. Both main-thread settles (animateDrawer's and the
trackpad's) now note framer's onStop and drop an arrival that comes
after it.

Closes #29908

(cherry picked from commit 4e8702c)
@buluoray buluoray changed the title fix: backport 0.12.1 batch 62 (11 wide-bar fixes) fix: backport 0.12.1 batch 62 (10 wide-bar fixes) Nov 8, 2026
@buluoray

buluoray commented Nov 8, 2026

Copy link
Copy Markdown
Contributor Author

Goal edited under the maintainer's standing rule for this round (drop a pick on a real AI finding): 11 -> 10. #31481 is removed (head 113be55 -> 1288121) because GPT 6.1's upheld finding on website/src/apps/issue-radar/components/IssueList.tsx:233 holds: the touched refresh still fails silently, which the blocking errors-use-error-notice rule forbids. main has the same code.

@buluoray
buluoray force-pushed the crew/slack/0.12.1-batch-62 branch from 113be55 to 1288121 Compare November 8, 2026 03:51
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 8, 2026
@buluoray
buluoray merged commit 193db41 into release/0.12.0 Nov 8, 2026
21 of 24 checks passed
@buluoray
buluoray deleted the crew/slack/0.12.1-batch-62 branch November 8, 2026 04:34
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants