Repository navigation
fix: backport 0.12.1 batch 62 (10 wide-bar fixes) - #32891
Conversation
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS This PR only moves fixes that are already merged on What this change shipsInventory (10 items) — 10 justifiedIntent: give 0.12.x users ten small fixes that already shipped on
[FIRST-PRINCIPLES-REVIEWED] 1288121 Description read[DESCRIPTION-READ] b7a94709c5c607594bd26912e25e78676744902c9fc0be24f1063dea7d29ae89 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS There are no design-level concerns. Each pick is a small fix already merged on [DESIGN-REVIEWED] 1288121 Description read[DESCRIPTION-READ] ca4759a8e7d8faa98b16ce16d8a1ad86f35c96b0bc9603459930a00ca7939a40 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing screenshots of the changed update copy, the Update button label, the pluralized clear confirm and the locale-joined lists. No image was supplied, so the blind read was not performed. Evidence gaps
[UX-REVIEWED] 1288121 Description read[DESCRIPTION-READ] 163950473367c4f696d569f039cddbf1c2e4e4ad598f02e400161583a9c3876e That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
…nux (#30441) On Windows and Linux the desktop app writes desktop-metrics.json to <userData>/logs, and Electron names userData after the npm package (kirocrew-desktop, kirocrew-desktop-nightly), not the product name. kirocrew desktop metrics probed the product-name directories there, so it never found an artifact the app had recorded and told the user to restart with KIROCREW_DEBUG=1, which they had already done. The Windows and Linux branches now probe the npm-name directories; the macOS branch is unchanged. A test pins both names to the Electron package and the nightly packaging override, and the profiling note and the brand-name gate's comment stop describing the old probe. Closes #13105 (cherry picked from commit 7451375)
Clearing completed items from the pet's watch list asks first with
"Deletes {{count}} completed item(s). This cannot be undone." The
key had one form and the count was passed as a string, so one item
read "1 completed item(s)", and Spanish, French, Italian and
Portuguese copied the shortcut.
Pass the count as a number and give the key the plural forms each
language needs, so one item reads "Deletes 1 completed item."
(cherry picked from commit f73f4fa)
Original author: Rohan Khanderia (#31377).
The Channels page joined two natural-language lists with a hard-coded ", ": the @mentions a message was addressed to and the roles a New Channel preset brings. A CJK reader saw an English comma-space instead of the list separator their language uses (zh-CN reads A、B和C). Both lists now go through fmtList, which the page already uses for the clear-context roster, so they follow the active locale. Fixes #31877 (cherry picked from commit ecb3d62) Original author: Rohan Khanderia (#31887).
…32435) In the sidebar's creator-filtered session list, Back is shown only past the first page and More only while another page exists. Pressing Back onto the first page, or More onto the last, removed the pressed button and dropped keyboard focus to the page body. Once the new page lands, focus now goes to the pressed button if it is still there, else to the other paging button. (cherry picked from commit 5843f47) Original author: Rohan Khanderia (#32435).
…2520) A drawer settle that runs on the main thread is stopped when a new gesture takes the panel over. When the settle's time had already run out before its last frame (a busy main thread), framer's stop completes it instead, and animate() delivers onComplete a microtask later, after the new gesture has committed. On the Bots page that stale "opened" report published the side panel open after a closing drag, and the panel slid back. Both main-thread settles (animateDrawer's and the trackpad's) now note framer's onStop and drop an arrival that comes after it. Closes #29908 (cherry picked from commit 4e8702c)
|
Goal edited under the maintainer's standing rule for this round (drop a pick on a real AI finding): 11 -> 10. #31481 is removed (head 113be55 -> 1288121) because GPT 6.1's upheld finding on |
113be55 to
1288121
Compare
Problem / Motivation
Goal: Bring 10 small fixes that merged on
mainafterv0.12.0ontorelease/0.12.0, one commit each, in a PR of their own.Why it matters
Each row is a user-visible fix from the 0.12.1 wide-bar list (Ray, 11-07). Every pick applied cleanly onto release.
Not a goal
main; nothing is changed only here.CHANGELOG.mdchange.website/src/apps/issue-radar/components/IssueList.tsx:233holds. The touched refresh still fails silently (the mutation error never reaches anErrorNotice), which the blockingerrors-use-error-noticerule requires of a touched request.mainhas the same code.What changed (motivation → approach → change)
Each main squash commit was cherry-picked with
-xontorelease/0.12.0@8e72744cbb, in merge order onmain, one commit each. Every pick applied cleanly, with no prerequisite and no hand-resolved hunk; every commit has added and removed lines identical to its main commit.a858681d453703ab701b74513752f0002c94c6008402a1bcd99f30ebf010d84616c94e8935c06913bc7f7974be3d63cb845ef73f4faf19e840d02c7c3e4954a7b8cac364b0f4ecb3d6225ab31a5b521e5843f47824a6fc1a9a7f4e8702c8c11288121a487 commits carried a non-public author email or an internal co-author trailer, which the push guard refuses, so they are authored with the public identity and name their original author in the message; internal trailer lines are removed. The other 3 keep their original author.
builder-security checked: each change is the one already merged on
main; no bind, listener, new route, auth mechanism or storage grant is added.Backwards compatibility
Compatible: each change is the one already merged on
main, and its compatibility note applies unchanged.Removes nothing: no setting, key or caller is removed.
Tests
Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs
release/*, so the direct test modules were run here: every touched test file plus every test file that imports a touched module, 3 files,-n 4 --dist loadgroup. 99 passed, 0 failed.tsc -p tsconfig.app.json --noEmitpasses.vitest runon every touched test file and every touched component name (first head, with fix(issue-radar): keep focus on the Refresh issues buttons while they refresh #31481): 40 files, 769 passed, 0 failed; on this head the Issue Radar tests pass.Manual verification
N/A - each fix was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.
Screenshots / video
Why no screenshot: each frontend pick carries the same rendered change as its main PR, whose screenshots show it.
Related Issues
Backport to the 0.12 line for 0.12.1 of #30273, #30441, #30452, #30881, #31360, #31377, #32049, #31887, #32435, #32520.
Sibling sweep
Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.
Pattern harvest
Not generalizable: this PR only carries fixes already on
main. The source PRs have their own harvest.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.