Skip to content

fix: backport 0.12.1 batch 63 (6 docs/tests-conflict fixes) - #32927

Merged
buluoray merged 6 commits into
release/0.12.0from
crew/slack/0.12.1-batch-63
Nov 8, 2026
Merged

buluoray merged 6 commits into
release/0.12.0from
crew/slack/0.12.1-batch-63

Conversation

@buluoray

@buluoray buluoray commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Bring 6 small fixes that merged on main after v0.12.0 onto release/0.12.0, one commit each, in a PR of their own.

Why it matters

Each row is a user-visible value-2 fix from the 0.12.1 wide-bar list (Ray, 11-07) that an earlier builder skipped because its pick conflicted in docs or tests only.

PR Area What a 0.12.0 user sees today
#31653 side panel Escape typed in the editor no longer closes the open file
#31893 dashboard Subagent replay waits for boot restore, so runs are not lost
#31442 cron Cron script path under ~/.kiro/crew resolves to the data home
#31106 chat Background chat slot memory no longer grows without bound
#31655 auth Former owner's session is told to sign in again
#32372 Claude harness Steering a Claude chat waits for the whole turn to finish

Not a goal

What changed (motivation → approach → change)

Each main squash commit was cherry-picked with -x onto release/0.12.0 @ 3c6a160c8a, in merge order on main, one commit each. #31893 applied cleanly. The other five conflicted in docs or test files only and are hand-resolved: keep release's text and structure, then apply the fix's own added and removed lines. No production code is hand-resolved, and no prerequisite is picked.

PR Hand-resolved file
#31653, #31442 docs/system-specs/modules/learn-cron-dashboard.md
#31106 website/src/store/chatSlice.publicSurface.test.ts
#31655 docs/system-specs/modules/dashboard-token-auth.md
#32372 docs/system-specs/modules/harness-parity.md

#31653, #31442 and #31655 have added and removed lines identical to the main commit. For #31106 and #32372, release words the line the fix rewrites differently, so the fix's word-level edit is applied to release's line; each differs from the main commit by exactly that one line.

# PR main commit release commit
1 #31653 keep a side-panel file open on escape typed in its editor 27fce313cb 5b9ff226fa
2 #31893 wait for the boot restore before the subagent replay a17bda3d08 89e895f591
3 #31442 read a ~/.kiro/crew cron script path as the configured data home 1694a06f92 897a7ca997
4 #31106 bound a background slot's live-appended transcript retention db008d59d4 3336dc97ca
5 #31655 tell a former owner's session to sign in again c1924789e0 db1ebdd51d
6 #32372 send a claude steer once its running tool call finishes 13e24338b6 4767fe9d0e

5 commits carried a non-public author email or an internal co-author trailer, which the push guard refuses, so they are authored with the public identity and name their original author in the message; internal trailer lines are removed. The other 1 keep their original author.

builder-security checked: each change is the one already merged on main; no bind, listener, new route, auth mechanism or storage grant is added.

Backwards compatibility

Compatible: each change is the one already merged on main, and its compatibility note applies unchanged.

Removes nothing: no setting, key or caller is removed.

Tests

Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs

  • CI does not run the backend suite on PRs into release/*, so the direct test modules were run here: every touched test file plus every test file that imports a touched module, 166 files, -n 4 --dist loadgroup. 6367 passed, 4 skipped, 2 failed; both fail the same way on a clean release/0.12.0 @ 3c6a160c8a on this host.
  • Frontend: tsc -p tsconfig.app.json --noEmit passes. vitest run on every touched test file and component name: 187 files, 3160 passed, 1 failed (MarkdownPanel.editFocus.test.tsx, which fails the same way on clean release).
  • flake8 passes on the changed Python files.

Manual verification

N/A - each fix was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.

Screenshots / video

Why no screenshot: each frontend pick carries the same rendered change as its main PR, whose screenshots show it.

Related Issues

Backport to the 0.12 line for 0.12.1 of #31653, #31893, #31442, #31106, #31655, #32372.

Sibling sweep

Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.

Pattern harvest

Not generalizable: this PR only carries fixes already on main. The source PRs have their own harvest.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 8, 2026 04:33
@buluoray
buluoray requested review from tim-finnigan and removed request for a team November 8, 2026 04:33
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 8, 2026
buluoray and others added 6 commits November 8, 2026 04:34
Escape typed into an editable field of a side-panel file tab (the code
editor, or the Files rail's filter) no longer closes the file. The tab
listened for Escape on the whole page and the editor does not claim the
key, so a press meant for the editor closed the file mid-edit. Escape
from anywhere else, the chat composer included, still closes it.

Closes #23975

(cherry picked from commit 27fce31)

Original author: Bolin Chen (#31653). Hand-resolved, docs/tests only: docs/system-specs/modules/learn-cron-dashboard.md  keep release's structure plus this commit's added and removed lines.
…31893)

A restarted gateway accepts WebSocket connections before its boot
restore has put the chat slots back. A dashboard tab that reconnects in
that window sends subscribe_subagents for slots that are not open yet,
so the replay queue refused every one of them and the Subagents panel
stayed empty until the user focused another slot.

An owner socket's replay queue now waits for the existing
startup_tabs_rebuilt event (bounded at 300s) before its first batch,
and admits the slots asked for meanwhile only after it. An app socket
does not wait: its visible slots are read at subscribe.

(cherry picked from commit a17bda3)
…#31442)

The cron help, tool schema and docs spell a script as
~/.kiro/crew/crons/<file>.py, but the resolver expanded ~ against the
real home, so under a KIROCREW_HOME override the documented spelling
never resolved. Rebase that prefix onto config_dir() before resolution.
A spec already inside the data home (an override nested under
~/.kiro/crew, compared on canonical paths) is kept, and the resolve,
sensitive-path and containment checks still judge the result.

Closes #29828

(cherry picked from commit 1694a06)

Original author: Bolin Chen (#31442). Hand-resolved, docs/tests only: docs/system-specs/modules/learn-cron-dashboard.md  keep release's structure plus this commit's added and removed lines.
…on (#31106)

* fix(chat): bound a background slot's live-appended transcript retention

* fix(chat): hydrate a split pane again once its slot stops being active

A split pane that shows the active slot has its hydrate refused, because
the active mirror is live. When the reader switches away while that view is
empty or still loading, the park writes no page marker, so the pane's hold
cannot flag the slot either. Nothing flagged it afterwards, and a finished
background turn then trimmed rows the pane still showed.

The pane's hydrate effect now also runs when the slot stops being active,
so the page refused earlier is placed and the slot is flagged.

---------

Co-authored-by: Gary Jennings <garysjennings@gmail.com>

(cherry picked from commit db008d5)

Original author: Pearcekieser (#31106). Hand-resolved, docs/tests only: website/src/store/chatSlice.publicSurface.test.ts  keep release's structure plus this commit's added and removed lines.
(cherry picked from commit c192478)

Original author: Joe Guo (#31655). Hand-resolved, docs/tests only: docs/system-specs/modules/dashboard-token-auth.md  keep release's structure plus this commit's added and removed lines.
On the Claude Code harness a message sent while a tool ran was refused
and queued for the next turn, because a _session/steering request during
a running tool makes claude-agent-acp background the tool and end the
turn early. Nothing retried it when the tool ended, so a mid-turn
message waited for the whole turn, and a wait sleep slept through it.

Hold such a steer, stamp it so a wait sleep ends, and send it once the
turn's last open tool call ends, oldest first. A held steer the turn
never takes is queued by the existing teardown, marked possibly
delivered when its write may have reached the adapter.

Builds on #25000.

Co-authored-by: Aaron Longwell <a@adl.io>

(cherry picked from commit 13e2433)

Original author: Bolin Chen (#32372). Hand-resolved, docs/tests only: docs/system-specs/modules/harness-parity.md  keep release's structure plus this commit's added and removed lines.
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 4767fe9d0e1aef3ffca89d6159b5567bb74df92b — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks: each item is a fix that has already merged on main, backported one commit each, and the only pin it rewrites is #32372's own steer test, reversed in that main commit along with the defect it records.

What this change ships

Inventory (8 items) — 8 justified

Intent: bring six user-visible fixes that already merged on main onto the 0.12 release line for 0.12.1. FIX.

  1. Pressing Escape inside the side-panel editor no longer closes the open file (fix: keep a side-panel file open on escape typed in its editor #31653) — justified
  2. After a gateway restart, the subagent replay waits for the boot restore, so finished runs are not lost (fix(dashboard): wait for the boot restore before the subagent replay #31893) — justified
  3. A cron script path written under ~/.kiro/crew now resolves to the configured data home (fix: read a ~/.kiro/crew cron script path as the configured data home #31442) — justified
  4. A background chat slot's live transcript stops growing without limit (fix(chat): bound a background slot's live-appended transcript retention #31106) — justified
  5. A former owner's dashboard session now gets the 401 that asks it to sign in again, instead of a plain 403 (fix(auth): tell a former owner's session to sign in again #31655) — justified
  6. Tokens minted for the owner (startup, local token, the owner's Slack link, the DM deep link) now carry an owner_mint claim (fix(auth): tell a former owner's session to sign in again #31655) — justified
  7. A Claude steer sent while a tool runs is held, then sent when the tool finishes, instead of waiting for the whole turn (fix: send a claude steer once its running tool call finishes #32372) — justified
  8. The security, SEL, subagent, harness-parity and cron specs are reworded to match the fixes — justified

[FIRST-PRINCIPLES-REVIEWED] 4767fe9

Description read

[DESCRIPTION-READ] 19d5ebe7b44574aa3851bed580752b98d812e2193a3e40d439ed5dce16a2e59f

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 4767fe9d0e1aef3ffca89d6159b5567bb74df92b — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks: the diff adds or changes no visible control, label or string, so nothing needed a screenshot. The one interaction change is Escape in the side-panel editor, which now leaves the open file open.

Notes

  • MarkdownPanel.tsx: typing Escape in a field inside the panel no longer closes the file, but Escape from anywhere else, including the chat composer, still does. A user who is used to closing the file from the editor with Escape will now find nothing happens. The panel's visible close control still works, so this is a minor habit change, not a blocker.

[UX-REVIEWED] 4767fe9

Description read

[DESCRIPTION-READ] ff7b9d23ac9c24ef3932d3b30c9c5bda2b1ffd59b61be72527efca25303e8d8d

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 4767fe9d0e1aef3ffca89d6159b5567bb74df92b — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

This is a straight cherry-pick of six fixes already merged on main. Every hunk traces to one of the listed PRs, and nothing in the patch removes a key, route or caller.

Notes

  • The new owner_mint claim only changes which denial a refused request gets, now on release/0.12.0 as well. Until the RC soak runs, token mint and refresh on this branch are covered by the targeted test run only, not by CI.

[DESIGN-REVIEWED] 4767fe9

Description read

[DESCRIPTION-READ] 279dd86808ecac356619b79da2118e5e058605657bc8e6ebcedbefaaee6e4c63

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 4767fe9d0e1aef3ffca89d6159b5567bb74df92b and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 4767fe9

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 4767fe9d0e1aef3ffca89d6159b5567bb74df92b false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 4767fe9d0e1aef3ffca89d6159b5567bb74df92b — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 4767fe9

Verdict parsed from the review's SHA-scoped output markers for commit 4767fe9d0e1aef3ffca89d6159b5567bb74df92b.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 4767fe9d0e1aef3ffca89d6159b5567bb74df92b false-positive: <reason, 20 to 500 characters>

@buluoray
buluoray force-pushed the crew/slack/0.12.1-batch-63 branch from 4629996 to 4767fe9 Compare November 8, 2026 04:45
@buluoray buluoray changed the title fix: backport 0.12.1 batch 63 (18 docs/tests-conflict fixes) fix: backport 0.12.1 batch 63 (6 docs/tests-conflict fixes) Nov 8, 2026
@buluoray

buluoray commented Nov 8, 2026

Copy link
Copy Markdown
Contributor Author

Goal edited at the maintainer's request: scope split between builders. This PR now carries only the value-2 docs/tests-conflict rows (#31653, #31893, #31442, #31655, #31106, #32372); the value-1 rows and #30084 move to another builder's batch, and #31400 is left out because an open release PR records that it needs a prerequisite. Head 4629996 -> 4767fe9.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 8, 2026
@buluoray
buluoray merged commit da99e81 into release/0.12.0 Nov 8, 2026
23 of 34 checks passed
@buluoray
buluoray deleted the crew/slack/0.12.1-batch-63 branch November 8, 2026 05:14
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants