Skip to content

fix: backport 0.12.1 batch 64 (6 left-out value-2 fixes) - #32941

Merged
buluoray merged 6 commits into
release/0.12.0from
crew/slack/0.12.1-batch-64
Nov 8, 2026
Merged

buluoray merged 6 commits into
release/0.12.0from
crew/slack/0.12.1-batch-64

Conversation

@buluoray

@buluoray buluoray commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Bring 6 small fixes that merged on main after v0.12.0 onto release/0.12.0, one commit each, in a PR of their own.

Why it matters

Each row is a user-visible value-2 fix from the 0.12.1 wide-bar list (Ray, 11-07) that an earlier batch left out because its pick conflicted or needed a prerequisite.

PR Area What a 0.12.0 user sees today
#31400 deploy pending deploy confirmations show time left and keep their errors
#31639 security Deny-rule check no longer hangs on one very long word
#32252 chat chat redaction stays consistent across re-renders
#27257 security security audit also scans session transcripts
#31980 pods Pod host per-user systemd manager misdetected, pod fails to run
#31579 terminal Terminal sessions keep running after the terminal panel is switched off

Not a goal

What changed (motivation → approach → change)

Each main squash commit was cherry-picked with -x onto release/0.12.0 @ 193db41120, in merge order on main, one commit each. #31400 applied cleanly: its prerequisite #31006 (the pending-confirmation expires_at_epoch) is already on release. The other five are hand-resolved, each listed below; no prerequisite is picked.

PR File Resolution
#31639, #32252, #27257 test/test_security_gate_liveness.py _PACKAGE_LINE_BUDGET (a ceiling on the security package's line count) is raised from release's own value by each commit's growth: 34,523 -> 34,548 (+25) -> 34,587 (+39) -> 34,694 (+107), with each commit's comment. Main's own +10 re-measure is not carried. The package measures 34,596 after all three.
#31639 docs/system-specs/modules/security.md release's text plus this commit's lines
#31980 src/kiro_crew/pod/runtime.py comment only: main's comment above the load-path fallback, which describes the code this commit adds; every code line is identical to main
#31579 dashboard/server_runtime/config_watch.py, test/test_config_live_server_appliers.py, learn-cron-dashboard.md release's structure plus this commit's added lines; main's neighbouring apps subscription belongs to a main feature not on release
#31579 test/test_dashboard_server_composition_contract.py release's literal lazy-import count 129 -> 130 for the one entry this commit adds

Every other file has added and removed lines identical to its main commit.

# PR main commit release commit
1 #31400 show time left on pending confirmations and keep errors 8dbdf0443c 6c51cce149
2 #31639 keep two interpreter deny rules linear on one long word ec3abef1f6 f95ff57e62
3 #32252 keep a chat display redaction consistent across renders bab2387339 d035dfb257
4 #27257 make security audit scan session transcripts b9245ab887 37544c9479
5 #31980 ask systemd whether a pod host has a per-user manager e6f6a101fb eaedf674c7
6 #31579 end every terminal session when the panel is switched off 1c0a80fadd d8e82e62d1

5 commits carried a non-public author email or an internal co-author trailer, which the push guard refuses, so they are authored with the public identity and name their original author in the message; internal trailer lines are removed. The other 1 keep their original author.

builder-security checked: each change is the one already merged on main; no bind, listener, new route, auth mechanism or storage grant is added.

Backwards compatibility

Compatible: each change is the one already merged on main, and its compatibility note applies unchanged.

Removes nothing: no setting, key or caller is removed.

Tests

Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs

  • CI does not run the backend suite on PRs into release/*, so the direct test modules were run here: every touched test file plus every test file that imports a touched module, 150 files, -n 4 --dist loadgroup (on a head that also carried fix(overview): confirm settings actions in-app instead of natively #30516 and fix(components): confirm restart, tag deletion and teardown in-app #30947, which only touched website/). 7475 passed, 5 skipped, 7 failed; all 7 fail the same way on a clean release/0.12.0 @ 193db41120 on this host. On this head: test_security_gate_liveness.py, test_dashboard_server_composition_contract.py and test_config_live_server_appliers.py pass, and the deploy and touched test files pass (1389 passed).
  • Frontend on this head: tsc -p tsconfig.app.json --noEmit passes; vitest run ArtifactDeploy Deploy deploy: 15 files, 180 passed.
  • flake8 passes on the changed Python files.

Manual verification

N/A - each fix was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.

Screenshots / video

Why no screenshot: each frontend pick carries the same rendered change as its main PR, whose screenshots show it.

Related Issues

Backport to the 0.12 line for 0.12.1 of #31400, #31639, #32252, #27257, #31980, #31579.

Sibling sweep

Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.

Pattern harvest

Not generalizable: this PR only carries fixes already on main. The source PRs have their own harvest.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

bolichen97 and others added 6 commits November 8, 2026 05:07
…31400)

A deploy preview's pending confirmation expires an hour after the
preview, but the Pending confirmations card on /deploy never said so,
and the poll that dropped an expired row also hid the whole card,
taking the card's own confirm or dismiss error and the open publish
acknowledgment with it.

Each row now shows the time left, read from the server's
expires_at_epoch, and the card stays on screen while a failed action's
error or the acknowledgment is still showing after the list empties.

Closes #17022

(cherry picked from commit 8dbdf04)
The kill-interpreter and token-argv deny rules took about 0.84 s each,
per pass, on a command holding one 20 KiB word, because an optional
module prefix in front of their call names rescanned the word from
every start. The rules are searched, so the prefix never decided a
match; both rows now name the calls bare and stay linear, with the
same verdict on every input. The old spellings stay resolvable for
governance pins through the legacy alias map.

(cherry picked from commit ec3abef)

Original author: Bolin Chen (#31639). Hand-resolved, docs/tests only: docs/system-specs/modules/security.md keeps release's text plus this commit's lines; test/test_security_gate_liveness.py raises release's own package line budget by this commit's 25 lines (34,523 -> 34,548) with its comment.
A chat message shown again from the display cache could carry a
different redaction than a fresh render under the settings in force at
that moment. The cached and the fresh result now always agree.

Builds on #22455.

Closes #22388

(cherry picked from commit bab2387)

Original author: Bolin Chen (#32252). Hand-resolved, tests only: test/test_security_gate_liveness.py raises release's own package line budget by this commit's 39 lines (34,548 -> 34,587) with its comment; main's separate +10 re-measure is not carried.
(cherry picked from commit b9245ab)

Original author: Rohan Khanderia (#27257). Hand-resolved, tests only: test/test_security_gate_liveness.py raises release's own package line budget by this commit's 107 lines (34,587 -> 34,694) with its comment.
The pod gate and doctor decided whether a host can run systemd --user by
walking a hand-copied list of systemd's unit directories. A masked
user@.service read as present and $SYSTEMD_UNIT_PATH was invisible, so a
host with no usable manager was told to enable linger.

Ask the system manager instead (systemctl show --property=LoadState
user@<uid>.service): it needs no user bus and applies systemd's own
instance-then-template lookup, masks and unit path. The directory walk
stays only for when that call cannot answer. Both pod gates and doctor
use the one helper; on the missing-bus branch the refusal is still
PodBackendAbsent whatever the answer, and no --user call is spawned.

Closes #7399

(cherry picked from commit e6f6a10)

Original author: Bolin Chen (#31980). Hand-resolved, comment only: src/kiro_crew/pod/runtime.py takes main's comment above the load-path fallback, which describes the code this commit adds; every code line is identical to main.
…off (#31579)

Switching dashboard.terminal.enabled to false left every registered
shell running until the 12-hour orphan sweep, including shells whose
tab was already gone. A live-config applier now ends each one at once:
its socket gets the shell-exited close so the tab closes instead of
redialing, and the gate's 30-second cache is expired so a redial is
refused rather than handed a new shell.

(cherry picked from commit 1c0a80f)

Original author: Bolin Chen (#31579). Hand-resolved: config_watch.py, test_config_live_server_appliers.py and learn-cron-dashboard.md keep release's structure plus this commit's added lines (main's neighbouring "apps" subscription belongs to a main feature not on release); test_dashboard_server_composition_contract.py raises release's literal lazy-import count 129 -> 130 for the one entry this commit adds.
@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 8, 2026 05:11
@buluoray
buluoray requested review from Zedmor and removed request for a team November 8, 2026 05:11
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of d8e82e62d16ff30832ad12bd08c1dd933ac975b2 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] d8e82e6

False positive or not applicable? A repository writer can comment:
/ai-review override gpt d8e82e62d16ff30832ad12bd08c1dd933ac975b2 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Security Scope Review -- 🔴 could not complete (fails closed)

No scope verdict for d8e82e62d16ff30832ad12bd08c1dd933ac975b2 (the review produced no [SCOPE-REVIEWED] marker for this head). This lane fails CLOSED: an unmeasured tightening must not read as "nothing newly refused". See the job logs, then re-run -- or record /ai-review override scope d8e82e62d16ff30832ad12bd08c1dd933ac975b2 <class>: <reason> if a human has judged the scope by hand.


Security scope review -- adjudicated candidates

  • macos-latest (platform posix): 14 classified, 0 newly refused, 14 still allowed.
  • ubuntu-latest (platform posix): 14 classified, 0 newly refused, 14 still allowed.
  • windows-latest (platform windows): 6 classified, 0 newly refused, 6 still allowed.

No candidate flipped from allowed to refused.

[SCOPE-REVIEWED] d8e82e6

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Sensitive Change Review

Sensitive files changed:

  • src/kiro_crew/security/denied_rules.py

  • src/kiro_crew/security/denied_rules_catalog.py

  • src/kiro_crew/security/memory_audit.py

  • src/kiro_crew/security/redaction.py

  • No reasoning template for d8e82e6 yet.

How to clear this check:

  1. The PR author posts the template below as a PR comment, with
    every field filled (N/A needs a reason). Keep the
    Head commit line: it must name the current head SHA.
  2. The check turns green within a minute, with no push.
  3. A new push resets this check: post it again for the new head.

Only the author's comment counts this way. A reviewer can instead
paste the filled template into an "Approve" review on this head.
Merging still needs a reviewer's approval.

## Sensitive change review
- Head commit: d8e82e62d16ff30832ad12bd08c1dd933ac975b2
- What rule changed:
- Before -> after (what was allowed/blocked, now):
- Worst case if wrong (breaks commands / leaks secret / locks user out):
- Evidence checked (which sandbox result proves it):
- No regression:
  - Tools still work (which tools/commands were run, result):
  - Backward compatible (old config / old data / old callers still work, how checked):
  - Existing tests (which suites passed on this head):
- How to undo:

@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of d8e82e62d16ff30832ad12bd08c1dd933ac975b2 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing a screenshot of the new "Preview expires {{when}} unless confirmed" line on Deploy's Pending confirmations card. The blind read was not performed because this PR supplies no image.

Evidence gaps

  • New expiry line (pages.artifactDeployPage.pending_expires_unless_confirmed), added under each row's age line in ArtifactDeployPage.tsx PendingConfirmations. To close: one screenshot of a pending row that shows the age line and the expiry line together.
  • Card that stays after its last row expires. It now stays when a confirm or dismiss failed, or when the acknowledgment is still open, even though the list is empty (!confirmMut.isError && !dismissMut.isError && !ackEntry). To close: one screenshot of the card with no rows and the error notice showing.
  • No admissible evidence. The <!-- no-visual-delta --> marker says the screenshots on main PR fix(deploy): show time left on pending confirmations and keep errors #31400 show this change. They are not attached to this PR, so they do not count for this revision. Attaching them, or new captures, as github.com/user-attachments images in this description closes both gaps above.

[UX-REVIEWED] d8e82e6

Description read

[DESCRIPTION-READ] cb58fdf441eeba8c21f37d85ec8b68165496712ea4deebbfda4850c544254d5b

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

Design-level review of d8e82e62d16ff30832ad12bd08c1dd933ac975b2 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

cannot evaluate: missing screenshot of the Pending confirmations card on /deploy for this revision. The diff adds a line to each row and changes when the card stays visible, and the evidence file lists 0 images.

Blockers

No rendered evidence of the reshaped Pending confirmations card
Trigger: website/src/pages/ArtifactDeployPage.tsx adds "{i18nT('pages.artifactDeployPage.pending_expires_unless_confirmed', …)}" as a new line in every pending row, and changes the hide condition to "if (!pending.length && !pendingQ.isError && !confirmMut.isError && !dismissMut.isError && !ackEntry) return null". The description offers only "each frontend pick carries the same rendered change as its main PR, whose screenshots show it".
Outcome: screenshots from the main PR come from a commit outside this PR, so they don't count as evidence. The release branch's card markup differs from main's, so nobody has seen how the new line fits beside the per-entry warning and the confirm button, or whether an empty card with only an error looks right. The surface ships unseen.
Fix: render /deploy on this head with one pending entry, then with a failed confirm after the entry expires. Attach both images, or commit them under temp-screenshots/.
Clears when: the description or the commit carries a downloaded image or recording of the Pending confirmations card on this head, showing the "Preview expires … unless confirmed" line, and the workflow's evidence file lists it.

Notes

[DESIGN-REVIEWED] d8e82e6

Description read

[DESCRIPTION-READ] 5454f9d6a2c1d185ecc12296dd1f3b7c5d95b8da7c31c2e80cbedc9ad3e0b1e3

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of d8e82e62d16ff30832ad12bd08c1dd933ac975b2 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Every item is a fix that has already merged on main and is carried over unchanged. The only hand-made edits are the conflict resolutions, and none of them adds anything new.

What this change ships

Inventory (7 items) — 7 justified

Intent: give 0.12.x users six fixes that already shipped on main, without waiting for 0.13 — FIX.

  1. Pending deploy confirmations show how long is left and keep their error text (fix(deploy): show time left on pending confirmations and keep errors #31400) — justified
  2. The deny-rule check stays fast on one very long word: two interpreter rules became linear (fix: keep two interpreter deny rules linear on one long word #31639) — justified
  3. Chat display redaction gives the same result on every render (fix: keep a chat display redaction consistent across renders #32252) — justified
  4. kirocrew security audit scans the sessions/ transcripts instead of history/, and says so when there was nothing to scan (fix(security): make security audit scan session transcripts #27257) — justified
  5. The pod platform gate asks systemd at system scope whether a per-user manager exists, so a masked unit now counts as absent (fix: ask systemd whether a pod host has a per-user manager #31980) — justified
  6. Switching dashboard.terminal.enabled off live ends every running terminal session (fix(terminal): end every terminal session when the panel is switched off #31579) — justified
  7. Test pins raised to fit the picks: security package line budget 34,523 → 34,694, lazy-import count 129 → 130 — justified

[FIRST-PRINCIPLES-REVIEWED] d8e82e6

Description read

[DESCRIPTION-READ] b66214de214a2f3f9398d8df6b60db5db67b395cb80f6851ec9405d8e9b5ed7d

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed d8e82e62d16ff30832ad12bd08c1dd933ac975b2 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] d8e82e6

Verdict parsed from the review's SHA-scoped output markers for commit d8e82e62d16ff30832ad12bd08c1dd933ac975b2.

False positive or not applicable? A repository writer can comment:
/ai-review override fable d8e82e62d16ff30832ad12bd08c1dd933ac975b2 false-positive: <reason, 20 to 500 characters>

@buluoray
buluoray merged commit 989d318 into release/0.12.0 Nov 8, 2026
31 of 48 checks passed
@buluoray
buluoray deleted the crew/slack/0.12.1-batch-64 branch November 8, 2026 05:47
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants