Repository navigation
fix: backport 0.12.1 batch 64 (6 left-out value-2 fixes) - #32941
Conversation
…31400) A deploy preview's pending confirmation expires an hour after the preview, but the Pending confirmations card on /deploy never said so, and the poll that dropped an expired row also hid the whole card, taking the card's own confirm or dismiss error and the open publish acknowledgment with it. Each row now shows the time left, read from the server's expires_at_epoch, and the card stays on screen while a failed action's error or the acknowledgment is still showing after the list empties. Closes #17022 (cherry picked from commit 8dbdf04)
The kill-interpreter and token-argv deny rules took about 0.84 s each, per pass, on a command holding one 20 KiB word, because an optional module prefix in front of their call names rescanned the word from every start. The rules are searched, so the prefix never decided a match; both rows now name the calls bare and stay linear, with the same verdict on every input. The old spellings stay resolvable for governance pins through the legacy alias map. (cherry picked from commit ec3abef) Original author: Bolin Chen (#31639). Hand-resolved, docs/tests only: docs/system-specs/modules/security.md keeps release's text plus this commit's lines; test/test_security_gate_liveness.py raises release's own package line budget by this commit's 25 lines (34,523 -> 34,548) with its comment.
A chat message shown again from the display cache could carry a different redaction than a fresh render under the settings in force at that moment. The cached and the fresh result now always agree. Builds on #22455. Closes #22388 (cherry picked from commit bab2387) Original author: Bolin Chen (#32252). Hand-resolved, tests only: test/test_security_gate_liveness.py raises release's own package line budget by this commit's 39 lines (34,548 -> 34,587) with its comment; main's separate +10 re-measure is not carried.
The pod gate and doctor decided whether a host can run systemd --user by walking a hand-copied list of systemd's unit directories. A masked user@.service read as present and $SYSTEMD_UNIT_PATH was invisible, so a host with no usable manager was told to enable linger. Ask the system manager instead (systemctl show --property=LoadState user@<uid>.service): it needs no user bus and applies systemd's own instance-then-template lookup, masks and unit path. The directory walk stays only for when that call cannot answer. Both pod gates and doctor use the one helper; on the missing-bus branch the refusal is still PodBackendAbsent whatever the answer, and no --user call is spawned. Closes #7399 (cherry picked from commit e6f6a10) Original author: Bolin Chen (#31980). Hand-resolved, comment only: src/kiro_crew/pod/runtime.py takes main's comment above the load-path fallback, which describes the code this commit adds; every code line is identical to main.
…off (#31579) Switching dashboard.terminal.enabled to false left every registered shell running until the 12-hour orphan sweep, including shells whose tab was already gone. A live-config applier now ends each one at once: its socket gets the shell-exited close so the tab closes instead of redialing, and the gate's 30-second cache is expired so a redial is refused rather than handed a new shell. (cherry picked from commit 1c0a80f) Original author: Bolin Chen (#31579). Hand-resolved: config_watch.py, test_config_live_server_appliers.py and learn-cron-dashboard.md keep release's structure plus this commit's added lines (main's neighbouring "apps" subscription belongs to a main feature not on release); test_dashboard_server_composition_contract.py raises release's literal lazy-import count 129 -> 130 for the one entry this commit adds.
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Security Scope Review -- 🔴 could not complete (fails closed)No scope verdict for Security scope review -- adjudicated candidates
No candidate flipped from allowed to refused. [SCOPE-REVIEWED] d8e82e6 |
Sensitive Change ReviewSensitive files changed:
How to clear this check:
Only the author's comment counts this way. A reviewer can instead |
UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing a screenshot of the new "Preview expires {{when}} unless confirmed" line on Deploy's Pending confirmations card. The blind read was not performed because this PR supplies no image. Evidence gaps
[UX-REVIEWED] d8e82e6 Description read[DESCRIPTION-READ] cb58fdf441eeba8c21f37d85ec8b68165496712ea4deebbfda4850c544254d5b That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)Design-level review of Design-Verdict: PASS cannot evaluate: missing screenshot of the Pending confirmations card on BlockersNo rendered evidence of the reshaped Pending confirmations card Notes
[DESIGN-REVIEWED] d8e82e6 Description read[DESCRIPTION-READ] 5454f9d6a2c1d185ecc12296dd1f3b7c5d95b8da7c31c2e80cbedc9ad3e0b1e3 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Every item is a fix that has already merged on What this change shipsInventory (7 items) — 7 justifiedIntent: give 0.12.x users six fixes that already shipped on
[FIRST-PRINCIPLES-REVIEWED] d8e82e6 Description read[DESCRIPTION-READ] b66214de214a2f3f9398d8df6b60db5db67b395cb80f6851ec9405d8e9b5ed7d That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
Problem / Motivation
Goal: Bring 6 small fixes that merged on
mainafterv0.12.0ontorelease/0.12.0, one commit each, in a PR of their own.Why it matters
Each row is a user-visible value-2 fix from the 0.12.1 wide-bar list (Ray, 11-07) that an earlier batch left out because its pick conflicted or needed a prerequisite.
Not a goal
main; nothing is changed only here.CHANGELOG.mdchange.ChatSidebar.boardColumnTagFilter.test.tsx("keeps focus in the tag question when the popover repositions") still fails on release, so it needs more main focus code than a small chain; fix(overview): confirm settings actions in-app instead of natively #30516 is left out with it.What changed (motivation → approach → change)
Each main squash commit was cherry-picked with
-xontorelease/0.12.0@193db41120, in merge order onmain, one commit each. #31400 applied cleanly: its prerequisite #31006 (the pending-confirmationexpires_at_epoch) is already on release. The other five are hand-resolved, each listed below; no prerequisite is picked.test/test_security_gate_liveness.py_PACKAGE_LINE_BUDGET(a ceiling on the security package's line count) is raised from release's own value by each commit's growth: 34,523 -> 34,548 (+25) -> 34,587 (+39) -> 34,694 (+107), with each commit's comment. Main's own +10 re-measure is not carried. The package measures 34,596 after all three.docs/system-specs/modules/security.mdsrc/kiro_crew/pod/runtime.pydashboard/server_runtime/config_watch.py,test/test_config_live_server_appliers.py,learn-cron-dashboard.mdappssubscription belongs to a main feature not on releasetest/test_dashboard_server_composition_contract.pyEvery other file has added and removed lines identical to its main commit.
8dbdf0443c6c51cce149ec3abef1f6f95ff57e62bab2387339d035dfb257b9245ab88737544c9479e6f6a101fbeaedf674c71c0a80faddd8e82e62d15 commits carried a non-public author email or an internal co-author trailer, which the push guard refuses, so they are authored with the public identity and name their original author in the message; internal trailer lines are removed. The other 1 keep their original author.
builder-security checked: each change is the one already merged on
main; no bind, listener, new route, auth mechanism or storage grant is added.Backwards compatibility
Compatible: each change is the one already merged on
main, and its compatibility note applies unchanged.Removes nothing: no setting, key or caller is removed.
Tests
Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs
release/*, so the direct test modules were run here: every touched test file plus every test file that imports a touched module, 150 files,-n 4 --dist loadgroup(on a head that also carried fix(overview): confirm settings actions in-app instead of natively #30516 and fix(components): confirm restart, tag deletion and teardown in-app #30947, which only touchedwebsite/). 7475 passed, 5 skipped, 7 failed; all 7 fail the same way on a cleanrelease/0.12.0@193db41120on this host. On this head:test_security_gate_liveness.py,test_dashboard_server_composition_contract.pyandtest_config_live_server_appliers.pypass, and the deploy and touched test files pass (1389 passed).tsc -p tsconfig.app.json --noEmitpasses;vitest run ArtifactDeploy Deploy deploy: 15 files, 180 passed.Manual verification
N/A - each fix was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.
Screenshots / video
Why no screenshot: each frontend pick carries the same rendered change as its main PR, whose screenshots show it.
Related Issues
Backport to the 0.12 line for 0.12.1 of #31400, #31639, #32252, #27257, #31980, #31579.
Sibling sweep
Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.
Pattern harvest
Not generalizable: this PR only carries fixes already on
main. The source PRs have their own harvest.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.