Skip to content

fix: backport 0.12.1 wide batch 5 (15 user-facing fixes) - #32948

Merged
buluoray merged 13 commits into
release/0.12.0from
crew/slack/0.12.1-wide-5
Nov 8, 2026
Merged

buluoray merged 13 commits into
release/0.12.0from
crew/slack/0.12.1-wide-5

Conversation

@buluoray

@buluoray buluoray commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Bring fifteen fixes for problems a 0.12.0 user can hit, merged on main after v0.12.0, onto release/0.12.0, one commit each, in a PR of its own.

Why it matters

Each fix changes behaviour a 0.12.0 user can run into today. Every pick applied to release/0.12.0 cleanly, so the code each one replaces is on release.

PR Reported by What a 0.12.0 user sees today
#30306 CrysisDeu (#29771) With dm_scope: unified, a second person's Telegram DM is folded into the first person's turn and never answered.
#30522 RohanK6 (#30521) One artifact comment with a non-string anchor quote stops the anchor rescan for every thread.
#30584 bolichen97 Crons from a registry app update never reach the running scheduler.
#30540 bolichen97 (#16721) On KAS, a deferred Tool Search call loses the agent's tool purpose label.
#29975 buluoray (#29974) App frames fail to load behind an authenticating reverse proxy.
#30555 Pearcekieser (#30554) The App Store re-clones an unreachable registry, and the detail page builds the listing twice.
#30664 bolichen97 A released former built-in app's route shows a broken page.
#30556 rnoack1 (#30466) The dashboard says a session is still open after a close that worked, when a proxy times out.
#30595 bolichen97 A backend is reported alive before its port is released.
#30861 bolichen97 (#30792) A Bot's chat does not show the live browser card a session shows.
#30921 CrysisDeu (#29721) After /clear the agent can still recall the cleared conversation.
#30203 buluoray kirocrew doctor fails when the optional voice extra or ffmpeg is missing.
#30870 CrysisDeu (#30406) The memory (RSS) ceiling does not count a warm-pool spare runtime.
#30779 kyleseaman A remote crew with an empty region shows it as set, and a launch can repeat.
#30815 Pearcekieser (#15102) A newly added host address is not recognised until the 300 s cache refresh.

Not a goal

  • No fix that is not already merged on main; nothing is changed only here.
  • No version bump, no tag, no CHANGELOG.md change.
  • Rows whose pick conflicts, and command-deny tightenings; they go in later batches.

What changed (motivation → approach → change)

Each main squash commit was cherry-picked with -x onto release/0.12.0 @ 989d318f81, in merge order on main, one commit each. Every commit keeps its original author.

#30664 and #30861 are not carried here. GPT 6.1 found a defect in each that is also on main. #30664's legacy-route lookup (apps/BuiltinAppRoute.tsx:147) drops the query error, against the blocking errors-use-error-notice rule. #30861 shows a browser card in Bot chat, which no decision record allows over the messages-only Bot chat decision. Both get settled on main first. Their rows under "Why it matters" stay as written when the PR opened.

Hand-resolved hunks, none of them in product code:

# PR main commit release commit
1 #30306 keep each telegram sender's message in their own turn 5e8741f525 583f9ef4be
2 #30522 keep the anchor rescan going past a non-string quote 82d0033ea1 fae17d8528
3 #30584 carry a registry update's crons into the running scheduler e3c7b2b212 765114783f
4 #30540 keep the tool purpose on a deferred tool search call f0ca73453d efa82e692a
5 #29975 load app frames through the dashboard behind a proxy e9f4fad62e a349891417
6 #30555 stop the store listing re-cloning an unreachable registry 1548e9f0cc 4204a91bfe
7 #30556 don't report a worked close as still open after a proxy timeout 2b6ad8c0e7 1ca8c419f8
8 #30595 wait out the port release before reporting a backend alive 7443c94b6a 94c0ee0394
9 #30921 keep pre-reset turns out of the context after /clear 5e431e9ed0 f16d29cd7f
10 #30203 stop failing on a missing optional voice extra or ffmpeg 94579a2e36 1725129a25
11 #30870 measure the warm-pool spare runtime against the RSS ceiling 302b4fb926 45ed7369e2
12 #30779 show an empty region as missing and stop a repeat launch 92cb8bdce5 1917084db1
13 #30815 recognize a newly added host address at once a67c9ddf00 4c4f2170b3

#30779's co-author trailer carried an internal host address and is rewritten as a plain "Co-author on main" line, because the commit guard refuses it.

#30771 (refuse dd to a raw disk device) is the next clean row but is a command-deny tightening, so it waits for its own batch.

Backwards compatibility

Compatible: each change is the one already merged on main, and its compatibility note applies unchanged.

Removes nothing: no setting, key or caller is removed. #29975 changes how app frames load: they go through the dashboard's own origin instead of the sandboxed frame's, which is what lets the cookie reach an authenticating proxy.

Tests

Proof: not provable -- other: a backport of main commits whose proofs ran on their own PRs

  • CI does not run the backend suite on PRs into release/*, so the related set was run here. Every touched test file plus the test files that import a touched source module, 156 files, gave 7,262 passed.
  • Every failure seen also fails outside this branch on this host:
  • Frontend: tsc -p tsconfig.app.json --noEmit passes; vitest on the touched test files plus RemoteCrewPanel.tabState, 67 passed; gen-ui-index --check and check-i18n-strings pass.
  • flake8, isort, black gate, subprocess-encoding gate, mypy src/kiro_crew and check_harness_parity.py pass. check_file_line_cap fails only on dashboard/chat_api/resume.py, which is already over the cap on release and is not touched here.

Manual verification

N/A - each fix was verified on its own main PR. The 0.12.1 RC soak is the end-to-end check.

Screenshots / video

Why no screenshot: the frontend picks (#29975, #30555, #30556, #30779) carry the same rendered change as their main PRs, which show it.

Related Issues

Backport to the 0.12 line for 0.12.1 of #30306, #30522, #30584, #30540, #29975, #30555, #30556, #30595, #30921, #30203, #30870, #30779 and #30815. Source issues: #29771, #30521, #16721, #29974, #30554, #30466, #29721, #30406, #15102.

Sibling sweep

Siblings: none -- each source PR carried its own sibling sweep; this PR only carries those fixes.

Pattern harvest

Not generalizable: this PR only carries fixes already on main. The source PRs have their own harvest.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 8, 2026 05:27
@buluoray
buluoray requested review from tim-finnigan and removed request for a team November 8, 2026 05:27
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Sensitive Change Review

Sensitive files changed:

  • src/kiro_crew/security/argv_floor.py

  • src/kiro_crew/security/argv_floor_hosts.py

  • No reasoning template for 4c4f217 yet.

How to clear this check:

  1. The PR author posts the template below as a PR comment, with
    every field filled (N/A needs a reason). Keep the
    Head commit line: it must name the current head SHA.
  2. The check turns green within a minute, with no push.
  3. A new push resets this check: post it again for the new head.

Only the author's comment counts this way. A reviewer can instead
paste the filled template into an "Approve" review on this head.
Merging still needs a reviewer's approval.

## Sensitive change review
- Head commit: 4c4f2170b350a96e3e58ee2eb2017ebb7892c0a8
- What rule changed:
- Before -> after (what was allowed/blocked, now):
- Worst case if wrong (breaks commands / leaks secret / locks user out):
- Evidence checked (which sandbox result proves it):
- No regression:
  - Tools still work (which tools/commands were run, result):
  - Backward compatible (old config / old data / old callers still work, how checked):
  - Existing tests (which suites passed on this head):
- How to undo:

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of 4c4f2170b350a96e3e58ee2eb2017ebb7892c0a8 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing screenshots of the Remote Crew launch form. The PR changes visible controls and copy there and attaches no image, so the blind read was not performed.

Evidence gaps

  • "Launch another crew" button. The PR adds this button and keeps Launch disabled after a successful launch with the same settings. Close with a screenshot taken just after a launch, showing both buttons and the launched_same_settings line.
  • Region error on the Region and identity Region fields. Both fields now show the region_required text and a danger border when empty. Close with a screenshot of each empty field in its error state.
  • "A crew setup is running below…" notice. The launch_wait_for_setup line replaces the helper text while a setup runs, and Launch is disabled. Close with a screenshot taken while a setup is running.
  • "Checked against profile …, with no region set." line. This new checking_against_no_region text has no screenshot. Close with a screenshot of the preflight line when the region field is empty.

Notes

  • launched_same_settings is three sentences and ends by restating the button label next to it. Cut it to "Launched — progress is shown below."
  • launch_wait_for_setup opens with "You can launch another crew…", an opener that delays the point. Use "Launch is available again when the setup below finishes."

[UX-REVIEWED] 4c4f217

Description read

[DESCRIPTION-READ] b4176c0a218264c4dcd4fc3ee6c8a14d406638aa3c8e09f0d85e0ad8c189be04

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

Design-level review of 4c4f2170b350a96e3e58ee2eb2017ebb7892c0a8 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

cannot evaluate: missing a screenshot of the Remote Crew launch form as it renders on release/0.12.0 with #30779 applied. This PR reshapes that control set and has no rendered evidence of this revision.

Blockers

The Remote Crew launch controls change with no rendered evidence of this revision
Trigger: #30779's hunk in website/src/pages/settings/RemoteCrewPanel.tsx adds a new launch_another button that only shows after a launch. It also adds the inline errors cloud-region-error and identity-region-error, the hints launch_wait_for_setup and launched_same_settings, and Launch is now disabled by !launchReady || alreadyLaunched. The evidence file lists 0 images and 0 recordings. The description only says the main PRs "show it".
Outcome: that layout lands next to #32042's radio tab, which is on release but was not on main when #30779 merged. The author already had to hand-fold #32042 into RemoteCrewPanelLaunchForm.test.tsx. So #30779's screenshots on main show a different surface, and nobody has seen how the second button, the error text and the radio tab sit together on the 0.12.1 page users will get.
Fix: attach a screenshot of this branch's Remote Crew panel with an empty region, and one after a launch showing "Launch another crew".
Clears when: the description carries a github.com/user-attachments image of this revision's launch form in both states.

Notes

[DESIGN-REVIEWED] 4c4f217

Description read

[DESCRIPTION-READ] de7855604cefe21bbfec8a445ccbc9b98ab1943a5c8d188003f4dd89161cf4f7

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 4c4f2170b350a96e3e58ee2eb2017ebb7892c0a8 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

This backports 13 fixes that are already merged on main, each with a named reporter. Only the count blocks nothing: the title and Goal promise fifteen, and the diff carries thirteen.

Notes

What this change ships

Inventory (10 items) — 10 justified

Intent: give 0.12.x users fixes already merged on main without waiting for 0.13. This is a FIX (a backport). There are 13 items; these are the 10 a user is most likely to notice.

  1. With dm_scope: unified, each Telegram sender's DM is answered in its own turn — justified
  2. One artifact comment with a non-string anchor quote no longer stops the anchor rescan for every thread — justified
  3. Crons from a registry app update reach the running scheduler — justified
  4. App frames load through the dashboard's origin, so they work behind an authenticating proxy — justified
  5. The App Store stops re-cloning an unreachable registry, and the detail page builds its listing once — justified
  6. A close that worked is no longer shown as still open after a proxy timeout — justified
  7. After /clear, turns from before the reset stay out of the context — justified
  8. kirocrew doctor no longer fails when the optional voice extra or ffmpeg is missing (this deletes the pin, as fix(doctor): stop failing on a missing optional voice extra or ffmpeg #30203 did on main) — justified
  9. The warm-pool spare runtime now counts against the RSS ceiling — justified
  10. A newly added host address is recognised at once instead of after the 300 s cache refresh — justified

[FIRST-PRINCIPLES-REVIEWED] 4c4f217

Description read

[DESCRIPTION-READ] f1d477cfe7b3ec6e94aa6491054d8fe0f880e8a124c95c50f6c51174544ab83d

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Security Scope Review -- ✅ PASS

Which legitimate operations does 4c4f2170b350a96e3e58ee2eb2017ebb7892c0a8 newly refuse? Updated in place on each push. A script-confirmed regression blocks; the model proposes candidates and never decides a refusal.

Verdict basis: adjudicated, zero confirmed regressions.

Security scope review -- adjudicated candidates

  • macos-latest (platform posix): 14 classified, 0 newly refused, 9 still allowed.
  • ubuntu-latest (platform posix): 14 classified, 0 newly refused, 11 still allowed.
  • windows-latest (platform windows): 5 classified, 0 newly refused, 4 still allowed.

No candidate flipped from allowed to refused.

Scope-Verdict: PASS

Reason: The only shell-gate tightening here is in the ssh-to-self check. Once the own-address cache is published, an IP literal in host position is now also checked by asking the kernel whether that address belongs to this machine. That check returns true only when the kernel chooses the destination itself as the source address, so remote addresses should keep passing. No regression is confirmed, and I am not claiming per-host verdicts. One part can't be classified: the new dashboard-side frame relay guard. It is named under UNADJUDICATED below.

TIGHTENING: _host_is_self in the ssh-family self-target check (sensitive-bash tier, via _operand_targets_self), which now runs _kernel_says_own_address after the cache is published -- it refuses ssh/scp/rsync/sftp to an address this machine gained after the last cache refresh (for example, when a VPN comes up). Hunk: - if dns_fallback and not published: / + if dns_fallback and (not published or _kernel_says_own_address(ip, zone)):. The same change appears in the inet_aton IPv4 branch with _kernel_says_own_address(ip4), and the IPv6 zone is now kept: + host, zone = host.split("%", 1).

ADJUDICATED: 19 candidates, 0 confirmed newly-refused

PLATFORM COVERAGE: posix (14 rows) and windows (5 rows); no any rows, because every row names an executable. The diff makes four platform assumptions, and the rows cover each one:

  • Datagram-connect source check: private, public, documentation-range, IPv4-mapped and bracketed IPv6 destinations, in the plain-host, host:path, user@, -J, -L and ssh:// (git) positions.
  • Zone handling: a named zone (%eth0, %wlan0, bracketed [fe80::1%eth0] for scp) goes through socket.if_nameindex() with lowercase matching. A numeric zone (%12, the Windows interface index that ipconfig prints) goes through the zone.isdigit() branch.
  • Windows spelling: ssh.exe / scp.exe, a C:\ source path and a %SSH_PORT% variable.
  • What I could not cover: a Windows interface name that contains a space (for example "Ethernet 2"). The tokenizer would split it, so it can't be written as one host token. These rows are classified on CI runners whose own addresses are unknown to me, so every row uses an address that should be remote from them.

UNADJUDICATED: The dashboard-side app-frame relay (website/src/appFrame/frameRelay.ts, sandboxFrame.ts; documented in docs/system-specs/modules/app-kit-platform.md). It is a new path, not a stricter version of an existing one, and the shell classifier can't check it.

  • Call path: a sandboxed app frame whose module import or ctx.fetch is refused by an authenticating reverse proxy posts a relay message to the dashboard. The dashboard checks it and re-issues it with credentials: same-origin, redirect: error. Anything that targets another app, a core route, or a header outside what the preflight allowed is refused before it is sent.
  • Inputs I would have submitted:
    • a card's GET of /apps/<app>/ui/<asset>.mjs;
    • a POST to /app-frame-fetch/<app>/kv with a JSON body and Content-Type: application/json;
    • a request with a query string (kv?x=1);
    • a request carrying the app capability header;
    • a binary (ArrayBuffer) body.
  • Covered by the patch's own tests: the GET and the kv?x=1 request, in test_app_frame_srcdoc.py.
  • Still open: whether an app's custom request header, which its backend CORS allows, survives the relay's header allowlist.

The ACP tool_id envelope change (deferred_call_arguments) looks behavior-preserving to me and does not tighten anything.

[SCOPE-REVIEWED] 4c4f217

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 4c4f2170b350a96e3e58ee2eb2017ebb7892c0a8 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 4c4f217

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 4c4f2170b350a96e3e58ee2eb2017ebb7892c0a8 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 4c4f2170b350a96e3e58ee2eb2017ebb7892c0a8 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 4c4f217

Verdict parsed from the review's SHA-scoped output markers for commit 4c4f2170b350a96e3e58ee2eb2017ebb7892c0a8.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 4c4f2170b350a96e3e58ee2eb2017ebb7892c0a8 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 8, 2026
bolichen97 and others added 13 commits November 8, 2026 05:59
A message one person sent while another person's turn was running
could be folded into that turn, so its sender was never answered and
the other person saw it. It now runs as its sender's own turn.

Closes #29771

(cherry picked from commit 5e8741f)
…30522)

comments.json is decoded verbatim, so a hand edit can leave an
anchor_quote that is a number, a list or an object. The rescan that
runs on every content write tested it with "quote not in content",
which raised TypeError on that row. The caller swallows the error, so
the write still landed, but the rescan stopped there: no other thread
was ever flagged anchor_orphaned when its quoted text was removed. The
comment list route raised on the same row too, while redacting the
anchor text, so the Library showed no threads at all.

A non-string quote is now skipped like an empty one, and the rest of
the threads are rescanned. The list route sends that comment with no
anchor, and a non-string prefix or suffix as null. The stored value
is left as it is.

(cherry picked from commit 82d0033)
…#30584)

A registry-sourced app update re-registered the app and restarted its
backend but never promoted the rewritten app-crons.json into the
gateway's running CronService. Only the local-source update branch did,
so a cron field a new registry version changed kept its old value until
the next gateway start. Former built-ins now update from their own
registry repositories, so this path is the one they take.

Call the existing _resync_app_crons_after_update after re-registering in
the registry branch of POST /api/apps/{name}/update, and in
POST /api/apps/registry/install and /install-stream when they install
over an app that is already there (the detail page's Update button). A
fresh install still promotes nothing: it leaves the app disabled and the
enable registers its crons.

(cherry picked from commit e3c7b2b)
A Tool Search deferred call on KAS reaches Crew as the envelope
{tool_id, arguments}, with the tool's own arguments (and the agent's
purpose line) nested inside. extract_tool_purpose read only top-level
keys, so the tool pill and the approval card lost the purpose for
every such call.

Add one strict envelope reader, session_directive.deferred_call_arguments,
and read the purpose through it. The session-directive digest and the
workspace-call gate each carried their own copy of the same strict
rule; both now call the shared reader and keep their own tool_id
identity check, so what they accept and refuse is unchanged.

Closes #16721

(cherry picked from commit f0ca734)
…an authenticating reverse proxy (#29975)

A sandboxed app frame has an opaque origin, so its own requests carry no
cookie. A reverse proxy in front of the dashboard that signs every request in
by cookie answers them with its login page: the frame document never loads
where the iframe navigation is cookieless, and elsewhere the module import and
every ctx.fetch get an HTML 403. The card then fails with "Couldn't load this
preview."

The dashboard now does the frame's network for it:

- A first mint also returns the frame document (srcdoc variant, after the
  mint's own checks). The dashboard sets it as the iframe's srcdoc. Sandbox
  stays allow-scripts, credentialless stays. The policy is a <meta> copy of
  frame_csp ('self' spelled as the dashboard's origin; sandbox and
  frame-ancestors cannot be in a <meta>), so nothing is widened.
- ctx.fetch, and the module source when its import is refused, go through
  appFrame/frameRelay.ts: only from the frame's own window with its per-frame
  nonce, only to the frame's own app routes (/app-frame-fetch/<app>/,
  /apps/<app>/ui/ GET), only with headers the frame could have sent, and the
  answer exposes only what a CORS read would have. The gateway's capability and
  grant checks run on the relayed request unchanged.
- The bootstrap imports the module by URL first, so the direct path is
  unchanged. When that is refused, the source runs as a nonce'd inline module
  that hands over its entry with globalThis.kirocrew.register(activate). A
  module that only exports activate keeps the URL path.

Point hosts skip relay messages before their own rate and size bounds.

(cherry picked from commit e9f4fad)
… and the detail page building it twice (#30555)

(cherry picked from commit 1548e9f)
Disable, trust withdrawal and uninstall probed the backend's port once,
right after stop_app_backend returned. That stop signals the whole
process group but waits only on the root it spawned, and a sandboxed
backend's root is the sandbox wrapper, which exits before the server
inside it closes its listening socket. The single probe caught the
socket still bound and reported "backend still running ... not ours to
stop" for a backend that was already exiting; on trust withdrawal that
turned into a 409 refusal.

stop_backend_and_observe now re-probes a still-listening port for a
bounded grace (2 s, 50 ms polls) and returns a port only when it is
still listening at the end. A listener that outlives the grace is
reported exactly where it was, so withdrawn trust still refuses.

Part of #26967

(cherry picked from commit 7443c94)
…30921)

After /clear or Reset conversation the replay was suppressed, but the
fresh session's first prompt still carried a "Recent Session Context"
block quoting the same session's turns from before the reset, so the
agent could recall them. The dashboard turn now tells the builder it is
the first turn after a reset, and that block is left out.

Fixes #29721

(cherry picked from commit 5e431e9)
…#30203)

STT is enabled by default, but a CLI or source install on Linux or
macOS does not pull in the optional voice extra or a system ffmpeg.
Doctor marked both gaps with an error and exited 1, so every fresh
CLI install failed `kirocrew doctor` and broke `doctor && gateway`.

Report them as a warning with the install hint instead. Only a
macOS/Linux desktop release whose payload ships both parts still
treats a missing one as an issue, since that is a damaged install.
Windows keeps its non-fatal report in every case.

(cherry picked from commit 94579a2)
…ling (#30870)

The 5-minute RSS tick built its candidate set only from the session
map, so a runtime no session owns -- the warm-pool spare pre-spawned at
boot -- was never measured. A child it spawned could grow past the
ceiling and run unrecycled.

Add a second pass that snapshots the warm providers, measures each
runtime tree with the same per-tick reader the session pass uses, and
tears down any over the ceiling. A spare over the ceiling is first taken
out of the pool by a synchronous removal that carries its own membership
check, so a spare a session claimed across the measurement await is not
found and is left to the session pass; the removed runtime is then torn
down through the pool's own discard path, its sweep shield dropped per
pid as it goes, and one refill is scheduled through the same helper the
health sweep uses so the pool is not left a spare short. The ceiling
value and the action on a hit are unchanged, and a spare is claimed by
nobody, so no sub-agent, injection or background-launch guard applies.
The discard already offloads its kill off the loop.

Closes #30406

Co-authored-by: kirocrew-agent <agent@kirocrew.local>
(cherry picked from commit 302b4fb)
…aunch (#30779)

* fix(remote-crew): show an empty region as missing and stop a repeat launch

* fix(remote-crew): make Launch another crew launch and key the guard on the gateway's provider

---------

Co-author on main: Kyle Seaman.
(cherry picked from commit 92cb8bd)
An address this machine gained since the last periodic refresh is
recognized as its own in the same check, instead of only after the
next refresh.

(cherry picked from commit a67c9dd)
@buluoray
buluoray force-pushed the crew/slack/0.12.1-wide-5 branch from d1a86e7 to 4c4f217 Compare November 8, 2026 06:08
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Nov 8, 2026
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 8, 2026
@buluoray

buluoray commented Nov 8, 2026

Copy link
Copy Markdown
Contributor Author

Dropped #30664 and #30861 from this batch. GPT 6.1's two blocking findings on d1a86e7 hold against the main code too: #30664's legacy-route lookup in website/src/apps/BuiltinAppRoute.tsx:147 keeps only data and never shows the query error (blocking AUTOSDE rule errors-use-error-notice), and #30861 shows a browser card in Bot chat, which no docs/decisions entry allows over the messages-only Bot chat decision. Both get settled on main first. Rebased onto release/0.12.0 @ 989d318; new head 4c4f217 carries 13 picks. The Goal line and the two rows under Why it matters are left as written when the PR opened.

@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 8, 2026
@buluoray
buluoray merged commit c681485 into release/0.12.0 Nov 8, 2026
26 of 40 checks passed
@buluoray
buluoray deleted the crew/slack/0.12.1-wide-5 branch November 8, 2026 06:19
@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants